Commit Graph

13260 Commits

Author SHA1 Message Date
Ulf Lamping 1c6b2cf0e3 Instead of calling each single thing when doing/finish a file operation, file.c shouldn't call all the GUI related functions itself, instead throwing some kind of Events to it's caller(s).
I've implemented a very simple callback mechanism which provides exactly this. I've tried GHook from GLib before, but this doesn't seem to be the right thing, as it's too inflexible for the purpose here.

So I've implemented a callback function in main.c which receives all "events" and spreads them to menu, statusbar and itself.

I would see this implementation as a prototype which may need  improvements. Please comment the changes.

svn path=/trunk/; revision=13330
2005-02-07 00:54:46 +00:00
Guy Harris 7be4ff2a92 Clean up indentation.
svn path=/trunk/; revision=13329
2005-02-07 00:31:45 +00:00
Guy Harris 1041ccdbe5 Don't have "set_menus_for_captured_packets()" call
"main_set_for_capture_file()"; it should only deal with menus, not
anything else - and it gets called while the menus are being set up,
which is before the main window has been completely created, so
"main_widgets_show_or_hide()", which is called by
"main_set_for_capture_file()", gets errors trying to show or hide
widgets the pointers to which are null.

svn path=/trunk/; revision=13328
2005-02-06 23:16:05 +00:00
Guy Harris 9a04fd314d Get rid of extra blank line at the end.
svn path=/trunk/; revision=13327
2005-02-06 23:06:23 +00:00
Guy Harris 2b7b39bb6f "iface" is now a member of "capture_opts", not "cfile".
svn path=/trunk/; revision=13326
2005-02-06 22:21:51 +00:00
Guy Harris 60ad11d708 Get rid of a few cf_get_ references missed by the previous checkin.
svn path=/trunk/; revision=13325
2005-02-06 22:19:53 +00:00
Guy Harris 3b088c63d7 Include <ctype.h> for "isspace()".
#ifdef a variable used only if _WIN32 is defined.

svn path=/trunk/; revision=13324
2005-02-06 22:18:15 +00:00
Guy Harris d83f7865ff Clean up indentation.
svn path=/trunk/; revision=13323
2005-02-06 22:06:31 +00:00
Guy Harris a9cf4fccb6 Back out the previous change - we were setting "datafiledir", not
"datafile", and code in epan/filesystem.c expectes DATAFILE_DIR to be
set to the "ethereal" subdirectory of the data directory, not to the
data directory itself.

svn path=/trunk/; revision=13322
2005-02-06 21:36:11 +00:00
Ulf Lamping 1749a91a96 minor code cleanup
svn path=/trunk/; revision=13321
2005-02-06 21:34:59 +00:00
Ulf Lamping 3a63719e38 another two steps towards privilege seperation:
move another two capture related fields (iface and cfilter) from cfile to capture_opts

also move the handling of capture related command line options from main.c to capture.c, that way a future privilege seperated capture program can use the same code to parse it's command line than Ethereal. 
It might be even possible to share this parser code even with Tethereal, didn't took a closer look at this.

svn path=/trunk/; revision=13320
2005-02-06 21:20:35 +00:00
Guy Harris a6694a746f Clean up indentation.
Make "reset()" static (it's not used outside "sctp_stat.c"), and fix its
prototype to match what's expected for a reset routine passed to
"register_tap_listener()".  Similarly, fix the prototypes of other
routines passed to "register_tap_listener()", and get rid of the casts
of pointers to those functions to "void *".

Fix some declarations in "sctp_stat.h" to have function prototypes.

svn path=/trunk/; revision=13319
2005-02-06 20:53:54 +00:00
Anders Broman c3440553eb From: LEGO
- fix a bug at gog reinit that disabled gogs after reload of a file.
- fix some crashes when Debug_GoG>0
- cleanup the debug output (no CR at the end is needed)
- Gops start when no GopStart is given and match an existing GogKey

svn path=/trunk/; revision=13318
2005-02-06 20:37:02 +00:00
Ulf Lamping 3a9e847e27 some cleanup of the initial start sequence of Ethereal, filling in capture_opts and alike
svn path=/trunk/; revision=13317
2005-02-06 14:43:27 +00:00
Ulf Lamping ba04a65a6a fix bugs regarding the capture child
svn path=/trunk/; revision=13316
2005-02-06 12:21:27 +00:00
Ulf Lamping 97866a968b instead of initializing the capture_options in main.c, use the new function capture_opts_init
svn path=/trunk/; revision=13315
2005-02-06 00:13:00 +00:00
Lars Roland a9cc1df551 remove obsolete function add_rtp_streams_graph() from voip_calls.[ch] and fix a register_tap_listener() call.
svn path=/trunk/; revision=13314
2005-02-05 23:34:56 +00:00
Ulf Lamping c8522d6dec begin a welcome page which is shown, if you don't have any capture data loaded.
This might be improved to have additional content and/or better layout of the elements.

svn path=/trunk/; revision=13313
2005-02-05 23:12:44 +00:00
Ulf Lamping fe7e1ec13c completely hide the main window panes, if we currently don't have a capture file.
svn path=/trunk/; revision=13312
2005-02-05 17:53:39 +00:00
Gerald Combs 9e93bf4747 From Josh Bailey:
Attached is an update to Lucent/Ascend trace parsing: fix a few bugs,
add support for ISDN and Ethernet captures - diffs to 0.10.9.


svn path=/trunk/; revision=13311
2005-02-05 17:39:12 +00:00
Anders Broman 17608107ff Remove g_free.
svn path=/trunk/; revision=13310
2005-02-05 15:51:45 +00:00
Ulf Lamping 7b16126cd8 fixed the dnd_init declaration
(we have to do something about the non existing win32 compile dependencies, this is just a pain)

svn path=/trunk/; revision=13309
2005-02-05 15:40:44 +00:00
Ulf Lamping a1a2ae3180 rename kill_capture_child to capture_kill_child to have a common prefix
split drag and drop support out of main.c into new file drag_and_drop.c, to reduce the size of main.c a bit.

Hopefully this won't break unix builds because of missing #include's, I will keep an eye on the buildbot

svn path=/trunk/; revision=13308
2005-02-05 15:35:25 +00:00
Ulf Lamping 244c060b45 use the interfaces descriptive name to be shown in the statusbar as it's, well, more descriptive
svn path=/trunk/; revision=13307
2005-02-05 14:37:56 +00:00
Ulf Lamping 316ce5f19b fix a comment
svn path=/trunk/; revision=13306
2005-02-05 14:33:03 +00:00
Anders Broman f0b6a60d55 Re-commit the asn2eth based gsm-map dissector, hopfully it'll work better now.
svn path=/trunk/; revision=13305
2005-02-05 14:24:26 +00:00
Ulf Lamping 9d18adec33 minor enhancements to Guy's last update
svn path=/trunk/; revision=13304
2005-02-05 13:44:27 +00:00
Guy Harris fa3e5609ab Put "cf_status_t" back.
svn path=/trunk/; revision=13303
2005-02-05 12:50:47 +00:00
Guy Harris 3e07757e58 Make "cf_open()" match the prototype in "file.h".
svn path=/trunk/; revision=13302
2005-02-05 12:08:01 +00:00
Ulf Lamping 49b4e57a10 updated some comments
svn path=/trunk/; revision=13301
2005-02-05 11:37:56 +00:00
Anders Broman 84d4f0e508 From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now 
using an RTP tap (not using the rtp_stream).

svn path=/trunk/; revision=13300
2005-02-05 11:08:24 +00:00
Anders Broman c00014119d From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now 
using an RTP tap (not using the rtp_stream).

svn path=/trunk/; revision=13299
2005-02-05 11:07:21 +00:00
Ulf Lamping 9bf11427f4 make some string parameters const, as they are not changed inside
svn path=/trunk/; revision=13298
2005-02-05 11:00:04 +00:00
Guy Harris 611508684e retap_packets() was renamed cf_retap_packets().
svn path=/trunk/; revision=13297
2005-02-05 04:37:36 +00:00
Michael Tüxen 431364d07c Activate SCTP association analysis
svn path=/trunk/; revision=13296
2005-02-04 22:48:17 +00:00
Michael Tüxen b608b5e406 Update to versions compiling on and working on Windows and Unix.
svn path=/trunk/; revision=13295
2005-02-04 22:45:15 +00:00
Michael Tüxen 04a154ec0a Add detection of zero checksum.
svn path=/trunk/; revision=13294
2005-02-04 22:39:48 +00:00
Guy Harris 2c89242aac Instead of having a single enumerated type for status return values from
cf_ functions, have separate ones for different classes of routines, and
use gboolean when the return value is just "success" or "failure" - that
way you don't get compiler warnings if a case statement isn't handling a
particular status value if the routine in question won't return it.

svn path=/trunk/; revision=13293
2005-02-04 20:54:12 +00:00
Guy Harris d3e4fe620c Properly define "cf_start_tail()".
svn path=/trunk/; revision=13292
2005-02-04 20:32:32 +00:00
Ulf Lamping 69e94faff8 remove #include "globals.h" from summary.c, as it's a bad idea for multiple capture files.
If a summary user would like to get a summary, it should know the file of *which* it needs the summary.

svn path=/trunk/; revision=13291
2005-02-04 19:29:27 +00:00
Ulf Lamping c922091c09 this file doesn't use any item of the globals.h so remove #include.
However, if it needs one of:
#include "file.h"
#include <epan/timestamp.h>
it should include it directly, please let me know if it's required, as I can't test it :-(

svn path=/trunk/; revision=13290
2005-02-04 19:24:40 +00:00
Ulf Lamping 0861927ce3 huge cleanup of capture file API (functions in file.c/file.h).
This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions.

Hopefully, I didn't introduced any new bugs, as I had to change a lot of files...

svn path=/trunk/; revision=13289
2005-02-04 18:44:44 +00:00
Gerald Combs d7ad33dc51 Fix a couple of distcheck problems:
Update conversation_new and find_conversation in plugin_api_list.c and
associated files.

Add packet-dcerpc-butc.h to the distribution.

svn path=/trunk/; revision=13288
2005-02-04 15:22:25 +00:00
Guy Harris 84dadf4eee From Dominique Bastien: marker and OAM slow protocol support.
Fix his e-mail address.

svn path=/trunk/; revision=13287
2005-02-04 10:48:03 +00:00
Guy Harris 428475c8a8 HFILL can't be used to initialize at run time.
svn path=/trunk/; revision=13286
2005-02-04 10:32:28 +00:00
Ulf Lamping 3a7097a8fb remove access to global cfile, use access functions and capture_opts instead
svn path=/trunk/; revision=13285
2005-02-04 08:52:38 +00:00
Ulf Lamping 10ee9093c8 remove #include "globals.h" and access to global cfile, use access functions and capture_opts instead
svn path=/trunk/; revision=13284
2005-02-04 08:42:39 +00:00
Ulf Lamping 9f171b0485 remove #include "globals.h" and access to global cfile, use access functions and capture_opts instead
svn path=/trunk/; revision=13283
2005-02-04 08:27:41 +00:00
Ronnie Sahlberg b1d285c375 use a bitmap for the restore flags so the dissection is prettier
svn path=/trunk/; revision=13282
2005-02-04 05:26:51 +00:00
Ronnie Sahlberg 4fead805d5 initial checkin of modified idl file for autogenerating the BUTC interface
svn path=/trunk/; revision=13281
2005-02-04 04:58:03 +00:00