Commit Graph

39 Commits

Author SHA1 Message Date
Ronnie Sahlberg 9fddfa2777 fix for the typo in bug 1094
svn path=/trunk/; revision=19163
2006-09-06 08:36:13 +00:00
Jaap Keuter db31d4a72f Fix for bug 1093, as proposed by Atsushi Fukumoto
svn path=/trunk/; revision=19152
2006-09-05 12:22:44 +00:00
Jörg Mayer b58714b375 Eric Fung <efung@certicom.com>
A very tiny patch that corrects decoding of the Next Payload field in
the IKEv2 header. RFC 4306, Sec 3.2 says that a payload type of 0
means "No Next Payload" and not RESERVED. The patch just uses the
same string the dissector uses for IKEv1, namely, "NONE".


svn path=/trunk/; revision=18914
2006-08-15 18:16:56 +00:00
Jörg Mayer f2a2bed08f efung@certicom.com:
Patch adding MOBIKE support to packet-isakmp.c

svn path=/trunk/; revision=18862
2006-08-10 03:11:33 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jaap Keuter 583f9e5436 Fix for bug 875. Adding description for groups 19-26.
svn path=/trunk/; revision=17895
2006-04-18 11:52:28 +00:00
Guy Harris 83aad499b4 Squelch some compiler warnings.
svn path=/trunk/; revision=17250
2006-02-11 09:54:10 +00:00
Gerald Combs acfe071eb6 Add decryption support. For this to work, you MUST link against
the Nettle library and specify a Pluto log file in the preferences.
The Pluto log MUST include the encryption key used in each phase.

Add filters for many fields (and get rid of a lot of
proto_tree_add_text()s in the process).

Fix up whitespace.

Sponsored by CableLabs.

svn path=/trunk/; revision=17229
2006-02-09 17:32:14 +00:00
Jörg Mayer 1900bf87fc done:
packet-ntp.c: Rather confused and incorrect use of g_snprintf return value
packet-pim.c: whitespace change
packet-icmpv6.c: g_snprintf takes trailing \0 into account, fix off by 1 error
packet-clnp.c: Fix incorrect use of g_snprintf return value
packet-isakmp.c: g_snprintf takes trailing \0 into account
packet-tr.c: Fix incorrect use of g_snprintf return value
packet-radius.c: Fix incorrect use of g_snprintf return value
packet-radius.h: constify a string variable
packet-ldap.c: The return value isn't needed, so don't use it incorrectly
packet-tcp.c: Fix incorrect use of g_snprintf return value
packet-windows-common.c: Remove unneeded DISSECTOR_ASSERT
packet-smb-sidsnooping.c: g_snprintf takes trailing \0 into account
packet-pvfs2.c: g_snprintf takes trailing \0 into account
packet-ptp.c: Remove #include snprintf
packet-ppp.c: Fix incorrect use of g_snprintf return value
packet-ospf.c: Fix incorrect use of g_snprintf return value
packet-mip6.c: snprintf -> g_snprintf
packet-bootp.c: Remove a commented out bad use of g_snprintf
packet-ber.c: snprintf -> g_snprintf, g_snprintf takes trailing \0 into account

2do:

     52 packet-ieee80211.c: 2DO
      2 packet-nfs.c: 2DO - too many side effects
     33 packet-bgp.c: 2DO
     18 packet-dns.c: 2DO
     14 packet-dcm.c: 2DO
     13 packet-x11.c: 2DO
     11 packet-kerberos.c: 2DO
     10 packet-diameter.c: 2DO
      9 packet-snmp.c: 2DO
      9 packet-pgm.c: 2DO
      7 packet-nbns.c: 2DO
      6 packet-fcswils.c: 2DO
      5 packet-wccp.c: 2DO
      5 packet-cops.c: 2DO
      4 packet-wtp.c: 2DO


svn path=/trunk/; revision=17038
2006-01-16 07:59:44 +00:00
Ronnie Sahlberg 15f441cdd6 add decoding of RFC3947 which should fix bug 513
svn path=/trunk/; revision=16883
2005-12-22 21:28:51 +00:00
Anders Broman 261ff255ac From Shoichi Sakane
svn path=/trunk/; revision=16200
2005-10-12 05:36:44 +00:00
Guy Harris 5e6d63a804 Squelch some compiler warnings.
svn path=/trunk/; revision=15991
2005-09-24 19:09:40 +00:00
Jörg Mayer 86e8646afd That code was never even compiled for testing
svn path=/trunk/; revision=15988
2005-09-24 15:52:42 +00:00
Jörg Mayer 32eccf1162 Shoichi Sakane:
Hi, I fixed some bugs to decoding IKEv2 payloads.  the following things
have been checked at the IPsec bake off in Toronto this week.

        - fixed decoding IP address in TS payload
        - fixed decoding IPv6 address in ID payload
        - fixed decoding IKEv2 Delete payload
        - SPI printing


svn path=/trunk/; revision=15987
2005-09-24 15:42:37 +00:00
Guy Harris 25c4bc9379 Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,
and that extract IPv6 addresses into a "struct e_in6_addr", with
tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we
remove, by using proto_tree_add_item(), rather than replacing.

Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct
e_in6_addr" (not necessary to declare the tvbuff routines, but including
it there means "struct e_in6_addr" is guaranteed to be defined before
those declarations, so we don't get compiler complaints if we define it
*after* those declarations).

svn path=/trunk/; revision=15758
2005-09-11 21:25:37 +00:00
Ulf Lamping 495eb1b788 snprintf -> g_snprintf
svn path=/trunk/; revision=15398
2005-08-17 23:10:28 +00:00
Gerald Combs 6e18761afc Break out of a loop before we exhaust system memory.
svn path=/trunk/; revision=15163
2005-08-01 13:52:22 +00:00
Jörg Mayer eab0aeb4bb More char -> const char fixes
Declare some functions static

svn path=/trunk/; revision=15158
2005-07-30 16:34:38 +00:00
Ronnie Sahlberg 762fc4f4eb fix some bugs in a value string
this fixes bug 291



svn path=/trunk/; revision=14983
2005-07-22 02:07:43 +00:00
Ronnie Sahlberg 0138306bc7 fix for bug 290
v2 exchange code 37 is "INFORMATIONAL"



svn path=/trunk/; revision=14982
2005-07-22 02:00:04 +00:00
Ronnie Sahlberg 568266283e fix for bug 285
decode isakmp nat keepalive packets properly


svn path=/trunk/; revision=14964
2005-07-20 07:51:24 +00:00
Ronnie Sahlberg 98a0c9a590 ISAKMP version2 has changed the payload format of a CertificateRequest.
In version 2 this is just a concatenation of 20 byte SHA-1 hashes with no other encxapsulation.

this resolves bug 281




svn path=/trunk/; revision=14917
2005-07-14 08:10:30 +00:00
Guy Harris 3b3670d2d3 Static variables considered harmful. Make the ISAKMP version a
parameter to many functions inside the ISAKMP dissector, as well as to
the "isakmp_dissect_payloads()" routine it exports.  Get rid of
"isakmp_set_version()", as the version can be passed to
"isakmp_dissect_payloads()" from the KINK dissector.

Put the declaration of "isakmp_dissect_payloads()" into a
"packet-isakmp.h" header, and have "packet-isakmp.c" and "packet-kink.h"
include it rather than declariing "isakmp_dissect_payloads()" itself -
or not doing so at all.

svn path=/trunk/; revision=14648
2005-06-16 06:19:03 +00:00
Ronnie Sahlberg 94d8512749 From T.Nakashima
updates to KINK


svn path=/trunk/; revision=14453
2005-05-27 08:53:07 +00:00
Gerald Combs 137d5a0fcd Add a tvb_ensure_bytes_exist() and fix a few other offset-related bugs.
svn path=/trunk/; revision=13974
2005-03-29 22:23:09 +00:00
Guy Harris 7431ca3f58 The table containing payload types and payload dissectors are now sparse
tables that are searched rather than dense tables that are indexed, so
there's no reason to tread payload types 130 and 131 specially.

svn path=/trunk/; revision=13844
2005-03-21 02:00:14 +00:00
Ulf Lamping 49045443e9 bugfix (hopefully make buildbot happy again): don't call a function pointer, if it's NULL
However, handling of payload 130 and 131 at that place still seems to be bogus to me

svn path=/trunk/; revision=13839
2005-03-21 00:54:13 +00:00
Guy Harris 6e2808c4bd Fix some offsets.
svn path=/trunk/; revision=13835
2005-03-20 22:24:51 +00:00
Ulf Lamping 5ada21589e remove some MSVC warnings
svn path=/trunk/; revision=13824
2005-03-20 12:07:00 +00:00
Guy Harris 38de3a617a Get rid of some redundant tests that cause compiler warnings.
svn path=/trunk/; revision=13774
2005-03-16 19:41:33 +00:00
Ronnie Sahlberg abd7102bed fix a compiler warning
svn path=/trunk/; revision=13761
2005-03-15 10:05:54 +00:00
Ronnie Sahlberg e85d023949 ikev2 support from Shoichi Sakane
svn path=/trunk/; revision=13760
2005-03-15 09:58:58 +00:00
Gerald Combs 795a28ec7c Add another length check.
svn path=/trunk/; revision=12621
2004-11-29 19:30:12 +00:00
Guy Harris 1b96812a61 Get rid of a debug message.
svn path=/trunk/; revision=12620
2004-11-29 18:02:07 +00:00
Gerald Combs 37667ae337 Check for an overly large header length value in order to avoid an integer
overflow.

svn path=/trunk/; revision=12619
2004-11-29 17:52:38 +00:00
Ronnie Sahlberg 9d81458421 from Stig: change the draft number for NAT-D
svn path=/trunk/; revision=12602
2004-11-25 20:44:17 +00:00
Guy Harris eaadcc4c62 Move various tables into the epan directory.
svn path=/trunk/; revision=12130
2004-09-29 00:52:45 +00:00
Guy Harris ecd078e68a From Yaniv Kaul:
1. Fix dissection of Check Point vendor ID version field. The length was
   wrong.
2. Added dissection of payloads 130 and 131, which were used in early
   NAT-T drafts (and are still used by MS and others). They are equal to
   payloads 15 & 16, (NAT-D, NAT-OA), respectively.
3. Added ASN.1 decoding of Certificate requests of type X.509
   Certificate - Signature (4)
4. Added ASN.1 decoding of ID of type ID_DER_ASN1_DN (9) 

svn path=/trunk/; revision=12059
2004-09-21 07:47:14 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00