Commit Graph

31872 Commits

Author SHA1 Message Date
Kovarththanan Rajaratnam 9bd8195d0e Align defines
svn path=/trunk/; revision=32887
2010-05-19 06:01:29 +00:00
Guy Harris b4f61dfe67 Fix indentation.
svn path=/trunk/; revision=32886
2010-05-19 03:50:09 +00:00
Guy Harris bcba2a44e3 Fix comments.
svn path=/trunk/; revision=32885
2010-05-19 03:49:52 +00:00
Guy Harris 15e546e65d If the user asks for the Capture -> Interfaces dialog, and there are no
network interfaces, pop up a dialog saying that, rather than popping up
an empty Interfaces dialog.

svn path=/trunk/; revision=32884
2010-05-19 03:05:40 +00:00
Guy Harris c1e651802e -S doesn't require an interface, either.
svn path=/trunk/; revision=32883
2010-05-19 02:55:05 +00:00
Guy Harris ccac912244 Regularize indentation a bit.
Let pcap_statustostr()'s result suffice for most PCAP_ERROR_ errors. 
Don't mention the capture device name multiple times in the error
message.  Treat positive returns from pcap_can_set_rfmon() other than 0
or 1 as weird returns, not error returns.

svn path=/trunk/; revision=32882
2010-05-19 02:47:16 +00:00
Ronnie Sahlberg 415f314c53 iscsi also has a system port (860) registered in addition to the more common
port (3260).

add knowledge about the registered system port for iscsi to the heuristics
so we automatically detect when iscsi is transported over this optional port.


svn path=/trunk/; revision=32881
2010-05-18 22:00:17 +00:00
Jeff Morriss 1eeb3442b2 Use val_to_str() instead of match_strval() to ensure we get a non-NULL result to pass to proto_tree_add*().
svn path=/trunk/; revision=32880
2010-05-18 16:05:37 +00:00
Jeff Morriss 7575b52df7 Add epan/dissectors/dcerpc/ and epan/dissectors/pidl/ to the source distribution
svn path=/trunk/; revision=32879
2010-05-18 15:58:49 +00:00
Jeff Morriss 3dce901718 Avoid passing a NULL pointer to a string to proto_tree_add_uint_format()
svn path=/trunk/; revision=32878
2010-05-18 14:17:11 +00:00
Jeff Morriss e031f88f0b Use val_to_str() instead of match_strval() to ensure we get a non-NULL result.
svn path=/trunk/; revision=32877
2010-05-18 14:04:31 +00:00
Bill Meier 71114aac39 Restore blank line before "and by" removed in SVN #32864;
Also: Line up EMail address text for slava.

svn path=/trunk/; revision=32876
2010-05-18 14:01:59 +00:00
Jeff Morriss 01e1da16a9 Add Slava as per https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4741#c4
svn path=/trunk/; revision=32875
2010-05-18 13:39:22 +00:00
Kovarththanan Rajaratnam 93bc47d26a Add FIXME
svn path=/trunk/; revision=32874
2010-05-18 11:44:32 +00:00
Kovarththanan Rajaratnam bb2340b232 Remove NULL pointer guard in defragment_init()
svn path=/trunk/; revision=32873
2010-05-18 10:49:09 +00:00
Kovarththanan Rajaratnam ea6d8edcce Remove a couple of superfluous NULL assignments
svn path=/trunk/; revision=32872
2010-05-18 10:45:39 +00:00
Kovarththanan Rajaratnam 52122ece9c Remove a couple of check_col()
svn path=/trunk/; revision=32871
2010-05-18 10:43:36 +00:00
Kovarththanan Rajaratnam f572eff156 Parse everything as OBEX (for now).
svn path=/trunk/; revision=32870
2010-05-18 10:39:12 +00:00
Stig Bjørlykke 223eaa97c3 Add proper item for "User encapsulation not handled" to be able to
second-click the entry to edit preferences.

svn path=/trunk/; revision=32869
2010-05-18 09:01:08 +00:00
Kovarththanan Rajaratnam 05dbecb7ca Remove #if 0 code
svn path=/trunk/; revision=32868
2010-05-18 08:29:19 +00:00
Kovarththanan Rajaratnam 82a7293640 Handle fgets() error path
svn path=/trunk/; revision=32867
2010-05-18 08:22:42 +00:00
Kovarththanan Rajaratnam 62a20b9b19 Mark defragment_init() as an init routine
svn path=/trunk/; revision=32866
2010-05-18 08:08:08 +00:00
Kovarththanan Rajaratnam 100e30939a Fix several GCC build issues
svn path=/trunk/; revision=32865
2010-05-18 07:49:55 +00:00
Kovarththanan Rajaratnam 578257873a Add Allan M. Madsen
svn path=/trunk/; revision=32864
2010-05-18 07:37:37 +00:00
Kovarththanan Rajaratnam 6476632fda Include (local) packet-btl2cap.h properly
svn path=/trunk/; revision=32863
2010-05-18 07:35:31 +00:00
Kovarththanan Rajaratnam 9d568f7f9c From Allan M. Madsen:
Initial implementation of Bluetooth OBEX dissector. Work in progress.

svn path=/trunk/; revision=32862
2010-05-18 07:32:04 +00:00
Jaap Keuter 427acccd3f Prepare the docbooks for the 1.4 branch.
svn path=/trunk/; revision=32861
2010-05-18 06:16:03 +00:00
Kovarththanan Rajaratnam 0c8a3cbb4f Extract ogf from the opcode
svn path=/trunk/; revision=32860
2010-05-18 06:09:52 +00:00
Jaap Keuter 876187e1db Add CPackConfig.txt to the tarball.
svn path=/trunk/; revision=32859
2010-05-18 06:03:05 +00:00
Kovarththanan Rajaratnam 60fca26f05 Dissect Synchronous Connection correctly
svn path=/trunk/; revision=32858
2010-05-18 05:46:44 +00:00
Guy Harris 414399b572 Fix some errors. Use FormatMessageA(), as we need the string in ASCII.
svn path=/trunk/; revision=32857
2010-05-18 05:32:29 +00:00
Guy Harris ece9788353 Squelch an unused-variable warning.
svn path=/trunk/; revision=32856
2010-05-18 03:35:20 +00:00
Guy Harris 964383bf1c Add a routine to convert Win32 error statuses into strings, and use it
when generating error messages.

The error code from CreatePipe() is gotten by calling GetLastError();
it's not in errno.

Clean up indentation a bit.

svn path=/trunk/; revision=32855
2010-05-18 03:29:45 +00:00
Guy Harris 0910d319cd Move some routines around, fix and shuffle comments.
svn path=/trunk/; revision=32854
2010-05-18 02:48:51 +00:00
Guy Harris 1bf60839c9 Move get_pcap_linktype() into dumpcap - it's not used elsewhere.
svn path=/trunk/; revision=32853
2010-05-18 02:36:02 +00:00
Guy Harris c58680fd40 Only negative return values from pcap_activate() are errors; positive
return values are success-with-a-warning.

Report those errors with a string.

svn path=/trunk/; revision=32852
2010-05-18 01:48:46 +00:00
Guy Harris e3038273ca Don't write the SP_SUCCESS messages unless -Z was specified.
Add support for a machine-readable "-v" output, which prints only the
pcap version string.

Give a little more information about the machine-readable format, but
note that it's primarily intended for consumption by Wireshark and
TShark and is subject to change.

Properly hyphenate "pcap-ng".

svn path=/trunk/; revision=32851
2010-05-18 00:20:30 +00:00
Guy Harris 14c40a21aa Make -Z always generate machine-readable output, and don't bother
supplying -M along with -Z.  (We keep -M around for debugging use; it's
documented, unlike -Z.)

svn path=/trunk/; revision=32850
2010-05-17 23:56:00 +00:00
Guy Harris 859c6e4d3e If dumpcap is run with -D, don't select a default interface; it's not
necessary.

If it's run with -D and -M, and we found no interfaces, don't treat that
as an error; let the code that reads our output just indicate it as "no
interfaces available", so *its* caller can decide whether to report an
error or not (in some cases in Wireshark, it's obvious that there are no
interfaces, e.g. there aren't any listed on the welcome screen, so
popping up a dialog is pointless).

svn path=/trunk/; revision=32849
2010-05-17 23:13:24 +00:00
Jeff Morriss d1573b53c0 Don't pass a NULL pointer to what is supposed to be (according to the format) a string: some implementations of vsnprintf() will core on that. (Unfortunately it seems that g_vsnprintf() doesn't protect us from this...)
svn path=/trunk/; revision=32848
2010-05-17 21:49:09 +00:00
Jeff Morriss 734fb0725f Add a bunch of tools to the source distribution
svn path=/trunk/; revision=32847
2010-05-17 20:38:46 +00:00
Stig Bjørlykke f62ae563dc Added some new features.
svn path=/trunk/; revision=32846
2010-05-17 20:24:28 +00:00
Jaap Keuter 5140e8f44e From Lars Ruoff:
Add some more robustness to Alcatel-Lucent vendor specific 
DHCP options and add some new option values.

It now supports all currently implemented option values, i.e.:
{Option Opcode Length (bytes) Content}
AVA 58 (0x3A) 2 Vlanid
IP Touch TFTP1 64 (0x40) 4 IPv4 address
IP Touch TFTP2 65 (0x41) 4 IPv4 address
APPLICATION_TYPE 66 (0x42) 1 0 (noe) / 1 (sip)
SIP URL 67 (0x43) x bytes url string

svn path=/trunk/; revision=32845
2010-05-17 18:48:44 +00:00
Guy Harris 03d408abcb Update a comment.
svn path=/trunk/; revision=32844
2010-05-17 18:41:48 +00:00
Guy Harris 991c5e9898 When dumpcap is run to get an interface list, interface capabilities, or
interface statistics, have its error messages come out as sync-pipe
errors, have it send a sync-pipe "success" message on success, and have
the callers get that message and display it.

svn path=/trunk/; revision=32843
2010-05-17 18:40:23 +00:00
Jeff Morriss 01c752e5ef Update Robert Hogan's entry to include TN5250
svn path=/trunk/; revision=32842
2010-05-17 15:07:08 +00:00
Bill Meier 1f1a38f961 From Torrey Atcitty: IEEE 1722(AVB Transport Protocol) Dissector
See Bug #4764 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4764)

svn path=/trunk/; revision=32841
2010-05-17 04:08:08 +00:00
Jeff Morriss 4749e0f19f Move most of the contents of the header file into the .c file.
svn path=/trunk/; revision=32840
2010-05-17 03:01:03 +00:00
Jeff Morriss 8225d821da Remove trailing white space
svn path=/trunk/; revision=32839
2010-05-17 03:00:37 +00:00
Jeff Morriss a229509b85 From Robert Hogan via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3922 :
Add support for the IBM TN5250 data stream protocol.

http://wiki.wireshark.org/TN5250

From me:

Move most of the contents of the header file to the .c file.

Replace blurbs that match the hf name with NULL.
Replace empty-string blurbs with NULL.
Fix some abbreviations (hf_tn5220_xxx -> tn5220.xxx).
Make some functions static.
Cast some offset increments to unsigned to make sure we don't go backwards
(which could create a loop).  This includes making most of the subdissection
functions return an unsigned number.

Use find_or_create_conversation().

svn path=/trunk/; revision=32838
2010-05-17 02:55:51 +00:00