osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
41,357 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

31 Commits

Author SHA1 Message Date
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Bill Meier 2ed4baea4f all: 
Merge .h files into .c files since .h files unused elsewhere;
     Do whitespace, indentation & formatting cleanup.
packet-acn.c:
     Fix 2 minor bugs wherein subtree not displayed in packet-details
     because tree variable used in proto_tree_add_text() always NULL.

svn path=/trunk/; revision=42647
 2012-05-16 01:41:03 +00:00
Guy Harris 761ce3c75b Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls; for the items that don't actually have hf_
entries (which is a bug in the dissector!), assume the short
fixed-length ones are integral and the "to the end of the packet" ones
are byte arrays (hence ENC_NA).

svn path=/trunk/; revision=42475
 2012-05-07 18:00:13 +00:00
Anders Broman e6b7af69b5 From Evan Huus: There were two cases where we could underflow an unsigned subtraction, leading to huge values and near-infinite loops. Catch them and add an expert_info warning that the packet is bad. Also fix some other expert_info messages to hang off of the right dissection tree. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7125 
svn path=/trunk/; revision=42122
 2012-04-18 05:29:02 +00:00
Bill Meier 4f8e416fdc Fix benign issue: For FT_BOOLEAN fields with a zero bitmask, use BASE_NONE for 'display' 
svn path=/trunk/; revision=41385
 2012-03-06 22:12:42 +00:00
Bill Meier 54b72021bb Fix encoding arg for various fcn calls: 
- proto_tree_add_bits_item
 - proto_tree_add_bits_ret_val
 - proto_tree_add_bitmask
 - tvb_get_bits
 - tvb_get_bits16
 - tvb_get_bits24
 - tvb_get_bits32
 - tvb_get_bits64


svn path=/trunk/; revision=39539
 2011-10-24 19:57:53 +00:00
Bill Meier 63e83b1303 Fix a proto_tree_add_item() encoding arg. 
svn path=/trunk/; revision=39527
 2011-10-23 20:50:48 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier 126aa85393 Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows: 
1. If there's no character encoding (ENC_ASCII, ...) specified
    then use ENC_ASCII.
 2. For all but FT_UINT_STRING, always use ENC_NA
    (replacing any existing True/1/FALSE/0
    /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).



svn path=/trunk/; revision=39426
 2011-10-15 18:46:26 +00:00
Bill Meier e81572eaa9 Comment out some unused hf[] entries; 
Add notes about missing hf[] entries.

svn path=/trunk/; revision=39344
 2011-10-10 20:57:56 +00:00
Bill Meier a78fdcfddc Convert proto_tree_add_item() 'encoding' parameter as appropriate. 
svn path=/trunk/; revision=39343
 2011-10-10 20:12:57 +00:00
Bill Meier 67ee5049d4 Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
  the encoding parameter for proto_tree_add_item() calls which directly reference
  an item in hf[] which has a type of:
     FT_BOOLEAN
     FT_IPv4
     FT_EUI64
     FT_GUID
     FT_UINT_STRING

Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260)

svn path=/trunk/; revision=39328
 2011-10-10 00:39:31 +00:00
Bill Meier 4e57694d4a Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors: 
Specifically:  Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
 the encoding parameter for proto_tree_add_item() calls which directly reference
 an item in hf[] which has a type of:
    FT_UINT8
    FT_UINT16
    FT_UINT24
    FT_UINT32
    FT_UINT64
    FT_INT8
    FT_INT16
    FT_INT24
    FT_INT32
    FT_INT64
    FT_FLOAT
    FT_DOUBLE


svn path=/trunk/; revision=39288
 2011-10-06 03:35:44 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types: 
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
 2011-10-04 22:44:31 +00:00
Stig Bjørlykke 5359494b1f Second try to move crc routines to libwsutil. 
This time keep the tvb routines in epan.

Now we can use common crc routines outside epan.

svn path=/trunk/; revision=38810
 2011-08-31 09:00:54 +00:00
Stig Bjørlykke 71f903b956 Revert r38800, as the crc routines contains some tvb functions. 
svn path=/trunk/; revision=38803
 2011-08-30 14:17:40 +00:00
Stig Bjørlykke 4132d40e50 Move all crc routines to libwsutil. 
This way we can use the crc routines in wiretap.

svn path=/trunk/; revision=38800
 2011-08-30 13:46:42 +00:00
Stephen Fisher 9a8c084580 Found by clang 3.0 (built from trunk): various implicit conversion from 
enumeration type 'xxx' to different enumeration type 'xxx'

Fix: Create different structs based on the enum type contained within.


svn path=/trunk/; revision=36814
 2011-04-22 16:27:01 +00:00
Alexis La Goutte 56c8001d3c Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=36764
 2011-04-21 13:43:23 +00:00
Alexis La Goutte ace0276b1c Fix Dead Store (Dead nested assignment) Warning found by Clang 
svn path=/trunk/; revision=36753
 2011-04-21 13:31:42 +00:00
Stephen Fisher fc7b0c019b Fix the dead initialization warnings found by clang's static analysis 
("Value stored to 'xxx' during its initialization is never read")


svn path=/trunk/; revision=35598
 2011-01-20 18:56:11 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Bill Meier 03b57df5a0 Fix various typos and spelling errors. 
svn path=/trunk/; revision=35126
 2010-12-06 01:34:58 +00:00
Bill Meier d318d360d5 Use value_string_ext fcns when accessing value_string arrays. 
svn path=/trunk/; revision=34744
 2010-11-01 17:11:04 +00:00
Bill Meier e7568712ef Define some fcns & vars as static; 
Minor whitespace and comments cleanup.

svn path=/trunk/; revision=34477
 2010-10-11 19:00:55 +00:00
Guy Harris 8084fd5152 Squelch a compiler warning. 
svn path=/trunk/; revision=32414
 2010-04-07 00:41:44 +00:00
Gerasimos Dimitriadis 20e77097eb Fix for Bug 4369: 
Use the correct function for adding an FT_STRING field and make some
checks regarding the length of parameters in cmd_manageuser().

svn path=/trunk/; revision=31476
 2010-01-10 14:29:49 +00:00
Gerasimos Dimitriadis e53c76e9af Partial fix for Bug 4369: 
Remove the possibility of infinite loop when counting items of length 0.

svn path=/trunk/; revision=31475
 2010-01-10 14:00:49 +00:00
Gerasimos Dimitriadis e1af738d14 Partial fix for Bug 4369: 
Remove the possibility of infinite loop when command length is 0.

svn path=/trunk/; revision=31463
 2010-01-07 22:03:29 +00:00
Bill Meier 5cae51417c proto_reg_handoff...: if (!initialized) not req'd; 
Remove unneeded #includes;
Use true_false_string definitions from tfs.c when possible. 

svn path=/trunk/; revision=31106
 2009-11-28 14:47:12 +00:00
Jaap Keuter 698b6e37a0 From J.C. Wren: 
This patch adds protocol dissection support for the Assa Abloy R3 protocol. 
R3 is an electronic lock management protocol for configuring operational
parameters, adding/removing/altering users, dumping log files, etc.

svn path=/trunk/; revision=31105
 2009-11-28 01:16:52 +00:00