Commit Graph

45 Commits

Author SHA1 Message Date
Anders Broman 8f1d357618 From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

svn path=/trunk/; revision=22780
2007-09-04 05:22:43 +00:00
Jeff Morriss d47443ba38 Replace a couple more calls to tvb_get_string() with tvb_get_ephemeral_string(). 2 of the 3 replacements fix memory leaks.
svn path=/trunk/; revision=22542
2007-08-17 21:21:50 +00:00
Jeff Morriss 3dec62b85c - s/ntohs/g_ntohs
- s/ntohl/g_ntohl
- s/free/g_free
- Change some tvb_get_string()+g_free()'s into tvb_get_ephemeral_string()
- Change some tvb_fake_unicode()+g_free()'s into tvb_get_ephemeral_faked_unicode()
- Change some tvb_get_string() calls that were clearly memory leaks (like
  atoi(tvb_get_string(...))) into tvb_get_ephemeral_string()

svn path=/trunk/; revision=22515
2007-08-15 22:27:52 +00:00
Martin Mathieson 355d1e1321 Show malformed SDP line as an expert item
svn path=/trunk/; revision=22334
2007-07-17 13:09:44 +00:00
Anders Broman 1cf1f16391 Split out common asn1 stuff to asn1.h and include that where needed.
svn path=/trunk/; revision=21635
2007-05-01 22:05:11 +00:00
Anders Broman 8d756c3049 Add a reference.
svn path=/trunk/; revision=21377
2007-04-10 21:02:50 +00:00
Anders Broman fc16dece75 From Mikael Magnusson:
This patch adds support for key-mgmt session attributes in SDP (defined in RFC 4567). The patch also contains a Multimedia Internet KEYing (MIKEY is defined in RFC 3830) dissector plugin for "mikey" key-mgmt data.

svn path=/trunk/; revision=20977
2007-03-05 23:11:11 +00:00
Luis Ontanon aa654a1f8a Those two spaces before sdp were bctp (Q.1990), a protocol conveniently encoded to be two spaces in case of IPBCP (SDP+extras).
There's probably something similar in packet-isup.c

svn path=/trunk/; revision=20952
2007-03-01 00:24:57 +00:00
Luis Ontanon 215b7eecc5 have sdp ignoring useless caracters efore the first element (this is a hack to avoid the two spaces found before the v= in sdp messages embeded in h248/q1950)
svn path=/trunk/; revision=20913
2007-02-24 12:24:13 +00:00
Anders Broman 3c8dcc67bb Fix a cut and paste error.
svn path=/trunk/; revision=20043
2006-12-05 06:53:28 +00:00
Anders Broman 9226c9ef57 Add description of CT AS TIAS and H263-2000 profile.
svn path=/trunk/; revision=20035
2006-12-04 23:03:11 +00:00
Anders Broman e5188939c3 Dissect h324ext_h223lcparm.
svn path=/trunk/; revision=19786
2006-11-03 20:15:17 +00:00
Martin Mathieson 358701731b Cast away most remaining warnings.
2 will remain, because the 'needle' arg in tvb_pbrk_guint8() isn't const...  Should it be?

svn path=/trunk/; revision=19717
2006-10-27 14:36:48 +00:00
Martin Mathieson 37317874e4 More warnings
svn path=/trunk/; revision=19716
2006-10-27 13:03:38 +00:00
Martin Mathieson f378c52320 More warnings...
svn path=/trunk/; revision=19710
2006-10-26 17:03:45 +00:00
Anders Broman c99428334a Fix(?) bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1042
Does the string need to be freed ad destruction of the hashtable?

Surplus add_text removed.

svn path=/trunk/; revision=19139
2006-09-04 21:07:35 +00:00
Anders Broman 4f7ff62fcf From Martin Mathieson:
- allow SDP to parse the IP address + port for the MSRP session from the 
path attribute
- setup an MSRP conversation using this address, whose data points back 
to the SDP frame
- link to the SDP setup frame while dissecting MSRP (can be switched off 
by a preference)
- I also changed sdp.media.port to be a numeric field

svn path=/trunk/; revision=18806
2006-07-28 21:26:39 +00:00
Anders Broman 5f6f853d16 From Martin Mathieson:
- while parsing fmtp lines, the dissector looks for the MPEG4 'profile-level-id' parameter.  If there is no '=' present, it was throwing an exception and the frame marked as malformed (see e.g. the attached
capture)
- I've added a few comments where the code wasn't obvious to me...

svn path=/trunk/; revision=18332
2006-06-03 11:48:27 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 97419848da From Andrei Emeltchenko:
I attached patch to add preferences in SDP for RTP stream detection. By default SDP decodes RTP stream but now I can disable it.

svn path=/trunk/; revision=18080
2006-05-03 05:07:04 +00:00
Guy Harris f3d1963924 Clean up indentation; use 2-space indentation throughout.
Save the media encoding name in the transport_info_t structure rather
than in a global variable.  Allocate it with tvb_get_ephemeral_string()
so it's released after the packet is completely processed.  Do *NOT*
assume it's necessarily non-null in decode_sdp_fmtp(), as the code flow
doesn't guarantee that to be true.

proto_tree_add_string() now suffices for adding a particular SDP item -
strings are now displayed "safely", with escaping of non-printable
characters done.

Update a comment (we no longer have the Big Transfer Vector to allow
plugins to call dissector functions in Windows, we have those functions
in a DLL).

svn path=/trunk/; revision=18031
2006-04-29 17:31:20 +00:00
Anders Broman 13d178a3fc Check Payload type before dissecting fmtp parameters.
svn path=/trunk/; revision=18028
2006-04-28 21:42:18 +00:00
Anders Broman fd42a33307 Add dissection of MPEG4 fmtp parameter.
svn path=/trunk/; revision=18010
2006-04-26 20:16:57 +00:00
Gerald Combs b3d0b97635 Make sure we don't use the ADNS version of inet_aton; it's broken.
This fixes bug 523, but exposes more of bug 658.

The TACACS and SDP dissectors don't call inet_aton(), so don't include it.

svn path=/trunk/; revision=17056
2006-01-19 23:01:24 +00:00
Jaap Keuter 815a4af69e Hi All,
Find attached a couple of changes for t38:
- Use the dissector to reassemble t30 frames
- Dissect t30 protocol
- Move the "Fax t38 analysis" to the "VoIP Calls". Now when selecting
"Statistics"->"Fax t38 analysis" option, there is a message that
redirect the user to use the "Voip calls" instead. We may keep this
option for one release, and then remove it ?
- Added in the "Voip calls" the ability to detect a t38 call if there
are not signaling associated with it. For example, when using "Decode
as.." to dissect t38 packets, it is possible to use the "Voip calls" to                                                      analyze that call.
- Display "SDP (t38)" in the "Voip calls graph" for SDP t38 sessions.

Regards
Alejandro Vaquero


svn path=/trunk/; revision=17033
2006-01-15 15:01:14 +00:00
Guy Harris b7b80d94be Move a pile of protocol-related headers from the top-level source
directory to the epan directory.  Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.

Fix Gerald's e-mail address in files we're moving.

svn path=/trunk/; revision=15844
2005-09-17 00:02:31 +00:00
Ronnie Sahlberg 68bfa7736e replace g_malloc() with ep_alloc() for ftp and sdp
sdp never free the allocated memory so it were leaking memory for every packet containng sdp.
fix memleak for sdp


svn path=/trunk/; revision=15381
2005-08-17 08:50:04 +00:00
Ronnie Sahlberg ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Ronnie Sahlberg 12f5bdb99f remove a pointless g_strdup
svn path=/trunk/; revision=15195
2005-08-02 17:15:56 +00:00
Ronnie Sahlberg e51caa85fb some more ememification of tvb_get_string()
svn path=/trunk/; revision=15142
2005-07-29 10:00:37 +00:00
Ronnie Sahlberg 699e51ccdd some more ep_tvb_get_string updates
svn path=/trunk/; revision=15034
2005-07-24 04:24:30 +00:00
Luis Ontanon acddab0452 add ipbcp attribute as in Q.1970
svn path=/trunk/; revision=14724
2005-06-22 02:18:10 +00:00
Lars Roland 118ce715a7 From Alejandro Vaquero:
improve dissection of Dynamic payload 
types used in conversations and the
codec list summary in the "Voip Calls Graph".

svn path=/trunk/; revision=14180
2005-04-24 18:43:42 +00:00
Anders Broman b183d4d1e3 From Ulf Lamping:
Fix a "off by one" error.

svn path=/trunk/; revision=13977
2005-03-30 13:37:27 +00:00
Anders Broman dfdd9ce19d From Martin Mathieson:
- bump up SDP_MAX_PAYLOAD_TYPES to 20 (I have an mgcp capture where a media
gateway responded with 12 media types, resulting in a crash).  Probably more
care needs to be taken while parsing the list of media types though...

svn path=/trunk/; revision=13973
2005-03-29 20:58:03 +00:00
Anders Broman b583591455 Previous commit failed doing them one by one.
From  Alejandro Vaquero :
 Find attached a patch for SDP sessions to:
 - Dissect Dynamic payload types in RTP packets
 - Add the dynamic payload type description in RTP packets
 - Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.

svn path=/trunk/; revision=13940
2005-03-27 21:14:15 +00:00
Luis Ontanon 008054453b From Alejandro Vaquero:
- Automatic dissection of RTP events (RFC2833) set in SDP sessions.
- Add RTP events (RFC2833) to the Voip Graph


svn path=/trunk/; revision=13697
2005-03-10 19:32:22 +00:00
Jörg Mayer 9432483a14 Warning fix:
packet-sdp.c:74: warning: 'reset_sdp_packet_info' declared 'static'
        but never defined


svn path=/trunk/; revision=13624
2005-03-06 09:33:44 +00:00
Anders Broman 851ecd2ac4 From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the 
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass 
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image 
are present, and T.38 conversation if only m=image is present. I expect that 
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 
packets.

svn path=/trunk/; revision=13243
2005-02-02 20:07:03 +00:00
Lars Roland 197ceddab1 From Alejandro Vaquero:
h323 taps support up to 5 messages per packet now.

VoIP call analysis:
      - Collect ISUP, SIP and H323 calls from a capture and show them in window with the following info:
      - Start and Stop time of the call
      - Init

svn path=/trunk/; revision=13225
2005-02-01 12:12:35 +00:00
Guy Harris 77762e2ddc From Chris Maynard: don't extract strings with "tvb_get_string()" if
we're not going to use them, and free them when we're done with them.

Clean up white space.

svn path=/trunk/; revision=12963
2005-01-05 10:51:05 +00:00
Guy Harris ff3efbb9ff From Francisco Alcoba: handle RTP over IPv6.
svn path=/trunk/; revision=12586
2004-11-24 03:18:30 +00:00
Guy Harris bd23f6f1a8 From Alejandro Vaquero: start T.38 conversations for SDP sessions.
"T38" -> "T.38" in the T.38 dissector.

svn path=/trunk/; revision=12374
2004-10-22 06:19:00 +00:00
Guy Harris 344dddb124 Pass an "address *" to "rtp_add_address()" and "rtcp_add_address()", so
so that they could handle IPv6 addresses.

Clean up white space.

svn path=/trunk/; revision=11854
2004-08-30 10:03:54 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00