In "dissect_nds_request()", insert the request information into the hash
table the first time we see the packet, regardless of whether we created
a new conversation or not.
svn path=/trunk/; revision=8541
column, and we need stuff from the protocol tree for the Info column.
Go back to the previous scheme for constructing the Info column; the
previous change fixes the problems for which the Info column changes
were fixes.
svn path=/trunk/; revision=8526
1. Added support for defragmentation of NDS packets
2. Moved the run_info_string logic outside of the
pinfo->fd->flags->visited because of the dissection of info
strings is not processed on subsequent decodes then the
find/string/info will not locate info string values. By moving
this outside then when the find logic runs a tvb_dissect_new
then the info string gets processed again and all data is
visible. Otherwise only info column data that is processed by
the NCP dissector is visible not any data from ncp2222.py
processed by the info string function.
svn path=/trunk/; revision=8257
1. Some NCP's that displayed the file/directory path in the
summary window would display blank lines on Windows based
machines. This was due to unicode or non-displayable
characters contained in the character string being added to
the column data. I made a change to format/strip out
non-displayable characters prior to adding to the column
data.
2. Moved ncp_req_hash_value struct to packet-ncp-int.h so that
I can use it within a future dissector (NMAS).
Clean up white space.
svn path=/trunk/; revision=7560
1. Added a number of NCP Error return values.
2. Added ability to pass byte strings to summary window.
3. Modified file NCP's to reflect file handle in summary window.
4. Changed all NCP's using QueueID from big endian to little endian.
This is different from Novell's NCP documentation but matches same
information obtained from NDS dissector.
5. Added over 50 more NDS error return values.
6. Partially fixed NDS Request verb 6 (Search Entries)
svn path=/trunk/; revision=7172
adding 1 to them is incorrect (and cannot possibly be correct, as that'd
rule out 0 as valid values, meaning nothing can ever happen in the first
hour after midnight or in the first minute after the hour).
svn path=/trunk/; revision=7099
qualifiers as necessary to ensure that we don't have to.
"strcmp()", "strcasecmp()", and "memcmp()" don't return booleans; don't
test their results as if they did.
Use "guint8", not "guchar", for a pointer to (one or more) 8-bit bytes.
Update Michael Tuexen's e-mail address.
svn path=/trunk/; revision=6726
Various NDS dissector enhancements including NDS verb 0x07, and
proper ping flags for NDS ping version 10 request.
Updated error codes for several NCP reply packets.
NDPS enhancements.
svn path=/trunk/; revision=6463
constant, as that won't work with "get_string()" (it'll try to overwrite
the constant, and either crash, trash memory, or both).
svn path=/trunk/; revision=6460
Clean up the stuff to handle MVTYPE_PROC_ENTRY_SPECIFIERS a bit, and put
in comments explaining what's going on for that and MVTYPE_ATTR_REQUEST.
svn path=/trunk/; revision=6439
just wrap the entire dissection in an "if", as was done before.
(Actually, we can just skip the "if" entirely, I guess....)
svn path=/trunk/; revision=6429
whether we're building a protocol tree or not.
Set the separator if we put "Revision" into the summary.
Check for a remaining length >= 8, not > 8, to check for an NDS version
10 or later ping, and check the reported length, not the captued length.
svn path=/trunk/; revision=6428
longest possible flag string.
Don't create a temporary protocol tree unless we're not filling in a
protocol tree.
The NDS version isn't present in NDS pings prior to version 10; dissect
it only if it's present.
svn path=/trunk/; revision=6412
"dissect_ncp_request()".
Fix "dissect_ping_req()" to properly put the NDS version in a ping
request into the tree (although that field isn't present in the ping
requests I've seen, so perhaps it's only in NDS version 10 and later),
as big-endian (change FALSE to TRUE if it's little-endian).
Get rid of the unused "ncp_nds_verb" variable (set, but not used) in
"dissect_ncp_common()".
Call "dissect_ping_req()" from "dissect_ncp_common()" again.
svn path=/trunk/; revision=6411
string, it's a tree name (as the field's display name suggests).
Get rid of the unused "ncp.nds_string_value" field.
Fix up the names of some fields, and use "proto_tree_add_uint()" rather
than "proto_tree_add_uint_format()" to add them to the protocol tree.
svn path=/trunk/; revision=6408
list, check whether the protocol field is enabled, not whether the info
field is enabled. Update the protocol field before trying to look at
the packet, so it gets updated even for short packets.
Only parse service reply packets as NDS packets; don't parse positive
ack packets that way.
svn path=/trunk/; revision=6404
the string for the completion code. Do put the string for the NDS error
into the summary line, however.
Don't clear the NDS error code if we can't translate it to a string.
svn path=/trunk/; revision=6400
crashes on many platforms, and other random behavior on others.
Don't create a temporary tree with an NCP tree underneath it if we
already have an NCP tree; we don't want the results of a dissection to
be stuck in an invisible temporary tree if we're supposed to be
generating a protocol tree.
svn path=/trunk/; revision=6399
can compile the code.
Note that Bill Fumerola rewrote the Cisco NetFlow dissector.
Update a bunch of addresses in the Ethereal man page, and put some
missing addresses in.
svn path=/trunk/; revision=6380
This update adds NCP 87/66.
Also add additional error codes, added hf_definition for super class
(NDS). Cleaned up some unused variables (Warnings when building
Ethereal). Fixed NCP type 0x9999 (server busy packets to echo
information to summary information), Added subtree format to NDS
dissector to cleanup display.
svn path=/trunk/; revision=6331
without having to know the numerical values for the verbs.
Use that table to convert the verb value to a verb name.
Fix indentation.
svn path=/trunk/; revision=6075
Guy Harris