Commit Graph

83506 Commits

Author SHA1 Message Date
Gerald Combs ebe22f7b7b ZigBee ZCL: Make sure our offset advances.
Fixes #17926.
2022-02-05 11:11:32 -08:00
Uli Heilmeier a25347c59c GSM RLC MAC: Check length tvb_new_octet_aligned
Check if length not 0 before calling tvb_new_octet_aligned()

Related to #17890 case 28
2022-02-05 13:42:17 +00:00
Roland Knall d003ad9092 Qt: Display fieldname as tooltip in expert info dialog 2022-02-05 11:49:41 +00:00
Roland Knall 00149f1454 Git: Ignore Visual Studio Code workspace definition 2022-02-05 12:34:14 +01:00
Uli Heilmeier 64f98ee13c PER: Check length calling tvb_new_octet_aligned()
Fix calling tvb_new_octet_aligned() with length == 0

Related to #17890 case 1 and 6
2022-02-04 21:02:28 +01:00
Martin Mathieson 1f22c7e04c Trivial: change some formatting in hf item definitions 2022-02-04 11:56:24 +00:00
Gerald Combs 1d8690f8ef AMP: Fix large / infinite loops.
Make sure our offset advances in a few places. Fixes #17829.
2022-02-04 01:42:36 +00:00
Roland Knall 4e11aa1829 Qt: Show Preference key in the tooltip 2022-02-03 23:15:41 +00:00
Gerald Combs 1136ce9610 epan: Check our FT_UINT_BYTES and FT_UINT_STRING lengths.
Add length checks to get_full_length for FT_UINT_BYTES and
FT_UINT_STRING items. Fixes #17891.
2022-02-03 23:05:00 +00:00
John Thacker f2dbaa1d53 epan: Handle -1 length in tvb_ascii_isprint
tvb_ascii_isprint like other tvb_ functions accepts -1 as a parameter,
meaning "to the end of the tvb". Get the real length for the loop.
2022-02-03 22:47:35 +00:00
Martin Mathieson 3466798ed0 More mask/field-length fixes 2022-02-03 22:13:43 +00:00
Uli Heilmeier ad356d2672 WSUG: Fix TCP keep alive description
Fix description which flags are not set.
2022-02-03 20:38:05 +00:00
Gerald Combs 13f5d72453 ASN.1 PER + ATN-ULCS: Add checks for nulls in sequences.
In ASN.1 PER, Stop dissection if our sequence offset hasn't advanced
after 50 items.

atn-ulcs.asn overrides the definition of AttributeTypeAndValue as a
sequence of NULLs. Update our .cnf file so that we only dissect the
first item in that case.

Fixes #17842.
2022-02-03 20:10:33 +00:00
Uli Heilmeier 758b41a017 x509af: Call dissect_ber_bitstring() with hf_index
Calling dissect_ber_bitstring() with hf_index to fix a failed assertion.

Related #17890
2022-02-03 11:18:16 +00:00
Martin Mathieson 3c5fd8a0df q.261: Fix a couple of fields (masks/lengths) 2022-02-03 10:16:52 +00:00
Gerald Combs 3abd163127 Docs: Start migrating the Developer's Guide to Visual Studio 2022. 2022-02-03 03:05:03 +00:00
Dr. Lars Völker c442f180f7 TECMP: Allowing Chassis Temperature to be not available too
Not only the Silicon Temperature can be "not available" but the Chassis
Temperature too.
2022-02-02 15:20:38 +00:00
Stefan Metzmacher d848127c6e packet-smb2: use better error checking logic in do_decrypt
This hopefully avoids the warnings discussed in
https://gitlab.com/wireshark/wireshark/-/merge_requests/3671

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2022-02-02 14:39:29 +00:00
Martin Mathieson cfe93f8001 Fix some masks/widths. 2022-02-02 14:03:25 +00:00
Martin Mathieson a690119080 Fix some too-narrow field types. 2022-02-02 10:01:03 +00:00
Stefan Metzmacher a979189ab0 packet-smb2: add AES-256-* decryption
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2022-02-02 07:54:40 +00:00
John Thacker a30d6a442e GTP: Update checked messages
Updating the message checking for 3GPP TS 29.060 V16.0.0,
adding 7.5A MBMS Messages and 7.5B MS Info Change Reporting Messages.

This adds all the messages from TS 29.060. Some of them could be
updates to use the GSN specific fields in some cases. Also the
ETSI message checking needs to be updated to handle GTP' correctly.
2022-02-01 23:02:23 -05:00
John Thacker 0582cc7a68 GTP: Add UE Registration Query messages
Add message types 61 and 62, UE Registration Query Request and
Response, that first appeared in Rel 13.
2022-02-01 22:34:49 -05:00
John Thacker b7dc881571 GTP: Update more checked message contents to V16.0.0
Update 7.4 Location Management and 7.5 Mobility Management messages
to 3GPP TS 29.060 V16.0.0 for the check_etsi preference.
2022-02-01 22:13:25 -05:00
John Thacker 7023907c57 GTP: Add Initiate PDP Context Activation to checked messages
Add 7.3.12 and 7.3.13 Initiated PDP Context Activation Request
and Response to checked messages on UMTS.
2022-02-01 21:16:49 -05:00
John Thacker 185a5b3473 GTP: Update ETSI checked Tunnel Management Messages to V16.0.0
Update the optional IEs for the Tunnel Management messages to
3GPP TS 29.060 V16.0.0 for when the check_etsi preference is on.
2022-02-01 20:58:59 -05:00
John Thacker f201f23299 GTP: Use alternative GSN address decoders for Update PDP Resp
The GGSN addresses for control plane and user traffic are both
included or both not included in the Update PDP Context Response
message (included if the Cause is Request Accepted), so we know
which one is the control plane and which one is the user plane.
Also fix the coment about the IEs for the alternative address, and
that they are Conditional, not Optional.
2022-02-02 01:39:12 +00:00
John Thacker 09ecc11be5 ipsec: Don't use NULL heuristic if padding length is impossible
If the ESP NULL heuristic is on, but interpreting the padding length
byte as unencrypted would leave fewer than zero bytes remaining for
the payload tvb, just consider the heuristic failed instead of trying
to create the next_tvb subset and thus throwing an error.
2022-02-02 01:05:16 +00:00
Dr. Lars Völker 8ef0114995 SOME/IP: Add stats information to tshark man file 2022-02-02 00:45:04 +00:00
Dr. Lars Völker 9038f5a7da SOME/IP: Add name resolution to statistics 2022-02-02 00:34:35 +00:00
Guy Harris 0d357951c3 pflog: byte swap UID and PID fields in the header if necessary. 2022-02-01 16:20:21 -08:00
Chuck Craft 5c020863c7 Qt: Go To Packet field - change from inputMask to QIntValidator
inputMask populates the field with a space for each character
in the mask. Mouse people that click in the field may position
the cursor at the far right of the mask and not be able to enter
a value.
https://www.qtcentre.org/threads/7106-QLineEdit-and-input-mask

Remove the inputMask from the field definition and add a validator.
2022-02-01 21:41:18 +00:00
Stefan Metzmacher a0426314a7 packet-ntlmssp: only mark invalid target_info lists without failing the rest
This copes with invalid target info AvPairs, see
https://bugzilla.samba.org/show_bug.cgi?id=14932
and
https://gitlab.com/wireshark/wireshark/-/issues/17817

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2022-02-01 21:23:48 +00:00
Stefan Metzmacher c9e1c2cf4e Revert "NTLMv2 dissector: skip target info for AUTHENTICATE_MESSAGE"
This reverts commit e8e6a2c6df.

This introduced regression of skipping valid target_info blobs.

The next commit will fix
https://gitlab.com/wireshark/wireshark/-/issues/17817
in a better way.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2022-02-01 21:23:48 +00:00
Vladimir Bespalov 0b2c35986b ZBOSS NCP renamed zbncp.data.joined 2022-02-01 21:23:05 +00:00
Roland Knall a087544ba8 Qt: Fix PacketDialog preference context menu
The context menu is not being filled in the packetdialog popup

Fixes #17803
2022-02-01 19:44:39 +00:00
John Thacker 65b44f4621 docs: tshark: read filter -> display filter
The beginning of the tshark manual talks about read filters and
using the -R option. Switch all that to display filters and -Y,
since that's the typical use now, with -R limited to two-pass
analysis.
2022-02-01 13:25:03 +00:00
Volodymyr Khomenko 43a0a3bc8b ONC-RPC: when a GSS context is destroyed, NULL proc Verifier must be dissected
When RPCGSS flavor is used and GSS context is destroyed (GSS procedure is set
to RPCSEC_GSS_DESTROY), Verifier field must be dissected as a part of 'RPC'
protocol in the same way as for other GSS procedures.  This behaviour
is explicitly defined by RFC2203 chapter '5.4 COntext Destruction'.
Reverts commit 3d81f3612b.
Fixes #17845.

Signed-off-by: Volodymyr Khomenko <Khomenko.Volodymyr@gmail.com>
2022-02-01 09:43:23 +00:00
Guy Harris 08dc06027f TShark, Wireshark: add some more documentation of "-i TCP@<host>:<port>".
Add a mention of the meaning of the "TCP@<host>:<port>" syntax in the
text about the -i option.
2022-01-31 21:31:48 -08:00
Uli Heilmeier dc16d91c37 OER: Check length
Check if length > 0 before calling proto_tree_add_item_ret_uint64() or
proto_tree_add_item_ret_uint().

Related to #17890
2022-02-01 02:37:33 +00:00
John Thacker b88b7ce798 SCTP: Fix relative sequence number calculation first pass
Calculate the relative sequence number correctly for the first
data chunk of an association in the first pass. This fixes
tshark display and fixes calculation of retransmissions if the
first data chunk of an association is retransmitted. Fix #17917.
2022-01-31 21:01:53 -05:00
Guy Harris 778fc283a7 dumpcap: add some more documentation of "-i TCP@<host>:<port>".
Add a mention of the meaning of the "TCP@<host>:<port>" syntax in the
text about the -i option.
2022-01-31 16:45:31 -08:00
Guy Harris 62c1f9e1a9 pflog: fix typo in URL. 2022-01-31 15:25:02 -08:00
ardnew 84873418da
macos-setup.sh: libtiff: refactor curl fail logic
- Rebased against master (18edc17)
2022-01-31 12:57:25 -06:00
ardnew d06e7bd0f6
macos-setup.sh: fix libtiff filename and URL
macos-setup.sh:
  - Fix filename of libtiff in existence test from "libtiff" to "tiff"
  - Added fallback URL for libtiff when the downloaded file is not a valid gzip
    archive. The host rotates older versions of libtiff into an "old"
    subdirectory, so curl downloads a 404 Web page and exits without error. Then
    the call to gzcat fails with an invalid gzip archive error. Maybe libtiff
    version should be updated instead?
2022-01-31 12:54:05 -06:00
Roman Volkov 18edc17bf3 mpeg_descriptor: add Telephone Descriptor (0x57) 2022-01-31 13:01:29 +00:00
Guy Harris 2700bd60ce pflog: more cleanups.
Fix the URL for the FreeBSD pflog code.

Make the byte order for the UID and the PID an enum, with the default
being *host*-endian, as, from a quick look at the PF code in the OSes
that have it, both the IDs are in the byte order of the host writing
the file.  (This means I need to update libpcap and libwiretap to
byte-swap them when reading a byte-swapped capture file or file section,
as we do with some other pseudo-header fields.  That's next on the
list.)

Add some comments about the signedness of the UID and PID fields.

This is the right way to handle #10202.
2022-01-31 04:45:51 -08:00
Roman Volkov a02b964b5f mpeg_descriptor: add NVOD Reference Descriptor (0x4B) 2022-01-31 07:06:18 +00:00
Uli Heilmeier 37dcb3902b DCM: Check if buf_desc is not NULL
Only use buf_desc when it is not NULL.

Related #17890
2022-01-31 06:54:36 +00:00
John Thacker b0036e01f8 SIP: Fix SIP Statistics in GUI
At some point the indices of the request and response stat tables
got switched, and stats were being looked up in the wrong table.
Use stat_tap_find_table to lookup the tables rather than hardcoding
the indices. Fix #17904
2022-01-31 02:22:03 +00:00