Commit Graph

16772 Commits

Author SHA1 Message Date
Ulf Lamping c73ed3c6d5 add Win32 Structured Exception Handling (SEH) at the same place we're already doing the Portable Exception Handling.
This way we (hopefully) can continue dissecting with the next packet, even if a more serious exception had occured, e.g. a memory access violation or a divide by zero exception.

Obviously, not all problems solved, as SEH won't protect us from other problems, e.g. endless loops and such

svn path=/trunk/; revision=17070
2006-01-22 02:22:14 +00:00
Anders Broman fded8deafc RANAP - Dissect ProtocolExtensionField IE:s
GSM A - Service Request; Mobile identity element is LV type

svn path=/trunk/; revision=17069
2006-01-21 19:12:52 +00:00
Ulf Lamping 864edeb5ac add matched coloring rule name and string to the frame dissector output (or nothing if no coloring rule matched or none was set)
svn path=/trunk/; revision=17068
2006-01-21 17:49:00 +00:00
Luis Ontanon 5ccce794e6 Another iteration, new things aren't tested yet.
Update README, to have a description of the classes



svn path=/trunk/; revision=17067
2006-01-21 14:54:57 +00:00
Ulf Lamping 89a40818e2 bugfix #709: don't g_assert returned (mandatory) length of some NDIS driver functions.
simply ignore the length returned in that cases

this way, we may "print" buggy data, but that's what the driver returned ...

svn path=/trunk/; revision=17066
2006-01-21 14:36:04 +00:00
Jörg Mayer a052b3a98b packet-bgp.c: Fix incorrect use of g_snprintf return value
mp_addr_to_str was unnecessary 'complex' - simplified it
packet-dns.c: Fix incorrect use of g_snprintf return value
packet-dcm.c: Fix incorrect use of g_snprintf return value
        Someone who understands the protocol should look at the
        "vr, tr might be used uninitialized..." warning.
packet-x11.c: Fix incorrect use of g_snprintf return value
packet-kerberos.c: Fix incorrect use of g_snprintf return value
        Someone should take a look at the
        "longjump might clobber ..." messages
packet-diameter.c: Fix incorrect use of g_snprintf return value
        Get rid of unsigned < 0 check
packet-pgm.c: Fix incorrect use of g_snprintf return value
packet-nbns.c: Fix incorrect use of g_snprintf return value
packet-winsrepl.c: Collateral damage to packet-nbns.c fix
packet-netbios.c: Collateral damage to packet-nbns.c fix
packet-netbios.h: Collateral damage to packet-nbns.c fix
packet-kerberos.c: Collateral damage to packet-nbns.c fix
packet-nbipx.c: Collateral damage to packet-nbns.c fix


svn path=/trunk/; revision=17065
2006-01-20 21:18:18 +00:00
Jaap Keuter 613d04a1ce Cleaning up copy to CSV code
svn path=/trunk/; revision=17064
2006-01-20 19:56:02 +00:00
Anders Broman f194c9eddb Dissect:
- PDPcontext
 - GSN-Address
 - QoS

svn path=/trunk/; revision=17063
2006-01-20 19:41:31 +00:00
Anders Broman ae3e48d228 Dissect:
- PDPcontext
 - GSN-Address
 - QoS

svn path=/trunk/; revision=17062
2006-01-20 19:39:38 +00:00
Anders Broman d5ee40fd86 Dissect:
- PDPcontext
- GSN-Address
- QoS

svn path=/trunk/; revision=17061
2006-01-20 19:34:53 +00:00
Anders Broman f2bc8ad4a8 Handle sgmented XUDT:s
svn path=/trunk/; revision=17060
2006-01-20 19:32:59 +00:00
Jörg Mayer 4ab485600c Add the commit message as README
svn propset svn:keywords Id *
svn propset svn:eol-style native *

Todo: svn propset svn:ignore .
  Because I don't know what to ignore

svn path=/trunk/; revision=17059
2006-01-20 09:09:26 +00:00
Jörg Mayer 256225d73f Mike Hall:
This will add the ability to configure a .1q vlan column in ethereal.

Me:
Change 1q -> 1Q

svn path=/trunk/; revision=17058
2006-01-20 08:48:43 +00:00
Luis Ontanon 3facb43c07 Starts to work so I check it in.
This is an interface to the Lua programming language.

http://www.lua.org

I've already wrote a simple dissector that calls another dissectors.

soon It will be able to register a tap and do something more.

I did not checkin changes to the Makefiles so in order to use it you must change the makefiles.

Other than that to get it to work you need to download lua-5.0.2.tar.gz into the plugin directory, uncompress it, cd to it and call make.

the interface is buggy and far from finished, time will help on this.



svn path=/trunk/; revision=17057
2006-01-20 00:06:20 +00:00
Gerald Combs b3d0b97635 Make sure we don't use the ADNS version of inet_aton; it's broken.
This fixes bug 523, but exposes more of bug 658.

The TACACS and SDP dissectors don't call inet_aton(), so don't include it.

svn path=/trunk/; revision=17056
2006-01-19 23:01:24 +00:00
Anders Broman 9d6de675a4 ext_qos_subscribed was not correctly decoded in Camel and GSM MAP
Change to use proto_add_item in packet-gsm_a.c for some octets and export value strings.

svn path=/trunk/; revision=17055
2006-01-19 18:20:14 +00:00
Anders Broman 28e69752b2 Dont dissect XDT data in case of Segmentation as that will give [Malformed packet] and the Segmentation IE will n ot be dissecterd.
svn path=/trunk/; revision=17054
2006-01-19 05:51:59 +00:00
Ulf Lamping 67e90082a7 add "RPC_E_TIMEOUT" to the reject status codes
svn path=/trunk/; revision=17053
2006-01-19 02:00:28 +00:00
Jaap Keuter ac3e6ed312 Add option presentation, solving bug 697
svn path=/trunk/; revision=17052
2006-01-18 21:41:34 +00:00
Gerald Combs f816511ea9 In packet-cops.c use proto_item_append_text() instead of creating a
separate buffer.  Fixes the current Buildbot failure.

Don't let the sprint_realloc_* functions reallocate ep_allocated memory.
Add comments warning against this in the future.

In emem.c, make sure we don't use an extra 100k every stinkin' time
someone wants to allocate memory when debugging is enabled.

Fixup whitespace.

svn path=/trunk/; revision=17051
2006-01-18 20:02:19 +00:00
Anders Broman 4ecd261cfb Change some OPCODE decodes from respons to Invoke (bug fix), let gsm_a decode som IE:s.
svn path=/trunk/; revision=17050
2006-01-17 21:52:30 +00:00
Anders Broman dbf15d9e0b Add ethertypes and value_str for IEC 61850
svn path=/trunk/; revision=17049
2006-01-17 21:50:43 +00:00
Gerald Combs 4b15bf76a7 Fix an off-by-one error. Fixes bug 698, possibly others.
svn path=/trunk/; revision=17048
2006-01-17 18:50:02 +00:00
Jörg Mayer 467de087cc According to 802.11e D11, 7.3.2.13, station count is a 16 bit value.
Accoding to 802.11, 7.1.1, numbers are little endian.

svn path=/trunk/; revision=17047
2006-01-17 13:13:29 +00:00
Jörg Mayer f905ad1862 packet-fcswils.c: Fix incorrect use of g_snprintf return
packet-wccp.c: Fix incorrect use of g_snprintf return
packet-cops.c: Fix incorrect use of g_snprintf return value
packet-wtp.c: Fix incorrect use of g_snprintf return value


svn path=/trunk/; revision=17046
2006-01-17 10:56:06 +00:00
Jörg Mayer be27196e0a - Replace snprintf by g_snprintf
- Beginning of incorrect g_snprintf retval ussage fixes
- Make qbss station count a byte again until we know
  whether the count is a 2 byte le value instead

svn path=/trunk/; revision=17045
2006-01-17 10:54:23 +00:00
Jaap Keuter d0c1a48a34 Fix typo, solving bug 693
svn path=/trunk/; revision=17044
2006-01-17 06:39:57 +00:00
Ulf Lamping 83413ca191 remove an obsolete comment
svn path=/trunk/; revision=17043
2006-01-17 01:18:51 +00:00
Ulf Lamping 8b7477f57c GTK 2.x only: show a slightly different Ethereal main icon while capturing.
I very often forget to stop a running capture, so Ethereal keeps capturing packets on and on, leaving me with a lot of unrequired packets.

On the other hand (because of the above) I often maximize Ethereal just to see that it's really not capturing any longer.

Looking at the window title isn't of much help, as this title changes with every capture file name loaded, so there's no title which can be easily remembered.

We probably might use this icon mechanism as well, when Ethereal loads a (huge) file, so the user get's a more visual feedback when the capture loading is finished (and probably for other potential "lengthy" tasks as well).

svn path=/trunk/; revision=17042
2006-01-17 00:40:32 +00:00
Ulf Lamping c59c716e7a MSVC compiler warnings:
packet-ldap.c(784) : warning C4101: 'seq_len' : unreferenced local variable
packet-ldap.c(782) : warning C4101: 'length' : unreferenced local variable
packet-ldap.c(785) : warning C4101: 'header_bytes' : unreferenced local variable

svn path=/trunk/; revision=17041
2006-01-17 00:01:22 +00:00
Ulf Lamping 6b2b3e777b add bugs #648 and #661: "Win32: Unicode chars in filenames" as they seems to be really relevant for some Win32 users
svn path=/trunk/; revision=17040
2006-01-16 23:43:06 +00:00
Jörg Mayer 1b47d72350 Update from samba tree revision 12761 to 12961
============================ Samba log start ============
------------------------------------------------------------------------
r12776 | metze | 2006-01-08 21:20:18 +0100 (Sun, 08 Jan 2006) | 3 lines
Changed paths:
   M /branches/SAMBA_4_0/source/pidl/tests/Util.pm

use $ENV{TEST_DATA_PREFIX} for test files if available

metze
------------------------------------------------------------------------
============================ Samba log end ==============


svn path=/trunk/; revision=17039
2006-01-16 16:31:54 +00:00
Jörg Mayer 1900bf87fc done:
packet-ntp.c: Rather confused and incorrect use of g_snprintf return value
packet-pim.c: whitespace change
packet-icmpv6.c: g_snprintf takes trailing \0 into account, fix off by 1 error
packet-clnp.c: Fix incorrect use of g_snprintf return value
packet-isakmp.c: g_snprintf takes trailing \0 into account
packet-tr.c: Fix incorrect use of g_snprintf return value
packet-radius.c: Fix incorrect use of g_snprintf return value
packet-radius.h: constify a string variable
packet-ldap.c: The return value isn't needed, so don't use it incorrectly
packet-tcp.c: Fix incorrect use of g_snprintf return value
packet-windows-common.c: Remove unneeded DISSECTOR_ASSERT
packet-smb-sidsnooping.c: g_snprintf takes trailing \0 into account
packet-pvfs2.c: g_snprintf takes trailing \0 into account
packet-ptp.c: Remove #include snprintf
packet-ppp.c: Fix incorrect use of g_snprintf return value
packet-ospf.c: Fix incorrect use of g_snprintf return value
packet-mip6.c: snprintf -> g_snprintf
packet-bootp.c: Remove a commented out bad use of g_snprintf
packet-ber.c: snprintf -> g_snprintf, g_snprintf takes trailing \0 into account

2do:

     52 packet-ieee80211.c: 2DO
      2 packet-nfs.c: 2DO - too many side effects
     33 packet-bgp.c: 2DO
     18 packet-dns.c: 2DO
     14 packet-dcm.c: 2DO
     13 packet-x11.c: 2DO
     11 packet-kerberos.c: 2DO
     10 packet-diameter.c: 2DO
      9 packet-snmp.c: 2DO
      9 packet-pgm.c: 2DO
      7 packet-nbns.c: 2DO
      6 packet-fcswils.c: 2DO
      5 packet-wccp.c: 2DO
      5 packet-cops.c: 2DO
      4 packet-wtp.c: 2DO


svn path=/trunk/; revision=17038
2006-01-16 07:59:44 +00:00
Jaap Keuter 5a128e3958 Remove uninitalized variable warning
svn path=/trunk/; revision=17037
2006-01-16 06:31:25 +00:00
Anders Broman c5e0d27e84 From Alejandro Vaquero:
patch to add t38 setup info for h245 packets.

- Me add /y to makefiles.

svn path=/trunk/; revision=17036
2006-01-16 06:05:25 +00:00
Anders Broman d9b0082c91 Backup changes.
svn path=/trunk/; revision=17035
2006-01-15 22:10:56 +00:00
Anders Broman ccea540c58 Sort AVP:s nummerically to make updates easier, remove double entries add nasreq AVP:s and expand some enums.
svn path=/trunk/; revision=17034
2006-01-15 22:09:41 +00:00
Jaap Keuter 815a4af69e Hi All,
Find attached a couple of changes for t38:
- Use the dissector to reassemble t30 frames
- Dissect t30 protocol
- Move the "Fax t38 analysis" to the "VoIP Calls". Now when selecting
"Statistics"->"Fax t38 analysis" option, there is a message that
redirect the user to use the "Voip calls" instead. We may keep this
option for one release, and then remove it ?
- Added in the "Voip calls" the ability to detect a t38 call if there
are not signaling associated with it. For example, when using "Decode
as.." to dissect t38 packets, it is possible to use the "Voip calls" to                                                      analyze that call.
- Display "SDP (t38)" in the "Voip calls graph" for SDP t38 sessions.

Regards
Alejandro Vaquero


svn path=/trunk/; revision=17033
2006-01-15 15:01:14 +00:00
Ulf Lamping d0dd39b277 add COTP to fragment COL_INFO message, so the user knows where the fragment is coming from
svn path=/trunk/; revision=17032
2006-01-15 13:51:58 +00:00
Jörg Mayer 122671b36c Jaap Keuter:
I'm not too fond of using pointer arithmetic in such cases. How about
this:


svn path=/trunk/; revision=17031
2006-01-14 23:09:44 +00:00
Jörg Mayer 0bfcf705cd We may not work with the length returned by g_snprintf, as this is
the number of bytes that would have been used if the buffer was long
enough.
Fixes http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=686

svn path=/trunk/; revision=17030
2006-01-14 11:29:24 +00:00
Anders Broman 6c822ae0e6 MTP3 standard in SCCP MTP3 and M3UA will be determined by Preference setting in MTP3.
svn path=/trunk/; revision=17029
2006-01-14 09:52:04 +00:00
Jörg Mayer 59bccbee5e - Change Cisco QBSS V2 to be part of the Aironet IE dissection.
- Change proto_tree_add_uint ( ...., tvb_get_guint8(...)) to
  proto_tree_add_item ( ....) for all qbss dissection code
- Change all qbss occurrences scount to be 16 bits (I may have
  gotten endianess wrong! Testers / sample captures needed)
- Change wlan_mgt.tag.aironet... filter to wlan_mgt.aironet...

svn path=/trunk/; revision=17028
2006-01-13 18:30:12 +00:00
Jaap Keuter 343b357b0e From Patrik Olsson
Attached is a patch that fixes several decoding problem is the gsm_a
dissector. The bugs are also submitted to bugzilla id #684 and #687.

svn path=/trunk/; revision=17027
2006-01-13 15:17:50 +00:00
Jörg Mayer 96576bbb3e Add code to verify the shared secret for documentation purposes.
#if 0 that code.


svn path=/trunk/; revision=17026
2006-01-13 04:35:10 +00:00
Ulf Lamping 545110c939 fix #661
Win32: convert filenames coming in from command line parameters from locale (current code page) into utf8 encoding

This must also be done for the other command line tools like tethereal, editcap and alike ...

svn path=/trunk/; revision=17025
2006-01-12 22:38:37 +00:00
Ulf Lamping a9f4ae4f99 fix #648:
Win32 only: reading a pathname from an environment var requires us to read it in as unicode somehow and convert it to utf8. Using _wgetenv should work under all circumstances on NT, using getenv and g_locale_to_utf8 on Windows OT is the best we can do in this case.


svn path=/trunk/; revision=17024
2006-01-12 22:32:29 +00:00
Jaap Keuter 6e80585275 Add warning when UDP length field is too large.
Patch by Graeme Hewson

svn path=/trunk/; revision=17023
2006-01-12 22:16:20 +00:00
Gerald Combs 62a3709da3 Reset h245_pi using CLEANUP_PUSH/CLEANUP_CALL_AND_POP so that we don't leave
ep_alloc()ated memory lying around.  Fixes bug 667.

Fixup whitespace.

svn path=/trunk/; revision=17022
2006-01-12 21:53:02 +00:00
Anders Broman e3e5ea61c2 Backup the latest edits
svn path=/trunk/; revision=17021
2006-01-12 19:27:56 +00:00