application ID zero is a valid application ID (it is often used as
experimental applciation ID). By default, the preference is disabled.
Fix the XML dictionary parser so it skips comment lines too.
svn path=/trunk/; revision=10320
"new-style" dissectors, and have them reject packets that don't start
with a version number of 1, in the hopes that it'll be less likely to
try to dissect non-Diameter packets to/from port 1812 as Diameter and
thus less likely to spew out a bunch of warnings that cause users to ask
the Ethereal mailing lists what the problem is.
Use "tcp_dissect_pdus()" to handle Diameter-over-TCP.
svn path=/trunk/; revision=10165
any string pointed to by the preference variable - as the value we set
it to is allocated, we should free it after registering the preference.
The register routine is called only once - don't worry about whether
"gbl_diameterDictionary" is null or not.
Get rid of a duplicate credit entry in the man page.
svn path=/trunk/; revision=8813
add support for a system-wide color filter file;
fix a bug where "read_filters()" didn't close the file handle.
Use the "get_datafile_path()" routine he added to construct the pathname
of the Diameter directory, the global preferences file, and the manuf
file.
svn path=/trunk/; revision=7677
qualifiers as necessary to ensure that we don't have to.
"strcmp()", "strcasecmp()", and "memcmp()" don't return booleans; don't
test their results as if they did.
Use "guint8", not "guchar", for a pointer to (one or more) 8-bit bytes.
Update Michael Tuexen's e-mail address.
svn path=/trunk/; revision=6726
equivalents for the toplevel directory. The removal of winsock2.h will
hopefully not cause any problems under MSVC++, as those files using
struct timeval still include wtap.h, which still includes winsock2.h.
svn path=/trunk/; revision=5932
static, and add a new "packet-data.h" to declare "proto_data".
Display escape sequences in octal in the IAPP dissector, as is now done
in the RADIUS dissector.
svn path=/trunk/; revision=5441
stuff from the buffer - extract what you need directly from the tvbuff.
(And definitely don't extract stuff from the buffer if you haven't
copied stuff to it.)
For integral AVP items, check the length of the item before processing
it.
Put time items into the protocol tree as times, not as byte arrays.
svn path=/trunk/; revision=4645
Include "snprintf.h", when needed, to declare "snprintf()" on platforms
that don't have it.
Fix some formats and arguments to various printing routines.
Fix "diameter_time_to_string()" to properly fetch the time value from
the data buffer handed to it.
svn path=/trunk/; revision=4639
"epan/..." pathnames, so as to avoid collisions with header files in any
of the directories in which we look (e.g., "proto.h", as some other
package has its own "proto.h" file which it installs in the top-level
include directory).
Don't add "-I" flags to search "epan", as that's no longer necessary
(and we want includes of "epan" headers to fail if the "epan/" is left
out, so that we don't re-introduce includes lacking "epan/").
svn path=/trunk/; revision=4586
the beginning, and to use underscores rather than periods where the
preference's name really isn't part of a hierarchical namespace.
Use "%u" rather than "%d" to print unsigned quantities.
svn path=/trunk/; revision=4543
structure to the "packet_info" structure; only stuff that's permanently
stored with each frame should be in the "frame_data" structure, and the
"column_info" structure is not guaranteed to hold the column values for
that frame at all times - it was only in the "frame_data" structure so
that it could be passed to dissectors, and, as all dissectors are now
passed a pointer to a "packet_info" structure, it could just as well be
put in the "packet_info" structure.
That saves memory, by shrinking the "frame_data" structure (there's one
of those per frame), and also lets us clean up the code a bit.
svn path=/trunk/; revision=4370
take a dissector handle as an argument, rather than a pointer to a
dissector function and a protocol ID. Associate dissector handles with
dissector table entries.
svn path=/trunk/; revision=4308
obsolete; we silently ignore attempts to set those in a preferences
file, so that we don't spam the user with error messages caused by them
having saved preferences in an earlier release that contained those
preferences.
Make the Diameter and iSCSI dissectors register obsolete preferences.
Crash if some code tries to register a preferences module with a name
that contains something other than lower-case ASCII letters, numbers, or
underscores, or that has already been registered, or if some code tries
to register a preference with a name that contains something other than
lower-case ASCII letters, numbers, underscores, or periods, or that has
already been registered, so that we don't put code like that in a
release and have to shovel code into "prefs.c" to fix it up later. (The
problem with multiple modules or preferences with the same name should
be obvious; the problem with names with blanks, or upper-case letters,
or punctuation, is that they're a pain to type on the command line.)
svn path=/trunk/; revision=4148
FT_INT64 type, and make the Diameter dissector use it.
Handle the 64-bit integer types in the display filter semantics checks.
svn path=/trunk/; revision=4125
without requiring compiler support for them, and updates to the
Diameter, L2TP, NFS, and NLM dissectors to use it and to the ONC RPC
dissector to allow ONC RPC subdissectors to use it.
svn path=/trunk/; revision=4099
data type "gint64" really is - should be sufficiient for a %llx format,
and not all compilers that support 64-bit data types have "long long".
svn path=/trunk/; revision=3820
draft-ietf-aaa-diameter-07. His changenotes:
Changes:
o Flags are now done properly. (I changed it to dissect
them like packet-tcp.c does)
o Completely re-did the dictionary. I think it is much
more maintainable now. And, it is no longer dynamically
generated.
o Added some lookup routines to work with new dictionary.
o Removed lots of old lookup stuff that had been cloned
from packet-radius.c. It's much cleaner now.
svn path=/trunk/; revision=3799
anything from the packet, so that if we throw an exception before
setting the Info column, it doesn't have stuff left over from the
previous dissector.
Tvbuffify the RADIUS dissector.
svn path=/trunk/; revision=3055
defined.
Use "gint64" and "guint64", not "long long int", for 64-bit integral
types, so that this code works with compilers (such as Microsoft Visual
C++) that have 64-bit integral types but that don't call them "long
long".
Use "pntohll()" to extract 64-bit integral types from a field.
Put a "break;" into a "default:" clause - MSVC++ doesn't like
switch (XXX) {
...
default:
}
svn path=/trunk/; revision=3051
It doesn't do DIAMETER-over-UDP, so the RADIUS dissector no longer
checks for DIAMETER packets and calls the DIAMETER dissector if it finds
one.
svn path=/trunk/; revision=3049
Olivier Biot