Commit Graph

17 Commits

Author SHA1 Message Date
Evan Huus cbba4d518e Fix typo s/jounral/journal/ as pointed out in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8504

svn path=/trunk/; revision=48477
2013-03-22 12:34:50 +00:00
Evan Huus 80cd2ec768 Remove some sanity checks that I was able to prove wrong and/or redundant by
manual flow analysis. Fixes part of
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8504

General note: this dissector does *weird* things with sanity checks and
manually throwing exceptions. It needs a general cleanup, but that
is outside the scope of the current bug (and my available time).

svn path=/trunk/; revision=48473
2013-03-22 00:43:12 +00:00
Evan Huus db122cefe4 Remove 55(!) thoroughly unnecessary tvb_bytes_exist calls from RTP-MIDI
dissector. Discovered while poking around in
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8504

svn path=/trunk/; revision=48472
2013-03-22 00:27:29 +00:00
Guy Harris 8ed7a73e22 Fix a bunch of warnings.
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748
2012-12-26 05:57:06 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address.
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Bill Meier bab856a504 General cleanup including as appropriate:
- Remove unneeded #include files (string.h, addr_resolv.h);
 - Remove unneeded 'if(!initialized){...}' in proto_reg_handoff();
 - Reformat hf[] entries;
 - Remove unneeded variable initializations;
 - "localize" some variables;
 - Whitespace/indentation/long lines/formatting
(in one case: re-order code slightly to not do col_set_str() & etc until
              after initial "frame acceptance testing" by dissector.

svn path=/trunk/; revision=42683
2012-05-17 20:13:22 +00:00
Chris Maynard 76f582c58d Fix logic bug. I'm sure this was something Coverity found and I fixed but forgot to commit it. Unfortunately Coverity has upgraded to Scan 5.5 and things are different now so I can't cross reference which CID this was anymore.
svn path=/trunk/; revision=42395
2012-05-03 14:00:56 +00:00
Jakub Zawadzki 8a1dc57c03 Remove doubled semicolons and semicolons outside function.
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
Jörg Mayer adc575f065 gcc.47 would complain that rsoffset might be used uninitialized
when passed by reference. Init to 0 to silence this warning.

Some whitespace fixes.

svn path=/trunk/; revision=41846
2012-03-30 14:48:37 +00:00
Anders Broman edbdf1b6de Don't register the payload type unless it's in the dynamic range
svn path=/trunk/; revision=41460
2012-03-10 17:00:30 +00:00
Alexis La Goutte 08006ac943 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=41303
2012-03-02 11:04:31 +00:00
Anders Broman 210331411a More Warning fixes.
svn path=/trunk/; revision=41207
2012-02-27 12:48:08 +00:00
Anders Broman 8ad3109708 More warning fixes.
svn path=/trunk/; revision=41206
2012-02-27 12:13:06 +00:00
Anders Broman 6734e90b9c Try to fix warning: comparison between signed and unsigned.
svn path=/trunk/; revision=41205
2012-02-27 11:48:38 +00:00
Anders Broman cb46002a19 Fix some unused parameter warnings etc.
svn path=/trunk/; revision=41204
2012-02-27 11:44:19 +00:00
Anders Broman 06cee2dfe3 From Tobias Erichsen:
RTP-MIDI - dissector for transmission of MIDI-commands via RTP (RFC 4695).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5451

svn path=/trunk/; revision=41200
2012-02-27 09:18:53 +00:00