osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
45,868 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

163 Commits

Author SHA1 Message Date
Evan Huus 37600a157b Rename value string (and similar) functions to use a consistent pattern. This 
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).

Use a consistent coding style, and make proper use of the WS_DLL_* defines.

Group the functions appropriately in the header.

I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.

Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467

svn path=/trunk/; revision=48634
 2013-03-29 00:26:23 +00:00
Anders Broman 7c56677cf9 From beroset: 
remove C++ incompatibilities 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416

svn path=/trunk/; revision=48429
 2013-03-19 21:22:31 +00:00
Bill Meier d449c31d1d its ==> it's & it's ==> its as needed. 
svn path=/trunk/; revision=47892
 2013-02-26 01:22:18 +00:00
Guy Harris 021069a56b Clean up white space - get rid of 4-space tabs. 
Reformat the hf[] array to be consistent, and get rid of some bogus
blurbs (probably copy-and-pasteos).

svn path=/trunk/; revision=47759
 2013-02-20 01:37:08 +00:00
Bill Meier 8ef31f222e Hack: disguise '/*' in text strings to prevent checkAPIs & etc seeing 'start of comment' within a text string. 
svn path=/trunk/; revision=47446
 2013-02-02 14:20:15 +00:00
Evan Huus 518eee193b Use epan-scoped memory to clean up another 1Kb+ of valgrind 
sorta-false-positive leaks.

svn path=/trunk/; revision=47170
 2013-01-19 20:14:42 +00:00
Pascal Quantin 53edadd49b From John Batty via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8087 : 
H.248 MEGACO PkgName property is poorly formatted

svn path=/trunk/; revision=46526
 2012-12-13 14:24:44 +00:00
Jakub Zawadzki 7a9d27c33f Regenerate asn.1 dissectors. 
svn path=/trunk/; revision=45110
 2012-09-24 19:38:46 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Anders Broman 6dfa10bc57 Revert part of revision 43107 which broke sub dissection of 
Signal and events as a new tvb wasn't created. 
|BASE_EXT_STRING also removed.

svn path=/trunk/; revision=43661
 2012-07-11 14:40:35 +00:00
Jakub Zawadzki bf81b42e1e Update Free Software Foundation address. 
(COPYING will be updated in next commit)

svn path=/trunk/; revision=43536
 2012-06-28 22:56:06 +00:00
Anders Broman 3cdd0278aa Add a link to IANA registry. 
svn path=/trunk/; revision=43403
 2012-06-20 10:47:18 +00:00
Anders Broman 189ea54f0b from Alex Lindberg: 
Update to packet-h248.c and associated h248 dissecorts.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7332

svn path=/trunk/; revision=43107
 2012-06-05 10:54:21 +00:00
Guy Harris c51cadd00e Get rid of remaining Booleans-as-encoding-arguments in 
proto_tree_add_item() calls.

svn path=/trunk/; revision=42488
 2012-05-07 22:46:14 +00:00
Anders Broman fd19aa7c89 H.248 Annex E dissector does not properly dissect event parameters 
(Update the h.248 dissector's package registration to support v1 packets.)

Applying part of the patch from Alex Lindberg in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6915 by hand.
Fixes bug
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4842

svn path=/trunk/; revision=41526
 2012-03-13 13:26:13 +00:00
Jeff Morriss 183f0e934c Create a list of MTP Service Indicator macros and use them. 
svn path=/trunk/; revision=40828
 2012-02-03 18:26:37 +00:00
Anders Broman 34ea886454 [-Wunused-but-set-variable] 
svn path=/trunk/; revision=39829
 2011-11-14 17:35:04 +00:00
Anders Broman fa7ea2ea34 fix [-Wunused-but-set-variable] 
svn path=/trunk/; revision=39803
 2011-11-12 12:37:38 +00:00
Bill Meier 794757ae8f For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg. 
Also: remove trailing whitespace for a number of files.

svn path=/trunk/; revision=39503
 2011-10-21 02:10:19 +00:00
Bill Meier 24cf0aad06 Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss; 
The only change in each file is in a comment showing the asn2wrs cmd used to build that file.

svn path=/trunk/; revision=39427
 2011-10-15 19:27:27 +00:00
Jeff Morriss f3f9f2697f Make TVBs opaque for most users. 
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions.

svn path=/trunk/; revision=37422
 2011-05-27 03:06:50 +00:00
Gerald Combs 01e072411f Regenerate more ASN.1 dissectors for Coverity. 
svn path=/trunk/; revision=36609
 2011-04-12 20:45:25 +00:00
Guy Harris a8bc4a0d13 Rename the routines that handle dissector tables with unsigned integer 
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys.  (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)

svn path=/trunk/; revision=35224
 2010-12-20 05:35:29 +00:00
Bill Meier b1554fc198 Use value_string_ext fcns to access certain value_string arrays; 
Whitespace cleanup.

svn path=/trunk/; revision=34882
 2010-11-15 19:08:12 +00:00
Bill Meier ed7105e21b Update package_name_vals[] value_string array: 
- Add new entries based on: http://www.iana.org/assignments/megaco-h248 last updated 2010-10-01;
- Fix a typo (incorrect value for an entry);
- Switch values between two entries to match the IANA list;
- Switch two entries so list is in ascending order by value.

svn path=/trunk/; revision=34881
 2010-11-15 19:00:16 +00:00
Jeff Morriss a0c858efcd Add a little more code to avoid not-very-useful blurbs: 
- Change spaces in the name to underscores before comparing it to the blurb.
  - Check if the type simply as T_ prepended to the name.
  - Don't put in a blurb of "NULL".

and regenerate the dissectors.

svn path=/trunk/; revision=32748
 2010-05-11 03:53:31 +00:00
Jeff Morriss 8f210cf4e0 Regenerate a few of the ASN.1 dissectors 
svn path=/trunk/; revision=32742
 2010-05-11 02:13:26 +00:00
Anders Broman eb136e00d8 From Alex Lindberg: 
resolves all h248V1 differences and provides dissection of V1
instances of Packets, Events, Signals, and Properties.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3999

svn path=/trunk/; revision=31597
 2010-01-21 06:39:25 +00:00
Anders Broman a255c08b66 Get rid of check_col(); 
svn path=/trunk/; revision=31546
 2010-01-17 12:46:00 +00:00
Kovarththanan Rajaratnam 9490d1b74c Regenerate asn1 dissectors (no change, only some line offset changes) 
svn path=/trunk/; revision=30454
 2009-10-09 21:34:49 +00:00
Kovarththanan Rajaratnam a9ed97b344 From Gerasimos Dimitriadis via. bug 4104: 
When dissecting a h248 message, col_set_str is called with a string from the ephemeral pool and an assertion fails.

svn path=/trunk/; revision=30398
 2009-10-08 13:17:51 +00:00
Stig Bjørlykke e2d6320d75 Only include config.h in C files, to avoid multiple inclusion. 
svn path=/trunk/; revision=30182
 2009-09-28 17:58:47 +00:00
Anders Broman 8a23b29c91 From Alex Lindberg: 
Add H248V1 suport.
(H248 dissector fails on poorly formed AuditReply packet from Media Gateway)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953

svn path=/trunk/; revision=29835
 2009-09-10 05:57:30 +00:00
Anders Broman 3d2e307ae6 From Alex Lindberg: 
Update to h248v3.asn

Applied the change from the Amendment 1 by hand.

svn path=/trunk/; revision=29787
 2009-09-08 09:11:21 +00:00
Kovarththanan Rajaratnam 17c9803cac Sanitize epan includes 
svn path=/trunk/; revision=29499
 2009-08-21 20:25:24 +00:00
Kovarththanan Rajaratnam e971354a54 Don't guard col_set_str (COL_PROTOCOL) with col_check 
svn path=/trunk/; revision=29340
 2009-08-09 06:26:46 +00:00
Anders Broman 9b9880a25a From yin sun: 
h248 term wildcard enhancement

svn path=/trunk/; revision=28861
 2009-06-27 13:37:03 +00:00
Stig Bjørlykke 9733aadcfe Re-generate asn1 dissectors after hf_register_info cleanup. 
svn path=/trunk/; revision=28848
 2009-06-26 03:59:01 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548: 
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
 2009-06-18 21:30:42 +00:00
Stig Bjørlykke c47e788c94 Regenerate all asn2wrs generated dissectors. 
svn path=/trunk/; revision=28379
 2009-05-16 22:07:03 +00:00
Anders Broman 7afd67fd94 Update value strings. 
svn path=/trunk/; revision=27916
 2009-03-31 18:52:36 +00:00
Bill Meier a8f30cbca1 Fix some typos and spelling (mostly in text strings) 
svn path=/trunk/; revision=27037
 2008-12-17 17:23:37 +00:00
Bill Meier 7280c469a3 Fix some spelling/typos 
svn path=/trunk/; revision=27024
 2008-12-16 14:18:55 +00:00
Bill Meier 09e139a234 asn2wrs generated files changed as a result of recent asn1 template changes 
svn path=/trunk/; revision=26698
 2008-11-04 22:28:52 +00:00
Anders Broman e375c3990a Regenerate all asn2wrs generated dissectors 
svn path=/trunk/; revision=26670
 2008-11-01 22:30:14 +00:00
Gerald Combs 09868c5db5 Fix some checkAPIs warnings. 
svn path=/trunk/; revision=25617
 2008-06-27 16:07:21 +00:00
Anders Broman aa81806094 Update package name from IANA's list. 
svn path=/trunk/; revision=24078
 2008-01-13 17:03:06 +00:00
Anders Broman 02c27c89f0 transactionId wasn't processed for: 
SegmentReply/transactionId
TransactionReply/transactionId
TransactionPending/transactionId
Fixes bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2165

svn path=/trunk/; revision=24077
 2008-01-13 16:07:52 +00:00
Anders Broman de16039c51 Get rid of dissect_ber_boolean_value() and change the signature of 
dissect_ber_boolean() to return a value and update asn2wrs to generate the new signature.
Regenerate all BER dissectors.

svn path=/trunk/; revision=24015
 2008-01-04 16:21:07 +00:00
Anders Broman 73fee653de Get rid of ber_last_created_item(). (Final?) 
svn path=/trunk/; revision=24010
 2008-01-04 13:39:24 +00:00