osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
45,868 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

102 Commits

Author SHA1 Message Date
Chris Maynard 9c6325a069 Properly dissect lat and long according to 3GPP TS 23.032. Fix incorrect display filters for hf_gsm_a_geo_loc_deg_of_lat and hf_gsm_a_geo_loc_deg_of_long. 
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8532
#BACKPORT(1.6,1.8)

svn path=/trunk/; revision=48613
 2013-03-28 14:23:07 +00:00
Pascal Quantin 1af56ab0c7 Upgrade NAS disssectors to v11.6.0 
svn path=/trunk/; revision=48427
 2013-03-19 20:47:48 +00:00
Pascal Quantin f904464fe9 Add a missing static 
svn path=/trunk/; revision=48410
 2013-03-18 22:58:36 +00:00
Pascal Quantin 86eda54fe6 As suggested by Evan Huus, use extended value_strings 
svn path=/trunk/; revision=48407
 2013-03-18 22:21:53 +00:00
Pascal Quantin 94f330030d use enum values instead of hardcoded values 
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487)

svn path=/trunk/; revision=48397
 2013-03-18 20:26:47 +00:00
Pascal Quantin ae61fe0158 Try to fix dissection of GSM protocol family broken by r47209. 
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)


svn path=/trunk/; revision=47218
 2013-01-22 23:25:44 +00:00
Jaap Keuter 6a6aaf7409 Fix for CID 717414-717435. 
Never ever access a string in a value string by its array index.
Use the proper access functions (val_to_str[_ext] and friends).

Also: make clean compile, so move out of dirty dissectors.

svn path=/trunk/; revision=47209
 2013-01-22 07:18:20 +00:00
Anders Broman 54cb9e70ab Use tvb_bcd_dig_to_ep_str 
svn path=/trunk/; revision=46858
 2012-12-30 11:10:35 +00:00
Pascal Quantin 0b20f855f0 Upgrade NAS disssectors to v11.5.0 
svn path=/trunk/; revision=46842
 2012-12-29 17:10:04 +00:00
Guy Harris 8ed7a73e22 Fix a bunch of warnings. 
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748
 2012-12-26 05:57:06 +00:00
Bill Meier cd859fd85f Fix several purported [-Wshadow] warnings; 
svn path=/trunk/; revision=46189
 2012-11-25 22:16:22 +00:00
Anders Broman 7a4b359823 GSM classmark3 8-PSK decode error 
proto_tree_add_bits_item() can't be called with a length value of -1.
Calculate the value, fixes BUG:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7964

#BACKOPRT

svn path=/trunk/; revision=45980
 2012-11-09 08:58:42 +00:00
Pascal Quantin 04ba20fa0e Upgrade NAS dissector to v11.4.0 (Release 11) 
svn path=/trunk/; revision=45325
 2012-10-04 21:23:06 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not. 
svn path=/trunk/; revision=45017
 2012-09-20 02:03:38 +00:00
Pascal Quantin 7da4784b25 Following r44648, revert part of r44162 and followups so as to have a top level gsm_a filter name 
svn path=/trunk/; revision=44667
 2012-08-25 13:32:41 +00:00
Pascal Quantin 6c8d938dd4 Follow-up of r44162: clean more filters 
svn path=/trunk/; revision=44187
 2012-08-01 14:07:18 +00:00
Pascal Quantin 70ea1804d8 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7524 : 
8-PSK structure in GSM Classmark 3 is not properly dissected

svn path=/trunk/; revision=44008
 2012-07-25 20:04:33 +00:00
Jakub Zawadzki b18e880040 Update FSF address - part II. 
svn path=/trunk/; revision=43538
 2012-06-28 23:18:38 +00:00
Pascal Quantin e68222ebfd Fix copy/paste errors 
svn path=/trunk/; revision=43447
 2012-06-23 14:11:06 +00:00
Anders Broman a0910557c7 Get rid of a couple of warnings. 
svn path=/trunk/; revision=43064
 2012-06-04 12:20:37 +00:00
pascal 0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs) 
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
 2012-05-21 19:27:38 +00:00
pascal 254fcdfe19 Upgrade NAS dissector to Release 10 (v10.6.1) 
svn path=/trunk/; revision=42728
 2012-05-20 20:56:42 +00:00
pascal 774748914f Upgrade NAS EPS dissector to Release 10 (10.6.1) 
svn path=/trunk/; revision=42722
 2012-05-20 09:50:34 +00:00
Bill Meier d53320919a Remove unneeded #includes (stdlib, stdio, ctypes, time); 
In a few cases: do some whitespace, indentation cleanup & reformatting.

svn path=/trunk/; revision=42632
 2012-05-15 19:23:35 +00:00
Guy Harris a93f134b99 checkapi said 
Error: the blurb for field "NMO I" ("gsm_a.nmo_1") has trailing
	    space in packet-gsm_a_common.c

so remove the trailing space.

svn path=/trunk/; revision=42087
 2012-04-15 17:37:16 +00:00
pascal 1e2f3bb55a Update RRC to V10.7.0 and add dissection of Core Network System Information IEs 
svn path=/trunk/; revision=42081
 2012-04-15 11:51:40 +00:00
Bill Meier bc30c6d5aa FT_BOOLEAN hf[] entries with a 0 'bitmask' should have 'display' = BASE_NONE; 
Convert "4 space tabs" to "4 spaces";
General whitespace & formatting changes.

svn path=/trunk/; revision=41580
 2012-03-15 23:19:28 +00:00
Bill Meier de43e2c55b hg_gsm_a_vamos_level --> hf_gsm_a_vamos_level 
svn path=/trunk/; revision=41550
 2012-03-14 18:57:17 +00:00
Anders Broman 017351556b From Sylvain Munaut: 
packet-gmr1_rr: Add dissector for GMR-1 RR elements and CCCH messages (Step 2).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921

svn path=/trunk/; revision=41448
 2012-03-09 12:15:08 +00:00
Anders Broman a908ffac57 From Sylvain Munaut: 
GMR-1: Add dissections for various GMR 04.08 elements (Step1).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6921

svn path=/trunk/; revision=41446
 2012-03-09 09:38:21 +00:00
Anders Broman e512e8b691 From Sylvain Munaut: gsm_a_common: elem_v_short doesn't create subtree for the IE https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6923 
svn path=/trunk/; revision=41432
 2012-03-08 11:09:39 +00:00
Jeff Morriss 5ca357f245 Don't use FT_BOOLEAN with value_strings: the code to generate 
representations of former is expecting true_false_strings--which are quite
different than the latter.

svn path=/trunk/; revision=41363
 2012-03-06 02:19:23 +00:00
Alexis La Goutte aa4a11af37 Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang 
svn path=/trunk/; revision=41315
 2012-03-02 11:09:34 +00:00
Anders Broman f5f746f54f From Mike Morrin: 
eliminates the global variable for tracking which nibble is
to be decoded by taking advantage of the fact that half octet IEs always occur
in pairs, and thus a pair can be grouped together for decoding.

There was probably also some confusion caused by the macros UPPER_NIBBLE and
LOWER_NIBBLE because the GSM bit numbering is opposite to Wireshark internal
numbering, so I have changed these to be LEFT_NIBBLE and RIGHT_NIBBLE, which
corresponds to the display format in Wireshark.

The dissection order of half octet IEs has been adjusted where necessary to
align with the ordering shown in the GSM specifications.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6658

svn path=/trunk/; revision=40157
 2011-12-12 07:24:57 +00:00
Anders Broman ae8165fd4c Fix some set but not used [-Wunused-but-set-variable] warnings. 
svn path=/trunk/; revision=39579
 2011-10-25 20:08:26 +00:00
Bill Meier 8fc194c881 Fix a 'set but not used' compiler warning. 
svn path=/trunk/; revision=39430
 2011-10-15 20:39:35 +00:00
Anders Broman 0a65432f96 Use ENC_BIG_ENDIAN. 
svn path=/trunk/; revision=38135
 2011-07-20 14:09:19 +00:00
Anders Broman 7dce5861cc From Pascal Quantin: 
Enhance the dissection of MM, GMM, SM, EPS EMM and EPS ESM
protocols according to 3GPP 24.008 V9.6.0 and 24.301 V9.6.0.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5866

svn path=/trunk/; revision=36918
 2011-04-27 22:18:00 +00:00
Anders Broman a7d7365f4a Mark pinfo as unused. 
svn path=/trunk/; revision=36445
 2011-04-04 15:09:22 +00:00
Anders Broman aaf0d277b8 Get rid of gsm_a_dtap_pinfo. 
svn path=/trunk/; revision=36444
 2011-04-04 14:49:14 +00:00
Anders Broman 8d6ca293dc Change the signature of elem_fcn():ns to include pinfo. 
svn path=/trunk/; revision=36443
 2011-04-04 14:37:25 +00:00
Anders Broman a469849210 From Pascal Quantin: 
[3GPP protocols] Prettify the display of Mandatory Value information elements

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711

svn path=/trunk/; revision=36026
 2011-02-22 11:56:10 +00:00
Stephen Fisher 1980a286ac Fix compilation error: gsm_a_dir_of_ver_speed_vals is a VALS not a TFS. 
svn path=/trunk/; revision=35739
 2011-02-01 00:46:59 +00:00
Anders Broman 882874e91c More IE dissection. 
svn path=/trunk/; revision=35736
 2011-01-31 22:25:19 +00:00
Stephen Fisher 53fec4ae34 Fix compilation errors 
svn path=/trunk/; revision=35673
 2011-01-26 23:11:08 +00:00
Anders Broman 68f4f61017 Dissect PS-HANDOVER-REQUEST. 
svn path=/trunk/; revision=35666
 2011-01-26 19:44:23 +00:00
Anders Broman 57f8048743 Add 10.5.1.14 NAS container for PS HO. 
svn path=/trunk/; revision=35665
 2011-01-26 19:37:30 +00:00
Anders Broman dd1ab4b227 Use EXTRANEOUS_DATA_CHECK_EXPERT 
svn path=/trunk/; revision=35608
 2011-01-21 09:31:25 +00:00
Anders Broman cbc7cbd1b2 Handle two length octets correctly in TELV. 
svn path=/trunk/; revision=35573
 2011-01-17 21:12:30 +00:00
Anders Broman fe7213590b Restore dissection of Mobile Identity(revert the code). 
svn path=/trunk/; revision=35567
 2011-01-17 14:18:54 +00:00