Pascal Quantin
e832253278
From Vineeth via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8450 :
...
Do not try to systematically fetch a third digit for Country Code: its length can be from 1 to 3 digits.
svn path=/trunk/; revision=48697
2013-04-02 13:09:15 +00:00
Pascal Quantin
36ad3475d9
Remove non ASCII characters
...
svn path=/trunk/; revision=48695
2013-04-02 08:34:09 +00:00
Anders Broman
3d2ca39863
Dissect more of 3GPP2_OBJECT.
...
svn path=/trunk/; revision=48694
2013-04-02 05:54:47 +00:00
Jaap Keuter
a62cc81d4b
Now only if I can get the case right :)
...
svn path=/trunk/; revision=48686
2013-04-01 15:33:42 +00:00
Jaap Keuter
97136126bc
Typo's. That is all.
...
svn path=/trunk/; revision=48685
2013-04-01 15:29:49 +00:00
Jaap Keuter
dfc87f20df
Fix for bug 8548:
...
Allow the IRC command and response dissection functions to be called with
subsets of the original (full) message line. Therefore we need to calculate
with real lengths and offsets, not mixed with lengths of the subset itself.
svn path=/trunk/; revision=48684
2013-04-01 14:09:44 +00:00
Anders Broman
2328de7bf8
Unused parameter.
...
svn path=/trunk/; revision=48681
2013-03-31 22:27:58 +00:00
Anders Broman
1f74d7a1b2
Initial decoding of 3GPP2_OBJECT.
...
svn path=/trunk/; revision=48679
2013-03-31 22:08:00 +00:00
Martin Kaiser
5ae86d3b2f
coverity 281315 logically dead code
...
svn path=/trunk/; revision=48676
2013-03-31 18:10:45 +00:00
Gerald Combs
84134c9e9c
[Automatic manuf, services and enterprise-numbers update for 2013-03-31]
...
svn path=/trunk/; revision=48671
2013-03-31 14:03:28 +00:00
Martin Kaiser
421cd9eaac
remove empty else-branches
...
svn path=/trunk/; revision=48670
2013-03-31 12:16:41 +00:00
Martin Kaiser
4f55532d59
TABs -> spaces
...
add editor modelines
svn path=/trunk/; revision=48669
2013-03-31 12:12:03 +00:00
Jaap Keuter
d2efac96b3
From Hauke Mehrtens:
...
Wireshark misses some new TLS and DTLS cipher suite names which are assigned by IANA.
svn path=/trunk/; revision=48664
2013-03-30 22:52:13 +00:00
Evan Huus
42ec0d8f0d
Hopefully fix a false-positive warning in the Mac buildbot.
...
It complains that service_info may be used uninitialized, but my manual analysis
agrees with GCC 4.7 that it can't, so just defaulting it to NULL will be fine.
svn path=/trunk/; revision=48663
2013-03-30 22:00:43 +00:00
Evan Huus
ff9c205f94
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
...
Add basic support for Bluetooth GNSS profile. It uses NMEA-0183, but that is not
free, so all we can do is add filtering and displaying for ASCII content.
Also add colors for DUN, GNSS to show them in contrast to RFCOMM.
svn path=/trunk/; revision=48662
2013-03-30 21:54:42 +00:00
Evan Huus
6976653023
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
...
Unify bluetooth direction handling (sent vs rcvd).
svn path=/trunk/; revision=48661
2013-03-30 21:47:27 +00:00
Evan Huus
6d17f1153a
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
...
Round 3 of Bluetooth SDP updates. Update the list of company IDs and fix
service recognition.
svn path=/trunk/; revision=48660
2013-03-30 21:43:18 +00:00
Martin Kaiser
77c9d43ce4
coverity 993742: potential division by zero
...
svn path=/trunk/; revision=48659
2013-03-30 19:16:51 +00:00
Martin Kaiser
94ea9af46c
fix indentation in one place
...
svn path=/trunk/; revision=48658
2013-03-30 19:15:29 +00:00
Martin Kaiser
3467c98afc
coverity 280417: logically dead code
...
svn path=/trunk/; revision=48657
2013-03-30 18:57:44 +00:00
Jaap Keuter
4e09bed012
From Tyson Key:
...
The attached patch adds support for dissection of SAMConfiguration request packets,
and updates the opcode table to identify their corresponding (null/empty) responses.
svn path=/trunk/; revision=48656
2013-03-30 17:09:26 +00:00
Evan Huus
02dff20783
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
...
Round 2 of Bluetooth SDP updates:
- replace a lot of proto_tree_add_text with named fields
- dissect more of the protocol
- misc fixes
svn path=/trunk/; revision=48655
2013-03-30 15:53:04 +00:00
Martin Kaiser
9ca8ee6c06
dissect CI+ Protection Descriptor
...
svn path=/trunk/; revision=48651
2013-03-30 10:59:30 +00:00
Martin Kaiser
b3bad40c60
use proto_mpeg_descriptor_loop_dissect() in the SDT descriptor loop
...
this takes private descriptors into account
svn path=/trunk/; revision=48650
2013-03-30 10:41:37 +00:00
Evan Huus
e964ab4164
Bump two guint16 to guint32 to prevent overflow when reassembling a large
...
number of fragments, and add an extra bounds check.
Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8540
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8541
svn path=/trunk/; revision=48644
2013-03-29 22:20:04 +00:00
Evan Huus
016f8e8d8c
Add some missing #includes to hopefully fix check-abi buildbot.
...
svn path=/trunk/; revision=48641
2013-03-29 17:43:14 +00:00
Evan Huus
ea6d7d8a34
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8509
...
First round of fixes for Bluetooth SDP.
From me:
- rename one call of match_strval to try_val_to_str instead
- remove a few hf entries that really belong with the second patch (they
weren't used in this one)
svn path=/trunk/; revision=48640
2013-03-29 17:25:23 +00:00
Pascal Quantin
5c46fcea6a
From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8506 :
...
Fix incompatible display filters using the same name
svn path=/trunk/; revision=48638
2013-03-29 13:22:53 +00:00
Michael Tüxen
7b7680f3ff
Add support for new version of the ID which has been adopted as a WG item.
...
The now version will be supported by Firefox soon.
svn path=/trunk/; revision=48637
2013-03-29 13:01:52 +00:00
Evan Huus
03b48f94c2
Fix two instances of col_set_str being used with ephemeral memory returned
...
from val_to_str. Use col_add_str instead.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8537
svn path=/trunk/; revision=48636
2013-03-29 02:46:06 +00:00
Evan Huus
a0d107beec
Remove decode_enumerated_bitfield and decode_enumerated_bitfield_shifted.
...
Effectively inline the only remain call (and replace a static buffer with ep
memory). Much of the NFS dissector needs to be converted to use named fields
at which point this code can go away, but that's a much bigger job.
Also, add modelines to packet-nfs.c and mark some internal value_string
functions as WS_DLL_LOCAL.
svn path=/trunk/; revision=48635
2013-03-29 02:34:23 +00:00
Evan Huus
37600a157b
Rename value string (and similar) functions to use a consistent pattern. This
...
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).
Use a consistent coding style, and make proper use of the WS_DLL_* defines.
Group the functions appropriately in the header.
I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
Chris Maynard
10260116f8
Fix incorrectly duplicated display filter for hf_openwire_throwable_linenumber.
...
#BACKPORT(1.8)
svn path=/trunk/; revision=48628
2013-03-28 18:16:52 +00:00
Chris Maynard
5e7d4af0d0
The uniqueness bit occurs in 2 different places, so go ahead and use both hf_nhrp_flag_U1 and hf_nhrp_flag_U2, but change the common display filter from "nhrp.flag.u1" to simply "nhrp.flag.u".
...
#BACKPORT(1.6, 1.8)???
svn path=/trunk/; revision=48626
2013-03-28 18:13:12 +00:00
Anders Broman
8e1b0ac304
Register a dissector table for Normal Vendor/Organization Specific Extension(NVSE) and use it for 3GPP2.
...
svn path=/trunk/; revision=48623
2013-03-28 16:55:06 +00:00
Chris Maynard
fc78e677a8
Fix Coverity CID's 280305-280306: Negative loop bound. (These are yet more annoying instances of not properly dealing with tvb_reported_length_remaining() possibly returning -1.)
...
#BACKPORT(1.6,1.8)
svn path=/trunk/; revision=48622
2013-03-28 16:02:41 +00:00
Chris Maynard
be892e31c0
Fix the remaining instances of Coverity CID's 741992 and 986498, which should have been committed with r47073 and r47830, respectively. (I find Coverity doesn't always make it so obvious that there's more than 1 instance for a given CID.)
...
svn path=/trunk/; revision=48621
2013-03-28 15:41:25 +00:00
Chris Maynard
bbf2beaa53
Fix Coverity CID's 281433 and 281434: Unintended sign extension. (18 instances)
...
Fix Coverity CID 702381: Missing break in switch.
Add an "XXX" note regarding the framing_rtp assignment, since something appears to be missing.
#BACKPORT(1.8)
svn path=/trunk/; revision=48620
2013-03-28 15:28:12 +00:00
Chris Maynard
64f0e71d07
first_flag should be static.
...
#BACKPORT(1.6,1.8)
svn path=/trunk/; revision=48619
2013-03-28 15:07:32 +00:00
Evan Huus
045152353c
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8536
...
Fix unrecognised CID session payload in bluetooth if there are multiple sessions
with the same DCID.
svn path=/trunk/; revision=48618
2013-03-28 15:05:46 +00:00
Evan Huus
63987d2894
From Dario Lombardo via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8506
...
Proper authorship and attribution information for
VITA 49 Radio Transport dissector.
svn path=/trunk/; revision=48617
2013-03-28 15:01:35 +00:00
Chris Maynard
476831d9de
Fix the incorrectly duplicated display filter for hf_kdsp_source_name.
...
#BACKPORT(1.8)
svn path=/trunk/; revision=48616
2013-03-28 14:56:58 +00:00
Chris Maynard
c9004d102e
Fix the incorrectly duplicated display filter for hf_gearman_data_content.
...
svn path=/trunk/; revision=48614
2013-03-28 14:49:41 +00:00
Chris Maynard
9c6325a069
Properly dissect lat and long according to 3GPP TS 23.032. Fix incorrect display filters for hf_gsm_a_geo_loc_deg_of_lat and hf_gsm_a_geo_loc_deg_of_long.
...
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8532
#BACKPORT(1.6,1.8)
svn path=/trunk/; revision=48613
2013-03-28 14:23:07 +00:00
Pascal Quantin
750b7659bb
Add dissection of Terminal Profile byte 32
...
svn path=/trunk/; revision=48611
2013-03-28 14:04:23 +00:00
Anders Broman
dafdc19d9e
-Wmissing-prototypes
...
svn path=/trunk/; revision=48609
2013-03-28 07:34:13 +00:00
Evan Huus
aee73d6d9e
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8530
...
Enable "Decode As" for Bluetooth over USB.
svn path=/trunk/; revision=48605
2013-03-28 03:06:30 +00:00
Ronnie Sahlberg
37de47688f
ISCSI: When printing the task management function, strip of the high bit which is always 1 before resoving the index into a name
...
svn path=/trunk/; revision=48604
2013-03-28 00:06:19 +00:00
Chris Maynard
15dbffefc8
Fix the incorrectly duplicated display filter for hf_ixveriwave_vw_info_retryCount.
...
#BACKPORT(1.8)
svn path=/trunk/; revision=48602
2013-03-27 22:04:46 +00:00
Chris Maynard
186d0c2006
Fix another incorrectly duplicated display filter, this time for hf_gsm_map_etsi_pdp_type_number.
...
#BACKPORT(1.6,1.8)
svn path=/trunk/; revision=48601
2013-03-27 21:41:56 +00:00