Commit Graph

22632 Commits

Author SHA1 Message Date
Ronnie Sahlberg 3c17f41224 coverity 263 check if variable is null before dereferencing it
svn path=/trunk/; revision=23046
2007-10-02 08:33:38 +00:00
Ronnie Sahlberg 880bab108c remove a test for null that we dont need since the variable can not be
null at this point


svn path=/trunk/; revision=23045
2007-10-02 08:27:39 +00:00
Ronnie Sahlberg cca87411fa get rid of a check for null we dont need
coverity 257


svn path=/trunk/; revision=23044
2007-10-02 08:21:25 +00:00
Tomas Kukosa 0f31c30b4b support of 'ANY DEFINED BY' from X.208 which is obsolete but still used in some RFCs
svn path=/trunk/; revision=23043
2007-10-02 06:52:11 +00:00
Ulf Lamping a8b2f589e9 be a bit more verbose, if the name given to register_dissector_table() is not unique (e.g. because of a buggy/duplicated plugin)
svn path=/trunk/; revision=23042
2007-10-02 05:07:13 +00:00
Ulf Lamping c3131594a8 update to latest IEC draft
svn path=/trunk/; revision=23041
2007-10-02 05:04:35 +00:00
Bill Meier adce7d882d Add 'C' as a valid -N option in error message.
svn path=/trunk/; revision=23040
2007-10-01 00:22:39 +00:00
Ronnie Sahlberg b8d35143d8 change dissect_radius() to become a new-style dissector that can reject
packets that doesnt look like valid radius.

verify that a packet is radius by checking that the command code is 
known and also that the length is between 20 and 4096 bytes

move the tap data to be ep_allocated instead of a static global variable

dont use tvb_memcpy() to read a structure off the wiredata
use tvb_get_...    to unmarshall the fields explicitely



this fixes bug 1634

svn path=/trunk/; revision=23039
2007-09-30 23:14:18 +00:00
Ronnie Sahlberg 927bf43d09 update filter fields for bug 1803
svn path=/trunk/; revision=23038
2007-09-30 22:34:19 +00:00
Guy Harris 61e8c424b3 "get_compiled_version_info()" appends to the string text starting with
"with", so we shouldn't put our own "with" in there.

svn path=/trunk/; revision=23037
2007-09-30 22:34:15 +00:00
Guy Harris 58585ac5c5 Clean up indentation.
"time_t" is not guaranteed to be an "unsigned long"; when printing it
with %lu, cast it to "unsigned long".

The "secs" field of a wtap_nstime, however, *is* defined to be a time_t;
there's no need to cast it to time_t.

svn path=/trunk/; revision=23036
2007-09-30 22:13:38 +00:00
Stig Bjørlykke 4245058b58 Try xdg-open before htmlview.
svn path=/trunk/; revision=23035
2007-09-30 10:07:56 +00:00
Guy Harris a3b70ff0da From Stéphane Loeuillet: patches to fix problems with the .desktop files
found by desktop-file-validate:

  wireshark.desktop: warning: value "" for key "Path" in group "Desktop Entry"
  does not look like an absolute path
  wireshark.desktop: warning: value "GNOME;Application;Network;" for key
  "Categories" in group "Desktop Entry" contains a deprecated value
  "Application"

  wireshark-root.desktop: warning: key "Encoding" in group "Desktop Entry" is
  deprecated
  wireshark-root.desktop: warning: value "" for key "Path" in group "Desktop
  Entry" does not look like an absolute path
  wireshark-root.desktop: warning: value "GNOME;Application;Network;" for key
  "Categories" in group "Desktop Entry" contains a deprecated value
  "Application"

svn path=/trunk/; revision=23034
2007-09-30 00:18:44 +00:00
Guy Harris 1c5db4d638 Wireshark builds with 10.4's X11 as well.
svn path=/trunk/; revision=23033
2007-09-30 00:03:38 +00:00
Guy Harris 115c3de229 Include DragonFly BSD in the list of BSDs to which this applies.
Add information on how to set the mode, owner, and/or group of the BPF
devices in FreeBSD with devfs.

svn path=/trunk/; revision=23032
2007-09-29 23:42:45 +00:00
Sake Blok a2778dcb27 When reading NetScreen snoop output, only use WTAP_ENCAP_PER_PACKET
if there are packets with different encapsulationtype in the file.
Otherwise use the encapsulationtype of the packets in the file. 

This makes it possible to save the imported data as libpcap file
(or any other format that does not support per-packet encapsulation).

svn path=/trunk/; revision=23031
2007-09-29 07:55:25 +00:00
Guy Harris 53e74d7931 Get rid of a forward declaration of a routine that no longer exists.
svn path=/trunk/; revision=23030
2007-09-29 02:27:04 +00:00
Guy Harris 8e87bd423f "pinfo->match_string" is a "const char *"; save it into a variable of
the same type - that makes compilers much happier.

svn path=/trunk/; revision=23029
2007-09-29 02:20:17 +00:00
Guy Harris 30e64a2528 Update to reflect that we're using libsmi, not Net-SNMP.
svn path=/trunk/; revision=23028
2007-09-29 02:10:25 +00:00
Guy Harris 5f9d1e28e6 Fix typo.
svn path=/trunk/; revision=23027
2007-09-29 02:05:31 +00:00
Guy Harris 81db68f38f Clean up indentation a bit.
Count packets even if we're not dissecting them.

svn path=/trunk/; revision=23026
2007-09-29 02:05:09 +00:00
Guy Harris 322d44d416 Make the "-Z" argument to dumpcap take an argument that's the file
descriptor to use as the sync pipe.  For now, always pass 1, so the sync
pipe is the standard output of dumpcap.

svn path=/trunk/; revision=23025
2007-09-29 01:36:03 +00:00
Guy Harris 6d065e2eb2 Don't hardcode the notion that the sync pipe is the standard output into
sync_pipe_errmsg_to_parent(); have it take the FD for the sync pipe as
an argument.

svn path=/trunk/; revision=23024
2007-09-29 01:15:11 +00:00
Guy Harris 343fa12c82 The fork_child argument to sync_interface_stats_close is unused on UN*X.
svn path=/trunk/; revision=23023
2007-09-29 01:14:16 +00:00
Guy Harris 72eed77ed7 We don't use NetSNMP any more.
svn path=/trunk/; revision=23022
2007-09-29 01:01:02 +00:00
Guy Harris ea22a35acd We don't use NetSNMP any more.
svn path=/trunk/; revision=23021
2007-09-29 00:58:20 +00:00
Gerald Combs 9c7e0b2e25 Support Solaris along with Windows.
svn path=/trunk/; revision=23020
2007-09-28 23:40:51 +00:00
Mike Duigou fc975182fe Improves dissection of JXTA traffic from http connections.
Improved address display in packet summary panes.

more options for jxta pdu filtering by addresses.

svn path=/trunk/; revision=23019
2007-09-28 20:53:56 +00:00
Jaap Keuter f2bc8dd002 Why do I have to enable the Bytes View to see the (start of) data of the Data dissector?
Adding the data as a subtree to the Data dissector.

svn path=/trunk/; revision=23018
2007-09-28 19:16:05 +00:00
Mike Duigou 2697adeda4 Special casing is no longer necessary for formatting of AT_STRINGZ in col_set_addr() as
address_to_str_buf() does now take COL_MAX_LEN as a parameter.

Add support for AT_URI to col_expr for addresses in col_set_addr(). The field names are "uri.src" and "uri.dst".


svn path=/trunk/; revision=23017
2007-09-28 19:00:45 +00:00
Mike Duigou 6aeb75c3f0 Changes get_addr_name_buf() to use the more common convention where the provided buffer size is the entire size of the buffer including the space for the terminating \0
svn path=/trunk/; revision=23016
2007-09-28 18:23:59 +00:00
Bill Meier f4e9824c46 Add error checking for fwrites; replacement for the 2nd of the patches provided in bug #1864
svn path=/trunk/; revision=23015
2007-09-28 17:22:03 +00:00
Jeff Morriss e55168c53d Specify that -l causes tshark to flush the *standard* output (from bug 1875). The man page already states this
svn path=/trunk/; revision=23014
2007-09-28 16:34:59 +00:00
Martin Mathieson ba1f5676e0 Handle IPv6 addresses in ipprim headers.
svn path=/trunk/; revision=23013
2007-09-28 16:17:22 +00:00
Sake Blok 235ab1445a When reading NetScreen snoop output, allow the '.' in interface names
so that packets on subinterfaces are accepted too.

svn path=/trunk/; revision=23012
2007-09-28 14:37:15 +00:00
Jeff Morriss 8ec05eb569 Add a small note saying not to use proto_tree_add_text() in new code unless you have a specific reason (like those given in the next paragraphs).
svn path=/trunk/; revision=23011
2007-09-28 13:39:20 +00:00
Jeff Morriss 7efd1b9a76 Add notes suggesting not to use hidden fields but if you're going to, use PROTO_ITEM_SET_HIDDEN() instead of proto_tree_add_*_hidden(). (I thought that was in here already...) Suggest putting fields-you-want-hidden in subtrees where they can be found by ordinary users.
svn path=/trunk/; revision=23010
2007-09-28 13:33:54 +00:00
Ronnie Sahlberg 93c5c7a70c this silly protocol uses the same port as ndmp and worse, there is
nothing really in the header to identify it reliably as silly 
vendor specific encapsulation 

10000 is actually registered by iana for ndmp   so it makes no sense for 
a lazy vendor to use it by default.

make it check if the packet is ndmp first before assuming that anything 
that goes to port 10000 must be some lazy vendor specific protocol

grrr


svn path=/trunk/; revision=23009
2007-09-28 07:34:42 +00:00
Ronnie Sahlberg b6aeeb9821 add ndmp.h to the makefile
svn path=/trunk/; revision=23008
2007-09-28 07:26:40 +00:00
Ronnie Sahlberg 651d8082c9 add a function to test if a packet is ndmp or not
svn path=/trunk/; revision=23007
2007-09-28 07:25:50 +00:00
Ronnie Sahlberg 1efa9bd6b6 ndmp and tcp encapsulation of esp both use port 10000
make ndmp a heuristic dissector so it will "win" over tcp esp  if the 
packets look like ndmp  and if "preferences/tcp/heuristic dissectors 
first has been 
chosen"



svn path=/trunk/; revision=23006
2007-09-28 07:08:52 +00:00
Anders Broman 79a3b2d675 Use the tag for downloading.
svn path=/trunk/; revision=23005
2007-09-28 06:06:36 +00:00
Ronnie Sahlberg 30b586ad61 queue the ip/eth headers for tapping before calling any subdissectors
so that they can be tapped even if the subdissectors cause an exception


this fixes bug 1527

svn path=/trunk/; revision=23004
2007-09-28 05:50:19 +00:00
Gerald Combs 69ddd8a773 Load wpcap.dll, since we still use it for some things. This should hopefully
fix Buildbot.

svn path=/trunk/; revision=23003
2007-09-27 23:49:05 +00:00
Stig Bjørlykke 9ca4a5c24a Updated to include the ranap header file.
svn path=/trunk/; revision=23002
2007-09-27 21:48:25 +00:00
Sake Blok 0e4ae39920 From Martin Warnes:
Attached is a small patch that correct an issue with reading certain IBM
iSeries Comms traces.

Traces where data has been dropped for whatever reason now have the
packet number suffixed with an asterix "*", this causes the current
iSeries wiretap routine to report a "bad" header. The attached patch
simply scans the packet number field and removes any "* characters prior
to scanning, the fact that data may be missing is more than adequately
reported later by current wireshark packet processing.

Regards .. Martin


svn path=/trunk/; revision=23000
2007-09-27 18:36:17 +00:00
Jeff Morriss f563945bf8 (Try to) get tshark capturing working on *NIX (it works for me anyway):
We can simply block waiting for input from the child process because we are
in a CLI that does not need to worry about updating a GUI while we're waiting
for packets and so forth.

Before I realized that I wrote a working (for me) method using select() that
I've left in for now (#ifdef'd out).

svn path=/trunk/; revision=22999
2007-09-27 15:58:54 +00:00
Jeff Morriss 1790075951 As requested by Juan Wortley on -users: instead of allowing only 2 UDP ports to be dissected as NSIP, allow a range. Obsolete the old preferences.
svn path=/trunk/; revision=22998
2007-09-27 14:11:57 +00:00
Jörg Mayer 682332dcc0 Convert asn1/dap/
svn path=/trunk/; revision=22997
2007-09-27 09:24:38 +00:00
Tomas Kukosa 6055995bf1 revert changes in config.nmake committed by mistake and commit configure.in
svn path=/trunk/; revision=22996
2007-09-27 08:33:53 +00:00