e746a01ce8
Display GTPv2 Area Code fields (which show up in some DIAMETER AVPs) as
...
BASE_HEX_DEC instead of just BASE_DEC.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9118
svn path=/trunk/; revision=51822
2013-09-07 13:56:25 +00:00
e69ec10794
Callers of tvb_per_bit_string expect that the returned value_tvb is non-NULL.
...
Ensure that is the case even in certain peculiar error conditions, by filling it
with a 0-length subset TVB. Fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9117
Also add modelines.
svn path=/trunk/; revision=51821
2013-09-07 13:48:13 +00:00
a1d88c4620
Fix a few more places that didn't have a semicolon after the address-macro use.
...
svn path=/trunk/; revision=51820
2013-09-07 13:22:58 +00:00
2e299ec910
Add modelines, use consistent indentation in address.h
...
Use the "do { } while (0)" trick to make the macros behave like regular function
calls syntatically.
Fix one dissector that wasn't using semicolons after the macro calls.
svn path=/trunk/; revision=51819
2013-09-07 12:51:29 +00:00
7d3d67407c
Added support for a "prefs_change" function in Lua scripts, which is called
...
when the preferences for the dissector are changed.
This is not a 100% correct implementation at the time because the
prefs_changed function in all Lua plugins will be called whenever
a preference in a single Lua plugin is changed.
svn path=/trunk/; revision=51818
2013-09-07 11:27:38 +00:00
a8638eec90
Added support for integer range in DissectorTable_add and DissectorTable_remove.
...
This was requested in bug 6762.
svn path=/trunk/; revision=51817
2013-09-07 11:07:18 +00:00
452bfe4ce0
A small documentation fix for DissectorTable_remove.
...
svn path=/trunk/; revision=51816
2013-09-07 11:01:52 +00:00
6b93b0e1dc
Added syntax and range checks for Lua Prefs.range default values.
...
Fixed some small memory leakages.
svn path=/trunk/; revision=51815
2013-09-07 10:56:52 +00:00
071f89e3b3
coverity 1047692: check return value of inet_pton()
...
svn path=/trunk/; revision=51814
2013-09-07 10:02:46 +00:00
c4f5a942d7
trivial: fix a typo
...
svn path=/trunk/; revision=51813
2013-09-07 09:03:21 +00:00
f974c74fd8
From Tyson Key via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9105 :
...
Add additional PN532 opcodes, and update USB CCID dissector to skip status word in PN532 responses
svn path=/trunk/; revision=51812
2013-09-07 08:03:32 +00:00
2dca89e7a3
Only add data points to the throughput graph if our time window has
...
advanced. Add a reset button.
svn path=/trunk/; revision=51811
2013-09-07 03:51:27 +00:00
f9a9753d01
Fix PacketList::goToPacket work correctly. Minor screen graph
...
improvements.
svn path=/trunk/; revision=51808
2013-09-07 00:33:41 +00:00
ac93afc00b
Use "recode" to convert HTML entities to UTF-8 if it's available.
...
svn path=/trunk/; revision=51806
2013-09-07 00:18:10 +00:00
f9f29d0307
Make the Lua dissector "init" routine work again.
...
svn path=/trunk/; revision=51805
2013-09-06 22:22:27 +00:00
51b613e485
Whitespace cleanup, sort options, add modelines.
...
svn path=/trunk/; revision=51804
2013-09-06 21:57:04 +00:00
faad753c65
The 'a' option doesn't take an argument. Fix bug introduced by r49964.
...
svn path=/trunk/; revision=51803
2013-09-06 20:40:54 +00:00
297d1994f8
Switch from a 20 segment moving average to a 1 second MA. Add a #define
...
to allow switching back to the old behavior.
Note that goToPacket can jump to the wrong packet if we have a display
filter applied.
svn path=/trunk/; revision=51801
2013-09-06 19:07:57 +00:00
52c9e57474
Deduplicate some type and field names.
...
svn path=/trunk/; revision=51800
2013-09-06 17:39:03 +00:00
1c46818354
Convert to wmem, and as per Michael's suggestion in
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9107 , use zeroed memory for
ntlmssp_info structs.
svn path=/trunk/; revision=51799
2013-09-06 15:59:45 +00:00
0e885e8089
Set length and contents to 0/NULL if the blob is empty. Fixes
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9107
svn path=/trunk/; revision=51798
2013-09-06 15:29:18 +00:00
df6f3412dd
Adjust titles and labels.
...
svn path=/trunk/; revision=51797
2013-09-06 02:00:14 +00:00
29e03fe9d6
Make graph movement pixel-based to match the GTK+ version.
...
svn path=/trunk/; revision=51796
2013-09-06 00:48:21 +00:00
6003d3b2f6
Throughput graph usability updates.
...
Make the stream graph dialog modeless and let the user open multiple
instances. The dangling dialog behaves similar to the GTK+ version. Add
a setDissectedCaptureFile signal to MainWindow (currently unused).
Properly transform yAxis2 and simplify resetAxes while we're at it.
Other bug fixes.
svn path=/trunk/; revision=51795
2013-09-06 00:41:07 +00:00
96d29a5d50
Get rid of a duplicated filter name.
...
svn path=/trunk/; revision=51792
2013-09-05 20:55:59 +00:00
0cf459a6cc
Try to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9106 :
...
Intialize phdr structure to avoid an invalid access to phdr->opt_comment
svn path=/trunk/; revision=51791
2013-09-05 20:35:03 +00:00
2d1b7d1e32
add casts to make my compiler (gcc 4.6.3) happy
...
svn path=/trunk/; revision=51790
2013-09-05 20:18:13 +00:00
f6eb619d87
Display "TEID/GRE Key" field consistently as hexadecimal since 3GPP TS 36.444 says this field is of type, "octet string".
...
Ref: http://ask.wireshark.org/questions/24221/decode-gtpv2-teid-as-decimal-or-hex
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=51789
2013-09-05 18:51:46 +00:00
f13c30d2c4
Per http://nsis.sourceforge.net/Docs/Chapter4.html#4.2.4 , we need to use $\n for a newline in strings. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9103 .
...
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=51788
2013-09-05 17:51:17 +00:00
b3f4084c4e
Make "content blob" dynamically sized so it doesn't take up 20k of memory per conversation.
...
Add filterable expert info while we're at it.
svn path=/trunk/; revision=51787
2013-09-05 16:29:08 +00:00
808d594087
Add an expert info if we see content-length header and chunked encoding
...
together.
The other part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9101
Also fix modelines.
svn path=/trunk/; revision=51786
2013-09-05 16:05:32 +00:00
40a83d1e2c
As per the HTTP spec, prefer chunked transfer-encoding to content-length if we
...
get both. Fixes reassembly for
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9101
svn path=/trunk/; revision=51785
2013-09-05 15:48:50 +00:00
8552f0df64
The length field is retrieved from the packet in bytes, not bits, so stop
...
adjusting it by 8 everywhere.
Seems to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9087 though
someone more familiar with the protocol will have to verify it's actually
correct now.
svn path=/trunk/; revision=51784
2013-09-05 13:15:04 +00:00
e67292ff14
Move where timing reference for DRX timers will be set
...
svn path=/trunk/; revision=51783
2013-09-05 13:11:54 +00:00
47e241f6c4
Make checkAPI notify (warnings only, for now) about deprecated emem functions.
...
svn path=/trunk/; revision=51782
2013-09-05 12:50:24 +00:00
3b6f55c579
Convert atn-* dissectors to wmem. No emem in new code please!
...
svn path=/trunk/; revision=51780
2013-09-05 12:13:00 +00:00
c248e3c5b2
Add modelines to avoid using tabs in the code
...
svn path=/trunk/; revision=51779
2013-09-05 09:23:50 +00:00
a5e2a30fc7
Change the regexp syntax a bit.
...
svn path=/trunk/; revision=51778
2013-09-05 08:55:09 +00:00
06c27f8749
Use intended regex modification for absolute paths.
...
svn path=/trunk/; revision=51777
2013-09-05 08:32:00 +00:00
fadd2ae1c8
Removed TAB as indent.
...
Fixed regex for modifying absolute paths in header.
svn path=/trunk/; revision=51776
2013-09-05 08:22:44 +00:00
8b842aeb02
Adapt generated output to always print paths relative to
...
the asn1/<proto>/ subdir. This makes cmake generated builds
look identical to autotools generated builds.
svn path=/trunk/; revision=51775
2013-09-05 07:38:32 +00:00
854363611c
Generated file differs in whitespace output
...
svn path=/trunk/; revision=51774
2013-09-05 07:36:16 +00:00
39bff3218a
Missed 50% of the updates in last commit
...
svn path=/trunk/; revision=51773
2013-09-05 07:33:05 +00:00
d4f2865595
CMakeLists was no longer in sync with Makefile.common
...
svn path=/trunk/; revision=51772
2013-09-05 07:28:47 +00:00
022706764b
Add missing CMakeLists.txt files
...
svn path=/trunk/; revision=51771
2013-09-05 06:05:15 +00:00
02a61b07e4
Fix cmake syntax - so now it "only" warns about missing
...
CMakeLists.txt in the subdirectories.
svn path=/trunk/; revision=51770
2013-09-05 05:48:22 +00:00
7e2efe9e6b
From Christoph Viethen:
...
Typo in the name of a PPPoE tag name.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9102
svn path=/trunk/; revision=51769
2013-09-05 05:39:15 +00:00
dd12400161
From Chris Bontje:
...
Changes include:
- Detect previously-unknown object types. No dissection is attempted of response messages, but at least the types are documented and labelled. As Graham notes, if some examples are provided we can attempt a little more here.
- Change up info_column object label handling to add some of the new objects. Also added in a few that would be present in 'write' messages.
- Add expert info field for abnormal IIN bits. This will help me in my job of detecting unknown objects and unsupported function codes and will easily flag to the user that 'something is up' due to the color changes.
- Only detect Application Layer if we are on the Final Transport Layer frame.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9056
svn path=/trunk/; revision=51768
2013-09-05 05:34:40 +00:00
436a6d2e99
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903
svn path=/trunk/; revision=51767
2013-09-05 05:26:34 +00:00
80cd0dca1d
From Mathias Guettler:
...
New dissector for Air/Ground Datalink ICAO doc 9705 Ed2: ULCS, CM, CPDLC.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8903
svn path=/trunk/; revision=51766
2013-09-05 05:26:04 +00:00
Evan Huus