af3435f669
In time_secs_to_str_buf(), handle the case where a large time value makes
...
things go wonky.
svn path=/trunk/; revision=14097
2005-04-15 21:38:42 +00:00
5eb73dd01b
In fragment_unhash(), free our key data _after_ we remove the key from
...
the hash table so that fragment_equal() doesn't end up working with
recently-freed data.
svn path=/trunk/; revision=14096
2005-04-15 20:15:03 +00:00
d96061b92d
Add a tvb_ensure_bytes_exist(). I'm not sure if this is the correct way
...
to do this, but it fixes bug 38.
svn path=/trunk/; revision=14094
2005-04-15 15:17:55 +00:00
7c5083489f
In dissect_ber_bitstring32(), make sure tmp_tvb is properly initialized.
...
Fixes bug 32.
svn path=/trunk/; revision=14092
2005-04-15 14:18:08 +00:00
15d1745271
From Olivier Jacques:
...
- Add bearerServiceCodes decoding
- Fixed sendRoutingInfoForSM and reportSM-DeliveryStatus invoke decoding (argument mismatch)
svn path=/trunk/; revision=14091
2005-04-15 08:30:23 +00:00
dca524507c
From Olivier Jacques:
...
- Adds callingPartyNumber and CalledPartyNumber parameter dissection uing ISUP dissector
- Adds IMSI and ISDN-AddressString parameter dissection
- A lot of changes in the .asn file to sort it, handle more parameters and error codes - contributed by Javier Acuna [javier.acuna@sixbell.cl ]
svn path=/trunk/; revision=14088
2005-04-15 08:18:48 +00:00
87f8d7b412
From Jacques Olivier :
...
Export callingPartyNumber and CalledPartyNumber parameter dissection .
svn path=/trunk/; revision=14086
2005-04-15 08:14:44 +00:00
191d38789c
Setr up conversations for RTP and RTCP.
...
svn path=/trunk/; revision=14085
2005-04-15 07:50:19 +00:00
0d7fcee40d
Add message type string to "message type", print Protocol ID short name in Info coulmn.
...
svn path=/trunk/; revision=14084
2005-04-15 07:49:31 +00:00
adbc8b86b5
In dissect_ber_integer(), generate a warning if the integer length is
...
invalid instead of throwing an assertion. Fixes bug 25.
svn path=/trunk/; revision=14080
2005-04-14 20:16:35 +00:00
3008014ed7
Add another passel of tvb_ensure_bytes_exist()s. Fixes bug 24.
...
svn path=/trunk/; revision=14079
2005-04-14 20:01:14 +00:00
a6b24ceaaa
Add a tvb_ensure_bytes_exist() to dissect_ber_octet_string(). Fixes bug
...
23.
svn path=/trunk/; revision=14078
2005-04-14 19:53:27 +00:00
5f4347c46d
Add a bunch of tvb_ensure_bytes_exist() calls. Some of these may not be
...
neccessary -- someone more knowledgeable about the SMB dissector may want
to check this. Throw a ReportedBoundsError instead of exiting.
svn path=/trunk/; revision=14077
2005-04-14 19:43:00 +00:00
7cac2e619c
From packetsteve :
...
CDMA2000 A10 uses a 4 byte gre key
svn path=/trunk/; revision=14076
2005-04-14 09:29:23 +00:00
a5863ec066
From Steve Karg
...
updates to BACNet
svn path=/trunk/; revision=14075
2005-04-14 09:20:02 +00:00
1d2c39cc60
make file name snooping use information from READDIRPLUS replies when building the filehandle to name mapping
...
svn path=/trunk/; revision=14074
2005-04-14 06:45:32 +00:00
2f3a371613
In dissect_h245_OpenLogicalChannelCodec(), make sure codec_type exists before
...
trying to access its contents.
svn path=/trunk/; revision=14072
2005-04-14 04:26:00 +00:00
7061524f79
fix bug in parsing of NDMP_DATA_CONNECT messages, it is a ndmp_address passed to this function not an ndmp_address_type.
...
svn path=/trunk/; revision=14071
2005-04-14 03:41:31 +00:00
cea394348c
Fix a bug introduced by my previous checkin.
...
svn path=/trunk/; revision=14067
2005-04-13 22:04:50 +00:00
37c30f6c63
Check for COL_INFO before trying to modify it.
...
svn path=/trunk/; revision=14066
2005-04-13 21:56:00 +00:00
d357c745a6
In dissect_ber_octet_string_wcb(), make sure out_tvb is non-NULL before
...
trying to use it so that we don't throw an assertion. Fixes bug 22.
Do the same thing in dissect_ber_GeneralString().
svn path=/trunk/; revision=14065
2005-04-13 21:20:23 +00:00
e3bd36c2d5
Add a couple of tvb_ensure_bytes_exist() calls to fix bug 12.
...
svn path=/trunk/; revision=14064
2005-04-13 20:59:39 +00:00
dc223932b8
another try to fix the unix build
...
svn path=/trunk/; revision=14063
2005-04-12 23:48:47 +00:00
6cacb84377
bugfix for unix builds, remove leftover things from function move
...
svn path=/trunk/; revision=14062
2005-04-12 23:12:37 +00:00
6e38159c25
add functions file_exists and file_identical to filesystem.c (coming from file.c)
...
svn path=/trunk/; revision=14057
2005-04-12 21:12:19 +00:00
4929e662b8
[CHECKSUM INCORRECT] -> [TCP CHECKSUM INCORRECT]
...
svn path=/trunk/; revision=14056
2005-04-12 21:07:48 +00:00
83f14e4614
change time_secs_to_str() and time_msecs_to_str() to take a signed integer as parameter so we can handle negtive times
...
svn path=/trunk/; revision=14055
2005-04-12 19:59:08 +00:00
2bc81b2a48
Major speed improvement for filtering and dissection.
...
It should not dump core as far as all my tests are concerned and Menu_Statistics/ProtocolHierStats work
It needs more testing and there might still be cases where it will crash that will need to be fixed but I feel it will be worth it since it will decrease the time to filter very large capture files dramatically.
Real significant performance boost for very large captures.
(If we cant fix all the problems we can just revert this patch)
svn path=/trunk/; revision=14051
2005-04-11 08:43:51 +00:00
b803431715
KRB_ERROR can be returned and it is not encapsulated
...
svn path=/trunk/; revision=14032
2005-04-09 01:28:23 +00:00
05ae084f5b
Fix brokenness from previous patch.
...
svn path=/trunk/; revision=14031
2005-04-08 20:28:24 +00:00
388c7e2da9
Add a length check, fix up some comments.
...
svn path=/trunk/; revision=14029
2005-04-08 19:09:46 +00:00
a55085054c
From Neil Kettle
...
Fix two potential buffer overflow bugs in fc els
svn path=/trunk/; revision=14027
2005-04-08 10:28:44 +00:00
df98534657
From Didier:
...
optimization for COLUMNS to make ethereal faster when filtering
optimization to make the slow find_protocol_by_id() fast.
(idea from Didier, implementation modified by me to be less intrusive)
svn path=/trunk/; revision=14026
2005-04-07 12:00:03 +00:00
412e592a12
updating Mark C Browns information
...
svn path=/trunk/; revision=14025
2005-04-07 10:04:50 +00:00
4eb8b88421
make the ip ip field we use as the reassembly key a bit more
...
"unique" by mixing in the source and destination address.
svn path=/trunk/; revision=14024
2005-04-07 09:44:58 +00:00
3fbcc50513
From Greg Morris
...
Fix the breakage from my previous patch
svn path=/trunk/; revision=14022
2005-04-07 08:32:49 +00:00
eb98d35922
use proto_item_appent_text() instead of proto_item_append_string() since the hf field is not neccessarily a FT_STRING value always.
...
svn path=/trunk/; revision=14019
2005-04-05 20:20:21 +00:00
c92c1df4a4
Try not to call proto_tree_add_text() with negative lengths in error messages.
...
svn path=/trunk/; revision=14018
2005-04-05 14:40:59 +00:00
b170e98255
Add length checks so that we don't overflow buffers.
...
svn path=/trunk/; revision=14016
2005-04-04 21:44:53 +00:00
79b30e6df5
From Lars Ruoff
...
Make it possible to tap 4 PDUs from one frame
svn path=/trunk/; revision=14015
2005-04-04 20:12:18 +00:00
8b95cd38d5
Don't generate a "dissector bug" warning in cases where a dissector calls
...
proto_tree_add_*(tree, tvb, offset, 0, ...);
and "offset" is greater than the length remaining in the tvbuff.
svn path=/trunk/; revision=14014
2005-04-04 18:10:42 +00:00
f16afe28a9
From Cvetan Ivanov
...
Updates to Q931, SM and ISUP
svn path=/trunk/; revision=14013
2005-04-04 07:40:07 +00:00
38fd4be564
the definition of tcp address structure changed between version 3 and version 4
...
make version 4 dissect tcp addr structure properly
svn path=/trunk/; revision=14012
2005-04-04 05:56:57 +00:00
882f734f34
From Kenny Shumard
...
Update for IAX2
svn path=/trunk/; revision=14011
2005-04-04 05:10:45 +00:00
088f70bb53
From Martin Mathieson
...
small update for SIP request/response matching.
svn path=/trunk/; revision=14010
2005-04-04 04:51:47 +00:00
d430320b6a
the netware dissector is the only dissector that accesses fvalue_ functions directly.
...
this made it crash for some packets when the filter speedup patch was enabled, since some of these finfo nodes did no longer exist.
as far as i can tell the only other instances of fvalue_ usage is from some tap based functions but all those do take care to make sure that the fields being accessed are all part of a filter, and will thus never be optimized away.
The patch does two things
1, refactor the code but do not change the logic to reduce the number of places where the external fvalue_ functions are called from.
2, add code to force the tree to be visible (and thus change the code) so that the speedup patch will not optimize these fiuelds away.
svn path=/trunk/; revision=14009
2005-04-04 04:14:41 +00:00
951b7c9aaa
From Tim Endean:
...
1) Return errors.
2) Return rejects.
Numerous other bugs fixed.
svn path=/trunk/; revision=14005
2005-04-02 18:51:38 +00:00
fb1ac828aa
from Jeremy Jouglet
...
some GTP updates and some tips for those using cygwin
svn path=/trunk/; revision=14003
2005-04-01 21:23:40 +00:00
61e984ffaf
update for padbyte on old juniper boxens
...
svn path=/trunk/; revision=14002
2005-04-01 21:04:55 +00:00
448191721c
from Lars R
...
TAP order of caller update
svn path=/trunk/; revision=14001
2005-04-01 20:55:33 +00:00
Gerald Combs