Commit Graph

27 Commits

Author SHA1 Message Date
Guy Harris 499d95964d Eliminate e_uuid_t in favor of e_guid_t.
That eliminates a redundant and confusing data type, and avoids issues
with one piece of code using e_uuid_t but wanting to use routines
expecting an e_guid_t.

Change-Id: I95e172d46d342ab40f6254300ecbd2a0530cde60
Reviewed-on: https://code.wireshark.org/review/7506
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-03 10:55:29 +00:00
Michael Mann 06237e4878 proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors.
Change-Id: I84755d059ef70ca98b0e7626b6425360daf0529d
Reviewed-on: https://code.wireshark.org/review/4199
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-20 11:59:25 +00:00
Alexis La Goutte f2dfc39d94 Continue to remove $Id$ from top of file
(Using sed : sed -i '/^ \t$Id\$/,+0 d') (tab before $Id$)

Also modify generator (NDR.pm)

Change-Id: I348a1d129d1d1320bd80b428038ea5ed291d6ca8
Reviewed-on: https://code.wireshark.org/review/878
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-31 18:29:18 +00:00
Jakub Zawadzki 5c79cbf152 Fix some trivial warnings.
svn path=/trunk/; revision=54085
2013-12-14 10:29:26 +00:00
Michael Mann e2df7c83cb Move dceprc_procedure_name from packet_info to dcerpc_info. Doesn't appear to be "used" by dissectors, just stored (for help in debugging?).
svn path=/trunk/; revision=53552
2013-11-24 20:55:55 +00:00
Evan Huus 5efc340771 Mark more unused parameters.
svn path=/trunk/; revision=53109
2013-11-06 17:52:11 +00:00
Michael Mann 22760b2d2a Remove pinfo->private_data from DCERPC dissectors and instead have dcerpc_info* infomation be passed in as a function parameter. Bug 9387 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387)
All "generated" source was manually modified (with the power of search/replace), but I believe the "source input" files have been adjusted (checked into revs 53098 and 53099) to reflect the necessary changes (with possible whitespace formatting differences).

The Microsoft compiler doesn't flag "unused function parameters", so I apologize in advance if I may have missed a few.  The "dcerpc_info* di" parameter is used in almost every function.

svn path=/trunk/; revision=53100
2013-11-06 14:31:29 +00:00
Michael Mann 0334c5b425 Remove check_col from generated DCE/RPC dissectors. Bug 8804 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8804).
I still couldn't figure out how to generate the source, so I made the modifications to the generated dissectors "manually" (search/replace tool in VS) that would match the "PIDL source" included here.

I will be sending the "PIDL source" (non dissector files) to the samba team.

svn path=/trunk/; revision=52313
2013-10-01 14:45:03 +00:00
Pascal Quantin 0a17799d61 From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :
Remove C++ incompatibilities from most of the dcerpc code

svn path=/trunk/; revision=48023
2013-03-02 22:54:39 +00:00
Jeff Morriss 2552c750e5 We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
Jeff Morriss 554ed113a9 Add an SVN Id to these PIDL-generated dissectors. A patch to PIDL will be sent upstream to the Samba developers.
svn path=/trunk/; revision=34713
2010-10-30 14:35:05 +00:00
Stig Bjørlykke 33987544f9 Removed some unused prototypes.
svn path=/trunk/; revision=30630
2009-10-20 08:27:25 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Gerald Combs 5f9afcd2c1 Squelch a couple of Valgrind warnings.
svn path=/trunk/; revision=26946
2008-12-09 17:16:20 +00:00
Ronnie Sahlberg f7aba27936 start prettifying SRVSVC
svn path=/trunk/; revision=21799
2007-05-16 01:06:30 +00:00
Ronnie Sahlberg 417b366bcd we must provide a hfinfo field when dissecting a dcerpc integer or else
we might get a dissector bug assert and fail to dissect the blob


svn path=/trunk/; revision=21797
2007-05-15 23:30:03 +00:00
Ronnie Sahlberg 78c12b2709 update INITSHUTDOWN and SRVSVC and regenerate with patched PIDL
svn path=/trunk/; revision=21265
2007-03-29 04:12:16 +00:00
Ulf Lamping a66bf7f559 as Gisle Vanem noted that MingW doesn't "like" the #pragmas:
change #ifdef _WIN32 -> #ifdef _MSC_VER around pragma warnings

svn path=/trunk/; revision=21228
2007-03-27 21:09:34 +00:00
Ulf Lamping c2408435bc fix the remaining MSVC warnings by setting individual #pragma(warning:disable) settings - this is very certainly not the way to go, but the way to prevent additional warnings rushing in ...
svn path=/trunk/; revision=21221
2007-03-27 02:14:56 +00:00
Ronnie Sahlberg fe89548ed9 some more bitmaps for SRVSVC
svn path=/trunk/; revision=19250
2006-09-18 08:42:46 +00:00
Ronnie Sahlberg 690ad14806 add decoding of the SessionInfo userflags
svn path=/trunk/; revision=19249
2006-09-18 08:05:51 +00:00
Ronnie Sahlberg b85f1d1b80 generate SRVSVC by pidl
small prettification regression but that will be fixed in the next few days



svn path=/trunk/; revision=19244
2006-09-16 11:57:14 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Ronnie Sahlberg 7fc663c738 rename lsa_dissect_LSA_SECURITY_DESCRIPTOR_data to lsa_dissect_sec_desc_buf_data
to make the symbol compatible with an autogenerated LSA dissector.

no changes to the code, just a rename.


svn path=/trunk/; revision=13206
2005-01-30 12:38:38 +00:00
Ronnie Sahlberg 610da77693 older MS DCE/RPC interfaces often use a construct that is to be treated as a 64 bit integer but in reality is a struct containing 2 32bit integers.
this construct is aligned on 4 byte boundaries in ndr and NOT
8 bytes as a real uint64 (== hyper) would be.


rename the existing dissect_ndr_uint64  ro  dissect_ndr_duint32  (double uint32) to make it reflect better the alignment of the type.



svn path=/trunk/; revision=13184
2005-01-28 09:29:49 +00:00
Guy Harris 13bb12c4f1 Move a bunch of stuff that's more Windows-related than SMB-related to
"packet-windows-common.[ch]".

svn path=/trunk/; revision=11592
2004-08-03 02:28:49 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00