Commit graph

62 commits

Author SHA1 Message Date
Jaap Keuter
81b585cf8e From Valerio Messina:
As now, when Wireshark save capture files, it show "Loading" in status bar and
in the dialog box, warning many users of lost them packets. Saving work as expected.
Is simply a GUI use interaction problem.

svn path=/trunk/; revision=31269
2009-12-14 22:05:29 +00:00
Stig Bjørlykke
0dbfde8b6d Removed some unused variables and unused assignments.
svn path=/trunk/; revision=30918
2009-11-10 12:05:25 +00:00
Stig Bjørlykke
74ffeef1e8 Removed an unneeded cast.
svn path=/trunk/; revision=30728
2009-10-27 09:58:57 +00:00
Stig Bjørlykke
ad6a8fbe51 Move cfselect_cb to avoid variable shadowing.
svn path=/trunk/; revision=30181
2009-09-28 17:44:06 +00:00
Michael Tüxen
3e74e4043d Get it compiling with -DNEW_PACKET_LIST on Mac OS X.
svn path=/trunk/; revision=28929
2009-07-02 22:04:22 +00:00
Stig Bjørlykke
58eba2d80c Added NEW_PACKET_LIST guard for new_packet_list.h
svn path=/trunk/; revision=28904
2009-07-01 09:05:13 +00:00
Anders Broman
ddad90c3e3 Make it possible to configure use of NEW_PACKET_LIST and fix
one compile error. It still fails in file.c trying to include gtk/gtk.h in new_packet_list.h

svn path=/trunk/; revision=28903
2009-07-01 08:23:32 +00:00
Stephen Fisher
e6d0686f7b Introduce experimental new feature: GTK2 tree view based packet list
To use the GTK2 based packet list, define NEW_PACKET_LIST when compiling.
To do this with gcc, set the environment variable CPPFLAGS to
"-DNEW_PACKET_LIST" and re-run configure.

Many features do not yet work.  This work began with prototypes by Ulf
quite a while back.  I've put quite a bit of work into this so far and
as discussed with a few of the core team members at Sharkfest09 and it was
decided that it would be best to commit what I have so far to allow others to
help work on this.


svn path=/trunk/; revision=28892
2009-06-30 18:05:04 +00:00
Guy Harris
432cac16f3 "main_menu.[ch]" -> "menus.[ch]"; it handles not only the main menu, but
context menus.

Note why we have an empty hex dump pane context menu.

svn path=/trunk/; revision=28794
2009-06-21 19:16:37 +00:00
Bill Meier
3c13985c49 *nix color_filters import/export: fix minor bug: failure to close dialog if a file open error.
svn path=/trunk/; revision=28685
2009-06-10 15:48:20 +00:00
Bill Meier
a599e0f938 Fix some small memory leaks.
svn path=/trunk/; revision=28613
2009-06-02 20:57:57 +00:00
Guy Harris
54c159cb41 Turn on -Wshorten-64-to-32 by default, and fix some issues that turned
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats).  Hopefully this will catch at least
some P64 issues on UN*X.

svn path=/trunk/; revision=28108
2009-04-21 16:57:52 +00:00
Stig Bjørlykke
18c5caa3d4 From Jakub Zawadzki:
Use non-formatting functions when appropriate.

svn path=/trunk/; revision=27709
2009-03-12 07:56:42 +00:00
Bill Meier
a392d821db Minor rewording of a few comments; fix a few typos.
svn path=/trunk/; revision=27151
2009-01-04 14:21:54 +00:00
Bill Meier
ea5cd2d8ff Check for preview timeout only every 1000 frames
svn path=/trunk/; revision=27110
2008-12-24 14:21:03 +00:00
Stig Bjørlykke
2aebbfb9f4 Add filter autocomplete for filter in file->open and file->merge windows.
svn path=/trunk/; revision=26493
2008-10-19 14:12:58 +00:00
Stig Bjørlykke
828f6baa42 Ensure we initialize all colorized filter text entries before we show the
widget, so we don't get wrong foreground color when using a dark theme.

svn path=/trunk/; revision=26414
2008-10-11 14:32:46 +00:00
Jeff Morriss
c77c787122 Merge files chronologically by default which:
- makes (much) more sense to me
	- makes the GUI's default behavior the same as mergecap's

For whatever reason the default behavior was to append the new file
/if transport resolution was enabled/ (not sure what those two things have to
do with each other).

svn path=/trunk/; revision=25947
2008-08-06 14:11:46 +00:00
Bill Meier
56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Jeff Morriss
a5cee04fad Move the file utility functions from wiretap to libwsutil so that
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Stephen Fisher
bbf7ec011a Remove all GTK+ < 2.4 code and minimum version checks.
svn path=/trunk/; revision=25182
2008-04-27 07:01:58 +00:00
Ulf Lamping
15b3bb93df don't mark a used parameter as unused
svn path=/trunk/; revision=25054
2008-04-15 20:53:41 +00:00
Ulf Lamping
6a5b1e0ec0 use the ending "_win32" for every windows specific file
svn path=/trunk/; revision=24972
2008-04-13 12:14:57 +00:00
Ulf Lamping
0b97c4211e sort #includes by directories
svn path=/trunk/; revision=24967
2008-04-13 00:55:59 +00:00
Ulf Lamping
b51da2eb77 rename menu -> main_menu
remove old (and unused and confusing) ../menu.h

svn path=/trunk/; revision=24947
2008-04-12 19:18:26 +00:00
Ulf Lamping
1dbdc34841 move drag_and_drop declarations into it's own file
svn path=/trunk/; revision=24927
2008-04-12 09:33:59 +00:00
Guy Harris
8c3d1dd9f1 Include "stock_icons.h" to get WIRESHARK_STOCK_DISPLAY_FILTER_ENTRY.
svn path=/trunk/; revision=24924
2008-04-12 02:28:21 +00:00
Ulf Lamping
b4f3c5fd40 compat_macros.h is gone now!!!
all GTK1 compatibility code was removed, so this file can simply be dropped

svn path=/trunk/; revision=24923
2008-04-12 01:41:53 +00:00
Guy Harris
434e7709ed Wrap the callback function pointer for g_signal_connect() in
G_CALLBACK(), to suppress compiler warnings (that's what the old
SIGNAL_CONNECT macro did).

svn path=/trunk/; revision=24915
2008-04-11 23:00:34 +00:00
Ulf Lamping
9af9a0e619 first round to replace SIGNAL_CONNECT with g_signal_connect
This requires some casts to be added and I just don't want to add casts at all possible places. So I compile and only add casts where the (MSVC) compiler has a hard time. 

Unfortunately this won't find any problems in Linux/Unix only code - I'll keep an eye on the buildbot and try to fix things as I'm going on ...

svn path=/trunk/; revision=24912
2008-04-11 21:20:51 +00:00
Ulf Lamping
c6d13dc2c8 replace WIDGET_SET_SIZE with gtk_widget_set_size_request
svn path=/trunk/; revision=24910
2008-04-11 20:31:05 +00:00
Ulf Lamping
1ab5a1ea4b replace RADIO_BUTTON_NEW_WITH_MNEMONIC with gtk_radio_button_new_with_mnemonic_from_widget
svn path=/trunk/; revision=24908
2008-04-11 19:26:22 +00:00
Ulf Lamping
4de04eae27 replace CHECK_BUTTON_NEW_WITH_MNEMONIC with gtk_check_button_new_with_mnemonic
svn path=/trunk/; revision=24905
2008-04-11 19:04:34 +00:00
Ulf Lamping
ae5f841083 replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Bill Meier
0502078a1b OBJECT_..._DATA --> g_object_..._data
svn path=/trunk/; revision=24898
2008-04-11 17:14:11 +00:00
Ulf Lamping
d470674329 some minor GTK1 related code fixes
svn path=/trunk/; revision=24873
2008-04-09 23:06:01 +00:00
Ulf Lamping
2db60e3b7e replace confusing #if checking for GTK2.4.0 (the GTK version when gtk_file_chooser was "invented") by #if GTK_CHECK_VERSION(2,4,0)
svn path=/trunk/; revision=24811
2008-04-06 22:36:23 +00:00
Ulf Lamping
6bd3a882ee remove GTK1 code
svn path=/trunk/; revision=24810
2008-04-06 22:25:36 +00:00
Gerald Combs
2f4830393c Add tooltips for the filter button and text entry in the open and merge
dialogs.

svn path=/trunk/; revision=24735
2008-03-27 17:26:59 +00:00
Stig Bjørlykke
57ab05545c Also destroy the window when failure to export/import color filters.
svn path=/trunk/; revision=24204
2008-01-26 17:04:49 +00:00
Stig Bjørlykke
dce0761a4a Destroy the open window after open failure to avoid having an unusable
open dialog when using GTK >= 2.4.

This fixes bug 1986.

svn path=/trunk/; revision=24203
2008-01-26 16:50:08 +00:00
Stig Bjørlykke
9c8078686e Destroy the save window after canceling a save to an existing file, so
the user is able to save again without having a hidden save window which 
will not open.

Older GTK versions will show the hidden window after failure.

This fixes bug 1896.

svn path=/trunk/; revision=24202
2008-01-26 16:45:29 +00:00
Bill Meier
01ec87aee5 Revert SVN #23728 since change (to fix a Windows issue) is in code not used on Windows
and thus does not actually fix anything.
See Bug #2055 for further info.

svn path=/trunk/; revision=23809
2007-12-08 20:59:15 +00:00
Gerald Combs
ed0bb11925 If we're using the native Windows file dialog, don't bother to see if the
file exists before we try to save it. The Windows file dialog code does that
for us.

svn path=/trunk/; revision=23728
2007-12-04 00:23:56 +00:00
Jeff Morriss
dd0a4750b0 s/stat/eth_stat/ and s/unlink/eth_unlink/ to avoid non-ASCII filename problems on Windows.
svn path=/trunk/; revision=23605
2007-11-26 18:35:37 +00:00
Luis Ontanon
d229a6a3c2 from Florent DROUIN:
I did load an k12 file (.rf5), and want to save the selected frames in a new file.
I got the error "Wireshark can't save this capture in that format"
I think this is due to this correction: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=22214
I have got a patch to force the type of file to libpcap, only if no other format is available. It should solve both problems.


svn path=/trunk/; revision=22403
2007-07-25 21:30:51 +00:00
Stephen Fisher
ce7d9544ce Fix a bug where you couldn't save individual packets from a file type that
Wireshark doesn't support writing to.  The default in the drop-down menu
was libpcap, but since gtk_option_menu_set_history() doesn't send the
activate signal we set up earlier, you would have to manually click on the
drop-down and reselect libpcap for it to work.  Now it works as expected.


svn path=/trunk/; revision=22214
2007-06-27 23:26:24 +00:00
Guy Harris
5a43799a17 Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLib
routines and routines using those routines.  GLib might use different
modifiers for 64-bit quantities than the platform's C library does.

svn path=/trunk/; revision=21990
2007-05-29 18:52:42 +00:00
Stephen Fisher
dba14a4f17 Fix bug #1600: Merge feature from File menu does'nt do what it should
(append vs prepend)


svn path=/trunk/; revision=21807
2007-05-16 20:19:30 +00:00
Stephen Fisher
6625e7503f Fix warnings on Linux/gcc 4.1.1
svn path=/trunk/; revision=21330
2007-04-03 21:17:13 +00:00