Commit Graph

12598 Commits

Author SHA1 Message Date
Ulf Lamping e321859a86 some code cleanup (comments changed)
svn path=/trunk/; revision=12848
2004-12-28 00:36:06 +00:00
Ulf Lamping 6d161f7dc4 add a more detailed description, how to add a new dissector file
svn path=/trunk/; revision=12847
2004-12-28 00:10:04 +00:00
Ulf Lamping 7f666b77a5 a lot of code cleanup/refactoring
svn path=/trunk/; revision=12846
2004-12-27 22:04:49 +00:00
Ulf Lamping 89c7567797 fix a freebsd buildbot compile error, caused by myself :-(
svn path=/trunk/; revision=12845
2004-12-27 21:35:09 +00:00
Ulf Lamping c8a328e2b9 fix a solaris buildbot compile error
svn path=/trunk/; revision=12844
2004-12-27 16:11:08 +00:00
Ulf Lamping e2f8b83268 location of cygwin's docbook xml changed
svn path=/trunk/; revision=12843
2004-12-27 14:27:27 +00:00
Ulf Lamping 5bcad85d01 Again, some warnings removed.
svn path=/trunk/; revision=12842
2004-12-27 13:17:20 +00:00
Ulf Lamping b026aa4bc2 Again, another warning (hopefully) removed.
svn path=/trunk/; revision=12841
2004-12-27 10:11:28 +00:00
Guy Harris c6bdaa41c6 From Jouni Malinen: use a length field from the packet to determine how
much data is available, rather than using "tvb_length_remaining()".

svn path=/trunk/; revision=12840
2004-12-26 22:52:16 +00:00
Guy Harris 1220516388 From Yaniv Kaul: add Ethernet address-to-name (or, at least, address-to-
vendor-name-and-next-three-bytes-in-hex) resolution for Ethernet/802.x
hardware addresses.

Move the ARP hardware types into a header file, for use by dissectors
other than the ARP dissector.

svn path=/trunk/; revision=12839
2004-12-26 22:26:02 +00:00
Gerald Combs dce666e0d1 From Vincent Jardin:
- support for new DHCPv6 options
 - fix for the support of OPTION_RELAY_MSG 

svn path=/trunk/; revision=12838
2004-12-26 18:58:52 +00:00
Ulf Lamping bf5bf359e0 Again, some warnings removed.
svn path=/trunk/; revision=12837
2004-12-26 10:11:42 +00:00
Guy Harris 355c52a0b3 From Jouni Malinen: dissect TLS extensions (RFC 3546) for ClientHello
and ServerHello.

svn path=/trunk/; revision=12836
2004-12-26 00:28:47 +00:00
Guy Harris ce604cf8f0 From Luis Ontanon: add more filterable fields to DNS, PGM, GTP, and RADIUS.
svn path=/trunk/; revision=12835
2004-12-26 00:22:16 +00:00
Ulf Lamping 5a89cfc00b Again, some warnings removed.
svn path=/trunk/; revision=12834
2004-12-25 18:35:21 +00:00
Ulf Lamping 872a860814 Fix a core dump causing the buildbot test menagerie to fail. It was caused by incorrectly trying to proto_tree_add_item() with a very huge length. However, someone with more SQL knowledge than me should have a qualified look at that place and do a better fix.
svn path=/trunk/; revision=12833
2004-12-25 14:46:40 +00:00
Ulf Lamping 78ff68d4b5 a lot of warnings removed, most of them about pointer to int casts without using the appropriate GLib macros
svn path=/trunk/; revision=12832
2004-12-25 13:49:30 +00:00
Ulf Lamping e8459f4ea1 Again, some warnings removed.
svn path=/trunk/; revision=12831
2004-12-25 10:30:58 +00:00
Ulf Lamping dc0fc1896e use GLib's pointer to int conversion macros to prevent compiler warnings
svn path=/trunk/; revision=12830
2004-12-24 23:17:38 +00:00
Guy Harris ed556cd7c4 Note the RFC that describes VJ compression.
svn path=/trunk/; revision=12829
2004-12-24 22:21:23 +00:00
Ronnie Sahlberg e0945a4762 New protocol RFC2510 PKIXCMP Certificate Management Protocol
svn path=/trunk/; revision=12828
2004-12-24 12:39:21 +00:00
Ronnie Sahlberg 0d1474e9a7 export ResonFlags from pkix1implicit
svn path=/trunk/; revision=12827
2004-12-24 12:22:52 +00:00
Ronnie Sahlberg 03ded18485 export Certificate and CertificateList from pkix1explicit
svn path=/trunk/; revision=12826
2004-12-24 12:16:27 +00:00
Ronnie Sahlberg 131c4164b4 New "protocol" the support functions from RFC2511 Certificate Request Message Format CRMF
svn path=/trunk/; revision=12825
2004-12-24 11:32:13 +00:00
Ronnie Sahlberg 69dd4345c1 export EnvelopedData
svn path=/trunk/; revision=12824
2004-12-24 11:24:35 +00:00
Ronnie Sahlberg 6b8c77703e RST segmetns are never WindowFull segments.
svn path=/trunk/; revision=12823
2004-12-23 19:56:29 +00:00
Ronnie Sahlberg 0b6ae100fe add another error code to dcerpc
svn path=/trunk/; revision=12822
2004-12-23 19:53:24 +00:00
Ulf Lamping 124544cc39 show a simple_dialog, if we use glib 1.x and trying to open a webbrowser (not implemented). This will prevent another compiler warning.
svn path=/trunk/; revision=12821
2004-12-23 13:34:02 +00:00
Lars Roland 5474c91d65 Fixes for Mate from Luis Ontanon:
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- scs_subscribe doesn't use g_malloc anymore. it uses GMemChunks
(I had to rename two GMemChunks to make MSVC happy)
- fixes crash at reinit when DiscardPduData=TRUE: check if there's an
avpl before deleting it.
- mate.pdu_type.RelativeTime had a dual use, add
mate.pdu_type.TimeInGop and leave the other alone.
- other fixes related to times (they now seem to be right)
- fixed few things at reinit:
     - reset last_id 
     - remove the nodes in the items hash tables 

svn path=/trunk/; revision=12820
2004-12-23 08:27:30 +00:00
Ulf Lamping 0da82dce11 Again, some warnings removed.
svn path=/trunk/; revision=12819
2004-12-23 00:27:20 +00:00
Richard Sharpe 8190410fb3 Clean up one more instance of 8-byte timestamps in SMB. Have to work on
the 4-byte ones soon.


svn path=/trunk/; revision=12818
2004-12-22 19:44:42 +00:00
Guy Harris 9e176608c5 RFC 2868 says that the length of a "tagged string" field must be at
least 3 - 2 for type+length and 1 for the tag - so treat a "tagged
string" field as bad if there isn't at least one byte of data.  (It's a
bit odd that the RFC says that the tag must be in the range 0x01-0x1F -
that sounds suspiciously as if they're saying "printable characters
aren't valid tags", to allow untagged strings, which might suggest that
a field with a length of 2 should be interpreted as an empty string.)

svn path=/trunk/; revision=12817
2004-12-22 19:27:09 +00:00
Guy Harris e501ee7f01 Check for all bogus ACE lengths, i.e. all lengths < 4.
Clean up indentation.

Add a comment asking whether the revision in an ACL is *really* 2 bytes
and the ACE count is *really* 4 bytes.

svn path=/trunk/; revision=12816
2004-12-22 10:44:20 +00:00
Guy Harris af7dca469a Add only one protocol tree item for the "weak IV" flag - add it as a
non-hidden Boolean, and use "proto_tree_add_boolean_format()" to add it
to include the key byte.

svn path=/trunk/; revision=12815
2004-12-22 09:58:28 +00:00
Guy Harris c52e88e19e Change the RCS ID - it's not getting expanded when it's "$Id $".
Fix a comment in conversations_wlan.c.

Refer to "WLAN" in hostlist_wlan.c, just as we do in
conversations_wlan.c.

svn path=/trunk/; revision=12814
2004-12-22 09:46:14 +00:00
Guy Harris 0f039d5245 From Brett Kuskie: recalculate the ranges every time an export dialog is
opened, not just the first time, so that if the packet counts change
up-to-date values are displayed.

svn path=/trunk/; revision=12813
2004-12-22 09:19:01 +00:00
Richard Sharpe 80e3a2ed9c Add a dissection for the GET_NETWORK_FILE_OPEN_INFO and make some stuff that
we do in several places into a subroutine. We need to do it also with the 
4-byte time stamps that are dissected all over the place. 

I had thought that that last unknown in the returned structure might be 
a count of the number of clients that have the file open, but a simple test
suggests that that is not the case.


svn path=/trunk/; revision=12812
2004-12-22 02:40:33 +00:00
Guy Harris d7ba617f71 In the "rdconvertXXXtostr()" routines, check that the length passed in
is >= 0 (if it's not, that's a bug), and make the buffer index and total
length variables int as well, to match the length.

svn path=/trunk/; revision=12811
2004-12-22 01:51:00 +00:00
Guy Harris 88cbf869eb Move the RADIUS_TIMESTAMP, RADIUS_INTEGER4_TAGGED, and RADIUS_UNKNOWN
case branches up, so the case branches are in the same order as the
elements of the enum are, and add length checks to RADIUS_TIMESTAMP and
RADIUS_INTEGER4_TAGGED.

svn path=/trunk/; revision=12810
2004-12-22 01:42:54 +00:00
Guy Harris ce604f09d8 Properly declare a variable as volatile, as the longjmp done by the
exception mechanism might clobber it otherwise.

svn path=/trunk/; revision=12809
2004-12-22 00:30:39 +00:00
Guy Harris 7402efa058 Add some checks to make sure the AVP length is large enough for the item
we're fetching from the AVP.

In the case of a tagged string, if the length is 2 (meaning the data
length is 0), assume there's no tag.

svn path=/trunk/; revision=12808
2004-12-22 00:23:55 +00:00
Guy Harris 6270a8e27b Fix one comment, and put in another one giving a note about where you
can get the protocol specs.

svn path=/trunk/; revision=12807
2004-12-21 23:26:01 +00:00
Olivier Biot 7661effba5 From Victor Stratan: GSM SMS fixes:
- Corrected incorrect Timezone output due to byte overflow.

 - Added descriptions for address string decoding.


svn path=/trunk/; revision=12806
2004-12-21 21:17:44 +00:00
Guy Harris c415e09f20 Use "format_text()" on strings, to better handle non-printable
characters.

svn path=/trunk/; revision=12805
2004-12-21 20:36:50 +00:00
Guy Harris 5694ead821 Put the strings for the X-Mms-Previously-Sent-By header under the MMSE
tree rather than at the top level.

svn path=/trunk/; revision=12804
2004-12-21 20:03:47 +00:00
Guy Harris 9461951d50 Make the array for the "setup method" for RTP, RTCP, and T.38
conversations large enough to hold the maximum setup method size plus a
trailing '\0'.  Make the maximum setup method size 7, so that when the
trailing '\0' is included the total array length is a power of 2.  (The
longest string currently used is "Skinny", which fits in 7 characters).

This fixes problems in the RTP and RTCP dissectors similar to the one
found in the T.38 dissector.

Undo the previous change to packet-t38.c, as it's now safe to store in
method[MAX_T38_SETUP_METHOD_SIZE], because the array now has
MAX_T38_SETUP_METHOD_SIZE+1 characters.

(Should we use "strlcpy()", and supply our own "strlcpy()" if the system
and/or C library doesn't supply it?  Its semantics are a bit cleaner
than those of the "strncpy()"/null-terminate idiom, perhaps making it
less likely that mistakes of this sort will be made.)

svn path=/trunk/; revision=12803
2004-12-21 19:28:48 +00:00
Ronnie Sahlberg 97755f83fc from metze
make ethereal handle gss-api encrypted ldap blobs


svn path=/trunk/; revision=12802
2004-12-21 17:05:14 +00:00
Ronnie Sahlberg cba7da7b6c abs_time_to_str() returns a staticly allocated string. dont g_free() it.
fix two instances of wrong parameter list to proto_tree_add_string_format()

if we call proto_tree_string()  the hf field has to be of a string format as well.



now it dissects christophe's capture without dumping core  but it looks weird.
mmse and telco people can read the specs and find ut what it wrong.



svn path=/trunk/; revision=12801
2004-12-21 16:44:11 +00:00
Jörg Mayer 337d6a27f0 Abhijit Menon-Sen:
- Make port configurable via prefs
        - Highlight keywords in addition to values in hexpane

svn path=/trunk/; revision=12800
2004-12-21 13:18:08 +00:00
Jörg Mayer 773681fca3 Giles Scott: Add Wlan tap
svn path=/trunk/; revision=12799
2004-12-21 12:30:24 +00:00