Commit Graph

3670 Commits

Author SHA1 Message Date
Guy Harris 2851b7ef76 Enable "Match Selected" only if there's a field selected *and* we can do
a "Match Selected" on it - we can't do a "Match Selected" if the field
has no value (e.g., FT_NULL) and has a length of 0.

If we unselect the current packet, we don't have a protocol tree, so we
don't have a currently selected field - clear the "Match Selected" menu
item and the display in the status line of information about the
currently selected field.

Move the low-level statusbar manipulation into "gtk/main.c", in routines
whose API doesn't expose anything GTK+-ish.

"close_cap_file()" calls one of those routines to clear out the status
bar, so it doesn't need to take a pointer to the statusbar widget as an
argument.

"clear_tree_and_hex_views()" is purely a display-manipulating routine;
move it to "gtk/proto_draw.c".

Extract from "tree_view_unselect_row_cb()" an "unselect_field()" routine
to do all the work that needs to be done if the currently selected
protocol tree row is unselected, and call it if the currently selected
packet list row is unselected (if it's unselected, there *is* no
protocol tree, so no row can be selected), as well as from
"tree_view_unselect_row_cb()".

Before pushing a new field-description message onto the statusbar, pop
the old one off.

Get rid of an unused variable (set, but not used).

svn path=/trunk/; revision=3513
2001-06-05 07:39:31 +00:00
Guy Harris 36efcd0364 There is no string value assigned to the "ip.fragment.error",
"ip.fragment", and "ip.fragments" fields, so make them FT_NONE, not
FT_STRING.  (Otherwise, if you try to do a "Match Selected" on them, we
dump core because the value is a null pointer and we try to dereference
it.)

svn path=/trunk/; revision=3512
2001-06-05 05:54:14 +00:00
Guy Harris 7778d77931 Make Ethereal default to promiscuous-mode captures, the way it did
before promiscuous-vs-non-promiscuous was made a preference in the
preferences file (I suspect at least some of the problems people are
seeing with captures on Windows not seeing all the traffic they expect
to see might be due to the captures not being done in promiscuous mode -
and the default behavior shouldn't have changed in any case).

svn path=/trunk/; revision=3511
2001-06-04 08:07:34 +00:00
Guy Harris 671992baab Define a "COPY_ADDRESS()" macro, which copies the data in one address to
another (copying the data to a mallocated array) in
"epan/packet_info.h", and use it in the conversation code.

svn path=/trunk/; revision=3510
2001-06-04 07:27:50 +00:00
Guy Harris a5a36589f8 Add an "ADDRESSES_EQUAL()" macro, taking pointers to two "address"
structures as arguments, that evaluates to "true" if the two addresses
are equal and "false" if they're not equal.  Use that macro in the
conversation code.

svn path=/trunk/; revision=3509
2001-06-04 06:46:07 +00:00
Guy Harris 8ee0584e8d Updates from Mark Burton.
svn path=/trunk/; revision=3508
2001-06-04 05:32:52 +00:00
Gilbert Ramirez 01c7763de3 Correct the values for sna_rh_ru_category_vals, thanks to
Edgar Iglesias <edgar.iglesias@axis.com>
Also fix a few more places where I accidentally used hex instead
of binary.

svn path=/trunk/; revision=3507
2001-06-02 22:18:17 +00:00
Guy Harris 048625f419 "old_dissector_delete()" is no longer used; remove it.
Update Gerald's e-mail address.

svn path=/trunk/; revision=3506
2001-06-02 08:23:10 +00:00
Guy Harris f5d135ad13 Handoff registration routines must be named "proto_reg_handoff_XXX()",
not "proto_register_handoff_xxx()"; otherwise, the Python
"register.c"-generation script will think it's a protocol registration
routine not a handoff registration routine.

svn path=/trunk/; revision=3505
2001-06-02 08:15:57 +00:00
Guy Harris 3831d06992 On Windows, "min" apparently gets defined or declared in such a fashion
that declaring our own static function "min()" doesn't work; rename it
"iscsi_min()" to get rid of the problem.

svn path=/trunk/; revision=3504
2001-06-02 08:13:04 +00:00
Guy Harris 261c18fcd7 Not all platforms have u_int32_t (for example, Windows+MSVC doesn't), so
use "guint32" instead.

svn path=/trunk/; revision=3503
2001-06-02 08:10:02 +00:00
Guy Harris 8e4d1cce1e Windows+MSVC lacks "strptime()", so we need to include "strptime.h" to
declare our version of it.

svn path=/trunk/; revision=3502
2001-06-02 08:07:47 +00:00
Guy Harris b699efc451 Changes to structure initializations not to initialize some but not all
members, from Joerg Mayer.

svn path=/trunk/; revision=3501
2001-06-02 06:26:54 +00:00
Guy Harris 14ab278788 Windows and the MSVC++ 6.0 library don't have "strptime()", so pull in
the glibc "strptime()" (modified so it doesn't require the rest of
glibc), set up the configure script to check for it, and set up
Makefile.am and Makefile.nmake to use it.

Get rid of NEED_MKSTEMP - nothing uses it.

svn path=/trunk/; revision=3500
2001-06-02 06:21:14 +00:00
Guy Harris 89a74629b2 Create the tree for an ICMPv6 optionn before putting something in it.
svn path=/trunk/; revision=3499
2001-06-02 06:10:08 +00:00
Guy Harris b2ab758ca7 The Cisco 802.11 bridges used 0000F8, i.e. OUI_CISCO_90, not 000078;
various Cisco documents indicate that 0000F8 is used on at least some
Cisco boxes for bridging Ethernet frames onto 802.x+LLC frames.

svn path=/trunk/; revision=3498
2001-06-02 03:04:12 +00:00
Jun-ichiro itojun Hagino 78d7c0ca28 draft-draves-ipngwg-router-selection-01 support.
fix icmp6 homeagent info option decoding (convert to tvb framework).
plug a memory leak.
sync some of mobile-ip6 #define symbol names with draft-ietf-ipngwg-2292bis-02.

svn path=/trunk/; revision=3497
2001-06-01 23:53:49 +00:00
Guy Harris 40c78f3b80 Some Cisco 802.11 bridges apparently change the OUI of packets from
000000 to 000078, so treat LLC packets with that OUI the same way we
treat LLC packets with 000000.

svn path=/trunk/; revision=3496
2001-06-01 23:04:37 +00:00
Guy Harris ce18175da0 Updates from Martin Held.
svn path=/trunk/; revision=3495
2001-06-01 21:00:13 +00:00
Guy Harris 7303b2da99 Bug fixes, and WEP support, from Javier Achirica.
svn path=/trunk/; revision=3494
2001-06-01 01:15:29 +00:00
Guy Harris 374151cc40 Support for leading LWS in RTSP headers, from Robert Tsai.
svn path=/trunk/; revision=3493
2001-05-31 20:40:29 +00:00
Guy Harris c3db6052cb Updates from Mark Burton.
svn path=/trunk/; revision=3492
2001-05-31 19:20:41 +00:00
Guy Harris ffb3b28de6 Don'tcramallthewordsinapreference'snametogether;
underscores_are_permitted_in_those_names.

svn path=/trunk/; revision=3491
2001-05-31 08:54:17 +00:00
Guy Harris e1b5ff9586 Make the "short name" of MTP Level 3 just "MTP3", matching what we put
in the Protocol column, and make the "filter name" "mtp3", as filter
names are supposed to be all-lower-case.

svn path=/trunk/; revision=3490
2001-05-31 08:51:29 +00:00
Guy Harris 6ee04dad33 Support for "-N" flag enabling selected forms of name resolution, from
Joerg Meyer.

Support for saving to the preferences file the settings for all types of
name resolution.

Do a case-insensitive check for "true" and "false" in Boolean preference
settings.

svn path=/trunk/; revision=3489
2001-05-31 08:36:46 +00:00
Guy Harris 6200054304 Add support for "Match Selected" on FT_ABSOLUTE_TIME and
FT_RELATIVE_TIME fields.

svn path=/trunk/; revision=3488
2001-05-31 07:15:23 +00:00
Guy Harris 52025d6956 Display all the digits of the microsecond field of an absolute time
value.

Check that the microseconds field of an absolute time is valid, if it's
present.

Set "tm_isdst" in the "struct tm" handed to "mktime()" to -1, so that
"mktime()" will attempt to figure out whether the time is daylight
savings time or not.

Check that "mktime()" was able to convert the time.

svn path=/trunk/; revision=3487
2001-05-31 06:48:00 +00:00
Guy Harris 15336e821c Don't require both the seconds and microseconds parts of a relative time
to be present - "1" is just as good as "1.0", and ".1" is just as good
as "1.1".

svn path=/trunk/; revision=3486
2001-05-31 06:20:10 +00:00
Guy Harris 963de49427 Free the string you "g_strdup()"ed, rather than handing "g_free()" the
null pointer that provoked you to free the string.

svn path=/trunk/; revision=3485
2001-05-31 05:33:15 +00:00
Guy Harris 7b4fbe10b5 Support for filtering on absolute and relative time fields, from Ronnie
Sahlberg.

svn path=/trunk/; revision=3484
2001-05-31 05:01:06 +00:00
Guy Harris 6922a9986a Updates from Johan Jorgensen.
Don't use "pinfo->captured_len" to check the length of the packet -
that's the length of the *entire* frame, not the length of the portion
that belongs to the 802.11 dissector (there are currently no dissectors
for protocols in which 802.11 is encapsulated, so it doesn't currently
make a difference, but dissectors should use "tvb_length()" and so on to
get that information for the tvbuff they were handed).

svn path=/trunk/; revision=3483
2001-05-30 19:17:31 +00:00
Guy Harris 714c10a91c iSCSI support, from Mark Burton.
svn path=/trunk/; revision=3482
2001-05-30 18:52:38 +00:00
Guy Harris 40abc4f2b0 MSVC++ doesn't define "uint"; use "guint" instead.
svn path=/trunk/; revision=3481
2001-05-30 08:49:23 +00:00
Guy Harris 31199a53a5 Get rid of some unnecessary settings of "pinfo->current_proto" - if the
dissector is called only through a handle or dissector table, the code
that handles those calls sets it for you.

svn path=/trunk/; revision=3480
2001-05-30 07:48:23 +00:00
Guy Harris 9fe2133a20 Call the Vines IP dissector through a handle, and call the Vines SPP
dissector through a handoff table.

svn path=/trunk/; revision=3479
2001-05-30 07:41:18 +00:00
Guy Harris cc6b18e6ab No old-style dissectors call "old_dissector_try_port()", so get rid of
"old_dissector_try_port()".

There are no longer any old-style heuristic or conversation dissectors,
so get rid of "old_heur_dissector_add()" and "old_conv_dissector_add()"
and the data-structure members that support old-style heuristic and
conversation dissectors.

svn path=/trunk/; revision=3478
2001-05-30 06:41:08 +00:00
Guy Harris abd9fc125f There are no more old-style (non-tvbuffified) ONC RPC dissectors, so get
rid of support for them, and remove the "_tvb" from the end of the names
of RPC type dissection routines.

Update Gerald's e-mail address.

svn path=/trunk/; revision=3477
2001-05-30 06:01:02 +00:00
Guy Harris e38a3ef330 Tvbuffified NFS dissector, from Mike Frisch, plus some registered-field
cleanups.

svn path=/trunk/; revision=3476
2001-05-30 04:40:27 +00:00
Guy Harris fe57b4a138 Fix a typo.
svn path=/trunk/; revision=3475
2001-05-28 20:18:08 +00:00
Guy Harris 73daa09911 We now might print four IP addresses on a protocol tree line, so make
"ip_to_str()" capable of producing up to four separate strings.

svn path=/trunk/; revision=3474
2001-05-28 20:12:30 +00:00
Guy Harris 9e82be175d Fix the copyright notice to reflect the fact that Gerald holds the
copyright on Ethereal as a whole.

svn path=/trunk/; revision=3473
2001-05-27 21:38:46 +00:00
Guy Harris f8993291b3 We can't use a single static buffer for decrypted ICQ data - you might
have more than one decrypted ICQ packet visible at a time, as you might
have popped up additional single-packet windows for those packets.
Allocate the buffer for the decrypted data when you decrypt, and arrange
that it be freed when the tvbuff that refers to it is freed.

Fix the copyright notice to reflect the fact that Gerald holds the
copyright on Ethereal as a whole.

svn path=/trunk/; revision=3472
2001-05-27 21:37:23 +00:00
Guy Harris cce642c0f7 Fix a comment, and update Gerald's e-mail address.
svn path=/trunk/; revision=3471
2001-05-27 21:34:05 +00:00
Guy Harris e3a94e0342 Plug a memory leak (we weren't freeing the "epan_dissect_t" pointed to
by the "edt" member of a "capture_file" structure if we were selecting a
new frame, we were just overwriting that pointer).

Update Gerald's e-mail address.

svn path=/trunk/; revision=3470
2001-05-27 21:33:16 +00:00
Guy Harris ac655efe2f Don't use END_OF_FRAME - or otherwise refer to "pi" - in tvbuffified
dissectors.

svn path=/trunk/; revision=3469
2001-05-27 09:15:14 +00:00
Guy Harris 0d801fd30e Don't use END_OF_FRAME in tvbuffified dissectors.
svn path=/trunk/; revision=3468
2001-05-27 08:45:51 +00:00
Guy Harris 76301b827b "END_OF_FRAME" should not be used in tvbuffified dissectors.
Update Gerald's e-mail address.

svn path=/trunk/; revision=3467
2001-05-27 08:09:49 +00:00
Guy Harris 176eaa265a Give protocol tree windows a horizontal scrollbar - yes, sometimes
protocol tree lines can be long enough that you might want, or even
need, one (consider really long names for SNMP OIDs, for example).

svn path=/trunk/; revision=3466
2001-05-27 07:50:28 +00:00
Guy Harris 0fe055e9dd Call the LANE dissector through a handle.
Create an ILMI dissector and call it through a handle.

Update Gerald's e-mail address.

svn path=/trunk/; revision=3465
2001-05-27 07:46:57 +00:00
Guy Harris ddec2eb25b Call the H.261 dissector through a handle.
Set the reported length of the tvbuff we hand to the H.261 dissector.

svn path=/trunk/; revision=3464
2001-05-27 07:37:46 +00:00