Commit Graph

3670 Commits

Author SHA1 Message Date
Guy Harris fafefda449 Don't offer the ability to edit capture filters if Ethereal wasn't
linked with libpcap.

svn path=/trunk/; revision=3613
2001-06-27 10:00:14 +00:00
Guy Harris cc9df27294 Fix a problem that shows up if you build without libpcap.
svn path=/trunk/; revision=3612
2001-06-27 08:36:08 +00:00
Guy Harris c932345421 Replace "--enable-pcap" with "--with-pcap", and if an argument is
specified to "--with-pcap", add that directory to the include file and
library search paths, so that you can use "--with-pcap=DIR" to search
for libpcap in a directory other than the standard ones (either because
it was installed somewhere other than under "/usr" or "/usr/local", or
because you want to use a special version you've installed rather than
the standard one).

svn path=/trunk/; revision=3611
2001-06-27 07:47:50 +00:00
Guy Harris 032f16e2eb If length arguments to "%*s" aren't of type "int", cast them to "int",
as that's what C requires them to be.

svn path=/trunk/; revision=3610
2001-06-26 20:52:19 +00:00
Guy Harris 0b36ed83c6 Add HFILL to explicitly fill in some additional structure members.
svn path=/trunk/; revision=3609
2001-06-26 20:50:30 +00:00
Jun-ichiro itojun Hagino 3242b12d40 indentation consistencies.
svn path=/trunk/; revision=3608
2001-06-26 17:31:36 +00:00
Guy Harris 43d40e561c Remove second entry for Michael Rozhavsky - "Additional OSPF LSA types
and opaque-options flag" falls under the broader heading of "OSPF
enhancements".

svn path=/trunk/; revision=3607
2001-06-25 08:36:48 +00:00
Guy Harris 25c2cb0ec0 A better fix - we don't use "assigned" if the action was E_DECODE_NO, so
don't bother fetching it if the action is E_DECODE_NO; that means we can
also avoid fetching the currently selected row if the action is
E_DECODE_NO, so the fact that we've cleared the selection if the action
is E_DECODE_NO doesn't matter.

svn path=/trunk/; revision=3606
2001-06-25 08:10:38 +00:00
Guy Harris 9c046f18a3 In "decode_network()", get the information about the currently selected
row *before* calling "decode_simple()", as, if the "Do not decode" radio
button is selected, "decode_simple()" will clear the current selection.

svn path=/trunk/; revision=3605
2001-06-25 07:57:50 +00:00
Guy Harris d4c81a142c More IS-IS updates.
HELLO message support in RSVP.

svn path=/trunk/; revision=3604
2001-06-23 19:45:12 +00:00
Guy Harris fb82ca171d Include "strerror.h" only on platforms that don't declare it in a
standard header file, so we get the platform's declaration (which may
include, for example, "dllexport"-type declarations) rather than the
"workaround for platforms that lack it" declaration.

svn path=/trunk/; revision=3603
2001-06-23 19:14:42 +00:00
Guy Harris 92d546499e "index()" is non-standard, and MSVC++ 6.0 complained about it; the ANSI
C standard has "strchr()" instead, so use it.

svn path=/trunk/; revision=3602
2001-06-23 19:10:27 +00:00
Gilbert Ramirez 39b0e82f63 Support CIDR notation in IPv4 address filtering.
svn path=/trunk/; revision=3601
2001-06-22 16:29:15 +00:00
Guy Harris b3c464723c Allow the 802.11 management-frame protocol to be disabled.
Don't bother doing the WEP processing and child-tvbuff construction for
frames other than management and data frames, as they have no payload to
be WEP-encrypted or dissected.

svn path=/trunk/; revision=3600
2001-06-22 08:12:11 +00:00
Guy Harris 210a722eca Dissect the payload of a management frame as a separate protocol, so
that you can open up that protocol without opening up the 802.11 MAC
header; this can save some screen real estate.

Make the tree item for all the WEP parameters a text item, rather than a
"string" field with a null string pointer, as "strings" with null string
pointers give the filtering code gastric distress.

Dissect the WEP initialization vector as an FT_UINT24 (as it's a 3-byte
field), and dissect the key ID as part of an FT_UINT8 (as it's in an
8-bit byte).

After dissecting the frame control field, dissect the rest of the header
in one switch statement, and then:

	handle WEP-encrypted frames with common code for all frame
	types;

	handle the payload of other frames.

(If we can supply the relevant keys to Ethereal, we could perhaps add
code to decrypt the WEP payload and then dissect the decrypted payload
the same way we dissect un-encrypted payloads.)

svn path=/trunk/; revision=3599
2001-06-22 07:46:25 +00:00
Guy Harris 31f2169275 Fix up some incorrect handling of the TO_DS and FROM_DS flags by
#defining all the bits in the flags field, and using those #defines in
the macros to test the flag fields, the macros fot the data address
types, the value_string table for the data frame to/from DS
combinations, and the bitfields for the flag bits.

svn path=/trunk/; revision=3598
2001-06-22 06:03:50 +00:00
Guy Harris 8e50692576 Fix a typo.
svn path=/trunk/; revision=3597
2001-06-21 22:35:33 +00:00
Guy Harris 81a6c19ccf M2PA support, from Jeff Morriss.
svn path=/trunk/; revision=3596
2001-06-21 22:25:53 +00:00
Uwe Girlich b966930fb5 some more dissectors of Uwe Girlich added
svn path=/trunk/; revision=3595
2001-06-21 15:18:11 +00:00
Uwe Girlich 83c16fabb0 new source files packet-quakeworld.c and packet-quake2.c added
svn path=/trunk/; revision=3594
2001-06-21 15:16:43 +00:00
Uwe Girlich 2d0a2ec04c initial checkin of the Quake II network protocol dissector
svn path=/trunk/; revision=3593
2001-06-21 15:15:57 +00:00
Uwe Girlich f4f5e0c4d4 initial checkin of the QuakeWorld network protocol dissector
svn path=/trunk/; revision=3592
2001-06-21 15:15:02 +00:00
Uwe Girlich 1b971dbfae signed/unsigned warning corrected
the server port is now configurable via preferences
code reformatting

svn path=/trunk/; revision=3591
2001-06-21 15:13:42 +00:00
Guy Harris 5748457c94 Get rid of an unused #define.
Make routines not used outside this module static.

Make "find_header_length()" return the correct value for management and
control frames.

svn path=/trunk/; revision=3590
2001-06-21 06:59:47 +00:00
Guy Harris eea200a485 Don't use "tvb_get_ptr()" and "pletohs()" just to fetch a 16-bit
integral value from a packet - "tvb_get_letohs()" can do that just fine.

Don't use "tvb_get_ptr()", casting the result to a "guint16 *", and
dereferencing that pointer, either: that doesn't handle byte order
correctly, and it may fail if the pointer isn't aligned on a 2-byte
boundary.

For that matter, don't just use "tvb_get_ptr()" and dereference the
result to get an 8-bit quantity.

Use "proto_tree_add_item()" in many places where it's possible.

Reuse the results of "tvb_get_ptr()" calls when possible.

Show the fragment number and sequence number in decimal - they're just
ordinals.

Fix the blurb for the sequence number field.

svn path=/trunk/; revision=3589
2001-06-21 06:36:44 +00:00
Guy Harris f492449c58 Make sure the top-level 802.11 item covers the entire frame.
Give the type field values names, rather than just showing them as 0, 1,
and 2.

svn path=/trunk/; revision=3588
2001-06-20 23:58:57 +00:00
Guy Harris a9eb080410 Make the type/subtype field the very first entry in the protocol tree,
and put it under the top-level 802.11 protocol item, so you don't have
to open the frame control field to see it.

Rename the variable for it, and the value_string array for it, to
indicate that it's made out of the type and subtype fields.

svn path=/trunk/; revision=3587
2001-06-20 23:29:16 +00:00
Guy Harris 693ff9fecb All four data frame types are now handled with identical code, so,
instead of having four identical copies of that code in switch
statements, just handle all four of them with the same case.

svn path=/trunk/; revision=3586
2001-06-20 23:12:05 +00:00
Guy Harris 49a931ee69 Put the combined type/subtype into the protocol tree, so you can look
for all Association Request frames, or all frames except for
Clear-to-send frames, or....

Compute the composed frame type early in the dissection process, and set
the Info column as soon as you've done that, rather than doing it in the
later switch statement.

svn path=/trunk/; revision=3585
2001-06-20 23:04:36 +00:00
Guy Harris 9b8bfbe171 If it's not a protocol, it doesn't belong at the top level of the
protocol tree; not only is putting it at the top level a little weird,
it upsets the heck out of the protocol-statistics code, causing it to
abort.  Put the fixed and tagged parameters under the top-level entry
for 802.11 (where one of the fixed-parameters entries already was).

Call the top-level item just "IEEE 802.11", not "IEEE 802.11 Header", as
it includes management-frame information.

svn path=/trunk/; revision=3584
2001-06-20 22:26:07 +00:00
Guy Harris ff0d7ee9c4 Clean up a string.
svn path=/trunk/; revision=3583
2001-06-20 06:22:33 +00:00
Guy Harris 65d0b1e526 Fix "COOK_ADDR_SELECTOR()" to extract the 2 bits that determine the
interpretation of the address fields, in DATA_ADDR_T{1,2,3,4} format.

Clean up a bunch of other macros to enclose their argument in
parentheses.

Clean up "find_header_length()" - it only needs to take the frame
control field of the frame as an argument, and should just check whether
"COOK_ADDR_SELECTOR()" returns DATA_ADDR_T4.

"tofrom_ds" is a value_string table, not a true_false_string table, so
wrap it in "VALS()", not "TFS()".

Don't fetch the header length in N different places in the main
dissector - just fetch it once and use it throughout.

svn path=/trunk/; revision=3582
2001-06-20 06:15:07 +00:00
Guy Harris 5d8b3d5659 Catch TLVs with bogus lengths (i.e., less than the fixed-length header
size); otherwise, we run the risk of looping forever.

svn path=/trunk/; revision=3581
2001-06-20 05:18:36 +00:00
Guy Harris 8073087bdf RTSP fixes, from nuf si.
svn path=/trunk/; revision=3580
2001-06-20 04:45:52 +00:00
Guy Harris eb5031e9df Handle Negotiate Protocol replies with the "extended security"
capability flag set.

svn path=/trunk/; revision=3579
2001-06-20 01:58:48 +00:00
Guy Harris 8c52d3db75 More signed vs. unsigned cleanups, and initialization cleanups, from
Joerg Mayer.

svn path=/trunk/; revision=3578
2001-06-19 23:08:57 +00:00
Guy Harris 099903ee7b Updates from Frank Singleton.
svn path=/trunk/; revision=3577
2001-06-19 20:10:51 +00:00
Guy Harris 5c183da3dc From Frank Singleton: fix compiler warnings.
svn path=/trunk/; revision=3576
2001-06-19 18:50:33 +00:00
Guy Harris 60d762a7c2 In a capture child process, *completely ignore* the preference setting
for promiscuous mode; just do what the parent process told you, i.e. do
a non-promiscuous capture iff a "-p" flag was specified.

svn path=/trunk/; revision=3575
2001-06-19 08:47:48 +00:00
Guy Harris decbfd0226 Labels must be followed by statements; GCC may let you get away without
the statement, but MSVC++ doesn't.

svn path=/trunk/; revision=3574
2001-06-19 08:33:00 +00:00
Guy Harris 02db206409 Not all Python scripts generate dissectors; "make-reg-dotc.py" generates
"register.c", and, as such, shouldn't stuff ", HFILL" into its output.

svn path=/trunk/; revision=3573
2001-06-19 08:29:32 +00:00
Guy Harris 61c0c6c290 Get rid of global references to "pi" - use "pinfo" instead.
svn path=/trunk/; revision=3572
2001-06-19 04:46:10 +00:00
Guy Harris 61cb233810 Many corrections and updates for connection-oriented WSP, from Alexandre
P. Ferreira.

svn path=/trunk/; revision=3571
2001-06-18 22:27:30 +00:00
Guy Harris 37445739b2 From Frank Singleton: add code generation support for IDL array types.
svn path=/trunk/; revision=3570
2001-06-18 19:31:50 +00:00
Uwe Girlich 61f8385703 NFS file handle analysing works now for kernel based NFS v3 servers of
Linux 2.4.0 too.

svn path=/trunk/; revision=3569
2001-06-18 16:38:22 +00:00
Guy Harris 4bb5c7d15e Don't list the attribute-value pairs if the length field of the packet
says there aren't any (i.e., if the length field minus the size of the
stuff before the AVP's is less than or equal to 0).

svn path=/trunk/; revision=3568
2001-06-18 09:31:15 +00:00
Guy Harris 516c93c5e3 From Craig Rodrigues: changes to handle current versions of RPM, which
compress man pages.

svn path=/trunk/; revision=3567
2001-06-18 07:21:30 +00:00
Guy Harris 322f2031f9 Fix up the buffer size calculation - the starting offset isn't a
multiple of 4, so making the size of the buffer a multiple of 4 isn't
the right thing to do.

svn path=/trunk/; revision=3566
2001-06-18 06:31:05 +00:00
Guy Harris 0645bf8d3f Get rid of an unnecessary declaration of "packet_list".
svn path=/trunk/; revision=3565
2001-06-18 06:18:03 +00:00
Guy Harris b938f1d657 The ICQ decryption code works on 4 bytes at a time, so the amount of
data it decrypts must be a multiple of 4; round the size of the ICQ data
to a multiple of 4, and use that as the size of the buffer into which to
put the decrypted data and as the byte count passed to the decryption
routine.

svn path=/trunk/; revision=3564
2001-06-18 05:54:26 +00:00