Commit Graph

10 Commits

Author SHA1 Message Date
Gilbert Ramirez f6e92a9e93 Break proto_tree_add_item_format() into multiple functions:
proto_tree_add_protocol_format()
	proto_tree_add_uint_format()
	proto_tree_add_ipxnet_format()
	proto_tree_add_ipv4_format()
	proto_tree_add_ipv6_format()
	proto_tree_add_bytes_format()
	proto_tree_add_string_format()
	proto_tree_add_ether_format()
	proto_tree_add_time_format()
	proto_tree_add_double_format()
	proto_tree_add_boolean_format()
If using GCC 2.x, we can check the print-format against the variable args
passed in. Regardless of compiler, we can now check at run-time that the
field type passed into the function corresponds to what that function
expects (FT_UINT, FT_BOOLEAN, etc.)

Note that proto_tree_add_protocol_format() does not require a value field,
since the value of a protocol is always NULL. It's more intuitive w/o the
vestigial argument.

Fixed a proto_tree_add_item_format-related bug in packet-isis-hello.c
Fixed a variable usage bug in packet-v120.c. (ett_* was used instead of hf_*)

Checked in Guy's fix for the function declearation for proto_tree_add_text()
and proto_tree_add_notext().

svn path=/trunk/; revision=1713
2000-03-12 04:48:32 +00:00
Guy Harris 5b5f2271cd "tm_mon" in a "struct tm" is 0-based, not 1-based; when printing the
month number, add 1 to "tm_mon".

svn path=/trunk/; revision=1519
2000-01-22 02:00:27 +00:00
Guy Harris 7a943b7810 Fix Gerald's e-mail address.
svn path=/trunk/; revision=1437
2000-01-07 22:05:43 +00:00
Gerald Combs 0084153517 Fix bus error/alignment issues in ntp_fmt_ts.
svn path=/trunk/; revision=1366
1999-12-21 17:21:22 +00:00
Guy Harris 9cff0cb137 When dissecting the reference clock ID field:
if it's stratum 0 or 1, use "memcmp()" to compare it against the
	strings in our table, rather than assuming it's aligned on a
	4-byte boundary and doing an integral comparison - neither of
	the strings being compared are necessarily so aligned - and, if
	it doesn't match any of them, include the value in the
	"Unidentified reference source" description;

	if it's stratum 2 or higher, extract the value with "pntohl()"
	before interpreting it as an IP address - IP addresses are in
	network byte order, and, again, it's not necessarily neatly
	aligned on a 4-byte boundary.

svn path=/trunk/; revision=1223
1999-12-06 03:18:24 +00:00
Guy Harris a7aba0a288 Replace the ETT_ "enum" members, declared in "packet.h", with
dynamically-assigned "ett_" integer values, assigned by
"proto_register_subtree_array()"; this:

	obviates the need to update "packet.h" whenever you add a new
	subtree type - you only have to add a call to
	"proto_register_subtree_array()" to a "register" routine and an
	array of pointers to "ett_", if they're not already there, and
	add a pointer to the new "ett_" variable to the array, if they
	are there;

	would allow run-time-loaded dissectors to allocate subtree types
	when they're loaded.

svn path=/trunk/; revision=1043
1999-11-16 11:44:20 +00:00
Guy Harris 50dc9d07c8 Include "snprintf", if necessary, to get "snprintf()" declared.
svn path=/trunk/; revision=926
1999-10-25 20:48:48 +00:00
Guy Harris 72eb3d5353 Tomislav Vujec's additional comments on the layout of NTP packets.
svn path=/trunk/; revision=923
1999-10-25 01:55:45 +00:00
Guy Harris 6921a22ac5 Additional NTP changes:
added misc. constants for parsing flags, and converting time
	stamps;

	added flags and primary sources explanations;

	added function for converting time stamps;

	improved item analysis;

	new item definitions;

from Tomislav Vujec.

svn path=/trunk/; revision=908
1999-10-22 06:31:39 +00:00
Guy Harris 5ed4011c30 Nathan Neulinger's NTP dissector.
svn path=/trunk/; revision=828
1999-10-14 05:10:33 +00:00