Bill Meier
0a94d24771
Fix several [-Wshadow] warnings.
...
svn path=/trunk/; revision=46287
2012-11-29 16:22:54 +00:00
Michael Mann
8dcfa4214c
replace unnecessary decode_numeric_bitfield calls
...
svn path=/trunk/; revision=45154
2012-09-26 18:33:10 +00:00
Jeff Morriss
3551a86c36
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45015
2012-09-20 01:29:52 +00:00
Jakub Zawadzki
5a8783f5b1
Initial commit to support yet another method of passing data between dissectors.
...
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL
svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
Jakub Zawadzki
b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
Jakub Zawadzki
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
Bill Meier
3d4b3f2784
Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if Makefile.common is changed
...
svn path=/trunk/; revision=42972
2012-06-01 14:44:35 +00:00
Bill Meier
1caa79ad80
Windows: Set Makefile.common as a plugin.c dependency so plugin.c is rebuilt if Makefile.common is changed
...
ToDo: ditto for Makefile.am ?
svn path=/trunk/; revision=42971
2012-06-01 14:08:12 +00:00
Guy Harris
944ae5ae49
Get rid of remaining Booleans-as-encoding-arguments in
...
proto_tree_add_item() calls.
svn path=/trunk/; revision=42590
2012-05-11 20:02:52 +00:00
Anders Broman
b1b0af6e66
From Pascal Quantin:
...
Fix Bug 6793 Some WiMAX messages decoded incorrectly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6793
svn path=/trunk/; revision=42045
2012-04-13 13:02:57 +00:00
Jeff Morriss
75c3c92f19
Add a "-build" argument to checkAPIs.pl. Use that argument when building
...
from makefiles (and thus from the buildbot).
The intention is to be able to tell when a human is running the tool so we
can provide more code-review guidance.
As a starter, enable the "too many proto_tree_add_text() calls" check when
a human is running the tool.
svn path=/trunk/; revision=41943
2012-04-04 20:46:49 +00:00
Bill Meier
605dea0486
CVARSDLL hasn't been used (is undefined) for a while....
...
svn path=/trunk/; revision=41180
2012-02-24 16:23:38 +00:00
Anders Broman
8e97665863
Add *.sbr files to the clean target.
...
svn path=/trunk/; revision=40761
2012-01-29 20:03:39 +00:00
Bill Meier
794757ae8f
For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.
...
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
2011-10-21 02:10:19 +00:00
Bill Meier
cca6984ab9
Do some more conversions of proto_tree_add_item() 'encoding' arg
...
(previously missed).
svn path=/trunk/; revision=39450
2011-10-18 00:17:48 +00:00
Chris Maynard
cfca66f6e1
Remove const qualifier to name, abbrev and blurb to pacify the buildbots.
...
svn path=/trunk/; revision=36860
2011-04-26 01:06:25 +00:00
Guy Harris
34f8f7e77d
Get rid of some unnecessary casts that just provoke uninteresting
...
warnings.
More fun with GArrays: cast away some warnings that don't report real
alignment problems and that wouldn't even happen if the "data" member of
a GArray were a "void *".
svn path=/trunk/; revision=36856
2011-04-25 21:20:47 +00:00
Chris Maynard
735b61500c
Don't dereference a NULL pointer. Fixes CID 426.
...
svn path=/trunk/; revision=36424
2011-03-31 18:00:26 +00:00
Martin Mathieson
7356320a2a
Don't assign proto_item pointers that are not used.
...
Coverity 1174
svn path=/trunk/; revision=36395
2011-03-29 14:23:13 +00:00
Guy Harris
3eecbb3248
Just use g_strdup_printf(), rather than doing it ourselves.
...
svn path=/trunk/; revision=35780
2011-02-03 08:31:04 +00:00
Bill Meier
d3efa3ed9f
A bit of Windows makefiles rework and cleanup:
...
- Define macros for certain CFLAGS in config.nmake iso of having defs in each makefile;
a. -DHAVE_CONFIG_H and -D_U_="" are now part of a macro named STANDARD_CFLAGS;
b. -WX has been replaced by WARNINGS_ARE_ERRORS (defined as -WX in config.nmake)
(This allows disabling "Warnings as Errors" by just changing config.nmake)
c. CVARSDLL definitions (not usage) have been removed from the various makefiles.
XXX: It appears the usage of CVARSDLL can also be removed (not yet done) since:
-DWIN32 and -DNULL=0 do not appear to be needed (any more);
-D_MT and _D_DLL are not needed since /MP causes these definitions.
d. Define a macro WARNINGS_CFLAGS with additional specific compiler (level4) warnings to be enabled.
E.G., 4295: array is too small to include a terminating null character
- config.nmake: reformat some long lines for readability;
- plugins\Makefile.nmake: clean-deps does nothing: remove it (and usage in top-level makefile);
- dissectors/Makefile.nmake: test to enable packet-rrc.obj target needs to include MSVC2010 ...
svn path=/trunk/; revision=35747
2011-02-02 01:19:53 +00:00
Jeff Morriss
f53744b59d
There's no need to pass the result of tvb_get_ptr() as the 'value' in
...
proto_tree_add_*(): just use proto_tree_add_item().
Replace some tvb_get_ptr()s with tvb_get_ephemeral_string().
svn path=/trunk/; revision=35603
2011-01-21 03:00:31 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Jeff Morriss
9aeb1dac17
From David Katz via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5166 :
...
Add a configuration parameter of the NWG version for WiMAX ASN CP dissector.
The format and meaning of TLVs, as well as function types and messages changed
between the different NWG versions.
Added support for the version number of TLVs in the dictionary xml, its parser,
and of course in the packet itself.
Added support for the version number of function-types and message-types by
extending the value_string structure to contain also a "since" version number.
Successfully tested with a live capture and capture file, containing WiMAX ASN
packets (full Network entry).
Also fuzzed 500 passes successfully.
The XML doesn't contain all existing NWG versions, only selected ones. This is
a little tedious work to go over all TLVs of each version, so I'll add some
newer versions later on. can add a short how-to of adding a new version, for
others to use, if needed.
svn path=/trunk/; revision=34919
2010-11-17 03:16:30 +00:00
Guy Harris
ac3ac6c476
Plugins are not shared libraries, so:
...
1) don't set thei SOVERSION - run-time-loaded modules don't have
an SOVERSION;
2) build them with link mode MODULE, not SHARED, on all
platforms.
(Fixing 1) also fixes the problem with building them as MODULE on OS X.)
svn path=/trunk/; revision=34243
2010-09-24 20:41:34 +00:00
Jörg Mayer
de68ad3066
H. Sivank <hsivank@gmail.com>
...
I try to configure Wireshark with cmake on macosx 10.6.
It fails with : set_target_properties called with incorrect number of arguments.
Attached a patch to fix this issue.
svn path=/trunk/; revision=34201
2010-09-23 07:02:33 +00:00
Bill Meier
7219ee2a49
Use val_to_str_ext() & friends to access sminmpec_values[];
...
Also: packet-nhrp.c: #include sminmpec.h not req'd;
svn path=/trunk/; revision=34143
2010-09-17 04:51:21 +00:00
Jeff Morriss
54082c6ed0
Add Cmake stuff to the source distribution so more people can try it out.
...
svn path=/trunk/; revision=32807
2010-05-14 16:27:03 +00:00
Anders Broman
846eed1d9e
Get rid of check_col
...
svn path=/trunk/; revision=32401
2010-04-06 16:13:09 +00:00
Jaap Keuter
9c05bc3bc5
Make the test compile.
...
svn path=/trunk/; revision=32359
2010-04-02 06:03:44 +00:00
Anders Broman
dc5e066cae
From sangaran:
...
8-bit Bit Flag decoder method needed in wimaxasncp plugin dissecto.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4608
svn path=/trunk/; revision=32356
2010-04-01 20:49:07 +00:00
Jörg Mayer
96779de920
cmake changes:
...
- Add checking for linker flags
- Install plugins with the name including the Wireshark version.
This will make it easier to find matching plugin versions if
files get just copied over.
svn path=/trunk/; revision=32231
2010-03-18 10:27:17 +00:00
Jörg Mayer
67072286bf
- Remove the lib prefix for plugin names.
...
- Remove a (resolved) comment.
- Add a commented out line how to add version infos to the
plugin's file name.
svn path=/trunk/; revision=31995
2010-02-24 22:32:10 +00:00
Bill Meier
c033a08313
Fix some gcc -Wshadow warnings.
...
svn path=/trunk/; revision=31724
2010-01-28 23:53:27 +00:00
Anders Broman
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
Jörg Mayer
d2cc318f4f
Beginnings of enabling static builds. Still to do:
...
* Add -static
* Registration may need different handling
* Add plugins
* Build error in wslua
svn path=/trunk/; revision=30987
2009-11-17 11:58:36 +00:00
Jörg Mayer
9ee31d1d0e
cmake will now honor -Werror if configured (default: on)
...
svn path=/trunk/; revision=30852
2009-11-07 10:07:00 +00:00
Kovarththanan Rajaratnam
8b8399b711
Use register_dissector_files in the plugins dissectors
...
svn path=/trunk/; revision=30435
2009-10-09 16:39:34 +00:00
Anders Broman
4d2e653901
From Didier Gautheron:
...
Dissectors using call_dissector() function inside a 'if (tree) {}' block.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107
svn path=/trunk/; revision=30415
2009-10-09 07:24:33 +00:00
Stig Bjørlykke
cf85342eec
Build plugins with cmake on OSX.
...
svn path=/trunk/; revision=30373
2009-10-06 18:58:09 +00:00
Jörg Mayer
ebfcf3c387
Build more plugins with cmake.
...
svn path=/trunk/; revision=30084
2009-09-23 04:41:14 +00:00
Jeff Morriss
4661aad9a4
Run checkapi on the dissector header files
...
svn path=/trunk/; revision=29883
2009-09-13 19:48:22 +00:00
Kovarththanan Rajaratnam
2547ce21bf
We no longer support the old plugin API so remove it completely from the build system
...
svn path=/trunk/; revision=29821
2009-09-09 14:01:57 +00:00
Bill Meier
94f28dd8f9
(FWIW) One step towards including stdio.h & stdlib.h only when req'd.
...
svn path=/trunk/; revision=29568
2009-08-26 19:27:49 +00:00
Bill Meier
6f87844d0a
(Minor) Remove unneeded #includes.
...
svn path=/trunk/; revision=29492
2009-08-21 14:36:27 +00:00
Kovarththanan Rajaratnam
ac463d2697
Don't guard col_clear with col_check
...
svn path=/trunk/; revision=29346
2009-08-09 08:14:59 +00:00
Kovarththanan Rajaratnam
6110a96f68
Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
...
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Anders Broman
1196da707d
From Rajasekhar Reddy Gali:
...
packet-wimaxasncp.c file need to update with latest wimax spec.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3730
svn path=/trunk/; revision=29125
2009-07-16 21:27:56 +00:00
Stig Bjørlykke
6d472a50fc
From Kovarththanan Rajaratnam via bug 3548:
...
Minor hf cleanup.
svn path=/trunk/; revision=28968
2009-07-07 07:46:57 +00:00
Stig Bjørlykke
2bba6be84f
From Kovarththanan Rajaratnam via bug 3548:
...
Cleanup header_field_info in plugins.
svn path=/trunk/; revision=28771
2009-06-18 23:22:10 +00:00
Gerald Combs
17f0d877fa
Fix Win64 compilation problems in the plugins directory.
...
svn path=/trunk/; revision=28064
2009-04-16 03:38:23 +00:00
Gerald Combs
07e5df616e
Disable manifest building for our DLLs. This attempts to fix bug 3272.
...
svn path=/trunk/; revision=27579
2009-03-02 18:57:35 +00:00
Ulf Lamping
043532d63e
add missing mt.exe calls, to include manifest files into exe / dll files
...
svn path=/trunk/; revision=27357
2009-02-02 23:09:36 +00:00
Gerald Combs
6d04f793f0
Back out r27047 and r27053.
...
svn path=/trunk/; revision=27062
2008-12-19 17:39:52 +00:00
Gerald Combs
fc71188963
Update calls to proto_tree_add_bytes_format to reflect r27047.
...
svn path=/trunk/; revision=27053
2008-12-18 20:19:49 +00:00
Stig Bjørlykke
94e9e2b1ec
Fix some "format not a string literal and no format arguments" warnings.
...
svn path=/trunk/; revision=26652
2008-10-31 17:27:51 +00:00
Luis Ontanon
42c3239a1a
luis.ontanon@gmail.com => luis@ontanon.org
...
svn path=/trunk/; revision=25937
2008-08-05 21:03:46 +00:00
Jeff Morriss
b4d2c37635
Allow checkapis target to work in out-of-tree builds (s#../../#$(top_srcdir)).
...
Also use $(top_builddir) instead of ../../ in a couple of other spots.
svn path=/trunk/; revision=25863
2008-07-29 22:06:37 +00:00
Guy Harris
a04774395f
Add Makefile.common files for epan/dfilter and epan/ftypes.
...
Add checkapi rules to Makefile.am files.
svn path=/trunk/; revision=25656
2008-07-02 01:44:30 +00:00
Guy Harris
b6e20d89be
Put printf into a separate "termoutput" API group. For most files,
...
check for it - but not for TShark plugins, as they are expected to
print to the standard output.
svn path=/trunk/; revision=25653
2008-07-01 21:13:32 +00:00
Gerald Combs
83aacf0a09
Add support for "API groups" in checkAPIs.pl. Make the "prohibited"
...
and "deprecated" groups the default. Add an "abort" group for code that
shouldn't exit the program. Update the makefiles to call "checkAPIs.pl
-g abort" for dissectors. Remove a dependency on "cat" in checkAPIs.pl.
svn path=/trunk/; revision=25614
2008-06-26 22:20:05 +00:00
Martin Mathieson
4aa522855d
Make sure info column is set correctly when tree == NULL.
...
Fixes but 2561.
svn path=/trunk/; revision=25530
2008-06-23 13:02:50 +00:00
Martin Mathieson
03d7032acd
Show ops, etc even when no filter set.
...
Also avoid crash I was seeing when changing preferences.
svn path=/trunk/; revision=25379
2008-05-26 08:22:33 +00:00
Jeff Morriss
a5cee04fad
Move the file utility functions from wiretap to libwsutil so that
...
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.
While doing that, rename the eth_* functions to ws_*.
svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Anders Broman
023a81709a
Make it possible to run checkapi on all plugins trough makefile.nmake
...
Note: Commented out in the plugins giving errors for now.
svn path=/trunk/; revision=25231
2008-05-05 16:55:19 +00:00
Bill Meier
0d4b874b44
Bug 2493: Fix (Part 2):
...
To prevent Windows compiler errors when using flex 2.5.35.
Fixes "missing unistd.h" and yywrap "mismatched parameter" warnings
[Upcoming Part 3: ignore 'signed /unsigned mismatch' errors]
svn path=/trunk/; revision=25173
2008-04-25 17:40:29 +00:00
Jörg Mayer
abaea4e100
The generated code warns about 'input' being unused. -Werror turns this into a failure
...
svn path=/trunk/; revision=25027
2008-04-14 21:29:29 +00:00
Martin Mathieson
88744abd6f
Don't load in files unless tree is set.
...
If a user wants to load or capture quickly, they won't want to wait
for the file to be processed after the first frame.
svn path=/trunk/; revision=24781
2008-04-05 04:48:36 +00:00
Martin Mathieson
4cfefcc5a4
Use proto_register_prefix() with wimaxasncp plugin.
...
Also fix a crash problem seen with no filters (i.e. NULL tree).
svn path=/trunk/; revision=24767
2008-04-04 05:38:13 +00:00
Jaap Keuter
b704bdcbc5
Remove the pre-release flag from FILEFLAGS in the resource file.
...
svn path=/trunk/; revision=24757
2008-03-29 23:04:33 +00:00
Jaap Keuter
fcf8509f69
Create proper dependancies for plugin.c
...
svn path=/trunk/; revision=24520
2008-03-01 12:31:01 +00:00
Stig Bjørlykke
fc5527ef6c
Quote argument to test in plugins Makefiles, as proposed by Greg A. Woods.
...
svn path=/trunk/; revision=24488
2008-02-27 16:18:30 +00:00
Gerald Combs
7abeb02747
If we have an SVN revision number, use it as the build number under Windows
...
instead of "0".
svn path=/trunk/; revision=24376
2008-02-18 18:08:14 +00:00
Martin Mathieson
b0998315f9
Fix some specifier strings (%d -> %u).
...
svn path=/trunk/; revision=23785
2007-12-06 17:47:00 +00:00
Jeff Morriss
565d493671
Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1914 when building out of the source tree by not issuing a complaint if the wimaxasncp dictionary is not found. This is ugly but it's how diameter does it, too, and I am not aware of a better way.
...
svn path=/trunk/; revision=23565
2007-11-24 16:09:47 +00:00
Martin Mathieson
9fb579537e
- Prettify "Value" node that contains EAP tree with top-level details
...
- Lose unuseful header file
svn path=/trunk/; revision=23499
2007-11-19 19:07:49 +00:00
Martin Mathieson
24d6a39eb0
Embedding EAP inside wimaxasncp.
...
svn path=/trunk/; revision=23474
2007-11-16 23:03:09 +00:00
Guy Harris
6f1740aa6c
Cast "char"s to "unsigned char" before handing them to <ctype.h> macros.
...
svn path=/trunk/; revision=23417
2007-11-10 00:36:01 +00:00
Martin Mathieson
0f63de9281
From Stephen Croll.
...
Dynamically register filter fields from TLV definitions.
svn path=/trunk/; revision=23414
2007-11-09 14:41:04 +00:00
Anders Broman
a6850bb34e
Delete generated files at distclean.
...
svn path=/trunk/; revision=23368
2007-11-05 20:44:10 +00:00
Stephen Fisher
d33e4cc381
Change a few g_string_append_printf() (GTK2 only) calls to g_strdup_printf()
...
and g_string_append() to work on GTK 1.2 also.
svn path=/trunk/; revision=23311
2007-10-30 05:49:41 +00:00
Martin Mathieson
7c80a7feae
Add expert item for cases of unmatched function type or message op.
...
svn path=/trunk/; revision=23276
2007-10-26 10:38:16 +00:00
Jeff Morriss
c7bed1298f
s/fopen()/eth_fopen()/ in plugins/ (for bug 1827).
...
svn path=/trunk/; revision=23221
2007-10-17 21:25:16 +00:00
Martin Mathieson
bafcd03634
In source tree, move wimaxasncp TLV files from plugin folder -> new top-level wimaxasncp folder.
...
svn path=/trunk/; revision=23184
2007-10-15 12:32:19 +00:00
Gerald Combs
ff5826a106
Fix wimaxasncp compilation under Windows. Rename a macro that's defined
...
by the platform SDK, cast an int, and use the top-level Makefile.nmake.inc
to build wimaxasncp_dict.{c|obj}.
svn path=/trunk/; revision=23165
2007-10-12 18:26:47 +00:00
Martin Mathieson
13bf6bc269
Another blind attempt to fix the Windows buildbot.
...
Could someone please review this (I'm leaving for the day soon)?
svn path=/trunk/; revision=23164
2007-10-12 16:51:42 +00:00
Martin Mathieson
faffc473d1
Add targets for lex compilation.
...
svn path=/trunk/; revision=23162
2007-10-12 15:00:20 +00:00
Martin Mathieson
258eab8c26
Try to fix distcheck. Is this change appropriate?
...
svn path=/trunk/; revision=23161
2007-10-12 13:29:54 +00:00
Martin Mathieson
2c994a337f
Added missing header file for distcheck.
...
svn path=/trunk/; revision=23160
2007-10-12 12:26:38 +00:00
Martin Mathieson
278271b8f7
Add missing file.
...
svn path=/trunk/; revision=23158
2007-10-12 10:44:49 +00:00
Martin Mathieson
358c4399ba
TLVs now defined in XML (from Stephen Croll).
...
svn path=/trunk/; revision=23156
2007-10-12 09:59:10 +00:00
Martin Mathieson
8e59e99b5c
- show type (number) of unrecognised tlvs in the tlv root item
...
- also add this as an expert item
- tlv root item is now an FT_BYTES item (allowing filtering on whole tlv contents)
svn path=/trunk/; revision=22986
2007-09-26 14:47:22 +00:00
Martin Mathieson
9d0e61f12c
Replace remaining non-printable characters that looked like spaces with real spaces.
...
svn path=/trunk/; revision=22824
2007-09-07 15:58:24 +00:00
Martin Mathieson
fe8b214d35
Small cleanup:
...
- remove unprintable chars (pasted from formatted spec doc?)
- use _U_ for unsused function argument
- remove accidental(?) assignment in function parameter
- make indentation consistent by removing the (few) tabs in the file
svn path=/trunk/; revision=22819
2007-09-07 13:53:49 +00:00
Martin Mathieson
aef34dca35
Try Stephen Croll's workaround.
...
svn path=/trunk/; revision=22818
2007-09-07 09:56:19 +00:00
Anders Broman
01bd582bc0
Change it back...
...
Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun.
svn path=/trunk/; revision=22813
2007-09-06 21:33:57 +00:00
Anders Broman
83f7ac9f95
Add A11 RRQ-CVSE-Active Start Airlink Record-Subtype 108 is expressed to Subnet.
...
Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun.
svn path=/trunk/; revision=22812
2007-09-06 21:25:41 +00:00
Guy Harris
00ea6ee9fd
Add .c.obj:: inference rule (to cause "batch compile")
...
svn path=/trunk/; revision=22809
2007-09-06 16:55:03 +00:00
Martin Mathieson
400f998e3b
Fix the unsigned errors. Not sure about the other windows errors yet...
...
svn path=/trunk/; revision=22806
2007-09-06 14:14:09 +00:00
Martin Mathieson
c4c6de35df
Add wimaxasncp plugin folder contents (other changes will follow)
...
svn path=/trunk/; revision=22800
2007-09-06 10:05:41 +00:00