Commit Graph

37461 Commits

Author SHA1 Message Date
Anders Broman 5b8891604f Check if the continue is from the originating side too.
svn path=/trunk/; revision=39275
2011-10-05 18:28:40 +00:00
Anders Broman 121b7d772e Add a couple of OID strings.
svn path=/trunk/; revision=39274
2011-10-05 18:27:48 +00:00
Chris Maynard cf4d497af4 Some minor documentation changes: little_endian -> encoding. Also, fully parenthesize FI_BITS_OFFSET, FI_BITS_SIZE, and FI_GET_FLAG macro arguments.
svn path=/trunk/; revision=39273
2011-10-05 18:22:30 +00:00
Bill Meier e79d91f328 Add a short description ofthe dissector (from the Bug submission)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6428

svn path=/trunk/; revision=39272
2011-10-05 16:12:29 +00:00
Bill Meier a5c09a54e3 Various cleanup:
- Add Gerald Combs copyright;
- Use correct address for FSF;
- Move proto_reg_handoff...() to the end of the file per convention;
- Remove unneeded check_col() and col_clear();
- Localize brp_handle;
- Whitespace cleanup ("4 space tabs" ==> spaces; remove trailing spaces).

svn path=/trunk/; revision=39271
2011-10-05 16:06:01 +00:00
Bill Meier 4c7f166dbb Use ENC_NA as the proto_tree_add_item() encoding parameter for a field of type FT_BYTES;
Fixes what appears to be a minor bug.

svn path=/trunk/; revision=39270
2011-10-05 14:51:06 +00:00
Stig Bjørlykke 3be3568bce Cleanup the unregister loop to avoid freeing wrong data.
svn path=/trunk/; revision=39269
2011-10-05 11:44:38 +00:00
Stig Bjørlykke 7714898212 Cleanup the unregister loop to avoid freeing wrong data.
svn path=/trunk/; revision=39268
2011-10-05 11:44:29 +00:00
Stig Bjørlykke d2922fb136 Use g_tree_steal to remove an entry without calling the destroy function.
This because we use the destroy function to determine same_name_hfinfo.

svn path=/trunk/; revision=39267
2011-10-05 11:44:19 +00:00
Anders Broman 33fc6f13ca Michael Mann:
Removed the Save button if live capture is going on when File->Quit is selected. Solves Assertion failed when doing File->Quit->Save during live capture
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1710

svn path=/trunk/; revision=39266
2011-10-05 05:53:53 +00:00
Anders Broman c22cc0a5bb From Sake Blok and Michael Mann:
Change "File -> Save As" to only save the displayed frames by default.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6192

svn path=/trunk/; revision=39265
2011-10-05 05:42:16 +00:00
Anders Broman 6951f00068 From Sake Blok and Michael Mann:
Change "File -> Save As" to only save the displayed frames by default.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6192

svn path=/trunk/; revision=39264
2011-10-05 05:40:34 +00:00
Bill Meier e18e2694c6 Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
     FT_BYTES
     FT_IPV6
     FT_IPXNET
     FT_OID
Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN
 

svn path=/trunk/; revision=39263
2011-10-05 02:39:04 +00:00
Bill Meier ef8009abe3 Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
    FT_BYTES
    FT_IPV6
    FT_IPXNET
    FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|1|0|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39262
2011-10-05 01:00:06 +00:00
Bill Meier 799578fb29 Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item with types in hf[] of:
FT_NONE
    FT_BYTES
    FT_IPV6
    FT_IPXNET
    FT_OID

svn path=/trunk/; revision=39261
2011-10-05 00:25:09 +00:00
Bill Meier 94f36ca4ff Use ENC_NA as encoding for proto_tree_add_item() calls which directly reference an hf item (in hf[] with types:
FT_NONE
   FT_BYTES
   FT_IPV6
   FT_IPXNET
   FT_OID

Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN

svn path=/trunk/; revision=39260
2011-10-04 22:44:31 +00:00
Stig Bjørlykke 039fc59cb1 Free duplicated strings in hf entries.
svn path=/trunk/; revision=39259
2011-10-04 21:06:40 +00:00
Stig Bjørlykke 19e87afd9d Free duplicated strings in hf entries.
svn path=/trunk/; revision=39258
2011-10-04 21:06:20 +00:00
Gerald Combs 996935a5de Add more entries to the Python CRT list.
svn path=/trunk/; revision=39257
2011-10-04 20:50:12 +00:00
Anders Broman 463fcff9f4 Remove unused variables.
svn path=/trunk/; revision=39256
2011-10-04 19:19:43 +00:00
Anders Broman 77a3810066 Added Id
svn path=/trunk/; revision=39255
2011-10-04 19:04:56 +00:00
Anders Broman 575bf125aa From Rob Kruciak:
This is a dissector for the BRP (Bandwidth Reservation Protocol). This protocol
is used by various telecommunications vendors to establish VoD (Video
On-Demand) sessions between a STB (Set Top Box) at the customer's home and the
VoD server at the video head-end. 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6428
- Changed hf blurbs to NULL
- Used dissector_add_handle() as the proposed port is registered to a different protocol.

svn path=/trunk/; revision=39254
2011-10-04 19:03:55 +00:00
Stig Bjørlykke 3316585afb Make custom IMF headers a part of profiles.
svn path=/trunk/; revision=39253
2011-10-04 18:53:35 +00:00
Stig Bjørlykke b3f8f54079 Delete allocated header fields when updating the UAT.
Don't call header_fields_initialize_cb for prefs, as it will be called
when done in the UAT.

svn path=/trunk/; revision=39252
2011-10-04 18:41:07 +00:00
Stig Bjørlykke 8c8cd4024c Unregister and delete allocated header fields when updating the UAT.
Avoid double loading the UAT.
Use the post update callback in uat_new for regenerating header_fields_hash.

svn path=/trunk/; revision=39251
2011-10-04 18:40:56 +00:00
Jeff Morriss d9d46c3014 Make value_strings const to fix checkapi warning. Do some minor reformatting.
svn path=/trunk/; revision=39250
2011-10-04 13:30:50 +00:00
Stig Bjørlykke 92001a0d3d Added support for configuring custom IMF headers.
svn path=/trunk/; revision=39249
2011-10-04 10:13:05 +00:00
Stig Bjørlykke 21dbaea387 Add proto_unregister_field().
This can be used to unregister fields registered in dissector UAT's.

svn path=/trunk/; revision=39248
2011-10-04 10:12:55 +00:00
Anders Broman 6a847b1f30 From Andrew Kampjes:
Allows the saving of packets with snapped length to ERF. Prevents the adding of
automatic CRC and rounds down to the nearest 8 bytes instead of up, adding
zeros.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6409

svn path=/trunk/; revision=39247
2011-10-04 05:27:14 +00:00
Anders Broman a17fcee039 From Pascal Quantin:
Add dissection of GERAN related messages.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6427

svn path=/trunk/; revision=39246
2011-10-03 21:15:04 +00:00
Anders Broman 838c1b337b Fix a typo
svn path=/trunk/; revision=39245
2011-10-03 17:22:47 +00:00
Anders Broman 797c140887 Set ENC
svn path=/trunk/; revision=39244
2011-10-03 16:47:54 +00:00
Alexis La Goutte 4ce630cead Fix checkhf error in packet-smb2.c file.
Unused entry: epan/dissectors/packet-smb2.c, hf_smb2_data_length => Add in Revision #16546 and never used
Unused entry: epan/dissectors/packet-smb2.c, hf_smb2_file_name_info => Add in Revision #25371 and never used
Unused entry: epan/dissectors/packet-smb2.c, hf_smb2_security_blob_len => Remove in Revision #16557
Unused entry: epan/dissectors/packet-smb2.c, hf_smb2_response_buffer_offset => Remove in Revision #21793
Unused entry: epan/dissectors/packet-smb2.c, hf_smb2_security_blob_offset => Remove in Revision #16557
Unused entry: epan/dissectors/packet-smb2.c, hf_smb2_response_size => Remove in Revision #16605

svn path=/trunk/; revision=39243
2011-10-03 11:49:17 +00:00
Guy Harris 66a8e6aa5d Thou shalt not use g_sprintf() lest thou overflow a buffer. (Yes, even
if you know it's safe.  Sorry.)

svn path=/trunk/; revision=39242
2011-10-03 07:28:45 +00:00
Guy Harris 574f05eb2c %hhu = %u in printf-like functions, as "char", "signed char", and
"unsigned char" get upsized to "int" and "unsigned int" when passed to
varargs functions.

svn path=/trunk/; revision=39241
2011-10-03 07:19:05 +00:00
Guy Harris 938bf0a03c Fix tpo.
svn path=/trunk/; revision=39240
2011-10-03 06:40:58 +00:00
Guy Harris 7bf74b645c Cast away a warning - if that buffer has more than 2^31-1 characters in
it, we have a real problem.

svn path=/trunk/; revision=39239
2011-10-03 06:39:59 +00:00
Anders Broman 49f715f169 Remove unused hf field.
svn path=/trunk/; revision=39238
2011-10-03 06:24:28 +00:00
Guy Harris 330fd51e8e tvb_get_bits{16,32,64} get passed encoding values. Rename the argument
appropriately; the only valid encoding is big-endian, so we don't
actually do anything different with the argument, so as not to break
code that passed it a gboolean endian flag.

svn path=/trunk/; revision=39237
2011-10-03 06:12:11 +00:00
Anders Broman 71dfc675ca Set encoding.
svn path=/trunk/; revision=39236
2011-10-03 05:44:17 +00:00
Anders Broman cd9d1c6cdf From Jakob Hirsch:
Parse T.30 PPR (partial page request) and show requested frames.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6326

svn path=/trunk/; revision=39235
2011-10-03 05:34:56 +00:00
Anders Broman 76da7fb4e5 From David Mueller:
Incorrect identification of UDP-encapsulated NAT-keepalive packets.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6414

svn path=/trunk/; revision=39234
2011-10-03 05:13:53 +00:00
Anders Broman f08f09ecd4 From Michael Mann:
Condense all SCTP CRC routines to wsutil/crc32.[ch]. Also made
crc32_ccitt_table not explicitly accessible (must use crc32_ccitt_table_lookup).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6298

svn path=/trunk/; revision=39233
2011-10-03 04:53:17 +00:00
Guy Harris b7bdb4a985 OK, those seem to depend on at least some of the CIP changes, so back
the ENIP changes out as well.

svn path=/trunk/; revision=39232
2011-10-02 19:05:20 +00:00
Guy Harris 65ea44dd27 Back out the changes to packet-cip.h, too, so that a fixed version of
the patch that updates both can be cleanly applied.

svn path=/trunk/; revision=39231
2011-10-02 18:58:21 +00:00
Guy Harris 1a267e4d0e Back out improvements - it's still getting a lot of "used uninitialized"
errors, so I'll reopen the bug and log all the warnings that have been
produced, and mark the patch as "rejected".

svn path=/trunk/; revision=39230
2011-10-02 18:47:00 +00:00
Guy Harris a1b6a2e95f "seg_size" isn't set here, and the items don't appear to have a variable
segment size, they just appear to be 2 bytes long.

svn path=/trunk/; revision=39229
2011-10-02 18:31:33 +00:00
Michael Tüxen dab27a2d3d Fix warnings.
svn path=/trunk/; revision=39228
2011-10-02 17:59:00 +00:00
Anders Broman 362d86a22f Add comments.
svn path=/trunk/; revision=39227
2011-10-02 17:27:05 +00:00
Michael Tüxen eb4f10eedb Fix warnings.
svn path=/trunk/; revision=39226
2011-10-02 17:18:23 +00:00