Bill Meier
126aa85393
Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, FT_STRINGZ, FT_UINT_STRING as follows:
...
1. If there's no character encoding (ENC_ASCII, ...) specified
then use ENC_ASCII.
2. For all but FT_UINT_STRING, always use ENC_NA
(replacing any existing True/1/FALSE/0
/ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN).
svn path=/trunk/; revision=39426
2011-10-15 18:46:26 +00:00
Bill Meier
67ee5049d4
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_BOOLEAN
FT_IPv4
FT_EUI64
FT_GUID
FT_UINT_STRING
Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260 )
svn path=/trunk/; revision=39328
2011-10-10 00:39:31 +00:00
Bill Meier
4e57694d4a
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
Bill Meier
c67363e4de
Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.
...
svn path=/trunk/; revision=38170
2011-07-22 18:33:44 +00:00
Jeff Morriss
4380cad67d
Finish removing tabs and fix up some indentation.
...
Add a break after decoding CSData Codec Type.
svn path=/trunk/; revision=37247
2011-05-18 17:31:48 +00:00
Jeff Morriss
7b3bd3e8a9
Add a default (else) case in the default case for cause values to avoid passing
...
a NULL string pointer to format routines.
While we're there, update the cause list from 48.008 v10.1.0.
svn path=/trunk/; revision=37244
2011-05-18 17:09:55 +00:00
Anders Broman
8d6ca293dc
Change the signature of elem_fcn():ns to include pinfo.
...
svn path=/trunk/; revision=36443
2011-04-04 14:37:25 +00:00
Anders Broman
72b69aeaf5
Change the msg_fcn() signature to include pinfo.
...
svn path=/trunk/; revision=36441
2011-04-04 07:45:34 +00:00
Anders Broman
691c566900
CID 453,454
...
Missing break
svn path=/trunk/; revision=36277
2011-03-23 05:48:58 +00:00
Anders Broman
b4941ca580
Prepare to remove old bssgp code by changing exports.
...
svn path=/trunk/; revision=36142
2011-03-06 09:42:41 +00:00
Anders Broman
f9b379bab5
Advance offsets in the "default" branch to avoid infinite loops.
...
** (tshark.exe:4392): WARNING **: Dissector bug, protocol GSM BSSMAP, in packet
194520: More than 1000000 items in the tree -- possible infinite loop
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5688
svn path=/trunk/; revision=35939
2011-02-13 15:43:17 +00:00
Anders Broman
35bde0d589
Update dissection of
...
3.2.2.103 Speech Codec List
3.2.2.104 Speech Codec
to 3GPP TS 48.008 version 9.4.0 Release 9.
svn path=/trunk/; revision=35935
2011-02-12 20:17:47 +00:00
Anders Broman
211e3a1eef
- Use ENC_BIG_ENDIAN.
...
- GSM_A_PDU_TYPE_BSSMAP.
svn path=/trunk/; revision=35879
2011-02-08 12:32:34 +00:00
Anders Broman
7a78a180c7
Dissect more IE's in PERFORM-LOCATION-REQUEST.
...
svn path=/trunk/; revision=35721
2011-01-31 15:16:45 +00:00
Stig Bjørlykke
64dab4f576
Removed duplicate hf_gsm_a_bssmap_lsa_only registry.
...
svn path=/trunk/; revision=35676
2011-01-27 07:45:31 +00:00
Anders Broman
68f4f61017
Dissect PS-HANDOVER-REQUEST.
...
svn path=/trunk/; revision=35666
2011-01-26 19:44:23 +00:00
Anders Broman
a78e5d7900
Use value_string_ext and friends.
...
svn path=/trunk/; revision=35484
2011-01-11 20:15:04 +00:00
Anders Broman
f108c58805
Complement to
...
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35477
svn path=/trunk/; revision=35483
2011-01-11 20:02:30 +00:00
Anders Broman
f23d884631
Try to fix:
...
packet-gtpv2.c:2648: warning: return type defaults to 'int'
packet-gtpv2.c: In function 'dissect_udp_s_port_nr':
packet-gtpv2.c:2690: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_fq_csid':
packet-gtpv2.c:2845: warning: unused parameter 'length'
packet-gtpv2.c: In function 'dissect_gtpv2_emlpp_pri':
packet-gtpv2.c:2927: warning: implicit declaration of function 'be_emlpp_prio'
packet-gtpv2.c: At top level:
packet-gtpv2.c:3056: warning: initialization from incompatible pointer type
svn path=/trunk/; revision=35431
2011-01-08 20:26:35 +00:00
Jeff Morriss
8535524c6a
Remove a duplicate return.
...
svn path=/trunk/; revision=35389
2011-01-05 22:27:41 +00:00
Anders Broman
d20be4e050
Fix the Message numbering.
...
svn path=/trunk/; revision=35271
2010-12-27 09:33:39 +00:00
Anders Broman
df66b02972
Correct:
...
RESET IP RESOURCE
RESET IP RESOURCE ACKNOWLEDGE
Tags
svn path=/trunk/; revision=35267
2010-12-26 21:23:06 +00:00
Anders Broman
356aced5bf
Start of a SGSAP (TS 29.118) dissector for LTE.
...
svn path=/trunk/; revision=35266
2010-12-26 21:06:08 +00:00
Guy Harris
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
Anders Broman
8bc65842e0
From Mike Morrin:
...
In bssmap, track L3 handover target (GSM or UMTS) between PDUs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5294
svn path=/trunk/; revision=35009
2010-11-22 20:24:12 +00:00
Anders Broman
348e0bc54b
Use value_string_ext for gsm_a_rr_rxlev_vals.
...
svn path=/trunk/; revision=34818
2010-11-09 07:28:04 +00:00
Gerasimos Dimitriadis
fe34e9a3fb
Support for eMLPP Priority IE in BSSMAP
...
svn path=/trunk/; revision=33971
2010-08-27 21:30:12 +00:00
Gerald Combs
9afeb63b49
Make sure we don't dereference an invalid function pointer. Fixes bug 4949.
...
svn path=/trunk/; revision=33362
2010-06-29 00:08:24 +00:00
Jeff Morriss
3dce901718
Avoid passing a NULL pointer to a string to proto_tree_add_uint_format()
...
svn path=/trunk/; revision=32878
2010-05-18 14:17:11 +00:00
Bill Meier
0fc9115705
Use consistent indentation; Whitesapce & formatting cleanup.
...
svn path=/trunk/; revision=32755
2010-05-11 16:54:55 +00:00
Anders Broman
447faa6082
From Mike Morrin:
...
Dissection of BSSMAP IEs: Old BSS to New BSS Info and New BSS to Old BSS Info
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4712
svn path=/trunk/; revision=32606
2010-04-29 20:45:53 +00:00
Bill Meier
69df32fb11
#include <string.h> not needed.
...
svn path=/trunk/; revision=32411
2010-04-06 22:09:47 +00:00
Bill Meier
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
Gerasimos Dimitriadis
dfde72f247
Fix for Bug 4588:
...
RANAP and friends want the MNC encoded in big endian form.
svn path=/trunk/; revision=32257
2010-03-20 23:53:22 +00:00
Anders Broman
2c41750861
Bug on bssmap SAI not decoded.
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4415
svn path=/trunk/; revision=31678
2010-01-26 12:22:03 +00:00
Bill Meier
de4c6ff515
Fix a number of gcc _Wshadow warnings
...
svn path=/trunk/; revision=31557
2010-01-18 21:49:47 +00:00
Gerasimos Dimitriadis
b7261fe2e4
Expert info when E.212 MCC/MNC contain non-decimal digits
...
svn path=/trunk/; revision=31102
2009-11-27 22:57:50 +00:00
Anders Broman
9ca6c5518c
If SourceRNC-ToTargetRNC-TransparentContainer is called trough dissect_ranap_SourceRNC_ToTargetRNC_TransparentContainer_PDU ProtocolIE_ID may be unset
...
svn path=/trunk/; revision=31073
2009-11-25 17:15:10 +00:00
Anders Broman
4187652696
Add dissection of Source RNC to target RNC transparent information in BSSAP.
...
Fix RRC container dissection in RANAP.
svn path=/trunk/; revision=31058
2009-11-23 22:02:05 +00:00
Gerasimos Dimitriadis
029f3641ae
Basic support for the DTAP User-User IE; print bitfields in a way more
...
similar to proto_tree_add_bits_item(); Minor comment edits
svn path=/trunk/; revision=31057
2009-11-23 20:23:30 +00:00
Gerasimos Dimitriadis
d07a4dd389
When decoding a Cell Identifier, curr_offset is not increased after
...
reading rnc-id
svn path=/trunk/; revision=31032
2009-11-20 16:23:18 +00:00
Anders Broman
1a79f3ead4
Fix Layer 3 Message Contents(?)
...
At least the trace at http://openbsc.gnumonks.org/trac/attachment/wiki/OpenBSCWithSCCP/bssmap_clean.pcap dissects correctly now.
svn path=/trunk/; revision=30799
2009-11-01 20:00:08 +00:00
Anders Broman
3da9d8fc41
From Holger Freyther:
...
GSM BSSMAP ChanType permitted indicator extension bit decoded wrongly.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4185
svn path=/trunk/; revision=30797
2009-11-01 19:11:13 +00:00
Kovarththanan Rajaratnam
65c53fedb6
Don't guard col_append_str with check_col
...
svn path=/trunk/; revision=30125
2009-09-24 20:00:21 +00:00
Bill Meier
6c545e0d79
Save some memory: Don't statically allocate ett[] arrays used "dynamically".
...
svn path=/trunk/; revision=29929
2009-09-15 17:37:54 +00:00
Anders Broman
d41058065f
From Mike Morrin:
...
The GSM L3 part of the BSSMAP CipherModeComplete message is not being decoded.
Sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3983
svn path=/trunk/; revision=29776
2009-09-07 17:17:07 +00:00
Anders Broman
99c24a8eb4
From Mike Morrin:
...
Patch adding BSSMAP dissectors MSC Invoke Trace and BSS Invoke Trace.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3985
svn path=/trunk/; revision=29774
2009-09-07 17:08:34 +00:00
Jaap Keuter
c9e3f66d14
Optimize empty strings to NULL pointers.
...
svn path=/trunk/; revision=29298
2009-08-04 21:05:38 +00:00
Anders Broman
04b77f8437
APDU incorrectly dissected(BSSLAP Protocol Not Decoded In BSSMAP-LE Messages).
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3711
svn path=/trunk/; revision=29077
2009-07-13 08:35:30 +00:00
Jörg Mayer
6270137b07
Fix my 'fix': guint8 > 0 is always true
...
svn path=/trunk/; revision=28807
2009-06-22 07:27:14 +00:00