def11f9418
CID4 and CID3 Change
...
if ((value >= 1) || (value <= 0x4a)) {
to if ((value >= 1) && (value <= 0x4a)) {
svn path=/trunk/; revision=17533
2006-03-08 18:58:08 +00:00
b4d028c47e
Fix:
...
Coverity CID19 Remove an uneccesarry line
CID20 Use the code from the asn2eth generated dissector while at it.
svn path=/trunk/; revision=17532
2006-03-08 18:56:13 +00:00
12224e5f22
Make calculation of TCP Graph bounds more robust. The calculation might have failed in unusual conditions.
...
This bug was discovered while looking at defects #130 and #131 discovered by coverity.
This patch also fixes these non-severe defects.
svn path=/trunk/; revision=17531
2006-03-08 18:42:16 +00:00
3b5ed30a0d
better support for ASN.1 Enumerated type in PER decoding
...
support in asn2eth will follow
svn path=/trunk/; revision=17530
2006-03-08 13:50:04 +00:00
ae1041e081
Coverity CID 103 pointed me to this section of code. The buffer
...
overrun that Coverity thought existed does not exist. But I did
notice something else: a signed/unsigned disparity between
net_bits and new_nmask_bits.
So I fixed that, then realized that the function in question, a static
function named created_mask, is only used by one other function in
the file. So I got ride of create_nmask and moved its logic into the
single calling function, ipv4_addr_set_netmask_bits.
svn path=/trunk/; revision=17529
2006-03-08 13:36:40 +00:00
3cd2777adc
fix minor bug coverity 74
...
length_remaining could become -1 and if so the next tvb access (tvb_memcpy()) would cause an exception. not really an ethereal since it would have no ill effects in reality.
change !=0 to >0 to make it more clear what we actually test.
svn path=/trunk/; revision=17528
2006-03-08 11:09:02 +00:00
3a92bf963c
fix coverity bug 122
...
svn path=/trunk/; revision=17527
2006-03-08 10:59:05 +00:00
cdc088fb66
An unimportant and harmless one per run leak in a tool used for building... Coverity cannot evaluate that :P
...
run 14 CID 107
svn path=/trunk/; revision=17526
2006-03-08 10:58:09 +00:00
6007c31402
Avoid passing junk to ssl_debug_printf fmt if a weird cipher is found ().
...
FIxes Coverity's run 14 CID 81
svn path=/trunk/; revision=17525
2006-03-08 10:53:12 +00:00
b1a11016ec
remove a redundant if statement
...
this if statement always evaluate to true since it is called from a single place that is only entered if the very same expression is also true there.
svn path=/trunk/; revision=17524
2006-03-08 10:51:33 +00:00
806a5c8d95
for really really weird malformed lanman packets it is theoretically possible
...
that trp is uniunitialized.
coverity bug 46
svn path=/trunk/; revision=17523
2006-03-08 10:36:28 +00:00
7417244b1e
Fix a cloding tag
...
svn path=/trunk/; revision=17522
2006-03-08 10:24:59 +00:00
83296ec679
Another off by one error found by coverity (CID 83), using > instead of >= when comparing index against array size.
...
svn path=/trunk/; revision=17521
2006-03-08 10:20:09 +00:00
3fa91ab7be
Coverity's run 14 CID 82.
...
an off by one error (> vs >= in bounds check).
svn path=/trunk/; revision=17520
2006-03-08 10:14:51 +00:00
8284947d84
Hide #line directives inside comments so that coverrity shows the errors it has found. It appears that Coverity doesn't look for source files but in the same dir where the generated file resides.
...
svn path=/trunk/; revision=17519
2006-03-08 09:49:31 +00:00
d2ae498e21
coverity bug 73
...
dont call fragment_add when len is -1 (or really really large if seen as a guint32)
svn path=/trunk/; revision=17518
2006-03-08 09:43:06 +00:00
9e6a992bd6
coverity turned up a false positive in cid 37
...
smb_info is guaranteed to always be non-NULL
so the test for !=NULL (which triggered coverity) is redundant
svn path=/trunk/; revision=17517
2006-03-08 09:03:10 +00:00
b4c4d56509
remove some harmless but redundant code
...
coverity cid 31
svn path=/trunk/; revision=17516
2006-03-08 08:35:13 +00:00
1f5ada6df0
Fix left open file (coverity CID 108) and g_string leak. Clean up double width line drawing.
...
svn path=/trunk/; revision=17515
2006-03-08 07:06:42 +00:00
853b929df0
Remove dead code. Due the to if() test that checks for specific
...
values of 'length', the code in question can never run.
This fixes Coverity bug ID #1 .
svn path=/trunk/; revision=17514
2006-03-07 22:38:51 +00:00
a103501de2
Fix what Coverity CID 61 was actually complaining about: Don't pass a NULL
...
value to get_interface_descriptive_name().
svn path=/trunk/; revision=17513
2006-03-07 22:14:12 +00:00
ed9d4d16c7
potential dereference of null pointer
...
coverity cid 39
svn path=/trunk/; revision=17512
2006-03-07 21:18:08 +00:00
60590c0163
fix a potential assignment of a wild pointer
...
fixes coverity cid 128
svn path=/trunk/; revision=17511
2006-03-07 20:52:23 +00:00
317c8e5f92
Fix Coverity CID: 8 dead code.
...
svn path=/trunk/; revision=17510
2006-03-07 20:51:05 +00:00
06d73310c9
fix a potential null dereference
...
found in coverity cid:48
svn path=/trunk/; revision=17509
2006-03-07 20:47:20 +00:00
0331204009
Undo the prevous unfortunate "rearrangement of code".
...
svn path=/trunk/; revision=17508
2006-03-07 20:24:11 +00:00
96db73a93f
Remove a case statement which can never be reached, because the
...
previous isprint() test covers that case. This fixes Coverity bug ID #2 .
svn path=/trunk/; revision=17507
2006-03-07 20:01:42 +00:00
1a4719ef8d
Fix Coverity run 12, CID 104: Don't overflow a guint8, and don't read past
...
the end of an array.
Update the release notes.
svn path=/trunk/; revision=17506
2006-03-07 19:53:57 +00:00
c47503fd5f
Fix Coverity run 12 CID 110: Make sure we don't dereference a NULL pointer.
...
svn path=/trunk/; revision=17505
2006-03-07 19:17:00 +00:00
432e1233bb
Fix Coverity run 12 CID 61: In main_cf_cb_live_capture_update_started(),
...
make sure capture_opts isn't NULL before we try to use it.
svn path=/trunk/; revision=17504
2006-03-07 19:11:35 +00:00
4e232aa98e
Dissect part of TIPCv2.
...
svn path=/trunk/; revision=17503
2006-03-07 18:19:42 +00:00
7e8a72a218
Fix a bug reported by covierty and solved by http://www.sqlite.org/cvstrac/rlog?f=sqlite/tool/lemon.c
...
Rearrange the code a bit to make it easier to make a diff with the sqlite version of lemon.
svn path=/trunk/; revision=17502
2006-03-07 18:18:04 +00:00
d986b91df6
Solving various uninitialized variable warnings.
...
coverity reports 132, 133 and 134
svn path=/trunk/; revision=17501
2006-03-07 16:39:54 +00:00
99a14bf9f1
From Jeff Morriss:
...
emem.c wouldn't compile with EP_DEBUG_FREE and SE_DEBUG_FREE defined.
The attached patch fixes that and cleans up some warnings that showed
up with those two were defined, too. (In fact 95% of the patch is
for warnings.)
Fix up whitespace.
svn path=/trunk/; revision=17500
2006-03-07 16:31:47 +00:00
ac32d8875f
Initialize a return value. Found by Coverity.
...
Fix up whitespace.
svn path=/trunk/; revision=17499
2006-03-07 16:28:25 +00:00
3b2760d2df
Catch negative return value, leading to near infinite loop.
...
Filed as coverity bug 136.
svn path=/trunk/; revision=17498
2006-03-07 15:22:57 +00:00
1816f28559
Fix a possible NULL pointer dereference (coverity bug id 32)
...
svn path=/trunk/; revision=17497
2006-03-07 14:44:25 +00:00
65f5262bb6
Rename set_string_hash... into se_tree_xxx_string as proposed by ronnie for consistency whith its real nature.
...
svn path=/trunk/; revision=17496
2006-03-07 14:10:30 +00:00
14c4d6fad9
From Jeff Morris,
...
Avoid an off by one error in dissect_fields_dnsea() and dissect_fields_onsea()
Fixes Bug 794
svn path=/trunk/; revision=17495
2006-03-07 14:02:25 +00:00
307ba63d48
Fix a possible NULL pointer dereference discovered by coverity.
...
I'm not sure, if it is possible to get a NULL pointer here, but it is safer to fix it.
svn path=/trunk/; revision=17494
2006-03-07 13:48:54 +00:00
b51d8f3f89
Use g_assert to save us from dereferencing a NULL pointer. g_warning is not strong enough. This should fix a defect discovered by coverity.
...
svn path=/trunk/; revision=17493
2006-03-07 13:11:08 +00:00
7fc017a5c4
rewrite of some hairy code
...
fixes (hopefully) coverity bug 137
svn path=/trunk/; revision=17492
2006-03-07 10:25:42 +00:00
888fc30d27
use an elaborated key for the string keyed "hash table"
...
svn path=/trunk/; revision=17491
2006-03-07 06:33:47 +00:00
84b00c55d1
Fix a bug reported by coverity.
...
svn path=/trunk/; revision=17490
2006-03-07 06:15:06 +00:00
95b2d64a36
ep_strdup stack buffer before returning it.
...
fixes coverity error 109.
svn path=/trunk/; revision=17489
2006-03-07 05:24:02 +00:00
e83301935d
Remove strhash test code from lua...
...
svn path=/trunk/; revision=17488
2006-03-07 04:40:57 +00:00
0cfdbc3676
- contsify a variable in packet-alcap.c to see if a fake bug reported by coverty goes away.
...
- fix an off by one error in packet-telnet.c reported by coverty
svn path=/trunk/; revision=17487
2006-03-07 04:33:46 +00:00
6e04b0aadb
- merge SubTree, ProtoTree and ProtoItem into a single TreeItem class.
...
- By the same token get rid of ProtoFieldArray having Proto.fields attribute been a lua "Array" containing fields.
(still untested, and probably broken)
svn path=/trunk/; revision=17486
2006-03-07 01:25:14 +00:00
8dbad83e5c
Add a hash table with string keys based on the red/black tree.
...
svn path=/trunk/; revision=17485
2006-03-07 01:15:29 +00:00
0c8b1090f4
From Ming Zhang:
...
Update on dissector packet-scsi
* modepage processing for MMC
* support cmd Get Event Status Notification
* support cmd start stop unit for mmc
svn path=/trunk/; revision=17484
2006-03-06 20:06:05 +00:00
Anders Broman