Commit Graph

73 Commits

Author SHA1 Message Date
Anders Broman 3a11073d6b Get info about media type(Video or not) a first step towards usage in rtp statistics.
svn path=/trunk/; revision=28415
2009-05-19 18:42:33 +00:00
Anders Broman c91a384702 Apply some of the patches from:
http://wiki.wireshark.org/Development/Optimization

svn path=/trunk/; revision=28356
2009-05-13 19:46:11 +00:00
Bill Meier b45c3cb272 Change to prevent "off-the-end" array access if invalid payload-type/media-format;
Prevents crash as reported in bug 3373:
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3373)

svn path=/trunk/; revision=27917
2009-03-31 21:47:58 +00:00
Bill Meier 808a4e2c3c Define certain fcns as static (if not used externally).
Also: whiule we're at it: 
 - fix hf[] blurbs as appropriate to use NULL;
 - fix some indentation

svn path=/trunk/; revision=27890
2009-03-29 22:16:26 +00:00
Anders Broman f77b5f8d77 Handle the case when FMTP parameters are "out-of-order".
-  - Use NULL instead of repeated text in blurb in hf[];

svn path=/trunk/; revision=27889
2009-03-29 21:59:28 +00:00
Anders Broman e0171e1a79 More size_t casts.
svn path=/trunk/; revision=27880
2009-03-29 13:47:15 +00:00
Anders Broman 8611ec5f5e More size_t casts.
svn path=/trunk/; revision=27879
2009-03-29 12:07:30 +00:00
Bill Meier 09d097e7a7 #include <conversation.h> not req'd ....
svn path=/trunk/; revision=27389
2009-02-06 20:33:53 +00:00
Anders Broman 821deda3ec Set item generated.
svn path=/trunk/; revision=27352
2009-02-02 18:26:26 +00:00
Anders Broman 2b607d7ce7 Dissect H263-1998/2000 Level
svn path=/trunk/; revision=27267
2009-01-19 20:35:52 +00:00
Anders Broman 360d9f94c7 Accept leading space, payload type name is case insensitive.
svn path=/trunk/; revision=26938
2008-12-08 21:31:37 +00:00
Anders Broman 93b9635a41 Dissect part ofconfiguration parameter in SDP for MP4V-ES.
svn path=/trunk/; revision=26754
2008-11-11 20:42:47 +00:00
Anders Broman 2b9d63a4b5 Move common code to base64.c
svn path=/trunk/; revision=25908
2008-08-03 14:27:22 +00:00
Anders Broman fec43e2350 Update mimetype_and_clock_map and ad samle rate to sdp.
svn path=/trunk/; revision=25860
2008-07-29 15:58:43 +00:00
Martin Mathieson 6492c8e5d0 Minor formatting improvements.
svn path=/trunk/; revision=25324
2008-05-20 09:22:06 +00:00
Martin Mathieson 693291377e Stop using deprecated functions identified by checkAPIs script.
svn path=/trunk/; revision=25258
2008-05-08 14:01:31 +00:00
Stephen Fisher 726a1caaf1 - Remove GLIB1 code
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION
- Remove ws_strsplit files because we no longer need to borrow GLIB2's
  g_strsplit code for the no longer supported GLIB1 builds


svn path=/trunk/; revision=24829
2008-04-07 05:22:54 +00:00
Stig Bjørlykke 28ae535b00 Removed even more "statement not reached" warnings.
svn path=/trunk/; revision=24286
2008-02-07 15:44:45 +00:00
Martin Mathieson b54b6b4af0 Fix preference text (SDP isn't only carried over SIP).
svn path=/trunk/; revision=23876
2007-12-15 18:26:21 +00:00
Anders Broman 4d01fd05cb tvbuff.c - fix abug if reading last byte in tvb
Further H.264 decoding in SDP

svn path=/trunk/; revision=23847
2007-12-12 21:50:14 +00:00
Anders Broman 92e1ee3721 Decode more of H264 info in SDP.
svn path=/trunk/; revision=23832
2007-12-10 21:25:32 +00:00
Jaap Keuter f4c89beb21 Remove superfluous buffer allocation.
svn path=/trunk/; revision=23742
2007-12-04 06:50:11 +00:00
Anders Broman 95d422156a Use common code for ASCII -> tvb.
svn path=/trunk/; revision=23741
2007-12-04 06:00:02 +00:00
Anders Broman b414c81f1f Fetch all fmtp parameters.
svn path=/trunk/; revision=23724
2007-12-03 22:40:04 +00:00
Ronnie Sahlberg 830da048fc mark two unused parameters as _U_
svn path=/trunk/; revision=23717
2007-12-03 21:52:57 +00:00
Anders Broman 20b383c1b1 Dissect RTP payload of H.264 and SDP profile-leve-id for H.264.
svn path=/trunk/; revision=23709
2007-12-03 20:14:42 +00:00
Tomas Kukosa 1a83466890 setup SRTP stream for RTP/SAVP media protocol
svn path=/trunk/; revision=23336
2007-11-02 07:41:56 +00:00
Ronnie Sahlberg befaad153b we dont have g_hash_table_new_full() on gtk1
use g_hash_table_new() on gtk1 and leak memory instead


this should actually a be using an se_tree instead of hashtables


svn path=/trunk/; revision=22789
2007-09-04 23:27:34 +00:00
Anders Broman 8f1d357618 From Stas Maximov:
RTP analysis' jitter values are thrown off by RTP events
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076
a) Ephemeral string (packet duration) was inserted into long-term hash of
dynamic payloads
b) There was no clock_rate mapping for MIME type "telephone-event".

svn path=/trunk/; revision=22780
2007-09-04 05:22:43 +00:00
Jeff Morriss d47443ba38 Replace a couple more calls to tvb_get_string() with tvb_get_ephemeral_string(). 2 of the 3 replacements fix memory leaks.
svn path=/trunk/; revision=22542
2007-08-17 21:21:50 +00:00
Jeff Morriss 3dec62b85c - s/ntohs/g_ntohs
- s/ntohl/g_ntohl
- s/free/g_free
- Change some tvb_get_string()+g_free()'s into tvb_get_ephemeral_string()
- Change some tvb_fake_unicode()+g_free()'s into tvb_get_ephemeral_faked_unicode()
- Change some tvb_get_string() calls that were clearly memory leaks (like
  atoi(tvb_get_string(...))) into tvb_get_ephemeral_string()

svn path=/trunk/; revision=22515
2007-08-15 22:27:52 +00:00
Martin Mathieson 355d1e1321 Show malformed SDP line as an expert item
svn path=/trunk/; revision=22334
2007-07-17 13:09:44 +00:00
Anders Broman 1cf1f16391 Split out common asn1 stuff to asn1.h and include that where needed.
svn path=/trunk/; revision=21635
2007-05-01 22:05:11 +00:00
Anders Broman 8d756c3049 Add a reference.
svn path=/trunk/; revision=21377
2007-04-10 21:02:50 +00:00
Anders Broman fc16dece75 From Mikael Magnusson:
This patch adds support for key-mgmt session attributes in SDP (defined in RFC 4567). The patch also contains a Multimedia Internet KEYing (MIKEY is defined in RFC 3830) dissector plugin for "mikey" key-mgmt data.

svn path=/trunk/; revision=20977
2007-03-05 23:11:11 +00:00
Luis Ontanon aa654a1f8a Those two spaces before sdp were bctp (Q.1990), a protocol conveniently encoded to be two spaces in case of IPBCP (SDP+extras).
There's probably something similar in packet-isup.c

svn path=/trunk/; revision=20952
2007-03-01 00:24:57 +00:00
Luis Ontanon 215b7eecc5 have sdp ignoring useless caracters efore the first element (this is a hack to avoid the two spaces found before the v= in sdp messages embeded in h248/q1950)
svn path=/trunk/; revision=20913
2007-02-24 12:24:13 +00:00
Anders Broman 3c8dcc67bb Fix a cut and paste error.
svn path=/trunk/; revision=20043
2006-12-05 06:53:28 +00:00
Anders Broman 9226c9ef57 Add description of CT AS TIAS and H263-2000 profile.
svn path=/trunk/; revision=20035
2006-12-04 23:03:11 +00:00
Anders Broman e5188939c3 Dissect h324ext_h223lcparm.
svn path=/trunk/; revision=19786
2006-11-03 20:15:17 +00:00
Martin Mathieson 358701731b Cast away most remaining warnings.
2 will remain, because the 'needle' arg in tvb_pbrk_guint8() isn't const...  Should it be?

svn path=/trunk/; revision=19717
2006-10-27 14:36:48 +00:00
Martin Mathieson 37317874e4 More warnings
svn path=/trunk/; revision=19716
2006-10-27 13:03:38 +00:00
Martin Mathieson f378c52320 More warnings...
svn path=/trunk/; revision=19710
2006-10-26 17:03:45 +00:00
Anders Broman c99428334a Fix(?) bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1042
Does the string need to be freed ad destruction of the hashtable?

Surplus add_text removed.

svn path=/trunk/; revision=19139
2006-09-04 21:07:35 +00:00
Anders Broman 4f7ff62fcf From Martin Mathieson:
- allow SDP to parse the IP address + port for the MSRP session from the 
path attribute
- setup an MSRP conversation using this address, whose data points back 
to the SDP frame
- link to the SDP setup frame while dissecting MSRP (can be switched off 
by a preference)
- I also changed sdp.media.port to be a numeric field

svn path=/trunk/; revision=18806
2006-07-28 21:26:39 +00:00
Anders Broman 5f6f853d16 From Martin Mathieson:
- while parsing fmtp lines, the dissector looks for the MPEG4 'profile-level-id' parameter.  If there is no '=' present, it was throwing an exception and the frame marked as malformed (see e.g. the attached
capture)
- I've added a few comments where the code wasn't obvious to me...

svn path=/trunk/; revision=18332
2006-06-03 11:48:27 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman 97419848da From Andrei Emeltchenko:
I attached patch to add preferences in SDP for RTP stream detection. By default SDP decodes RTP stream but now I can disable it.

svn path=/trunk/; revision=18080
2006-05-03 05:07:04 +00:00
Guy Harris f3d1963924 Clean up indentation; use 2-space indentation throughout.
Save the media encoding name in the transport_info_t structure rather
than in a global variable.  Allocate it with tvb_get_ephemeral_string()
so it's released after the packet is completely processed.  Do *NOT*
assume it's necessarily non-null in decode_sdp_fmtp(), as the code flow
doesn't guarantee that to be true.

proto_tree_add_string() now suffices for adding a particular SDP item -
strings are now displayed "safely", with escaping of non-printable
characters done.

Update a comment (we no longer have the Big Transfer Vector to allow
plugins to call dissector functions in Windows, we have those functions
in a DLL).

svn path=/trunk/; revision=18031
2006-04-29 17:31:20 +00:00
Anders Broman 13d178a3fc Check Payload type before dissecting fmtp parameters.
svn path=/trunk/; revision=18028
2006-04-28 21:42:18 +00:00