osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
61,898 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

242 Commits

Author SHA1 Message Date
Ronnie Sahlberg 7bed417e5e make dissect_nt_sid return ep allocated memory and thus fix a few memory leaks 
(this function is often called from dcerpc dissectors)


svn path=/trunk/; revision=19243
 2006-09-16 09:20:34 +00:00
Ronnie Sahlberg cf6d4692aa in LDAP over TCP 
use tcp_dissect_pdus() which works    insterad of trying to do the pdu tracking and signalling for reassembly manually.
This makes ldap pdu tracking and reassembly work properly for cases when hosts are streaming lpad over tcp and there is little or none alignlemt of pdus to the start of a segment



svn path=/trunk/; revision=18965
 2006-08-20 06:00:16 +00:00
Guy Harris 338f7ede99 Squelch a compiler warning. 
svn path=/trunk/; revision=18954
 2006-08-19 02:56:16 +00:00
Ronnie Sahlberg 5f8e067936 for sec descriptors found inside ldap 
decode the specific bits of the accessmask as the ldap specific accessmask bits

bit definitions from samba4


svn path=/trunk/; revision=18881
 2006-08-11 07:59:58 +00:00
Ronnie Sahlberg 8969e45027 marik the request_in/response_to/time as generated fields 
svn path=/trunk/; revision=18846
 2006-08-07 10:35:26 +00:00
Ronnie Sahlberg 5a5dcdc8ad dissect nTSecurityDescriptor attribute as a security descriptor 
svn path=/trunk/; revision=18845
 2006-08-07 10:29:39 +00:00
Ronnie Sahlberg 5823354433 objectSid attribute contains a sid so decode it nively as a sid 
svn path=/trunk/; revision=18844
 2006-08-07 10:19:37 +00:00
Ronnie Sahlberg 2d5ec44674 add some more oid's 
svn path=/trunk/; revision=18843
 2006-08-06 14:31:58 +00:00
Ronnie Sahlberg b446810939 the ldap values for supportedControl and supportedCapabilities is an oid in ascii format. 
resolve it into a anme if possible and present it.




svn path=/trunk/; revision=18842
 2006-08-06 14:04:07 +00:00
Ronnie Sahlberg 3ef9bcfa26 "objectGUID" should be dissected as a GUID 
also change the name of one of the strings we keep around since it is more generic than just used for attributeassertions



svn path=/trunk/; revision=18841
 2006-08-06 13:13:42 +00:00
Gerald Combs d4819d4690 Make sure our strings aren't null before we pass them to strncmp(). 
svn path=/trunk/; revision=18723
 2006-07-12 18:12:15 +00:00
Ronnie Sahlberg ed3e02ed61 prettify dissection od ldap attributes 
special case some common special attributes such as DomainSid and DomainGuid
and dissect them as SIDs and GUIDs

examples of these special attributes can be seen in Xiaoguang Liu's email to wireshark dev



svn path=/trunk/; revision=18719
 2006-07-12 09:02:00 +00:00
Gerald Combs e212e73354 Reset ldm_tree in dissect_ldap_pdu(). Fixes a couple of the current fuzz 
bugs.

svn path=/trunk/; revision=18697
 2006-07-10 13:42:59 +00:00
Gerald Combs 3ec4dc74e8 Fix a format string bug. This should fix some of the current fuzz 
crashes.

svn path=/trunk/; revision=18666
 2006-07-05 19:14:59 +00:00
Ronnie Sahlberg d0aae6dd3e from metze 
prettify dissection of filters containing substring and extensiblematch



svn path=/trunk/; revision=18617
 2006-06-29 21:04:37 +00:00
Gerald Combs 835afe4a96 Reset ldm_tree to NULL each time we dissect an LDAP packet. This should 
fix a current Buildbot crash.  Fix up whitespace.

svn path=/trunk/; revision=18601
 2006-06-28 22:07:23 +00:00
Tomas Kukosa 56d7db0c08 remove functions register_ber_oid_name() and get_ber_oid_name() from packet-ber.c, they were only OID but not BER related 
use add_oid_str_name() and get_oid_str_name() instead of them

svn path=/trunk/; revision=18595
 2006-06-28 14:19:08 +00:00
Ronnie Sahlberg 946a39d4fc the dissector for AssertionValue that is implemented in the template file 
did not check the implicit_tag flag and caused extensiblematch filters to show up as malformed packets.




svn path=/trunk/; revision=18540
 2006-06-22 10:29:49 +00:00
Guy Harris 2d20359c26 Include <epan/dissectors/packet-tcp.h> to declare tcp_dissect_pdus(). 
svn path=/trunk/; revision=18483
 2006-06-16 07:18:25 +00:00
Ronnie Sahlberg 2f95f76a1e fix tcp reassembly to work again for 
ldap   and ldap+sasl


remove a recent ber length validation in packet-ber.c that cant work and breaks reassembly  and also makes all ber pacvket sspanning multiple segments show up as malformed packets.



svn path=/trunk/; revision=18465
 2006-06-14 11:51:25 +00:00
Ronnie Sahlberg f3c5f96124 from metze 
make the display of the filters more similar to how the ldap c api represents
filters and how they are commonly represented in documentation and other texts.




svn path=/trunk/; revision=18449
 2006-06-13 07:44:37 +00:00
Guy Harris 6d2e9ee5f7 Constify to fix compiler warnings. 
Check for printable ASCII - 0x7F is >= 0x20, but it's not printable, and
0x80 through 0xFF aren't ASCII.

Note that we should perhaps be using RFC 2252-style schemas to figure
out which attribute and assertion values are text and which are binary.

svn path=/trunk/; revision=18447
 2006-06-13 05:39:55 +00:00
Anders Broman f51e366267 Fix some warnings. 
svn path=/trunk/; revision=18445
 2006-06-12 21:48:51 +00:00
Ronnie Sahlberg b501e15fe9 prettify dissection of LDAP search filters. 
svn path=/trunk/; revision=18431
 2006-06-12 08:30:07 +00:00
Ronnie Sahlberg 452226586d rework the previous patch slightly since we really need to push a string upward to our callers to be able to generate and display nice filter expressions on the top line as the original ldap dissectopr did 
svn path=/trunk/; revision=18421
 2006-06-10 06:48:09 +00:00
Ronnie Sahlberg fcf198a69d add simple heuristics to the decoding of assertionvalues to make it display ascii strings as ascii and binary data as hex bytes 
svn path=/trunk/; revision=18420
 2006-06-10 05:07:42 +00:00
Ronnie Sahlberg 5e49882844 make CLDAP show up as CLDAP in the dissectyion tree and not as LDAP 
this also makes the "cldap" filter work


svn path=/trunk/; revision=18419
 2006-06-10 04:29:26 +00:00
Tomas Kukosa 55600fb60a Ethereal -> Wireshark 
asn2eth -> asn2wrs

svn path=/trunk/; revision=18214
 2006-05-23 15:17:14 +00:00
Tomas Kukosa 62da958bd9 - asn2eth renamed to asn2wrs 
- remove obsolete -X option from makefiles
- not generate enumerated map table for BER

dissector will be regenerated later

svn path=/trunk/; revision=18199
 2006-05-21 14:36:05 +00:00
Ronnie Sahlberg 89f022b12b name change 
svn path=/trunk/; revision=18197
 2006-05-21 05:12:17 +00:00
Graeme Lunt 146d22767c LDAP attribute type dissector framework including support for "netlogon" attribute and PKI attributes 
svn path=/trunk/; revision=18109
 2006-05-08 17:52:42 +00:00
Ronnie Sahlberg 5a8a9702fe force the AssertionValue type to be displayed as a STRING instead of as hex BYTES. 
Most of the time  AssertionValue will contain an ascii string   so make it always display as a string to make the display "correct" most of the time insterad of being "wrong" most of the time.

There are situations when AssertionValue contains binary data though  and in those cases the display will be "wrong" (but not more wrong than the old dissector anyway)


What someone really should do (someone interested in ldap that is) to make it more correct would be to implement a dissector for AssertionValue in the template file and having the dissector check if any of the bytes of the octet string has a value <32   and if so display it in hex as   0x.....
It all bytes have values >=32   then it shoudlk display it as a string "...
instead.

Someone interested in ldap may spend time on this refinement.



svn path=/trunk/; revision=18089
 2006-05-04 10:19:32 +00:00
Ronnie Sahlberg c18467254d do some template magic to make ethereal dissect CLDAP RPC again. 
i dont think it is the optimal way to solve this but it is better than nothing for the time being.


svn path=/trunk/; revision=18083
 2006-05-03 10:59:15 +00:00
Anders Broman 051a12aa9a Preparations to restore CLDAP dissection, no need to regenerate the dissector yet. 
svn path=/trunk/; revision=18067
 2006-05-02 05:35:55 +00:00
Guy Harris 30820fa73e Include <epan/strutil.h> to define g_ascii_isprint() on systems with 
GLib 1.2[.x].

svn path=/trunk/; revision=18061
 2006-05-01 17:43:29 +00:00
Guy Harris 53e371e8a7 Add a Makefile to generate the dissectors from UN*X. 
svn path=/trunk/; revision=18060
 2006-05-01 17:42:01 +00:00
Graeme Lunt 4efe0f2423 Request/result matching, port preference and display tweaks 
svn path=/trunk/; revision=18042
 2006-04-30 07:23:42 +00:00
Guy Harris a6930fe4ae Add distclean and maintainerclean rules. 
svn path=/trunk/; revision=17999
 2006-04-25 18:45:08 +00:00
Anders Broman 54f6b68edc Add parsertab.pyc in clean target 
svn path=/trunk/; revision=17387
 2006-02-23 20:05:52 +00:00
Anders Broman 3d728fcf08 Put in some of the old functionallity. 
svn path=/trunk/; revision=17360
 2006-02-21 18:56:25 +00:00
Jörg Mayer 50d94b2f95 Add missing propset ... 
svn path=/trunk/; revision=16749
 2005-12-09 16:46:24 +00:00
Ronnie Sahlberg 30a69454db add work in progress asn2eth generated ldap dissector from AndersB's email of 
Nov 15

it is checked in but not copied to epan/dissectors so that those interested can work on it until it gets ready to replace the old one.



svn path=/trunk/; revision=16649
 2005-12-02 10:41:46 +00:00