Commit Graph

79 Commits

Author SHA1 Message Date
Bill Meier 63dfc596b2 flow_graph & etc: rework graph "save as" slightly:
- Pop up an alert box if unable to open file for write;
 - Prevent "dead" save-as window if unable to open file for write
    or if a directory is entered as the filename;
 - Fix a memory leak.

svn path=/trunk/; revision=28554
2009-06-01 14:00:09 +00:00
Gerald Combs 1582e052a1 More Win64 fixes.
svn path=/trunk/; revision=28062
2009-04-16 00:45:26 +00:00
Bill Meier 27024a1d5a As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
svn path=/trunk/; revision=27800
2009-03-19 17:49:11 +00:00
Stig Bjørlykke 18c5caa3d4 From Jakub Zawadzki:
Use non-formatting functions when appropriate.

svn path=/trunk/; revision=27709
2009-03-12 07:56:42 +00:00
Anders Broman 7c66938e7f Use gtk_file_chooser_dialog_new().
svn path=/trunk/; revision=27514
2009-02-22 20:10:17 +00:00
Stig Bjørlykke 8608c8f1de Fix some "format not a string literal and no format arguments" warnings.
svn path=/trunk/; revision=26641
2008-10-31 09:53:56 +00:00
Jaap Keuter 7ae1591787 Fix for bug 1854:
Even though not perfect, this effectively doubles the width of the header labels
without changing the rest of the layout.

svn path=/trunk/; revision=26615
2008-10-29 07:28:44 +00:00
Jaap Keuter 784ca2bd43 Clean up the whitespace.
svn path=/trunk/; revision=26503
2008-10-20 20:24:01 +00:00
Bill Meier d3fc3b6c3e Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_button_box_set_spacing()  ==> gtk_box_set_spacing()

svn path=/trunk/; revision=25673
2008-07-08 02:43:40 +00:00
Bill Meier 56206e0002 Fix some simple cases of GTK2 deprecated API usage by using a renamed or equivalent API
gtk_container_border_width()          ==> gtk_container_set_border_width()
  gtk_container_children()              ==> gtk_container_get_children()
  gtk_entry_new_with_max_length()       ==> gtk_entry_new(); gtk_entry_set_max_length()
  gtk_menu_append()                     ==> gtk_menu_shell_append()
  gtk_menu_prepend()                    ==> gtk_menu_shell_prepend()
  gtk_notebook_set_page()               ==> gtk_notebook_set_current_page()
  gtk_paned_gutter_size()               ==> gtk_paned_set_gutter_size()
  gtk_radio_button_group()              ==> gtk_radio_button_get_group()
  gtk_signal_connect()                  ==> g_signal_connect()
  gtk_signal_disconnect()               ==> g_signal_handler_disconnect()
  gtk_signal_emit_by_name()             ==> g_signal_emit_by_name()
  gtk_signal_handler_block_by_data()    ==> g_signal_handlers_block_matched()
  gtk_signal_handler_block_by_func()    ==> g_signal_handlers_block_by_func()
  gtk_signal_handler_unblock_by_data()  ==> g_signal-handlers_unblock_matched()
  gtk_signal_handler_unblock_by_func()  ==> g_signal-handlers_unblock_by_func()
  gtk_spin_button_get_value_as_float()  ==> gtk_spin_button_get_value()
  gtk_toggle_button_set_state()         ==> gtk_toggle_button_set_active()

svn path=/trunk/; revision=25634
2008-06-29 15:51:43 +00:00
Jeff Morriss a5cee04fad Move the file utility functions from wiretap to libwsutil so that
libwireshark (and the plugins using those functions) do not depend on
wiretap on Windows.

While doing that, rename the eth_* functions to ws_*.

svn path=/trunk/; revision=25354
2008-05-22 15:46:27 +00:00
Anders Broman b6454e76ac Fix some of the Errors/warnings detected by checkapi.
svn path=/trunk/; revision=25244
2008-05-06 05:50:31 +00:00
Ulf Lamping 8e3e8b588f sort #includes by directories
svn path=/trunk/; revision=24968
2008-04-13 01:54:20 +00:00
Ulf Lamping d4ccf577a8 where it's not necessary, remove #include "compat_macros.h"
svn path=/trunk/; revision=24922
2008-04-12 01:02:59 +00:00
Ulf Lamping 8e58ec7085 last round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24918
2008-04-11 23:16:06 +00:00
Ulf Lamping 736cada149 third round to replace SIGNAL_CONNECT with g_signal_connect
svn path=/trunk/; revision=24914
2008-04-11 22:10:36 +00:00
Ulf Lamping c6d13dc2c8 replace WIDGET_SET_SIZE with gtk_widget_set_size_request
svn path=/trunk/; revision=24910
2008-04-11 20:31:05 +00:00
Ulf Lamping ae5f841083 replace all appearances of BUTTON_NEW_FROM_STOCK with GTK2's gtk_button_new_from_stock
svn path=/trunk/; revision=24904
2008-04-11 18:58:19 +00:00
Bill Meier 74e1c12021 OBJECT_..._DATA --> g_object_..._data
svn path=/trunk/; revision=24895
2008-04-11 16:44:31 +00:00
Ulf Lamping d470674329 some minor GTK1 related code fixes
svn path=/trunk/; revision=24873
2008-04-09 23:06:01 +00:00
Ulf Lamping da80212715 remove GTK1 code
svn path=/trunk/; revision=24820
2008-04-06 23:49:02 +00:00
Stig Bjørlykke 11c616f11e Do not redraw graph and goto frame 1 if selecting an "item" outside the list
in Graph Analysis list.

svn path=/trunk/; revision=23770
2007-12-05 13:32:09 +00:00
Sake Blok e8ca13de9e After taking a closer look at SVN 23089, I believe it was intended only to add the
file-name to the window title and not change the rest of the name.
(the graph window is both used from "Flow Graph" and from "VoIP calls")


svn path=/trunk/; revision=23695
2007-12-01 02:10:03 +00:00
Sake Blok e825cba61b Give the flow graph window the correct title.
svn path=/trunk/; revision=23689
2007-11-30 18:55:34 +00:00
Alejandro Vaquero 4bf238547f VoIP Calls changes: Add the file name to the title window in VoIP calls, Voip graph and RTP player windows. Make the calls selection using standard multiple selection using the GTK buildin functions. Add a 'Select All' buttom to the VoIP calls window.
svn path=/trunk/; revision=23089
2007-10-08 00:31:26 +00:00
Stephen Fisher c638ab8e6d Fix bug #1530 this time for GTK1 builds.
svn path=/trunk/; revision=22009
2007-05-30 19:43:33 +00:00
Stephen Fisher d3454df68a Update to revision 22000: change #if GTK_MAJOR_VERSION > 2 to >= 2
svn path=/trunk/; revision=22001
2007-05-30 03:28:12 +00:00
Stephen Fisher 6049eda556 Wrap call to gtk_window_set_destroy_with_parent() within check for GTK_MAJOR_VERSION > 2 to get the Windows build-bot going again. This means that bug #1530 has to be reopened awaiting a fix that covers GTK1 also.
svn path=/trunk/; revision=22000
2007-05-30 02:37:37 +00:00
Stephen Fisher 5eb2b42d30 Fix for bug #1530: Graph Analysis window misbehaves if Flow Window that
created it is closed.

The fix is to close the graph analysis window when the flow graph setup
window is closed since closing the flow graph window first destroys all
of the data structures.


svn path=/trunk/; revision=21994
2007-05-29 23:09:09 +00:00
Bill Meier cb92dd7019 Another fix to allow gtk1 to compile w/o warnings....
svn path=/trunk/; revision=21512
2007-04-22 22:23:19 +00:00
Ronnie Sahlberg 872398a417 some updates to allow gtk1 to compile without warnings
svn path=/trunk/; revision=21500
2007-04-22 15:43:01 +00:00
Stephen Fisher 1909b97d4d Remove all warnings under Unix for the gtk/ directory.
svn path=/trunk/; revision=21160
2007-03-24 00:45:11 +00:00
Luis Ontanon 529c65f713 voip_calls.c:
- instead of wrongly using the h248 call counter use tapinfo's counter

graph_analysis.c:
- beautify  the code (I was trying to the bug that got fixed by bzeroing m3ua tap data however this looks better!).

svn path=/trunk/; revision=21063
2007-03-19 00:36:42 +00:00
Jeff Morriss 8c6bda4db5 Squelch a couple (false) uninitialized variable warnings
svn path=/trunk/; revision=20858
2007-02-19 10:26:21 +00:00
Ulf Lamping 1587983aff from Stephen Fisher:
A user asked what file format the flow graph is saved as, which isn't 
apparent by looking at the dialog.  I had to try saving a file and check 
its type -- plain text file.  Could someone please apply the attached 
patch or similar change to graph_analysis.c.  My patch updates the title 
of the dialog box from "Wireshark: Save graph to file" to "Wireshark: 
Save graph to text file".

However, I used the term "plain text file" instead ;-)

svn path=/trunk/; revision=20510
2007-01-20 17:52:39 +00:00
Gerald Combs 5da5bf2567 When dumping the graph data to a file, don't walk past the end of a buffer.
Should fix bug 396.

svn path=/trunk/; revision=19499
2006-10-11 23:25:51 +00:00
Guy Harris 92552c2d76 Get rid of a bunch of "Ethereal"s and "ethereal"s in comments, GUI
strings, and function names.

svn path=/trunk/; revision=18205
2006-05-22 07:29:40 +00:00
Ronnie Sahlberg 89f022b12b name change
svn path=/trunk/; revision=18197
2006-05-21 05:12:17 +00:00
Guy Harris 84aef00bad Move the file selection dialog routines to file_dlg.c, and give it a
header file.

#if 0 out some includes; if none of the builds have a problem with
that, I'll remove them.

svn path=/trunk/; revision=18036
2006-04-30 01:47:58 +00:00
Anders Broman d7610e4c0a From Laurent Rabret,
2 patches for the "flow graph" display. It is better not to insert invalid packets into the list than to control the list is correct while using it...

svn path=/trunk/; revision=17622
2006-03-14 05:49:15 +00:00
Jaap Keuter e6ca05b8d8 From Laurant Rabret:
Please find enclosed 2 patches.
- Voip_calls_dlg.c.patch fixes a problem that appears with a release
compiled with GTK 2.8 + Visual Studio 2003. It seems g_snprintf can
corrupt memory when a length bigger than the array size is provided in
the second parameter (even if the generated string is smaller than the
array actual size!!)
- graph_analysis.c.patch fixes a memory corruption problem easy to
reproduce. Just open the pcap file enclosed, select "Statistics"->"Flow
Graph" and activate the "Network source/destination addresses" radio
button before pressing OK. You'll see a crash dump.
Thanks to check in
Best Regards
Laurent

svn path=/trunk/; revision=17543
2006-03-09 07:07:35 +00:00
Jaap Keuter 1f5ada6df0 Fix left open file (coverity CID 108) and g_string leak. Clean up double width line drawing.
svn path=/trunk/; revision=17515
2006-03-08 07:06:42 +00:00
Anders Broman 1fd7fbdb1d From Alejandro Vaquero:
a patch for the VoipCalls to fix a couple of issues:
- a problem with the RTP Events (RFC2833) not been handle correctly
- Display the RTP stream in time order when the setup frame is after the 
RTP stream.
- fix a init issue that caused the H245 packet to not been displayed 
correctly.

svn path=/trunk/; revision=17383
2006-02-23 20:02:23 +00:00
Luis Ontanon bd63d8d003 I commented out this a while ago as they caused a crash in GTK2.8/cairo on my box. I checked it in by mistake with a lot of more files, even worst I did not pay attention to an e-mail on the list regarding the damage caused. Luckily Alejandro Vaquero contacted me directly.
svn path=/trunk/; revision=17363
2006-02-21 23:35:13 +00:00
Luis Ontanon fcf7b3789c add an userdata argument to register_stat_cmd_arg() and its callback to use the callback for multiple registrations.
svn path=/trunk/; revision=17252
2006-02-11 13:05:24 +00:00
Ulf Lamping c3187174bf replace *a lot* of file related calls by their GLib counterparts. This is necessary for the switch to GTK 2.6 (at least on WIN32).
to do this, I've added file_util.h to wiretap (would file_compat.h be a better name?), and provide compat_macros like eth_open() instead of open(). While at it, move other file related things there, like #include <io.h>, definition of O_BINARY and alike, so it's all in one place.

deleted related things from config.h.win32

As of these massive changes, I'm almost certain that this will break the Unix build. I'll keep an eye on the buildbot so hopefully everything is working again soon.

svn path=/trunk/; revision=16403
2005-11-06 22:43:25 +00:00
Anders Broman 15a08ae521 From Alejandro Vaquero:
New "Fax T38 Analysis" added to the "Statistics" menu to:

- Reassemble the HDLC t30 frames and dissect the header.
- Analyze the UPDTLPacket seq num for packet lost
- Stats of V.x Data:
    - Count the Data bytes
    - Duration
    - Wrong seq num
    - Max Burst of packet lost

svn path=/trunk/; revision=16073
2005-10-03 05:55:26 +00:00
Gerald Combs 551b9bc61d Free our flow graph strings when we're done with them. Add a note about
flow graphs to the release notes, along with other stuff.

svn path=/trunk/; revision=15928
2005-09-21 14:20:43 +00:00
Gerald Combs ad99e218ca In an attempt to fix bug 396, switch over to GStrings. There still appears
to be a problem with formatting, but we don't crash any more.

svn path=/trunk/; revision=15923
2005-09-21 03:28:22 +00:00
Anders Broman 06c1f4ad6c From Alejandro Vaquero.
svn path=/trunk/; revision=15778
2005-09-13 04:53:36 +00:00