Commit graph

21039 commits

Author SHA1 Message Date
Guy Harris
db53f99cca Yet another workaround for GArray's bad data type choice.
svn path=/trunk/; revision=21626
2007-04-30 16:54:29 +00:00
Guy Harris
358b838924 Fix up the asn/q932 Makefile as per Tomas Kukosa's suggestion - and make
it a lot more like the Makefile.nmake file.  Also, use $(PROTOCOL_NAME)
in a couple of places in Makefile.nmake where it wasn't being used
before.

(It might be interesting to see whether we can use a template for these
Makefiles, and just tweak some variables at the beginning.)

That lets us get a Q.932 ROS dissector with the right file name and with
"q932.ros" rather than "q932-ros" as the dissector name; do that.

svn path=/trunk/; revision=21625
2007-04-30 08:55:59 +00:00
Tomas Kukosa
8640032603 newline at end of file is required by some compilers
svn path=/trunk/; revision=21624
2007-04-30 08:38:59 +00:00
Guy Harris
3485b6810a Thou shalt not squelch compiler complaints about an assignment
discarding a qualifier by explicitly casting away the qualifier;
constness should persist, so that attempts to, for example, modify
something you got with tvb_get_ptr() get complained about (as we don't,
and won't, guarantee that you will get correct behavior if you do that).
Just make the pointer to which a const pointer is being assigned const
itself.

Yet *AGAIN* work around GArray's brokenness of having its data pointer
be a guint8 * rather than a void *.

svn path=/trunk/; revision=21623
2007-04-30 08:33:44 +00:00
Guy Harris
2f88e4ca81 The Q.932 dissector doesn't need to include <string.h>; the Q.932 ROS
dissector does.

The fix to the Makefile to generate packet-q932-ros.c changed the
protocol name in some cases; change it uniformly.

svn path=/trunk/; revision=21622
2007-04-30 06:41:53 +00:00
Tomas Kukosa
3dd386cc35 move T.30 protocol into its own dissector file
svn path=/trunk/; revision=21621
2007-04-30 06:40:07 +00:00
Guy Harris
d77bc4e02e Put the q932-ros dissector into a file with the right name.
svn path=/trunk/; revision=21620
2007-04-30 06:24:27 +00:00
Guy Harris
3a0381579e Don't cast a "guint8 *" to a pointer to a structure; just use the
pointer to the guint8, plus explicitly defined structure offsets (the
structure had better be the same on all platforms, forever, otherwise
binary compatibility breaks, which would be an error, given that the
structure appears in capture files).

svn path=/trunk/; revision=21619
2007-04-30 06:19:35 +00:00
Stephen Fisher
c38acbae0e From Sake Blok:
While looking into the http-dissector I improved a few things on
how it dissects a proxy CONNECT session. This is what I have changed:

- added the fields hf_http_proxy_connect_host and -port

- changed proto_tree_add_text to proto_tree_add_string and -uint
  so that it's possible to filter on them

- make these two fields "PROTO_ITEM_SET_GENERATED"

- removed the alteration of the ports within pinfo, now the
  ports in the column info are not changed to the port used to
  connect to the backend server. It is now possible to use
  follow-tcp-stream again on proxied ssl sessions.


svn path=/trunk/; revision=21618
2007-04-28 23:52:12 +00:00
Guy Harris
9772732adc The data in a GArray is guaranteed to be properly aligned; add a cast to
squelch compiler warnings.

svn path=/trunk/; revision=21617
2007-04-28 22:31:04 +00:00
Guy Harris
e502e1efb9 Include <string.h> before using C string functions.
svn path=/trunk/; revision=21616
2007-04-28 22:22:35 +00:00
Guy Harris
cc972cf349 Libwireshark is now a shared library.
svn path=/trunk/; revision=21615
2007-04-28 22:17:05 +00:00
Guy Harris
0d8936ebd8 Fix the dependencies.
svn path=/trunk/; revision=21614
2007-04-28 22:16:27 +00:00
Guy Harris
ed652180e6 NULL is a pointer value; routines returning integral values shouldn't
return NULL.

svn path=/trunk/; revision=21613
2007-04-28 22:01:27 +00:00
Guy Harris
706a028996 In emem_tree_lookup_string(), return NULL if the allocation fails.
svn path=/trunk/; revision=21612
2007-04-28 21:58:42 +00:00
Guy Harris
b98d651b21 In calls to the emem_tree routines, forcibly align items not known to be
aligned on 32-bit boundaries.

svn path=/trunk/; revision=21611
2007-04-28 21:09:20 +00:00
Guy Harris
b19c9f63e9 Make tvb_memdup(), like ep_tvb_memdup(), return a "void *".
svn path=/trunk/; revision=21610
2007-04-28 21:06:15 +00:00
Anders Broman
83f17c25a7 Revert some private experiments checked in by misstake.
svn path=/trunk/; revision=21609
2007-04-28 14:47:43 +00:00
Anders Broman
2630b817b0 From Gavin Heer:
Here's a patch that decodes MMS(Manufacturing Messaging
Specification) when transported over COTP/TPKT/TCP.  Previously, MMS would only be decoded if the OSI Presentation Layers were present. Now MMS/COTP/TPKT/TCP is dissected.
With a change to use more functions from packet-ber

svn path=/trunk/; revision=21608
2007-04-28 14:38:53 +00:00
Anders Broman
43bb2aea51 Add:
proto_tree_add_bits_ret_val()
tvb_get_bits()
And modify
proto_tree_add_bits() not to return a value.
little endian is not yet implemented.

svn path=/trunk/; revision=21607
2007-04-28 12:13:25 +00:00
Ronnie Sahlberg
3094ff6c61 from metatech at flashmail.com :
new protocol STARTEAM


>Hi,
>
>Here is a submission of a new dissector for the Borland StarTeam protocol.
>For the compiler warnings, I tried to get rid of them, at least what MSVC6
>is reporting.  If your compiler reports more, please tell me the line number.
>As I do not have SVN installed but I compiled from the 0.99.5 tarball,
>please forgive me if I cannot easily generate diffs against current SVN (I
>tried my best with Cygwin).
>I also added the sample capture file on the Wiki on which I ran 900 loops
>of fuzz testing with no problem.


svn path=/trunk/; revision=21606
2007-04-28 07:57:12 +00:00
Tomas Kukosa
4204c7006c Fix Q.932 extra dist and add QSIG to extra dist.
svn path=/trunk/; revision=21605
2007-04-28 07:55:41 +00:00
Anders Broman
ad6d3f5120 Add Q.932 to extra dist.
svn path=/trunk/; revision=21604
2007-04-27 23:03:37 +00:00
Jaap Keuter
b8bc2883e0 Change of authors email address
svn path=/trunk/; revision=21603
2007-04-27 18:16:05 +00:00
Tomas Kukosa
b3fedb67fa new Q.932 and QSIG dissectors
svn path=/trunk/; revision=21602
2007-04-27 08:10:18 +00:00
Tomas Kukosa
9e368307eb minor formal changes
svn path=/trunk/; revision=21601
2007-04-27 07:37:30 +00:00
Tomas Kukosa
9f6c1ed0bb - new #.Exports parameter VALS_WITH_TABLE which "exports" whole table into header file
/it is only one way how to use it in Windows plugins/
- better handling of imports and definitions if more ASN.1 sources are compiled together
- fix tag handling on top level of PDU
- new -I command line option for path(s) of conformance files including

svn path=/trunk/; revision=21600
2007-04-27 07:35:01 +00:00
Jaap Keuter
1eed0eae40 From Bingyao Du:
Attachment is a patch for adding a new Juniper NSRP dissector. In this patch, OICQ author email address 
<dubingyao@gmail.com> has also been updated to <secfire@gmail.com>. 

svn path=/trunk/; revision=21599
2007-04-27 06:34:31 +00:00
Guy Harris
235596a3c8 From Jeff Foster: add support for Cisco HDLC captures.
svn path=/trunk/; revision=21598
2007-04-26 20:06:06 +00:00
Guy Harris
65b4512fe3 As with other types of extra info, tag the UID extra info. Don't add
stuff to the UID tree unless it's UID stuff.

Also, as we appear to allow for null domain and account information in
dissect_smb_uid(), check for null information before trying to add it to
the top-level item.

svn path=/trunk/; revision=21597
2007-04-26 19:44:18 +00:00
Jörg Mayer
b5b70b8405 Tiny formatting change
svn path=/trunk/; revision=21596
2007-04-26 15:39:41 +00:00
Guy Harris
08ab8d8734 mtp3_addr_to_str_buf() and mtp3_pc_hash() expect to be passed a pointer
to a mtp3_addr_pc_t; declare them as such, and pass the argument as
such.

svn path=/trunk/; revision=21595
2007-04-26 07:57:44 +00:00
Anders Broman
ccac0e7983 Change the signature of proto_tree_add_bits() and add proto_tree_add_bits_ret_val()
which will hopefully be more acceptable.
Change name of tvb_get_bits() in ansi_801

svn path=/trunk/; revision=21594
2007-04-26 06:39:29 +00:00
Jaap Keuter
066ce1b938 Fix for bug 1505. Adding getprinterdriver levels 2, 6, and (partially) 101.
svn path=/trunk/; revision=21593
2007-04-26 06:00:48 +00:00
Guy Harris
f13901ef1c memmove() is needed only if the source and destination might overlap.
svn path=/trunk/; revision=21592
2007-04-26 05:47:34 +00:00
Guy Harris
f260d1cd81 memmove() is needed only if the source and destination might overlap.
svn path=/trunk/; revision=21591
2007-04-26 05:43:43 +00:00
Guy Harris
ba3792fc78 memmove() is needed only if the source and destination might overlap.
svn path=/trunk/; revision=21590
2007-04-26 05:40:48 +00:00
Guy Harris
847846d825 memmove() is needed only if the source and destination might overlap.
svn path=/trunk/; revision=21589
2007-04-26 05:35:04 +00:00
Guy Harris
f16cd039c9 Make ADD_ADDRESS_TO_HASH() take a pointer to an address as an argument,
as the other address macros do.

svn path=/trunk/; revision=21588
2007-04-26 04:30:41 +00:00
Guy Harris
8b0bc56f2c See previous comment.
svn path=/trunk/; revision=21587
2007-04-26 03:43:34 +00:00
Guy Harris
9463cd9070 Umm, that's *not* how you compare addresses for equality....
svn path=/trunk/; revision=21586
2007-04-26 03:41:44 +00:00
Guy Harris
29c7090c23 Copy up to 4 bytes from the source address, rather than just copying the
first byte; if the goal is to have the address not be fake for IPv4,
that's the way to do it.

svn path=/trunk/; revision=21585
2007-04-26 03:38:40 +00:00
Guy Harris
8a998bf38a For address types where the address is a bunch of bytes, convert the
address data pointer from a void * to a guint8 *.

For AT_STRINGZ, convert it to a char *.

Fix indentation.

svn path=/trunk/; revision=21584
2007-04-26 03:32:38 +00:00
Guy Harris
ff195c6868 For 1-byte and 2-byte FIDs, convert the void * data pointer in the
address to a guint8 *, to get at the bytes.

svn path=/trunk/; revision=21583
2007-04-26 03:08:23 +00:00
Guy Harris
febd662cf3 Get rid of unused variable.
svn path=/trunk/; revision=21582
2007-04-26 02:36:24 +00:00
Guy Harris
abc66d168a Use the right local variable.
svn path=/trunk/; revision=21581
2007-04-26 02:35:36 +00:00
Guy Harris
d78cbd4b00 Get rid of no-longer-needed variable.
svn path=/trunk/; revision=21580
2007-04-26 01:35:26 +00:00
Guy Harris
7537b3afa3 Add missing backslash.
svn path=/trunk/; revision=21579
2007-04-26 01:11:24 +00:00
Guy Harris
bba0b00392 Rename HASH_ADDRESS to ADD_ADDRESS_TO_HASH, to make it clearer what it
does (i.e., it will add the address bytes to the value that's already
there - it will not initialize the value, so you have to clear it before
doing any hashing).

svn path=/trunk/; revision=21578
2007-04-26 01:01:27 +00:00
Guy Harris
1ed26d317c Add a macro for hashing the bytes of an address into a hash value.
Use it in the IAX2 dissector and in the conversation code.

svn path=/trunk/; revision=21577
2007-04-26 00:51:33 +00:00