2ac134b3c5
whitespace fixes; mostly: remove trailing blanks
...
svn path=/trunk/; revision=52591
2013-10-13 19:56:52 +00:00
c8be3dcee2
Add a MBIM (Mobile Broadband Interface Model) dissector
...
Still to be done:
- fragmentation support
- plug the MBIM dissector on USB dissector
svn path=/trunk/; revision=52279
2013-09-29 22:50:27 +00:00
346f803d42
Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was all manual inspection and most cases were either:
...
1. Case sensitivity differences between hf_ field name and formatted string.
2. Unnecessary whitespace between hf_ field name and colon in formatted string
There are cases where the hf_ field name doesn't quite match the proto_tree_add_uint_format, but it's close enough that one of them should be "right", I'm just not sure which is, I just know the string in proto_tree_add_uint_format is the one displayed.
svn path=/trunk/; revision=52098
2013-09-16 10:39:06 +00:00
69dfcffbc0
Remove obsolete code
...
svn path=/trunk/; revision=51743
2013-09-03 21:25:16 +00:00
84bf0acc00
Convert a few dissectors from EMEM to WMEM API
...
svn path=/trunk/; revision=51597
2013-08-30 14:49:55 +00:00
ce537f6b94
Remove static packet_info *gpinfo and just use the packet_info provided by the function.
...
svn path=/trunk/; revision=49145
2013-05-03 14:54:39 +00:00
238659f271
Add dissection of USAT TLV IARI, PLMN list, EPS PDN connection activation parameters and Tracking Area Identification
...
svn path=/trunk/; revision=48862
2013-04-15 21:52:59 +00:00
37600a157b
Rename value string (and similar) functions to use a consistent pattern. This
...
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).
Use a consistent coding style, and make proper use of the WS_DLL_* defines.
Group the functions appropriately in the header.
I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
bda771b86b
Do not initialize ett_tree and msg_fcn_p when match_strval_idx_ext does not find a match
...
svn path=/trunk/; revision=48538
2013-03-24 21:52:19 +00:00
3eb06be97d
From beroset:
...
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48425
2013-03-19 19:28:57 +00:00
86eda54fe6
As suggested by Evan Huus, use extended value_strings
...
svn path=/trunk/; revision=48407
2013-03-18 22:21:53 +00:00
94f330030d
use enum values instead of hardcoded values
...
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487 )
svn path=/trunk/; revision=48397
2013-03-18 20:26:47 +00:00
ae61fe0158
Try to fix dissection of GSM protocol family broken by r47209.
...
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks.
(I hope I got everything right...)
svn path=/trunk/; revision=47218
2013-01-22 23:25:44 +00:00
b8af5b44d1
#if 0 out some variables that are used only in now-#if 0'ed code.
...
svn path=/trunk/; revision=47040
2013-01-11 21:20:57 +00:00
9f387eddbb
Try to deduce NAS EPS Detach Request direction from message size
...
svn path=/trunk/; revision=47039
2013-01-11 20:54:04 +00:00
952ccb4b83
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8168 :
...
Detect properly the EMM Service Request message
svn path=/trunk/; revision=46991
2013-01-07 21:37:55 +00:00
0b20f855f0
Upgrade NAS disssectors to v11.5.0
...
svn path=/trunk/; revision=46842
2012-12-29 17:10:04 +00:00
be99fcad4d
Minor cleanup:
...
- prefs callback not needed;
- move proto_reg_handoff...() to the end of the file as per convention;
- reformat some log lines.
svn path=/trunk/; revision=46358
2012-12-03 22:42:56 +00:00
727ed68381
Fix [-Wshadow] warning for purported variable shadowing another.
...
svn path=/trunk/; revision=46356
2012-12-03 22:26:34 +00:00
810a200141
Revert 46018. Needs rethinking.
...
svn path=/trunk/; revision=46028
2012-11-14 10:02:15 +00:00
9145ad5781
Display text in subtree
...
svn path=/trunk/; revision=46026
2012-11-13 21:59:14 +00:00
6edabe05d8
Try to fix dissection with g_nas_eps_dissect_plain == TRUE.
...
svn path=/trunk/; revision=46018
2012-11-13 12:54:58 +00:00
4518ece9f9
From Umberto Corponi via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7912 :
...
Allow dissection of ESM messages with integrity protection and EEA0 ciphering
From me:
Tighten heuristic to check for allowed EPS bearer identity values
svn path=/trunk/; revision=45789
2012-10-25 21:37:12 +00:00
924f9663fd
Enhance dissection of Open Channel proactive command
...
svn path=/trunk/; revision=45413
2012-10-08 22:30:47 +00:00
88324e39bb
Use a value string array for EPS Bearer Identity and remove useless de_esm_lnkd_eps_bearer_id function
...
svn path=/trunk/; revision=45267
2012-10-02 20:44:36 +00:00
ff3bd58b74
Upgrade NAS EPS dissector to v11.4.0 (Release 11)
...
svn path=/trunk/; revision=45253
2012-10-02 12:46:21 +00:00
6dedc6628b
Test Procedures messages should be also integrity protected
...
svn path=/trunk/; revision=45046
2012-09-21 19:58:34 +00:00
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
5a8783f5b1
Initial commit to support yet another method of passing data between dissectors.
...
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL
svn path=/trunk/; revision=44860
2012-09-10 21:40:21 +00:00
777bbfb20d
Use same capitalization for Service request message as for other messages
...
svn path=/trunk/; revision=43761
2012-07-17 10:35:21 +00:00
bf81b42e1e
Update Free Software Foundation address.
...
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
2012-06-28 22:56:06 +00:00
053707aef8
Fix dissection of NAS EPS Service Request message (broken in r42200)
...
svn path=/trunk/; revision=43474
2012-06-25 11:12:54 +00:00
2d5792d19b
Fix typo errors
...
svn path=/trunk/; revision=43473
2012-06-25 10:16:15 +00:00
41b3988bbd
Fix function name (it is an Authentication failure, not an Attach failure)
...
svn path=/trunk/; revision=43255
2012-06-14 07:25:53 +00:00
3c20eeb452
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7368 :
...
Identity request, Identity response and Authentication failure message dissection are swapped
svn path=/trunk/; revision=43253
2012-06-14 07:14:59 +00:00
0ba1ab2909
Display Element ID in hexadecimal (like in 3GPP specs)
...
Display EPS bearer ID in decimal
svn path=/trunk/; revision=42755
2012-05-21 19:27:38 +00:00
774748914f
Upgrade NAS EPS dissector to Release 10 (10.6.1)
...
svn path=/trunk/; revision=42722
2012-05-20 09:50:34 +00:00
c055ca8c7e
General minor cleanup including:
...
- remove unneeded #includes;
- use val_to_str_const() as appropriate;
- reformat hf[] entries;
- reformat long lines;
- use #if 0/#endif to coment out code instead of /* ... */;
- remove boilerplate comments;
- whitespace & indentation
svn path=/trunk/; revision=42487
2012-05-07 22:11:34 +00:00
77dc38ec5a
value_string_ext: Reorder entries in value_string arrays to get Binary Search instead of Linear Search.
...
svn path=/trunk/; revision=42418
2012-05-04 07:34:06 +00:00
949079e2b4
From David Wei:
...
Bug fixes and improvements to Sm (GTPv2) and SGmb (DIAMETER) dissectors.
svn path=/trunk/; revision=42220
2012-04-24 12:33:00 +00:00
8caed06a76
Use tvb_new_subset_remaining(...) in place of tvb_new_subset(..., -1, -1);
...
Use value_string_ext to reference a few value_strings;
Use val_to_str_const() in place of val_to_str() in a few cases;
Use BASE_NONE for a few hf[] FT_BOOLEAN entries with 0x0 bitmask.
svn path=/trunk/; revision=41539
2012-03-13 17:21:46 +00:00
77afe2d93d
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
...
svn path=/trunk/; revision=41305
2012-03-02 11:05:08 +00:00
501216eb8a
From Pascal Quantin:
...
[NAS EPS] Fix description of EPS Attach information element.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6886
svn path=/trunk/; revision=41245
2012-02-29 17:01:57 +00:00
a2df0df2ae
From Pascal Quantin:
...
[NAS EPS] PDN Connectivity Request message dissection fixes.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6845
svn path=/trunk/; revision=41033
2012-02-15 22:56:20 +00:00
f00ac880ca
From Pascal Quantin:
...
Dissect operator-specific QCI values in EPS quality of service IE
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6760
svn path=/trunk/; revision=40699
2012-01-24 19:09:12 +00:00
ae9c9a3906
Fix some duplicate display filter names.
...
svn path=/trunk/; revision=40664
2012-01-23 19:17:42 +00:00
6aef22ffd9
Updates from David Wei.
...
svn path=/trunk/; revision=40244
2011-12-19 16:57:17 +00:00
932ea790e8
Fix bugs related to Nounce IE dissection.
...
svn path=/trunk/; revision=39987
2011-11-22 17:44:50 +00:00
71039b37c6
Fix "With the current changes NAS messages with the "null ciphering algorithm" EEA0 are not handled."
...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6348
svn path=/trunk/; revision=39911
2011-11-17 20:03:36 +00:00
c7fb9d9fe3
From Pascal Quantin:
...
Fix dissection of PLMN List IE.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6513
svn path=/trunk/; revision=39674
2011-10-30 15:57:30 +00:00
Bill Meier