Patch 45480 introduced the following check:
"tvb_ensure_bytes_exist(tvb, offset, neo ? neo : *bcp - ((unsigned)offset + 1));:
When the last entry in the directory listing is processed, 'neo' the next entry offset is zero so bcp is checked. The 'bcp' variable is set to the remaining reported bytes in the tvb. Subtracting the current offset +1 from *bcp usually produces a negative result and causes the error.
Removed "- ((unsigned)offset + 1)" and added "CHECK_BYTE_COUNT_SUBR(4);"
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8549
svn path=/trunk/; revision=48744
makes the TDMoE dissector call the LAPD bitstream dissector on the D-Channel. As a result, LAPD calls Q.931, and you can actually see call setup and tear down, instead of just a hex dump.
It adds a preference for which channel the D-Channel is.
It patches the LAPD code to fix a few bugs, not pass the checksum to Q.931 (who isn't expecting it), to register the lapd-bitstream dissector, and to mark packets with aborts or resets.
also storing more data on the lapd_byte_state_t.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8374
svn path=/trunk/; revision=48743
find the corresponding libnl-genl or libnl-route libraries, act as if we
didn't find libnl.
If we didn't find libnl version 2 or 3, don't check whether it's version
2 or 3.
svn path=/trunk/; revision=48742
Merged packet-rtps.c and packet-rtps2.c into a single dissector. It appears packet-rtps2.[ch] "API" needs to be externally available, otherwise I would have rolled (the newly merged) packet-rtps.h into packet-rtps.c as well.
Converted many of the remaining proto_tree_add_text to proto_tree_add_item/expert_info and cleaned up the manual string manipulation so checkAPIs.pl is happy.
Added a "cooked" capture file to the SampleCaptures page on the wiki for future fuzztesting/regression.
svn path=/trunk/; revision=48727
Don't assume that enum nl80211_channel_type and enum
ws80211_channel_type happen to have matching values, map between them,
and always assign the right enum value to the right type. This is safer
(yes, they do happen to have matching values, but it's not very clean to
assume that), and also eliminates some -Wc++-compat warnings.
svn path=/trunk/; revision=48717
at least on OS X, to set the "proxy icon" - we need to clear the window
title *and* the file path before we set it, otherwise the set doesn't
happen.
While we're at it, clear the file path whenever we're *not* using a
path. For temporary files, don't set the file path.
The file path is, in fact, the *full path*, not just the last component.
svn path=/trunk/; revision=48715
indicates. (Note: "unsaved data" is more than just "unsaved changes";
it could also mean "temporary file that hasn't been saved anywhere".)
svn path=/trunk/; revision=48709
Michael Mann