7878e93cad
expert_add_info_format_text + proto_tree_add_text = proto_tree_add_expert_format, where applicable.
...
svn path=/trunk/; revision=50377
2013-07-03 23:43:26 +00:00
b00abd1c43
Check actx->private_data validity before using it
...
svn path=/trunk/; revision=50339
2013-07-03 12:01:12 +00:00
b91b990a77
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8880 :
...
Check actx->private_data validity before using it
svn path=/trunk/; revision=50338
2013-07-03 08:53:47 +00:00
98492c5619
expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicable
...
svn path=/trunk/; revision=50337
2013-07-03 02:59:31 +00:00
17772df943
Fix Coverity CID 1040373 (Dereference before null check). Minor whitespace changes come along for the ride on this one.
...
svn path=/trunk/; revision=50297
2013-07-01 15:09:56 +00:00
997c6c7d8e
Fix Coverity CID 712348 (Unused pointer value).
...
svn path=/trunk/; revision=50288
2013-07-01 06:15:37 +00:00
95daae2290
Squelch some warnings.
...
svn path=/trunk/; revision=50286
2013-07-01 06:13:21 +00:00
bfcaf93bff
Fix Coverity CID 1040372 (Printf arg count mismatch) by eliminating the double %'s.
...
svn path=/trunk/; revision=50283
2013-07-01 05:47:13 +00:00
c1ddd6046d
replace object_identifier_id with actx->external.direct_reference
...
svn path=/trunk/; revision=50209
2013-06-28 12:52:13 +00:00
9009944d51
Remove all global variables in P1 dissector. Bug 8515 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8515 )
...
Added a "subtree context" structure to asn1_ctx_t. This should allow other ASN.1 dissector global variables to be replaced when only used for transferring data between fields in a subtree.
svn path=/trunk/; revision=50208
2013-06-28 12:43:29 +00:00
a441793cba
Move a couple of time-related modules into wsutil.
...
A bunch of files didn't really need to include these header files so remove
the include line rather than changing it.
svn path=/trunk/; revision=50154
2013-06-25 22:02:20 +00:00
d23f769c0d
Add an option to dissect RRC-Container IE
...
svn path=/trunk/; revision=50130
2013-06-24 21:31:25 +00:00
87eb22f464
More proper fix (per advice of bug 8515 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8515 )) of global variables complained about in bug 7060 ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7060 ). Not sure if algorithm_id of x509af dissector could also be a actx->external.direct_reference, so left it alone.
...
svn path=/trunk/; revision=50113
2013-06-22 15:08:18 +00:00
de10bc6b5e
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8799 :
...
Display certificate as UINT64 and add support for a 64bits unsigned value in BER dissector
svn path=/trunk/; revision=50096
2013-06-20 23:37:16 +00:00
64e15853fc
Fix for bug 8826.
...
The global variable 'address_item' was not always being set to NULL
before the dissection of a new frame. Do more to set it in the general
case, and in the particular case of an MTSBindResult_PDU, which was
triggering an error in the supplied capture.
There may be other entry points where this still safely isn't being
set.
svn path=/trunk/; revision=50083
2013-06-20 18:54:58 +00:00
7c8530539c
Ldap still needs to include wmem.h since it uses wmem during normal dissection,
...
just not for UAT purposes.
svn path=/trunk/; revision=50074
2013-06-20 14:01:54 +00:00
d63bd5330f
Back out some of the wmem conversions (r50063 and r50057).
...
These dissectors allocate ephemeral or seasonal memory in UAT callbacks, which
really makes no sense because UAT callbacks can occur when there is no packet or
file in scope, making this effectively a leak if the user is fiddling with their
UAT and never opens a capture.
Emem let you get away with this, wmem forces an assertion. Back out the changes
so that the UATs are usable until the code can be properly fixed to not use
out-of-scope allocators.
svn path=/trunk/; revision=50073
2013-06-20 06:26:03 +00:00
0d3718b467
Add some missing wmem includes that apparently only show up on Windows.
...
svn path=/trunk/; revision=50071
2013-06-19 23:53:25 +00:00
8b0f1addd9
Apparently one of our major global headers must include emem.h, because I just
...
found a bunch more asn1 dissectors using emem without ever directly including
the header. Convert those to wmem as well, which involves add a number of
#include directives since dissectors do *not* automatically pull in the wmem
headers.
svn path=/trunk/; revision=50066
2013-06-19 23:08:58 +00:00
b1e12ec925
Convert the rest of the ASN1 dissectors from emem to wmem.
...
svn path=/trunk/; revision=50063
2013-06-19 22:47:36 +00:00
9fa4a8e6b6
Convert a batch of asn1 dissectors from emem to wmem.
...
svn path=/trunk/; revision=50057
2013-06-19 20:43:03 +00:00
b77119aca7
Remove traling whitespace.
...
svn path=/trunk/; revision=50048
2013-06-19 18:33:49 +00:00
2eec913a4d
Fet rid of a global variable
...
svn path=/trunk/; revision=50034
2013-06-19 07:16:14 +00:00
830ebed406
Get rid of global variables
...
svn path=/trunk/; revision=50032
2013-06-19 06:44:39 +00:00
d9b5210c61
Fix CID 712341: Dereference null return value (NULL_RETURNS)
...
Well, not really. Just catch that case and error out.
svn path=/trunk/; revision=50029
2013-06-19 03:23:31 +00:00
2cf27a92a6
Set PDCP SN length for DRBs for separate RRC element.
...
svn path=/trunk/; revision=50021
2013-06-18 22:38:54 +00:00
868f74d628
Also signal value of PDCP SN (only used if enabled by RLC preferences).
...
svn path=/trunk/; revision=50019
2013-06-18 21:44:48 +00:00
ece132a5ce
Configure MAC LCID -> RLC channel settings from RRC.
...
svn path=/trunk/; revision=50016
2013-06-18 21:02:00 +00:00
458dcb7ea2
Add ability to export decrypted SSL/DTLS PDUs
...
svn path=/trunk/; revision=50001
2013-06-18 01:13:07 +00:00
f42e5bc9c0
Remove check_col() and the occasional tree.
...
This leaves just the Pidl dissectors remaining for removal of check_col() in the dissectors directory. A small handful of check_col() calls remain outside of the dissectors.
svn path=/trunk/; revision=49941
2013-06-14 19:46:54 +00:00
9c26c32645
Add parentheses around assignment used as truth value.
...
svn path=/trunk/; revision=49929
2013-06-14 13:20:41 +00:00
2dbf6c59a2
Remove check_col() from ASN.1 dissectors
...
svn path=/trunk/; revision=49927
2013-06-14 12:44:50 +00:00
82e220f2bd
Pretify dissection of date and Time.
...
svn path=/trunk/; revision=49905
2013-06-12 15:08:08 +00:00
822c02b5d0
Fix wrong offset in H.235 tokens causing malformed packet exception
...
svn path=/trunk/; revision=49899
2013-06-12 09:03:21 +00:00
03a322661f
Fix a crash when oid_info->value_typem is NULL
...
svn path=/trunk/; revision=49894
2013-06-12 04:21:40 +00:00
93be0fb393
Batch of filterable expert infos with some minor cleanup I noticed while doing the filter conversions.
...
svn path=/trunk/; revision=49893
2013-06-12 03:33:44 +00:00
bbb5aacd42
Show DisplayString as a string.
...
svn path=/trunk/; revision=49887
2013-06-11 16:35:06 +00:00
c891784de7
Quick fix for bug 8768. For now assume that only three logical channels
...
are valid. If we run into more add expert item and cap the channel
count.
svn path=/trunk/; revision=49787
2013-06-05 16:38:20 +00:00
1bb2081fd2
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8746 :
...
Add procedure numbers to C12.22 dissection
svn path=/trunk/; revision=49775
2013-06-04 20:21:17 +00:00
3bfeaff546
Add subdissection of:
...
- SNMPv2-MIB sysDescr
- SNMPv2-MIB::sysName
svn path=/trunk/; revision=49774
2013-06-04 20:05:16 +00:00
29d51623c2
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8762 :
...
Remove dead code (condition can never happen).
svn path=/trunk/; revision=49743
2013-06-04 01:38:53 +00:00
5e408534c8
cc1: warnings being treated as errors
...
../../asn1/nbap/packet-nbap-template.c: In function 'add_hsdsch_bind':
../../asn1/nbap/packet-nbap-template.c:349: warning: unused parameter 'tree'
svn path=/trunk/; revision=49708
2013-06-03 04:25:31 +00:00
7fe5422c4b
Convert ASN.1 dissectors to use filterable expert info.
...
NOTE: Kerberos ASN.1 template was updated, but not generated to source.
svn path=/trunk/; revision=49707
2013-06-03 03:42:36 +00:00
d7638de9b7
Also notify CMAS alerts
...
svn path=/trunk/; revision=49685
2013-06-01 23:27:16 +00:00
c553280339
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8745 :
...
Upgrade AP-title ASN.1 description
svn path=/trunk/; revision=49684
2013-06-01 23:10:37 +00:00
d41ce46c92
Make Earthquake and Tsunami Warning Sytem indications stand out a
...
bit more.
svn path=/trunk/; revision=49683
2013-06-01 22:26:47 +00:00
c310bd7dcc
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8744 :
...
Display C12.22 Invocation Id as unsigned integer
svn path=/trunk/; revision=49682
2013-06-01 20:51:14 +00:00
813dcf79a1
Don't intentionally use -1 as an hfindex: while only naughty before, with the
...
changes from r49644 you'll get complaints about the hf being unregistered...
Note that this code also intentionally passes -1 as an ett_index. It doesn't
currently complain so I'm leaving it alone for now...
svn path=/trunk/; revision=49648
2013-05-31 02:27:40 +00:00
3a80080fe9
Add some info to make it easier to see when SI config changes:
...
- show systemInfoModification in info column (and expert info), also
show number of UEs paged
- add expert item when systemInfoValueTag changes
- for MIB, add SFN to info column
svn path=/trunk/; revision=49603
2013-05-28 22:11:56 +00:00
ec1ebf5dd8
From LI Hai via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8708 :
...
Add MAC-DATA support to TETRA dissector and other minor improvements
svn path=/trunk/; revision=49567
2013-05-24 20:55:42 +00:00
Michael Mann