PI_ERROR to PI_NOTE. (If FreeBSD's been living with the wrong behavior for
years then apparently it doesn't cause interop problems.)
svn path=/trunk/; revision=46401
(not very useful) but it means we'll also check the IPMI subparsers and
usb.c . (Yes, register.c could be split out into Yet Another Variable but
I'm not sure it's worth it...)
svn path=/trunk/; revision=46399
Improvements to BitTorrent DHT dissector
Fixed filtering on protocol "bt-dht".
Improved heuristics. Can probably be enabled by default now (but I'll let someone else make that decision).
Unexpected IP address (first packet in capture file) and binary "tokens" (packet 17) were incorrectly printed as UTF-8 strings.
Moved duplicate code into bencoded_string_length().
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8044
svn path=/trunk/; revision=46396
Looking at RFC 6424, the whole approach is unclear to me. We seem to read subtlv_type and _length only once and then do the while loop. Section 3.3 of RFC6424 says that there's a list of subtlvs, I'd expect type and length to be read in the while loop...
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8039
svn path=/trunk/; revision=46391
- prefs callback not needed;
- move proto_reg_handoff...() to the end of the file as per convention;
- reformat some log lines.
svn path=/trunk/; revision=46358
- create/use several extended value strings;
- remove unneeded #includes;
- remove unneeded code & variable initializers;
- convert "4 space tabs" to spaces;
- do some reformatting to use a consistent whitespace style.
svn path=/trunk/; revision=46347
Bluetooth: AVDTP: Fix initialization of codec and some
compiler warnings
If cannot obtain codec information by SetConfiguration/Reconfigure
use value "-1" to ensure that there will be no any stream dissected.
Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7893
svn path=/trunk/; revision=46342
I believe this fix addresses the remaining issues for Bug #6047.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6047
Also:
- Fix {-Wshadow] warning;
- Use tvb_get_ntoh24() in 2 places;
- Add ToDo comment about a TCP reassembly issue.
svn path=/trunk/; revision=46338
Check length of Slow Protocol OAM Vendor Specific Event Notification and add an expert info if it is not at least 2 bytes long
svn path=/trunk/; revision=46336
are like the non-TVB versions except that they take a TVB and an offset
instead of (frequently) a pointer into the TVB.
Calling tvb_get_ptr() before modifying the rest of the fields should help fix
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7960 (though I can't
reproduce that problem).
Replace a bunch of calls like:
SET_ADDRESS(..., AT_XXX, length, tvb_get_ptr(tvb, offset, length));
with:
TVB_SET_ADDRESS(..., AT_XXX, tvb, offset, length);
svn path=/trunk/; revision=46324
Don't store an AT_STRINGZ address in ep_ allocated memory: that memory is
freed before the addresses may be used. Use se_ memory instead (no, that's
not really ideal either).
It would appear that several other dissectors have the same problem.
svn path=/trunk/; revision=46320
https://www.wireshark.org/download/automated/captures/fuzz-2012-11-30-20336.pcap
(I can't reproduce the actual fuzz failure and this uninitialized-read
shouldn't have caused an out-of-memory condition--which is what the buildbot
said the problem with that capture was.)
Also stop marking a variable that is used as unused.
svn path=/trunk/; revision=46309
PATCH] USB: Add support for vendor_id/product_id,
bus_id/device_address and class/subclass/protocol tables
USB subdissectors can be decoded by class/subclass/protocol. If fail try vendor_id/product_id.
bus_id/device_address is intented to use by DecodeBy, so user can decode specified device as need.
Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032
svn path=/trunk/; revision=46306
Couple of coding style changes and fixes for:
warning: declaration of ‘k_frame_number’ shadows a previous local
warning: assignment discards qualifiers from pointer target type
Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032
svn path=/trunk/; revision=46304
The gsm rlcmac dissector truncates the 12 bit BSNs to 8 bits when storing them.
Fix this and the handling of BSN2 is refactored to clarify the difference between BSN2 (the stored value) and BSN2_offset (the value transferred at the air interface).
svn path=/trunk/; revision=46301
USB: Add support for vendor_id/product_id,
bus_id/device_address and class/subclass/protocol
tables
USB subdissectors can be decoded by class/subclass/protocol. If fail try vendor_id/product_id.
bus_id/device_address is intented to use by DecodeBy, so user can decode specified device as need.
Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032
svn path=/trunk/; revision=46283
Bluetooth: Add support for source/destination addresses
Within resolving devices names. Also make header file more generic,
packet-hci_h4.h renamed to packet-bluetooth-hci.h.
Part of:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5032
svn path=/trunk/; revision=46278
putting an "unused" variable (which was taken out in r24377) back in. This
time add a (bogus) "use" of the variable and explain why we're doing what
we're doing.
Use VALS() (in one case anyway) and PINFO_FD_NUM.
svn path=/trunk/; revision=46266
Also (for one or more of the files):
- create/use one or more extended variable strings;
- remove some uneeded variable initializers;
- reformat some long lines;
- reformat hf[] entries;
- convert apparent 4-space tabs to spaces;
- do some whitespace and formatting changes to use a consistent style.
svn path=/trunk/; revision=46265
time we start processing the MSTI messages and decrementing the copy;
it's a bit clearer, and may make it easier to avoid the "uninitialized
variable" problem.
svn path=/trunk/; revision=46257
Also:
- create/use several extended variable strings;
- remove some uneeded variable initializers;
- reformat some long lines;
- reformat hf[] entries;
- do some whitespace and formatting changes to use a consistent style.
svn path=/trunk/; revision=46253
- fix extensive use of expert...() under 'if(tree)'
- fix a [-Wshadow] warning;
- create/use several extended variable strings;
- "localize" some variable definitions;
- remove some uneeded variable initializers;
- do some whitespace and formatting changes to use a consistent style.
svn path=/trunk/; revision=46240
- create/use extended variable string;
- #if 0 unused value_string arrays (instead of marking with _U_);
- "localize" some variable definitions;
- remove some uneeded variable initializers;
- reformat hf[] entries;
- do some whitespace and formatting changes to use a consistent style.
svn path=/trunk/; revision=46236
Also:
- Create/use several extended value strings;
- Reformat hf[] array;
- Do various whitespace and formatting changes to use a consistent style.
svn path=/trunk/; revision=46222
Also:
- Create/use several extended value strings;
- Reformat hf[] array;
- Do various whitespace and formatting changes to use a consistent style.
svn path=/trunk/; revision=46210
Also:
- Create/use several extended value strings;
- Do various whitespace and formatting changes to use a consistent style.
svn path=/trunk/; revision=46205
Also: Do some minor whitespace and formatting changes.
-This line, and those below, will be ignored--
M dissectors/packet-bootp.c
M dissectors/packet-bssgp.c
M dissectors/packet-babel.c
svn path=/trunk/; revision=46191
Also:
- Add XXX comment about a line of code which does differently than apparently expected;
- Do some minor whitespace and formatting changes.
svn path=/trunk/; revision=46190
- Properly handle DataBlocks with optional fields at end;
- Fix a few field dissections;
General code cleanup;
- Remove almost all tests using tvb_length_remaining():
If there's not enough data available, just let an
exception be thrown.
- Fix a memory leak;
- Simplify code in various places.
- Add a reference to the (a ?) Microsoft spec for RDP.
Fixes Bug #7862 in a more complete manner than SVN #45566.
svn path=/trunk/; revision=46158
/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c: In function de_bssgp_son_transfer_app_id:
/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c:3173:12: error: variable next_tvb set but not used
[-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
svn path=/trunk/; revision=46125
Enhancement to support MPLS-TP FM and LI payloads as per RFC 6427 and RFC 6435
Fixed some errors found by checkapi, changed filter names to use
proto abbr.
svn path=/trunk/; revision=46084
- In de_bssgp_pdu_in_error() use current_offset isof 0.
- in function de_bssgp_ran_inf_error_rim_cont. Error rim
container doesn't have field rim sequence number. This field exists in the rest
of containers but not in this one. So I have removed this field.
In this function we have field pdu in error and this field is mandatory, not
optional
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8000
svn path=/trunk/; revision=46081
We hand the user data in a CR or CC packet to the subdissectors,
but don't tell the subdissectors that - do we need to?
We don't hand the data in an ED packet to the subdissectors -
should we, and do we need to tell them that it's an ED packet?
svn path=/trunk/; revision=46067
epan/exceptions.h; it crashes).
Try BER first, including both the test dissection and the check of the
results. If that fails due to an exception being thrown, or due to the
results not indicating that it's a BER-encoded T.125 packet, try PER, so
that if the BER dissection doesn't work we don't just give up.
Get rid of some _U_s attached to parameters that are, in fact, used.
svn path=/trunk/; revision=46066
ReportedBoundsError exceptions when attempting to dissect the first bit
of the packet and, if either is thrown, assume the packet isn't a packet
for what we were trying to dissect, rather than just completely failing.
Return TRUE if the heuristic T.124 dissector recognizes the packet.
Get rid of some _U_s attached to parameters that are, in fact, used.
svn path=/trunk/; revision=46064
Also simplify a hash function - haven't measured collisions, but before
change sometimes wrong results would get attached. Don't think I fixed
it, and don't understand how equality function could have matched even
if hash function were colliding...
svn path=/trunk/; revision=46063
the source and destination address lengths and data, and adding them in,
rather than by copying those fields to a fixed-size static buffer - that
gets rid of a global variable (global variables considered harmful), and
also means that we don't try to copy 24 bytes of length+address from
packets that don't *have* 24 bytes of length+address (which caused
exceptions to be thrown on some OSI captures I have).
Construct some LI #defines out of other LI #defines, to make it a bit
clearer why they have the values they do.
Support the "additional information related to the clearing of the
connection" variable part parameter of the COTP DR packet (which just
means giving it a name, as its contents are user-defined - some HP-UX
OSI stack appears to just stick in a string saying that it's said
stack).
Make the code that decodes the variable part of a DR packet look like
the code that decodes the variable part of most other packets.
For COTP CR packets, determine the class up front by checking whether
the length is > 2. (At some point we might want to associate a class
indication with the COTP connection, if we see the connection setup,
and, if we have that indication, use it in preference to the
heuristics.)
Make the code to handle various length indicator values in the ATN case
more like the code in the non-ATN case.
Dissect the variable part of COTP ER packets.
Fix tpyos (TDPU->TPDU, tdpu->tpdu) and typpoes (accross->across).
Clean up white space.
svn path=/trunk/; revision=46060
through a clause in a switch statement to the following clause (that's
what /* FALLTHROUGH */ is for - it was originally a comment to tell lint
not to complain about the lack of a break statement).
Use guint8 rather than guchar for an 8-bit binary value.
Add a comment noting the weird stuff Microsoft does with RDP atop ISO
COTP atop TPKT.
svn path=/trunk/; revision=46052
calc_checksum() doesn't return a Boolean, it returns a cksum_status_t,
which has more values than just "checksum OK" and "checksum not OK",
such as "not enough data available to check the checksum).
Fix typoes (Transport Protocol Data Unit is TPDU/tpdu, not TDPU/tdpu).
svn path=/trunk/; revision=46051
the OSI connectionless network protocol is both ISO 8473 and
ITU-T Recommendation X.233;
the OSI connection-oriented transport protocol is both ISO 8073
and ITU-T Recommendation X.224;
the OSI connectionless transport protocol is both ISO 8602 and
ITU-T Recommendation X.234.
(Yes, this means that the "X.224" dissector we have is redundant, as we
have an OSI transport protocol dissector already.)
svn path=/trunk/; revision=46050