Commit graph

68 commits

Author SHA1 Message Date
Martin Mathieson
899c936d3f Add some missing RFC references to header long text.
svn path=/trunk/; revision=20652
2007-01-31 17:42:45 +00:00
Tomas Kukosa
c5a0dfda69 make SIP TCP/TLS ports configurable via preferences
svn path=/trunk/; revision=20392
2007-01-11 10:10:03 +00:00
Martin Mathieson
55905b7bf3 Make Expires header value a numeric field
svn path=/trunk/; revision=20309
2007-01-04 17:56:17 +00:00
Martin Mathieson
d9da45e31e Dissect details of RAck header, and change RSeq to a numerical field.
svn path=/trunk/; revision=20271
2007-01-02 17:06:00 +00:00
Guy Harris
303082812e From Sebastien Tandel: fix places where a signed character was being
passed to ctype.h macros.

Make some routines in packet-exec.c not used outside that file static,
and fix a typo.

svn path=/trunk/; revision=20222
2006-12-26 22:56:35 +00:00
Anders Broman
bb3b431776 Prepare to decode Q.850 REASON.
svn path=/trunk/; revision=20056
2006-12-06 22:08:32 +00:00
Martin Mathieson
3c9a154750 Via param name copy-paste error
svn path=/trunk/; revision=20047
2006-12-05 14:20:55 +00:00
Anders Broman
34a2c27714 Add hf fields for the latest headers from IANA.
svn path=/trunk/; revision=20030
2006-12-01 18:49:09 +00:00
Jörg Mayer
dd26a7021b nikai@nikai.net:
Remaining fixes from:
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225

svn path=/trunk/; revision=19895
2006-11-14 20:32:29 +00:00
Martin Mathieson
49a3e2a6e5 Dissect Via header
svn path=/trunk/; revision=19364
2006-09-29 17:35:23 +00:00
Martin Mathieson
473347e064 Dissect sequence number & method name of CSeq header.
svn path=/trunk/; revision=19336
2006-09-27 12:49:00 +00:00
Martin Mathieson
133e459384 Make Content-Length and Max-Forwards fields uints
svn path=/trunk/; revision=19259
2006-09-19 17:40:24 +00:00
Tomas Kukosa
539102ca60 - new function ssl_dissector_delete()
- register H.225.0 over TLS (configurable port 1300)
- register SIP over TLS (fixed port 5061)
- new function proto_tree_get_root()

svn path=/trunk/; revision=19059
2006-08-28 07:05:02 +00:00
Martin Mathieson
6a6a108f5d Add an expert item to indicate unrecognised SIP headers. Useful for finding:
- encoding problems or use of exotic extensions in equipment
- headers missing from the SIP dissector

svn path=/trunk/; revision=18829
2006-08-03 14:51:45 +00:00
Gerald Combs
8e5bdb964d Pass tvb_format_text() through a format string, in case it returns any
"%" characters.

svn path=/trunk/; revision=18600
2006-06-28 20:30:42 +00:00
Anders Broman
0bf4780bf2 From Martin Mathieson:
Fix Bug 976

Looking at frame 170 in the trace, it looks like 
tvb_get_ephemeral_text() struggles with the null character in the middle 
of the 4th parameter (in the WWW-Authenticate header) and returns NULL.  
The attached patch uses tvb_format_text() instead which also does a 
better job of showing the string.

svn path=/trunk/; revision=18589
2006-06-27 22:04:35 +00:00
Jaap Keuter
036661ed3d Somewhat improve heuristic when SIP is encapsulated in another protocol.
svn path=/trunk/; revision=18531
2006-06-21 17:57:10 +00:00
Anders Broman
581f2e92aa From Martin Mathieson:
This version of the patch won't look for the authentication scheme (it 
just skips that part for Authentication-Info headers).  I tested it 
using the enclosed file (pasted from the RFC and fed through 
od/text2pcap, then messed around with so I could test the other new 
parameters, even if they don't really belong in that header...).

svn path=/trunk/; revision=18244
2006-05-29 18:13:55 +00:00
Ronnie Sahlberg
feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Anders Broman
e4f01d2051 From Martin Mathieson:
> > This patch adds a hidden 'sip.auth' field, that will be present 
> > whenever one of the authenticiation/authorization headers is 
> > present.
> >
> > I believe this is one place where hidden fields are justified:
> > - it is a substring of several sip.auth.* fields, so its reassuring 
> > to see the field turn green as you're typing in one of the visible 
> > fields
> > - it lets you quickly find all of the frames with any of these fields
> > (there are 4 different SIP headers that can contain the auth fields)

svn path=/trunk/; revision=17766
2006-03-30 05:02:06 +00:00
Lars Roland
e810b7a424 - dissect sip headers properly when they are extended over multiple lines
- skip white space characters, including CR and LF on various places (not complete yet, but better than before)

svn path=/trunk/; revision=17665
2006-03-18 20:28:40 +00:00
Lars Roland
87e4a20bbb Make some string comparisons case insensitive in the sip dissector
svn path=/trunk/; revision=17662
2006-03-18 04:40:11 +00:00
Lars Roland
fc81794dc9 based on a patch from Martin Mathieson:
- dissection of SIP headers containing credentials and challenges.

from me:
- add filter fields for some missing related parameters from RFC 3261
- improve calculation of parameter length.

This implements enhancement request (bug id 812)

svn path=/trunk/; revision=17660
2006-03-18 03:23:26 +00:00
Guy Harris
11d6f896b8 Squelch a compiler warning.
svn path=/trunk/; revision=17455
2006-03-03 10:14:27 +00:00
Anders Broman
2d6b49599e From Martin Mathieson:
This patch adds the SIP History-Info header from RFC4244.

svn path=/trunk/; revision=17429
2006-02-28 17:40:01 +00:00
Jaap Keuter
32dfb9b404 Fix bounds error.
svn path=/trunk/; revision=17412
2006-02-25 13:54:00 +00:00
Anders Broman
aeb971fa5d From Martin Mathieson:
This patch further tightens up testing for resent packets.
It now always compares the method.  I've seen examples where the called 
party hangs up, and chooses the same CSeq for the BYE as the calling 
party chose for the INVITE.

svn path=/trunk/; revision=17408
2006-02-25 09:23:10 +00:00
Luis Ontanon
009b5f7d29 From ENDOH Akira:
Add heuristic dissection of XML to SIP bodies with unknown media_type.


svn path=/trunk/; revision=17247
2006-02-11 00:13:23 +00:00
Anders Broman
098fcb0d2b Use dissect_sip_tcp_heur for TCP to make re-assembly work on hueristics.
svn path=/trunk/; revision=16379
2005-11-02 20:24:42 +00:00
Ronnie Sahlberg
a3ddb4994a remove a strcpy
svn path=/trunk/; revision=16335
2005-10-27 09:14:07 +00:00
Ulf Lamping
9a42ef9536 fix #480: Change defaults for all reassembling settings to ON
I've changed all settings I could find to TRUE. It might be reasonable to change some protocol settings back to FALSE, if reassembling fails very often.

svn path=/trunk/; revision=16048
2005-09-28 22:15:38 +00:00
Ulf Lamping
853067c739 bugfix: break out of an endless loop, if dissect_sip_common() returns 0 or -2, found in a file send to me by david martin in an attempt to fix #372
svn path=/trunk/; revision=15926
2005-09-21 10:22:14 +00:00
Guy Harris
c4b2c971fc In "dissect_sip()", return 0 if "dissect_sip_common()" returns a
negative value, so we reject the packet as "not SIP".

Add a "dissect_sip_tcp_heur()" that's heuristic - it'll return FALSE if
the first packet doesn't look like SIP, but once it's dissected one
packet it'll just treat subsequent SIP packets as continuations if they
don't look right.

Clean up indentation a bit.

svn path=/trunk/; revision=15752
2005-09-10 19:39:56 +00:00
Tomas Kukosa
cd88fb82d8 SIP reassembly using req_resp_hdrs_do_reassembly()
svn path=/trunk/; revision=15709
2005-09-07 10:08:13 +00:00
Tomas Kukosa
92015a695f reassembly improvements
svn path=/trunk/; revision=15699
2005-09-06 10:38:25 +00:00
Guy Harris
459327da14 Include "packet-tcp.h" to declare tcp_dissect_pdus().
svn path=/trunk/; revision=15692
2005-09-05 21:21:29 +00:00
Tomas Kukosa
03a6f6286b the first attempt at SIP reassembly
svn path=/trunk/; revision=15685
2005-09-05 13:25:49 +00:00
Ronnie Sahlberg
9e7dbe202b ememify sip and at the same plug a memleak
every single time the sip dissector was called   a 32byte or larger blob was g_malloced and never freed.
this not only leaks 32+ bytes + g_malloc bookkeeping overhead  but also fragments memory so the real leak of memory is likely much bigger.


fix  bad memleak


svn path=/trunk/; revision=15354
2005-08-14 06:00:20 +00:00
Ronnie Sahlberg
3f0f7e1d3f gmemchunk -> se_alloc() improvements
svn path=/trunk/; revision=15318
2005-08-12 21:29:06 +00:00
Ronnie Sahlberg
ec3ab9ec3e rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the documentation in README.developer
svn path=/trunk/; revision=15270
2005-08-10 13:41:13 +00:00
Jörg Mayer
69dcb66cd9 More char -> const char warning fixes
svn path=/trunk/; revision=15218
2005-08-05 00:23:22 +00:00
Jörg Mayer
7b2ff03d8c Fix more "no previous declaration" warnings
svn path=/trunk/; revision=15169
2005-08-02 04:31:42 +00:00
Anders Broman
fbb92df9f4 Get rid of an unused variable.
svn path=/trunk/; revision=15082
2005-07-26 09:25:46 +00:00
Luis Ontanon
60ae91aa5e Avoid leaking tap info by using emem allocators
svn path=/trunk/; revision=15075
2005-07-25 23:54:02 +00:00
Guy Harris
38c139dce3 Squelch a compiler warning (GCC 4.0's data flow analysis is
interprocedural, so it knows "sip_parse_line()" doesn't always set
"*token_1_len", but it doesn't know that if it doesn't return OTHER_LINE
it *does* always set it, so it's safe not to set it as long as it's
never used if the return value is OTHER_LINE).

svn path=/trunk/; revision=14355
2005-05-12 02:55:59 +00:00
Lars Roland
9a47db0c3d Add another sanity check to the new SIP URI parser.
Just to be sure.

svn path=/trunk/; revision=14335
2005-05-09 01:21:41 +00:00
Lars Roland
74328742ed Some fixes for the new SIP contact header parser.
svn path=/trunk/; revision=14334
2005-05-09 01:15:45 +00:00
Lars Roland
5f092fe201 Mark a function parameter as unused
svn path=/trunk/; revision=14332
2005-05-08 23:29:55 +00:00
Lars Roland
01f10ccd00 When saying that I remove the trailing white spaces I should do it, too.
So I do it now and do some more reindentation, too.

svn path=/trunk/; revision=14331
2005-05-08 22:39:38 +00:00
Lars Roland
e5134e2f2d Improve dissection of SIP contact header and counting of bindings in REGISTER messages.
Introduce a function for disseting a sip uri in general

TODO: 
- add dissection of contact and uri parameters
- simplify the ugly code for dissecting "to" and "from" headers
      by using the new function for uri dissection

svn path=/trunk/; revision=14330
2005-05-08 22:19:18 +00:00