Commit Graph

4552 Commits

Author SHA1 Message Date
Anders Broman 6265ac771c Start dissecting H.263 according to RFC 4629.
svn path=/trunk/; revision=20949
2007-02-28 21:46:06 +00:00
Anders Broman 12fd61a5de Add a missing OPTIONAL.
svn path=/trunk/; revision=20948
2007-02-28 21:10:25 +00:00
Luis Ontanon e8c5d47e26 SCTP TSN analysis part 1.
Up and running.
As it is analysis will stop at TSN rollover (0xffffffff->0x00000000).

And It will start to misbehave when a TSN is seen again in the same half association (that's a case where an out-of-memory error will probably had happened before).

It still needs testing.

svn path=/trunk/; revision=20947
2007-02-28 14:09:25 +00:00
Luis Ontanon bef1c99feb fix Bug 1407
as per bug 1406 actual values aren't raw bytes, they are BER encoded octet strings.


svn path=/trunk/; revision=20944
2007-02-27 10:47:58 +00:00
Luis Ontanon b1d91e4d2b fix Bug 1406:
it looks like 1 byte parameters are ber encoded integers, not raw data.

svn path=/trunk/; revision=20943
2007-02-27 10:27:05 +00:00
Jeff Morriss 01a71d7277 Some minor readability enhancements to the (still disabled) sequence analysis: use PROTO_ITEM_SET_GENERATED() on all the new fields and change hf_sctp_dup_ack's description to indicate that it's showing you the frame number of the previous ack.
svn path=/trunk/; revision=20942
2007-02-27 10:02:28 +00:00
Ronnie Sahlberg bf87640840 add PIDL friendly helper to manage unicode strings
svn path=/trunk/; revision=20941
2007-02-27 09:37:48 +00:00
Anders Broman bcdcace17b From Daniel Krüger:
I attached a patch to this dissector, which includes some corrections, updates and SDO by UDP support. I will upload a sample capture of SDO by UDP to the wiki. The patch is fuzzy tested against the current SVN rev under Linux and it builds also under MSVC2005.

svn path=/trunk/; revision=20937
2007-02-27 06:54:41 +00:00
Guy Harris 219a24a642 The type argument to dnp3_al_obj_quality() isn't taken from the packet,
so invalid type arguments are programming errors; check for them with
DISSECTOR_ASSERT().

Fix a call to use the right value from the packet.

The dissector is a new-style dissector, so register it as such.

svn path=/trunk/; revision=20930
2007-02-25 21:57:23 +00:00
Luis Ontanon 83682b6a5f I'm checking in what I got so far for TSN analysis.
It's disabled. To enable uncomment the preference, recompile and enable it from preferences.

I checking it in because I need it as a reference.

svn path=/trunk/; revision=20929
2007-02-25 18:22:08 +00:00
Ulf Lamping 7887d478cc add a new function dissect_dcom_HRESULT_item() for some more flexibility, use it in the CBA-ACCO dissector - as the value_strings from dcom can't be used in hf_register_info from a plugin
svn path=/trunk/; revision=20926
2007-02-25 15:48:43 +00:00
Ronnie Sahlberg 66cf1f33e0 add new flag for PIDL conformance files : PIDL_SET_COL_INFO
which applies (for now only) to integer types.
when this flag is specified as PARAM_VALUE the fields name and its value will be pushed onto the info column of the summary line



svn path=/trunk/; revision=20922
2007-02-25 11:48:06 +00:00
Luis Ontanon 0743cac9a4 remove warnings
svn path=/trunk/; revision=20921
2007-02-25 11:23:49 +00:00
Luis Ontanon 679cf729d3 + some cosmetic changes to package dissection.
+ add more Q.1950 packages and parameters

svn path=/trunk/; revision=20920
2007-02-25 10:13:49 +00:00
Ronnie Sahlberg 470e92125e move the defines for PIDL_POLHND_{OPEN|CLOSE} to packet-dcerpc.h
also change their values to use the top order bits of an uint32 instead of the least significant ones



svn path=/trunk/; revision=20919
2007-02-25 01:47:43 +00:00
Ronnie Sahlberg aa3d3793b7 add new PIDL friendly helpers for dissection of integer types.
these new helpers take a parameter that can be used to decorate the tree and summary line (when this parameter is acted upon/implemented in the code inside the helpers)

WINREG was regenerated using a patched version of PIDL. Mainline version of PIDL does not yet have this patch applied.



svn path=/trunk/; revision=20918
2007-02-25 01:34:41 +00:00
Ronnie Sahlberg 87f05b8bda update EFS and EVENTLOG conformance files to use the new defines
for when policy handles are opened/closed and regenerate the dissector
with the latest version of PIDL



svn path=/trunk/; revision=20917
2007-02-24 21:34:29 +00:00
Anders Broman 7a615b9729 Add basic support for RFC4585.
svn path=/trunk/; revision=20916
2007-02-24 17:31:55 +00:00
Luis Ontanon 215b7eecc5 have sdp ignoring useless caracters efore the first element (this is a hack to avoid the two spaces found before the v= in sdp messages embeded in h248/q1950)
svn path=/trunk/; revision=20913
2007-02-24 12:24:13 +00:00
Stephen Fisher fe0e340bff From Mark Lewis:
The current RTP/MPEG2 Transport Stream dissector has a bug. When both
Adaptation Field and Payload are present in a packet (AFC==3) the
payload is ignored and Wireshark marks the packet as malformed.
This patch to epan/dissectors/packet-mp2t.c fixes the problem.


svn path=/trunk/; revision=20910
2007-02-23 21:31:11 +00:00
Luis Ontanon 46956317e2 I unadvertedly checked in this one, it adds tsn analysis to sctp which is still broken (although it is disabled by default).
Revert to previous version.

svn path=/trunk/; revision=20909
2007-02-23 21:12:25 +00:00
Luis Ontanon 4211d0dba2 fix some bugs introduced in the latest releases and add value_strings for param, evt, sig and stat ids s well as "sub-parameters".
svn path=/trunk/; revision=20908
2007-02-23 20:57:22 +00:00
Luis Ontanon 13c9782e21 remove another hidden item
svn path=/trunk/; revision=20905
2007-02-23 19:47:02 +00:00
Luis Ontanon 1600480f1b Wow!
hidden fields appear twice defeating the purpose, that's what I call deprecating a function!! 

svn path=/trunk/; revision=20902
2007-02-23 19:26:09 +00:00
Luis Ontanon 9a2d0d9511 add hidden fields for mtp3.dpc mtp3.opc mtp3.pc to m3ua so that if someone filters by mtp3.pc can get both m2ua and m3ua packets directed towars a caertain pc.
svn path=/trunk/; revision=20901
2007-02-23 19:04:41 +00:00
Jaap Keuter 1d60ad8ce7 From Morro Roberto:
Please find attached a patch to the RSVP dissector that fixes a small inaccuracy when printing the SENDER TSPEC object.
Substantially, it changes the string
"C-type: 1 - Integrated Services" into the correct one
"C-type: 2 - Integrated Services"

svn path=/trunk/; revision=20900
2007-02-23 15:22:24 +00:00
Anders Broman 4098c5e357 From Charles Lepple:
When dissecting RTP packets with a H.263 payload, the "Mark" flag runs into the Mode A/B flag in the info column.

From me abriviate Payload type to PT.

svn path=/trunk/; revision=20899
2007-02-23 06:47:07 +00:00
Anders Broman 33910c713f From Richard van der Hoff:
Along with this bug, identified by Mark, there is another problem, in that one of the chunks of my earlier patch seemed to get missed off when Anders committed it. This won't break anything yet, as the H.223-over-RTP dissection hasn't landed on trunk yet, but it will cause all sorts of nasties when it does.

Here is a new patch, against current trunk, which should fix Mark's bug, my bug, and a comment typo.

And a patch wich improves the general robustness of the h.223 dissector (making it less likely to crash on malformed data).

Hopefully this also fixes a bug raised by Fabio Sguanci a few weeks ago. 
Fabio: I think a better way to fix the problem is to stop the dissector crashing when it finds a malformed PDU, so that it just treats the first pdu as malformed; there is then no need to special-case it.

svn path=/trunk/; revision=20898
2007-02-22 20:40:19 +00:00
Bill Meier 211cdda386 From Ryan Wamsley: Add Connection Configuration Object support to EtherNet/IP dissector
svn path=/trunk/; revision=20897
2007-02-22 03:21:26 +00:00
Ronnie Sahlberg 4fb922c2c8 regenerate WINREG as a test with the some new PIDL enhancements to show ithe name of the iprocedure a policy handle was created in.
also
fix some mistakes in the conformance file for when handles are opened/created


svn path=/trunk/; revision=20896
2007-02-21 20:23:44 +00:00
Ronnie Sahlberg 8ed1260c2c add a field in pinfo where dcerpc/pidl can store the name of the current dcerpc procedure
use this field in the policy handle helper to indicate not only which frames the handle was opened/close in but also the name of the function that opened it.
eventually, when other pidl support infrastructure is developed it would be nice if this could be expanded to also contain the name of the object/handle opened.



svn path=/trunk/; revision=20895
2007-02-21 20:21:11 +00:00
Anders Broman f34fa9c0ef From Richard van der Hoff:
This patch makes the defragmentation code in the iax2 dissector handle 
pinfo->desegment_len=DESEGMENT_ONE_MORE_SEGMENT, in line with
Ronnie's changes to the tcp dissector of 11 November.

svn path=/trunk/; revision=20892
2007-02-21 06:48:28 +00:00
Anders Broman 86671a0de0 From Richard van der Hoff:
Here's a patch which adds an option enabling subdissectors to request defragmentation of packets over RTP streams, using the 
pinfo->desegment_{len,offset} API.

svn path=/trunk/; revision=20891
2007-02-21 06:45:34 +00:00
Stephen Fisher 2d334be55d Major overhaul of VNC dissector: split everything into its own function and
bring the server message type dissection nearly to completion.  As for RealVNC
protocol dissection, the only things not working at 100% is the TCP
reassembly and some ZRLE subencoding types.  However, it is is much more useful
shape now than before.
 

svn path=/trunk/; revision=20886
2007-02-21 00:59:16 +00:00
Luis Ontanon da3cc2efa8 + add some more packages from 3GPP TS 29.232
- fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1385


svn path=/trunk/; revision=20885
2007-02-21 00:00:49 +00:00
Anders Broman 33c97b6a1f Get rid of yet another printout that does not go well with optional IE:s
svn path=/trunk/; revision=20884
2007-02-20 22:12:54 +00:00
Anders Broman fd3aa71e67 Test before comitting...
svn path=/trunk/; revision=20883
2007-02-20 21:58:30 +00:00
Ronnie Sahlberg dd7323f981 dont use _U_ when typedeffing a function pointer.
gcc 2.96 does not like _U_ here.



svn path=/trunk/; revision=20882
2007-02-20 20:21:49 +00:00
Uwe Girlich 19fd47b805 DTPT: Improve Blob handling, more error codes
svn path=/trunk/; revision=20881
2007-02-20 20:07:50 +00:00
Anders Broman 0c0367bfa1 Fix a typo and some reported compiler warnings(hopefully).
svn path=/trunk/; revision=20879
2007-02-20 19:40:14 +00:00
Anders Broman 564fd0fa57 From Florent Drouin:
This patch provide a new function to decode messages when several ASN1 encoding can be used.
This is the case, for example, when a same message has different encoding according to the MAP version, or in case of ASN1 encoder optimization.
 At the same time, I did remove the configuration variable "old_gsm_map_version", which is taken into account in the patch.
And likewise, for all the messages defined with the ASN1 sequence "[3] SEQUENCE", this function is called for the decoding.

svn path=/trunk/; revision=20878
2007-02-20 19:37:06 +00:00
Jörg Mayer 27c1729f0e Update to current version of openchange
svn path=/trunk/; revision=20877
2007-02-20 19:19:57 +00:00
Ronnie Sahlberg 83c66c05e9 add a PIDL specific helper for managing dissection of policy handles.
let this helper take a parameter to describe how the policy handle should be
managed (is this an open, close ?) to improve policy handle tracking.
(centralizing to a single function of code makes other changes easier)

create defines to indicate OPEN/CLOSE and use them as a start/test in the winreg conformance file.



svn path=/trunk/; revision=20872
2007-02-20 09:01:50 +00:00
Ronnie Sahlberg 0dfc6a0bf7 changes to comments generated for winreg using the latest svn of pidl
pidl will probably be in flux for a short while and this checkin is to reduce the some noice generated to winreg while other changes are implemented.

this change only affects c-code comments in the pidl generated code


svn path=/trunk/; revision=20871
2007-02-20 08:05:26 +00:00
Gerald Combs 5ddc9ab395 Clarify the description of frame.time_delta. This partially addresses
bug 491.

svn path=/trunk/; revision=20870
2007-02-20 01:32:14 +00:00
Stephen Fisher 7a2bfb7a61 Initial version of the new Statistics -> Content List -> HTTP feature. This
feature lists all of the content found in an HTTP stream (images, http, etc.)
and displays it in a list that allows the user to save each one as a file that
is already reassembled by the dissectors.


svn path=/trunk/; revision=20867
2007-02-19 22:37:45 +00:00
Bill Meier 103bf29730 Continuing the tradition: squelch some compiler warnings ....
svn path=/trunk/; revision=20866
2007-02-19 22:29:23 +00:00
Jeff Morriss 0787b688cc Squelch a few unused parameter warnings.
svn path=/trunk/; revision=20863
2007-02-19 15:30:06 +00:00
Ronnie Sahlberg 1401a27b06 the policy handles created/opened in CreateKey and OpenKey are now called "handle" and not "new_handle"
update the conformance file so the correct functions are loaded with the correct PARAM value to signal "in this frame, this policy handle was created"



svn path=/trunk/; revision=20857
2007-02-19 08:26:27 +00:00
Anders Broman 7164abe385 Decode some RANAP elements.
svn path=/trunk/; revision=20854
2007-02-19 06:09:33 +00:00