osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity
40,612 Commits 23 Branches 0 Tags 1.3 GiB
Commit Graph

40612 Commits

Author SHA1 Message Date
Guy Harris d231102428 Note that packet_range_calc() and packet_range_calc_user() can be 
painfully slow with a large capture.

svn path=/trunk/; revision=42763
 2012-05-22 02:37:32 +00:00
Jeff Morriss 7755747797 Finish fixing https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7270#c4 : 
Revert r42758 as it only helps in one case; rather, fix it correctly: if
we're redissecting or refiltering, clear any frame dependencies as we go
along.  (Fortunately, frame dependencies are all forward dependencies--
meaning that a given frame can only be depended upon by a later frame--
so we can do this as we rescan the packets/frames.)

svn path=/trunk/; revision=42762
 2012-05-22 01:59:34 +00:00
pascal a65518fe55 Fix indentation 
svn path=/trunk/; revision=42760
 2012-05-21 21:49:11 +00:00
pascal 6a1470ffc9 From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7267 : 
Add dissector function for SPB link metric sub tlv (type 29)

svn path=/trunk/; revision=42759
 2012-05-21 20:51:22 +00:00
Jeff Morriss 33c9fa1f30 Partial fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7270#c4 : 
Clear the dependent_of_displayed flag when there's no dfilter.  This only
helps the case when you clear a display filter before moving on to another
display filter.

svn path=/trunk/; revision=42758
 2012-05-21 19:44:24 +00:00
pascal 0ba1ab2909 Display Element ID in hexadecimal (like in 3GPP specs) 
Display EPS bearer ID in decimal

svn path=/trunk/; revision=42755
 2012-05-21 19:27:38 +00:00
Bill Meier bc55ee0616 Fix "Function call argument is an uninitialized value" issue found by scan-build. 
(It seems to me that this issue would rarely, if ever, actually occur).

Also:
- Use val_to_str_const() as appropriate;
- Localize some variables;
- Remove unneeded initializers;
- Do some parenthesizing;
- Use a consistent formatting style;
- Do whitespace cleanup.

svn path=/trunk/; revision=42754
 2012-05-21 18:25:29 +00:00
Jeff Morriss 1828c71743 Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7270 : 
Don't mark frames as dependent upon a displayed frame unless the (supposedly)
displayed frame is actually displayed.  (Fix to r41214 <sigh>.)

svn path=/trunk/; revision=42752
 2012-05-21 17:09:15 +00:00
Bill Meier 78a170a506 Cleanup whitespace; 
Reformat hf[] entries.

svn path=/trunk/; revision=42748
 2012-05-21 16:12:56 +00:00
Bill Meier a729320b0a Init some variables to prevent scan-build "Function call argument is an uninitialized value" messages. 
(Not actually a bug due to the way the code works ?)

svn path=/trunk/; revision=42747
 2012-05-21 15:56:26 +00:00
Bill Meier b2b8fae93c Init a pointer to prevent a (not actually valid) scan-build "Function call argument is an uninitialized value" msg 
Also:
 - #if 0 out some unused hf[] entries;
 - use val_to_str_const() in a few places;
 - remove some unneeded initializers;
 - do col_set_str()/col_clear() before referencing tvb;
 - reformat hf[] entries;
 - Fix whitespace (4-space tabs, etc).

svn path=/trunk/; revision=42746
 2012-05-21 15:06:24 +00:00
Bill Meier 78f3be74bf Additional cleanup: 
- use #if 0/#endif to comment out code(instead of /* ...*/
- remove unused #define
- replace col_clear()/col_add() by col_set()

svn path=/trunk/; revision=42745
 2012-05-21 14:25:27 +00:00
Bill Meier 6718bfd047 From Evan Huus: Unused Prefs registration; 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7273

From me: whitespace cleanup;

svn path=/trunk/; revision=42744
 2012-05-21 14:02:40 +00:00
Bill Meier b4519deb91 Fix some indentation. 
svn path=/trunk/; revision=42743
 2012-05-21 13:18:57 +00:00
Jakub Zawadzki 1d510f0616 Improve Gadu-Gadu dissector (part III) 
svn path=/trunk/; revision=42742
 2012-05-21 13:07:33 +00:00
pascal d6381b4123 From Evan Huus via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7271 : 
Remove useless null check

svn path=/trunk/; revision=42741
 2012-05-21 09:37:58 +00:00
pascal f09a30ea93 Add packet-sync.c to epan\CMakeLists.txt 
svn path=/trunk/; revision=42740
 2012-05-21 09:18:39 +00:00
Anders Broman 26d431148c From David Wei: 
fix for Higher bitrates than 16 Mbps flag.

svn path=/trunk/; revision=42739
 2012-05-21 08:21:26 +00:00
Anders Broman fec821f303 From Evan Huus: 
Fix Three memory leaks and a bad if-condition, as caught by CppCheck.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7272

svn path=/trunk/; revision=42738
 2012-05-21 07:42:09 +00:00
Anders Broman 35dd3b052e Use new_register_dissector. 
svn path=/trunk/; revision=42737
 2012-05-21 07:34:20 +00:00
Anders Broman 36cd403381 From Michael Mann: 
Check for enabled XML dissecto.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6625
xmpp decoder crashes when xml is disabled

svn path=/trunk/; revision=42736
 2012-05-21 07:28:13 +00:00
Anders Broman 4684cb30f4 From David Wei: 
New dissector for MBMS synchronisation protocol.

svn path=/trunk/; revision=42735
 2012-05-21 07:11:36 +00:00
Bill Meier 7d3f69262d Whitespace cleanup; 
svn path=/trunk/; revision=42734
 2012-05-21 02:20:53 +00:00
Bill Meier e3ea682270 General cleanup: 
- 4-space tabs, trailing whitespace, etc
- use a consistent formatting style
- ...

svn path=/trunk/; revision=42733
 2012-05-21 02:13:49 +00:00
Bill Meier ca4a51873e Prevent (what seems to me to be) a possible null pointer dereference. 
svn path=/trunk/; revision=42732
 2012-05-21 01:00:12 +00:00
Jörg Mayer d40cea2e7b Two cases where gcc has problems to detect that a specific specific 
variable may not be used uninitialized.

svn path=/trunk/; revision=42731
 2012-05-21 00:23:13 +00:00
Bill Meier 0b6c88942b Fix 'unused parameter' warning. 
svn path=/trunk/; revision=42730
 2012-05-21 00:20:09 +00:00
Anders Broman c5d3f8c2ba Set up conversations for more channel types 
svn path=/trunk/; revision=42729
 2012-05-20 21:24:18 +00:00
pascal 254fcdfe19 Upgrade NAS dissector to Release 10 (v10.6.1) 
svn path=/trunk/; revision=42728
 2012-05-20 20:56:42 +00:00
Jakub Zawadzki 42ec0ca701 Revert r35131 fix bug #5738 
g_unichar_isprint() is for *wide characters*.
For UTF-8 multibyte characters we could 
use g_utf8_validate() and g_utf8_next_char(),
but IMHO format_text_* should be ASCII-only.

We rather need to store encoding of FT_STRING[Z]
and in proto_item_fill_label() call appropiate
function.
For ENC_ASCII use format_text(),
for unicode (ENC_UTF*, ENC_UCS*) use format_text_utf(),
etc..

svn path=/trunk/; revision=42727
 2012-05-20 18:32:44 +00:00
Gerald Combs feeed92f95 [Automatic manuf, services and enterprise-numbers update for 2012-05-20] 
svn path=/trunk/; revision=42724
 2012-05-20 14:03:32 +00:00
Michael Tüxen 2250389193 Make the compiler happy. 
svn path=/trunk/; revision=42723
 2012-05-20 10:57:12 +00:00
pascal 774748914f Upgrade NAS EPS dissector to Release 10 (10.6.1) 
svn path=/trunk/; revision=42722
 2012-05-20 09:50:34 +00:00
Guy Harris 4a9b825c49 Change the "user_saved" member of a capture_file structure to 
"unsaved_changes", and have it be TRUE iff changes have been made to the
file since it was read - *not* if it's a temporary file from a live
capture.

Check the "is_tempfile" member, and the "unsaved_changes" member, when
appropriate.

Just have a set_toolbar_for_capture_file() routine that updates the
"save", "close", and "reload" toolbar as appropriate, given a
capture_file structure - absorb the function of
set_toolbar_for_unsaved_capture_file() into it.

svn path=/trunk/; revision=42721
 2012-05-20 08:56:06 +00:00
pascal acc2a3706b Fix RVALS() macro usage 
svn path=/trunk/; revision=42720
 2012-05-19 19:05:36 +00:00
Bill Meier a297af9d64 Add an 'if' test to prevent a potential null pointer dereference 
identified by clang scan-build.


svn path=/trunk/; revision=42719
 2012-05-19 17:21:32 +00:00
Bill Meier 576fcd2a47 Rework 'ct_nb_switch_page_cb()' slightly to prevent a scan-build "null pointer de-reference" message; 
(In practice, the "null pointer de-reference" would not actually occur ?).

svn path=/trunk/; revision=42718
 2012-05-19 16:55:22 +00:00
Bill Meier 12ba85a2a4 Rework proto_registrar_dump_protocols() to prevent a Clang scan-build "de-reference of a null poiunter" warning 
(In practice, bug would not actually occur).

svn path=/trunk/; revision=42717
 2012-05-19 16:07:50 +00:00
pascal cf0d560849 Use col_append_sep_str instead of col_append_str 
svn path=/trunk/; revision=42716
 2012-05-19 16:06:12 +00:00
Bill Meier 91e5923458 Fix some "warning: Value stored to '...' is never read" clang scan-build warnings. 
Also; Do some whitespace cleanup in a few cases.

svn path=/trunk/; revision=42715
 2012-05-19 14:20:55 +00:00
Jakub Zawadzki 63d6b6bf2a Z_BLOCK was added in zlib-1.2.0.5 
Pass Z_NO_FLUSH to inflate() when Z_BLOCK is not defined,
just in case also disable fast seeking when it's not defined.

References: http://www.wireshark.org/lists/wireshark-dev/201205/msg00145.html 

svn path=/trunk/; revision=42714
 2012-05-19 13:27:43 +00:00
pascal 7bbbb88068 From Thomas Loockx via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7269 : 
Add BGP MDT-SAFI dissection (RFC6037)

svn path=/trunk/; revision=42713
 2012-05-19 12:32:10 +00:00
pascal 20793cc947 From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7262 : 
Digest details display issue in SPB Digest subtlv (ISIS hello pdu)

svn path=/trunk/; revision=42712
 2012-05-19 10:35:43 +00:00
Jakub Zawadzki aaa9b34c86 Improve Gadu-Gadu dissector and fix some comments. 
svn path=/trunk/; revision=42711
 2012-05-19 07:57:45 +00:00
Anders Broman 8499bf8b8e Fix the DCH data collection for conversation setup 
svn path=/trunk/; revision=42710
 2012-05-19 06:20:05 +00:00
Jakub Zawadzki 3bb88a972b Improve Gadu-Gadu dissector. 
svn path=/trunk/; revision=42709
 2012-05-18 17:43:48 +00:00
Jeff Morriss 5c0dfb9e8e There's no need to include Custom.common here; it gets pulled in by Makefile.common 
svn path=/trunk/; revision=42708
 2012-05-18 17:19:50 +00:00
Jeff Morriss af87b31852 Allow custom dissectors in automake too. 
svn path=/trunk/; revision=42707
 2012-05-18 16:20:36 +00:00
Guy Harris fb8054f131 Expand a comment. 
Clear the struct sigaction *before* we fill in any fields in it.

svn path=/trunk/; revision=42706
 2012-05-18 04:06:35 +00:00
Guy Harris 60637d4b70 When saving packets, fill in hdr.presence_flags from the flags in the 
frame_data structure; there's no guarantee that the wtap_pkthdr in the
wtap structure reflects the current packet.

svn path=/trunk/; revision=42705
 2012-05-18 03:31:50 +00:00