Commit Graph

2302 Commits

Author SHA1 Message Date
Ulf Lamping 6244dc8ec9 fix a simple GTK1 warning
svn path=/trunk/; revision=16595
2005-11-25 23:54:19 +00:00
Ulf Lamping 5d66658184 from Greg Morris:
Composite Expert statistics, see: 
http://www.ethereal.com/lists/ethereal-dev/200511/msg00002.html
and the following discussions

svn path=/trunk/; revision=16593
2005-11-25 23:42:52 +00:00
Jörg Mayer eff40f65db Trivial warning fixes
svn path=/trunk/; revision=16561
2005-11-22 12:51:14 +00:00
Guy Harris 2f7fd680e2 Handle "-G" only in Tethereal - it doesn't work in Ethereal, and isn't
necessary there.

Add a "cmdarg_err()" routine to report command-line option errors; it
creates a console if necessary, and prints the command name and the
trailing newline.  Also add "cmdarg_err_cont()", which also creates a
console if necessary, and prints a trailing newline but no command name;
it's used to continue the message.  Use those, rather than
"g_warning()", for errors.

That means that we no longer need to pass the command name to various
command-line argument parsing routines.

svn path=/trunk/; revision=16526
2005-11-17 05:59:21 +00:00
Guy Harris ff10d1c217 Don't list "-B" on UN*X - it's not available there.
On Windows, show it using the same usage-message syntax as other
options.

Clean up the usage message.

When doing the "pre-scan" of command-line arguments, suppress error
messages - that suppresses bogus messages for GTK+ command-line flags,
and gets rid of double messages for other errors.

svn path=/trunk/; revision=16521
2005-11-17 04:10:31 +00:00
Ulf Lamping 32b71d9b7e hmmm, buggy bugfix
capture_child isn't initialized already here, so remove the whole error reaction check for now

svn path=/trunk/; revision=16517
2005-11-16 22:08:50 +00:00
Ulf Lamping 8b24e8d8f0 the "pre-scan" of the command line parameters shouldn't stop the capture child. The child uses a slightly different parameter pattern, so this isn't an error here. Fixes the reported capture problem
svn path=/trunk/; revision=16516
2005-11-16 21:46:24 +00:00
Guy Harris 0dbf17b690 Allow a progress dialog to have "Stop" or "Cancel" as the "terminate
button"; "Stop" should be used for operations that can only be stopped
(meaning that what it's already done isn't undone), not cancelled
(meaning that whatever it's already done *is* undone), for which
"Cancel" is used.

Allow the merging process to be cancelled.

Clean up indentation.

Update some comments.

svn path=/trunk/; revision=16489
2005-11-12 11:05:02 +00:00
Guy Harris 177dc6902c Skip some toolbar #includes if we're not using GTK+ 2.x.
svn path=/trunk/; revision=16454
2005-11-10 03:00:43 +00:00
Guy Harris 03ac44a500 Remove comment that no longer applies.
If we get a getopt() error in the pre-scanning, quit - don't do all the
GUI stuff and re-scan the arguments (and print the error message twice).

svn path=/trunk/; revision=16443
2005-11-09 08:46:24 +00:00
Ulf Lamping c3187174bf replace *a lot* of file related calls by their GLib counterparts. This is necessary for the switch to GTK 2.6 (at least on WIN32).
to do this, I've added file_util.h to wiretap (would file_compat.h be a better name?), and provide compat_macros like eth_open() instead of open(). While at it, move other file related things there, like #include <io.h>, definition of O_BINARY and alike, so it's all in one place.

deleted related things from config.h.win32

As of these massive changes, I'm almost certain that this will break the Unix build. I'll keep an eye on the buildbot so hopefully everything is working again soon.

svn path=/trunk/; revision=16403
2005-11-06 22:43:25 +00:00
Anders Broman 2916d12d76 Packet-amr Register as "AMR" not "amr".
Add Dynamic PT:s mimestring  to rtp_info if avalable.
Use Dynamic PT:s mime string to find clock rate.

svn path=/trunk/; revision=16397
2005-11-05 21:38:22 +00:00
Guy Harris 542381825f Get rid of no-longer-used code (the list of plugins is now just a tab in
Help->About, not a separate dialog from Help->About Plugins).

svn path=/trunk/; revision=16385
2005-11-03 04:32:11 +00:00
Anders Broman bd8e72aa0a From Jaap Keuter
Improvments to PCMA and PCMU handling-

svn path=/trunk/; revision=16356
2005-10-29 15:34:16 +00:00
Guy Harris eb7e8111c6 Fix uninitialized variable errors.
Rename some variables to make the names used in progress bars more
common.  (Should more of that functionality be moved into common
progress bar code?)

svn path=/trunk/; revision=16347
2005-10-27 20:18:50 +00:00
Guy Harris 6ed8c9a07b Make the processing of "-z" arguments in the Tethereal I/O stat tap more
like that of the Ethereal I/O stat tap.  Improve error messages in both
taps.

Use nstime() routines and structure assignment to do operations on
nstime_t values.

svn path=/trunk/; revision=16346
2005-10-27 19:42:24 +00:00
Guy Harris 0203c65739 Check on every iteration of a loop whether to pop up a dialog box,
rather than checking only on every progress bar update quantum, so that
if the update quantum is *very* large, we don't end up waiting longer
than the standard time for a dialog box before checking.

svn path=/trunk/; revision=16327
2005-10-27 06:45:37 +00:00
Ulf Lamping fe17843002 bugfix: don't crash the file open dialog, if the preview gets confused by "invalid" timestamps.
The localtime call will return NULL on invalid input which results in a NULL pointer exception. Simply print '?' if localtime returned NULL.

svn path=/trunk/; revision=16317
2005-10-26 08:32:21 +00:00
Gilbert Ramirez 0b3c9ad5ce Revert 16279.
svn path=/trunk/; revision=16281
2005-10-21 13:11:04 +00:00
Gilbert Ramirez 385fb3eea2 From Greg Morris.
Expert data must perform a re-dissection to trigger the NCP dissector.
Change the call cf_retap_packets() to cf_redissect_packets().

svn path=/trunk/; revision=16279
2005-10-20 18:07:03 +00:00
Gilbert Ramirez c5db51da2d From Greg Morris, patch to allow proper search/filtering of
NCP conversations.

svn path=/trunk/; revision=16278
2005-10-20 18:04:11 +00:00
Gilbert Ramirez 05bdac4d3a From Greg Morris.
Adds NCP data to conversations and SRT.

svn path=/trunk/; revision=16269
2005-10-19 14:45:24 +00:00
Ulf Lamping fab07a94e0 don't show the "stopping currently running capture" dialog, as the packet list seems to have problems updating the screen, so some ugly artefacts remain on the screen.
after I've fixed a bug in the Win32 capture stop mechanism some days(?) before (which speeds up that stopping a lot), this dialog isn't really needed

svn path=/trunk/; revision=16257
2005-10-17 19:46:29 +00:00
Ulf Lamping fafdf68095 from Richard van der Hoff:
Attached is a patch which makes the console log level (warning/message/debug etc) a configurable preference. There's no gui for setting it, but since it's pretty much only going to be useful for developers, I'm sure you'll cope...
----
I've added a small comment to the file output that it has no dialog output

svn path=/trunk/; revision=16205
2005-10-12 21:26:27 +00:00
Ulf Lamping 9759510199 fix the link to the online users-guide
svn path=/trunk/; revision=16169
2005-10-09 00:01:13 +00:00
Ulf Lamping e01a43a9bf minor bugfix: while closing a capture file, update the packets statusbar *after* closing the file
svn path=/trunk/; revision=16150
2005-10-07 04:26:29 +00:00
Ulf Lamping 4443681a9e fix Ethereal so command line capture parameter will work with kilobytes (again)
remove Byte(s) from the dropdown list of filesizes, this doesn't make sense
replace 1000 with 1024, as all (modern?) file managers are based on 1024 bytes for a kilobyte (the old KB vs. KiB controversy)

svn path=/trunk/; revision=16149
2005-10-07 03:34:27 +00:00
Ulf Lamping bb5e5d6ce1 fix a packet_list_freeze / thaw pair, if a return comes in it's way
add a g_warning() call if an error occured while reading from capture file (while doing a live update), usually shouldn't happen but is difficult to debug *if* it happens
add a new log domain LOG_DOMAIN_MAIN and the standard log handler for it
add some (partly commented out) g_log() calls, useful for GUI sequence debugging

svn path=/trunk/; revision=16136
2005-10-06 00:55:21 +00:00
Ulf Lamping ec98957e13 fix 369: we must do some more GUI stuff in capture_update_started(),
as GUI state get's cleared while switching to the next "multiple file" because of a call to cf_close()

svn path=/trunk/; revision=16134
2005-10-05 23:56:36 +00:00
Ulf Lamping aa7a238a42 fix cant_load_winpcap_err() parameter
svn path=/trunk/; revision=16123
2005-10-05 06:05:35 +00:00
Guy Harris bfcbcfb4ea Add a "capture_errs.c" routine to cough up error messages for capture
problems, and use the first routine in it in multiple places.

Get rid of DISSECTOR_SUPPORT_INCLUDES - just add its contents to
ETHEREAL_COMMON_INCLUDES.

svn path=/trunk/; revision=16109
2005-10-04 06:25:01 +00:00
Guy Harris 62948d4d6b Properly terminate some value_string tables.
svn path=/trunk/; revision=16098
2005-10-03 22:26:32 +00:00
Guy Harris 7ff9b98428 Include "gui_stat_menu.h" to declare "register_stat_menu_item()".
Fix the type of "t38_analysis_init()" to match what
"register_stat_cmd_arg()" expects.

svn path=/trunk/; revision=16097
2005-10-03 22:23:04 +00:00
Ulf Lamping 8b696f70b8 Win32: don't crash if Capture/Start is clicked and WinPcap is not installed.
svn path=/trunk/; revision=16093
2005-10-03 20:04:06 +00:00
Ulf Lamping e0e8cb76a3 move the list down to the latest message while new messages rush in. We might want to have a checkbox or alike to en/disable this (as discussed for the Statistics) lately.
svn path=/trunk/; revision=16092
2005-10-03 19:37:17 +00:00
Ulf Lamping d24ce3d4ad major Win32 bugfix: when getting messages from the capture slave, only one message was processed every 200ms (UNIX handles this differently). If more messages were initiated from the slave, they stacked up. This slowed down the display update and slowed down stopping the capture as a lot of messages had to be processed before the close really finished ...
Now the timer callback function will call the pipe read function up to 5 times to avoid this, but won't do this more often to prevent "endless blocking".

svn path=/trunk/; revision=16091
2005-10-03 19:34:58 +00:00
Ulf Lamping 5851cd1694 minor bugfix: hide main widgets, if command line file couldn't be loaded
svn path=/trunk/; revision=16090
2005-10-03 19:11:57 +00:00
Luis Ontanon ee804fcb5a This one was missing from the checkin...
svn path=/trunk/; revision=16077
2005-10-03 11:36:24 +00:00
Anders Broman 15a08ae521 From Alejandro Vaquero:
New "Fax T38 Analysis" added to the "Statistics" menu to:

- Reassemble the HDLC t30 frames and dissect the header.
- Analyze the UPDTLPacket seq num for packet lost
- Stats of V.x Data:
    - Count the Data bytes
    - Duration
    - Wrong seq num
    - Max Burst of packet lost

svn path=/trunk/; revision=16073
2005-10-03 05:55:26 +00:00
Ulf Lamping 347398ee6f code cleanup: use the prefix packet_list_ for every function mentioned in packet_list.h
svn path=/trunk/; revision=16027
2005-09-27 21:51:08 +00:00
Ulf Lamping d415c719ae fix #322, 2nd try: don't pass NULL to gtk_tree_iter_free(), this seems to cause an assert on some GTK versions
svn path=/trunk/; revision=16011
2005-09-26 19:24:06 +00:00
Ulf Lamping d3d18948b5 compiler warning removed
svn path=/trunk/; revision=16006
2005-09-26 07:08:42 +00:00
Ulf Lamping fa1647d9a6 fix #322: packet detail window -> Protocol Preferences: tree not expanded
also removed global notebook value

svn path=/trunk/; revision=16004
2005-09-25 22:46:49 +00:00
Ulf Lamping e34467a28c disable gzip output compression for now, as it won't work in some cases (see source commment for details)
svn path=/trunk/; revision=15981
2005-09-23 18:50:07 +00:00
Ulf Lamping ba1c5f49d5 do freeze/thaw in packet_list_set_selected_row only, if the list must be moved. This avoids some screen flickering.
svn path=/trunk/; revision=15965
2005-09-22 21:14:39 +00:00
Luis Ontanon 35bd5bd854 Instead of checking if this is a new packet at every call to avoid recounting the packets at every rerun remove the tap listener of this stats tree.
fixes bug 474

svn path=/trunk/; revision=15960
2005-09-22 17:01:06 +00:00
Ulf Lamping a7a1077bb5 fix 467: when using -k command line option, convert interface name display string ("user_description: devicename" from Preferences) into device name. Hopefully this won't break the UNIX version.
svn path=/trunk/; revision=15943
2005-09-21 20:33:12 +00:00
Ulf Lamping 8efa36ee51 fix #465: replace all fprintf(stderr, ...) with g_warning(...) calls
svn path=/trunk/; revision=15942
2005-09-21 20:27:32 +00:00
Ulf Lamping a8ef1df32b fix/add doxygen comments
svn path=/trunk/; revision=15941
2005-09-21 20:11:55 +00:00
Ulf Lamping 512a4983c0 fix a copy/paste error inside of a comment
svn path=/trunk/; revision=15940
2005-09-21 20:08:32 +00:00