Commit Graph

2094 Commits

Author SHA1 Message Date
Roland Knall 0e64e9f3ca extcap: Allow loading of extcap files from personal directory
Allow the storage of extcap plugins in the personal directory and
enable loading from there. It will also take precedence of any
system-wide extcaps with an identical name

Change-Id: Ib88e09a26c4f99cf5e793327f2808c7445c6b1b5
Reviewed-on: https://code.wireshark.org/review/34988
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05 16:57:09 +00:00
Roland Knall a802000a2e Qt: Allow action buttons to be left-aligned
Buttons can be left-aligned in the display filter edit bar, by selecting
the corresponding option from the context menu

Bug: 14123
Change-Id: I18b48bb0ea43a598b2e309dcad9210463be06414
Reviewed-on: https://code.wireshark.org/review/34980
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05 16:56:33 +00:00
Roland Knall a218460e22 Qt: IOGraph display filter graph added
Add a graph for the currently display filter if none exists, upon
opening IOGraph

Change-Id: Ic25b014484898dd1917b13f2616fd519e2e8183b
Reviewed-on: https://code.wireshark.org/review/34984
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-05 15:50:50 +00:00
Roland Knall a8052b9f38 Qt: Coloringrules Mime is encoded as JSON
Encode coloring rules as json objects to avoid encoding issues

Change-Id: I4b5369fef3c0f9e73cbb08edf14de6535ff35026
Reviewed-on: https://code.wireshark.org/review/34947
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-04 13:09:52 +00:00
Roland Knall 013e87a8fd Qt: Remove DisplayFilterMimeData
Make the mimetype for the display filter more generic, so that external
programs can attach to Wireshark and users can drag and drop display
filters to the program

Change-Id: Id78b4dff7883e3dab879a31aad07f577d8cc4ee3
Reviewed-on: https://code.wireshark.org/review/34936
Reviewed-by: Roland Knall <rknall@gmail.com>
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-04 11:39:48 +00:00
Huang Qiangxiong 0b0bbb8060 HTTP2/gRPC: Support streaming mode reassembly
If working in streaming RPC mode, many grpc messages will be
contained in one http2 stream, the stream will end very late
(for example ETCD watch stream).

So we could not rely on old http2 reassembly mode which call
sub-dissector only END_STREAM appeared. We need a reassembly
mode that call subdissector which support streaming mode as
soon as the message in STREAM is available.

Please refer to comments of
reassemble_http2_data_according_to_subdissector() function
of epan/dissectors/packet-http2.c for more detail.

See the linked bug for streaming mode gRPC capture files.

Ping-Bug: 16160
Change-Id: Id9e5337a0e3ca9f8c8119d74d2c1fe4cc263afc3
Reviewed-on: https://code.wireshark.org/review/23988
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-03 16:43:39 +00:00
Roland Knall accd563aaf Qt: Consolidate mimedata usage
Ensure, that all mimedata uses similar mimetypes and document
the mimetypes being used throughout wireshark

Change-Id: I7c02d0a5e12a823153640e600051abb95d58cdeb
Reviewed-on: https://code.wireshark.org/review/34923
Petri-Dish: Roland Knall <rknall@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03 15:45:34 +00:00
Gerald Combs 530c30e8a8 Docs: Try to make our "drag and drop" usage more consistent.
Apple uses "drag and drop" and "drag-and-drop":
https://developer.apple.com/design/human-interface-guidelines/macos/user-interaction/drag-and-drop/
https://support.apple.com/guide/mac-help/drag-and-drop-items-mh35852/mac
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/DragandDrop/DragandDrop.html

So does Microsoft:
https://docs.microsoft.com/en-us/windows/win32/com/drag-and-drop

Qt and KDE use "drag and drop":
https://doc.qt.io/qt-5/dnd.html
https://docs.kde.org/stable5/en/applications/konsole/drag-and-drop.html

GTK+ and GNOME uses "drag-and-drop"
https://developer.gnome.org/gtk-tutorial/stable/c1899.html

Wikipedia uses "drag and drop" and "drag-and-drop"
https://en.wikipedia.org/wiki/Drag_and_drop

Let's go with "drag and drop" (and "dragging and dropping") in the
release notes and User's Guide.

Change-Id: I5010478e5d15928a3a8a7528296c3f5cdc98f3ab
Reviewed-on: https://code.wireshark.org/review/34921
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-03 13:15:33 +00:00
Gerald Combs dc3cdf87a5 Release notes: We're building with VS 2019 on Windows.
Change-Id: I5fd3f6546419aa5906cbc3def2be175989fa0e4b
Reviewed-on: https://code.wireshark.org/review/34858
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-25 16:11:32 +00:00
Moshe Kaplan 9d6551f3fd WSUG: fix <= escaping
Change-Id: I06ddd372ae51580bc9010db1f3bf32f69360d2f7
Reviewed-on: https://code.wireshark.org/review/34798
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-19 11:34:18 +00:00
Moshe Kaplan 42683fbd94 WSUG: Update enabled protocols image
Change-Id: I78042220df3de00e11f5e9a514365150e6ca7de6
Reviewed-on: https://code.wireshark.org/review/34799
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-18 05:17:19 +00:00
Gerald Combs e76f518913 Release notes: Remove an item.
The recent macOS installer changes were backported to master-3.0, so
they're no longer new in master.

Change-Id: I357e0f8facbc2266c3780bcf8d696b5c2b00602d
Reviewed-on: https://code.wireshark.org/review/34745
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-10-08 18:04:32 +00:00
Moshe Kaplan 930aa328dd WSUG: Clean up opening sentences
Change-Id: I7c1443459f5705a1a087dfe3e3af8c3826dc1f08
Reviewed-on: https://code.wireshark.org/review/34727
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-10-08 06:31:41 +00:00
Moshe Kaplan 67d5c58bd2 WSDG: Fix duplicate 'the the'
Change-Id: Iaa383391daa6deb569852fe4bb464f7cda3658dd
Reviewed-on: https://code.wireshark.org/review/34726
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-08 03:58:17 +00:00
Moshe Kaplan cb7dafbcf6 WSUG: Clean up duplicated words
Used egrep "\b([a-zA-Z]+) \1\b" docbook/wsug_src/*.adoc to find instances
where words were erroneously duplicated.

Change-Id: Ie390fa4f1c61a288ff0ed77aa84c4fb01f4de27e
Reviewed-on: https://code.wireshark.org/review/34725
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-08 03:57:49 +00:00
Huang Qiangxiong 5750c4981c protobuf: add support for Protocol Buffers Language (*.proto) files
1. A C-style Protocol Buffers Language (PBL) parser for *.proto file is added.
It contains protobuf_lang_scanner.l (lex scanner), epan/protobuf_lang.y (grammar
parser), and protobuf_lang_tree.h/c (grammar tree implementation).

2. The protobuf-helper.h/cpp is an interface wrapper layer. If one day C++ is allowed,
we can create a protobuf-helper.cpp file, which using offical protobuf C++
library, to replace protobuf-helper.c. That keeps packet-protobuf.c unchanged.

3. User can specify protobuf search paths, and the UDP ports to protobuf message type
maps at the Protobuf protocol preferences.

4. Other dissectors can pass the message type to Protobuf dissector by data parameter
or pinfo->private_table["pb_msg_type"] (pinfo.private["pb_msg_type"] in lua).

Some Sample of GRPC with Protobuf captures can be found in Bug: 13932.

Bug: 13932
Change-Id: Ife16c2f7b381296f8db4740dabe5f8362a456f48
Reviewed-on: https://code.wireshark.org/review/22892
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-07 10:35:52 +00:00
Peter Wu d2a660d805 QUIC: Add Follow QUIC Stream support to Qt and tshark
The QUIC transport protocol provides a stream, similar to HTTP/2. Make
it possible to look at the stream contents. This can be helpful while
HTTP/3 support is not yet complete.

Known issues that will be addressed in the future:

 - If a single packet contains multiple streams, then Follow QUIC Stream
   will wrongly include data from streams other than the selected one.
   This is tracked by bug 16093 and affects HTTP/2 as well.

 - The Substream index menu does not properly filter for available
   stream numbers. If a non-existing stream is selected, then changing
   to another (potentially valid) index results in the "Capture file
   invalid." error. As workaround, clear the display filter first.

 - Follow Stream always selects Stream ID 0 instead of the first or
   currently selected stream field in a packet. Users should manually
   update the stream index as needed.

Change-Id: I5866be380d58c96f0a71a29abdbd1be20ae3534a
Ping-Bug: 13881
Reviewed-on: https://code.wireshark.org/review/34694
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-04 04:36:09 +00:00
Gerald Combs 160f525e2c Docbook: Update macOS packaging.
Update the macOS packaging sections to reflect current reality.

Change-Id: I6795787c0d4d3c9a85da14bdb69a31fc74e9ddf2
Reviewed-on: https://code.wireshark.org/review/34624
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-26 19:51:53 +00:00
Dr. Lars Völker 3aeaf5c6fc SOMEIP: Adding support for the SOME/IP protocol.
The Scalable service-Oriented MiddlewarE over IP (SOME/IP) is the
standard communication middleware for IP and Ethernet based
communication. It supports Service Discovery, RPC, Pub/Sub, and more.

Bug: 16014
Change-Id: Ifd6549818ccc87f376a5fb9ba1d6c335818c6e00
Signed-off-by: Dr. Lars Völker <lars.voelker@bmw.de>
Reviewed-on: https://code.wireshark.org/review/34497
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-26 04:01:33 +00:00
Gerald Combs ac4f3c0f4d macOS: Make Wireshark.app drag-installable.
Create ChmodBPF installer and uninstaller packages using pkgbuild and
productbuild. Place them in Wireshark.app/Resources/Extras.

Add a path_helper installer and uninstaller which respectively add and
remove /etc/*paths.d/Wireshark.

Remove the PackageMaker and utility-launcher assets and build targets.

Show a message in the main welcome screen if we don't have capture
permissions. Add an link which launches the ChmodBPF installer.

Add a "macOS Extras" item to About → Folders.

Migrate "Read me first" from RTF to Asciidoctor, which lets us add links
and looks like our other documentation.

Rename dmg_set_style.scpt to arrange_dmg.applescript and make it plain
text. Always run it in osx-dmg.sh.

Bug: 6991
Bug: 12593
Bug: 11399
Ping-Bug: 16074
Change-Id: I7b6aa89aae2be522b4141b0d44e8142dec749e90
Reviewed-on: https://code.wireshark.org/review/31047
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-25 16:26:31 +00:00
Alexander Gryanko 9fff62e2a8 Qt, http2: Add Follow HTTP/2 Stream functionality
The HTTP/2 protocol multiplexes a single TCP connection into multiple
independent streams. The Follow TCP output can interleave multiple
HTTP/2 streams, making it harder to analyze a single HTTP/2 stream.

Add the ability to select HTTP/2 Streams within a TCP stream.
Internally, the HTTP/2 dissector now stores the known Stream IDs in a
set for every TCP session which allows an amortized O(n) lookup time for
the previous/next/max Stream ID.

[Peter: make the dissector responsible for clamping the HTTP/2 Stream ID
instead of the Qt code, that should permit future optimizations.]

Change-Id: I5d78f29904ae8f227ae36e1a883155c0ed719200
Reviewed-on: https://code.wireshark.org/review/32221
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexander Gryanko <xpahos@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-09-22 05:29:30 +00:00
Peter Wu 29be7f9d9a Qt, docs, ieee1905: fix some spelling errors
The spelling error for "Desription" in the context menu was very
obvious. The others were found by scanning the output of:

    grep -Po '<source>\K.*(?=</source>)' wireshark_en.ts

Change-Id: I4b95236c82f76828a115d59d7c8e0b853eae1d26
Reviewed-on: https://code.wireshark.org/review/34582
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-09-21 08:33:58 +00:00
Gerald Combs 655f7442ae WSDG: Add an "or".
Change-Id: I3f068dcdf4b7df1e54a742ccf55983aae200eba5
Reviewed-on: https://code.wireshark.org/review/34550
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-16 22:47:54 +00:00
Gerald Combs 72eb4e5b26 WSUG: Packet list and detail context menu updates.
Update some of the packet list and detail context menu items.

Add a release note entry noting the new Apply/Prepare behavior and
update some other items.

Change-Id: I3c2336a3f438f2d97bdb4df764e2af78a3499d81
Reviewed-on: https://code.wireshark.org/review/34543
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-16 22:40:30 +00:00
Gerald Combs c8ce89111d WSDG: Visual Studio fixes.
Convert a single numbered list to a simple paragraph. Generalize a
reference to to the VS Community Edition in one place and fix the VS
version in another.

Start using one sentence per line as recommended at
https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line

Change-Id: Iaa2a830d6cdb034c8057e4a6c45935e65d1d387e
Reviewed-on: https://code.wireshark.org/review/34519
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-16 17:37:11 +00:00
Gerald Combs fb5a029e47 Docbook: Fixup our table delimiters.
Update our table delimiters to match the Asciidoctor documentation.

Change-Id: I87a6834f2889e175236aa609984a9bc4dd9d3b8e
Reviewed-on: https://code.wireshark.org/review/34544
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-09-16 17:35:49 +00:00
Gerald Combs 3bff8f372e WSDG: Updates for Visual Studio 2019.
Start recommending Visual Studio 2019.

Change-Id: I743844691baf6798f708aca48dd73da8d7fb6aeb
Reviewed-on: https://code.wireshark.org/review/34508
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-12 03:47:55 +00:00
Dr. Lars Völker d963b312d0 DLT: Adding support for the DLT protocol
The Diagnostic Log and Trace protocol (DLT) is a commonly used and
standardized protocol in the automotive industry used to retrieve
log data. This patch adds the protocol to Wireshark. Keep in mind
that ports have to be configured before the dissector can be used.

Change-Id: I24592705476fb0c3bb83a1cc10b3dae8867523f4
Signed-off-by: Dr. Lars Völker <lars.voelker@bmw.de>
Reviewed-on: https://code.wireshark.org/review/34462
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-10 03:56:28 +00:00
Moshe Kaplan f45ed90a4f WSUG: Update docs on working with captured packets
Change-Id: Ic411028e4026618471fa9933bea0b5a78875e049
Reviewed-on: https://code.wireshark.org/review/34414
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04 16:59:08 +00:00
Roland Knall d56ad090fb Qt: in EnabledProtocolsDialog handle protocol type
Allow a selection of the list based on the protocol type. That way
one can easily enable/disable for instance just heuristic protocols

Change-Id: I1ee8df5d9887c764272ec55b33703855c0c91f5a
Reviewed-on: https://code.wireshark.org/review/34442
Reviewed-by: Roland Knall <rknall@gmail.com>
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-04 06:45:00 +00:00
Guy Harris 286369a758 Clean up some formatting.
List syntax is *not* one of the more straightforward parts of AsciiDoc.

Change-Id: Icfed27de84c8c11cad02c4ba4d359786cd480eea
Reviewed-on: https://code.wireshark.org/review/34423
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-01 21:50:29 +00:00
Guy Harris 9ae6abdec9 Fix the section on Boolean fields to match reality.
Confusing though it might be, a patch-matching expression containing
only the name of a Boolean field matches all packets containing that
field, regardless of whether the field is true or false; you need to
compare the field against 1 to check whether it's true.

Change-Id: I615acc4d71964c8474e6f3655ade8814cbe07b22
Reviewed-on: https://code.wireshark.org/review/34422
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-09-01 21:09:55 +00:00
Ido Schimmel a94a860c06 net_dm: Add dissector for drop monitor netlink packets
The Linux kernel includes a module called drop monitor which -
unsurprisingly - monitors packet drops.

Once enabled, the module will periodically send netlink notifications to
user space over generic netlink. Historically, these notifications only
included the program counter where the drop occurred and the number of
packets that were dropped in this location in the last interval.

Patches in net-next (queued for Linux kernel 5.4) extend drop monitor
with another mode of operation where the dropped packets themselves are
sent to user space along with relevant metadata as netlink
notifications. This allows users to perform a more detailed analysis of
the dropped packets.

This patch adds a dissector for these netlink packets. The dissector is
expected to be invoked by the generic netlink dissector and during its
hand off routine it adds an entry in the 'genl.family' dissector table.

The various netlink attributes are dissected by calling
dissect_netlink_attributes(), in a similar fashion to the rtnetlink
dissector. The dropped packet itself is encoded in the netlink attribute
'NET_DM_ATTR_PAYLOAD' and dissected by invoking a dissector from the
'sll.ltype' dissector table based on the packet's protocol which is
encoded in the 'NET_DM_ATTR_PROTO' attribute.

Bug: 16018
Change-Id: I10bfa4b9c9d8f5e82769c250f929f74693142a23
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-on: https://code.wireshark.org/review/34351
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-01 09:03:37 +00:00
Roland Knall 6e240e6727 Qt: Apply Invert/Enable/Disable only to selected list
Also, put the search field on top, as this is the default for search
fields and apply the change of enable/disable and invert-all only to
the selected items, instead of all items.

Bug: 16013
Change-Id: If4ef1c5ce63eef6fa72db679cdcbf52dcb0e8fb6
Reviewed-on: https://code.wireshark.org/review/34393
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-29 10:26:02 +00:00
Gerald Combs e9daf6ce51 WSUG: Clean up some menu item descriptions.
Summarize and clean up some of the menu item text. Start sentences on a
new line as recommended at
https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line,
although we wrap long lines.

Change-Id: I778f278d8503153ec649c3f0a4b2ccb24512e701
Reviewed-on: https://code.wireshark.org/review/34341
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-08-23 18:18:03 +00:00
Jaap Keuter 7519c077d0 WSUG: Update Control Protocol dissection chapter
With the design changes made in the Qt interface with respect to the
Deocode as dialogs the Users Guide content is confusing. Update the
graphics and text to accurately describe the current design. Update
references in other parts of the document too.

Change-Id: Iad6af555d2da3430230c7f176bf2ec1e808cc134
Reviewed-on: https://code.wireshark.org/review/34337
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-22 15:17:25 +00:00
Gerald Combs 646ff56fae doc+docbook: Add .guisubmenu.
Change-Id: I40ce4a26b0d8228cccca2904dc4c71f2c01b40ce
Reviewed-on: https://code.wireshark.org/review/34296
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-15 17:55:08 +00:00
Harald Welte b1412ab11d Add dissector for OsmoTRX protocol
This protocol is a non-standard, ad-hoc protocol to pass baseband GSM
bursts between the modem (osmo-trx) and the encoder / decoder
(osmo-bts-trx). Osmocom inherited this when forking OsmoTRX off the
OpenBTS "Transceiver" program.

Change-Id: I31f5071d08eff1731f1d602886e204c87eed107c
Related: OS#4081 (https://osmocom.org/issues/4081)
Bug: 14814
Reviewed-on: https://code.wireshark.org/review/26796
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-08-14 10:00:34 +00:00
Jaap Keuter fb42c24a2c User Guide: document dfilter_macros file
In the configuration files overview the dfilter_macros file was missing.
Add its description and slay a few typos on the way.

Bug: 15973
Change-Id: I381d0482ac13dce6ea1daf44300c74d3a1ff03fe
Reviewed-on: https://code.wireshark.org/review/34243
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-08-13 22:55:11 +00:00
Gerald Combs f5aaea0da9 doc+docbook: More CSS tweaks.
Change-Id: I16af6fec3eccf5e8516a1fbcfe269882493e41d0
Reviewed-on: https://code.wireshark.org/review/34260
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-12 23:07:20 +00:00
Gerald Combs 7af296d9fd doc+docbook: Add .guimenuitem.
Change-Id: I63f097576d3dd85425e6e44fbc1c46fd4305f3e7
Reviewed-on: https://code.wireshark.org/review/34254
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-12 18:43:40 +00:00
Gerald Combs 29febdc4f3 doc+docbook: Add .guibutton and .keycap rules.
Change-Id: I3499b97600ea3ad8e036a40f219e2a80693916ed
Reviewed-on: https://code.wireshark.org/review/34253
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-08-12 17:59:50 +00:00
Gerald Combs 8a0e22b4b9 doc+docbook: Update our CSS file.
Update ws.css by rebasing
https://github.com/geraldcombs/asciidoctor-stylesheet-factory against
the latest master at
https://github.com/asciidoctor/asciidoctor-stylesheet-factory and adding
a ".guimenu" rule.

Change-Id: I79532c18ffd036ba5a24b84a7eaa448231cbf7f0
Reviewed-on: https://code.wireshark.org/review/34225
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-12 04:07:39 +00:00
Guy Harris a41c7aa223 Update the set of buildbots to the current reality.
(That's the master and 3.0.x buildbots; the 2.6 Mac buildbot is running
an older version of Apple's UNIX-for-Macs - sufficiently older that
Apple's name for it was different back then.)

While we're at it, note that it's been updated past VS 2013.

Change-Id: I063daa7c38ff58aed0c77950d4265b5544783f2c
Reviewed-on: https://code.wireshark.org/review/34217
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-08-09 02:43:43 +00:00
Gerald Combs 545a3986fe Docbook: Document using middle-click to mark packets.
Add an item about marking packets using the middle mouse button to the
release notes.

Update the "Marking Packets" section of the User's Guide accordingly.

Use "menu:...[]" to mark up menu items in a bunch of places. It looks
like we need to a add a "guimenu" class to ws.css.

Change-Id: Ide99112f7643e509d8af8a4aa6ddb4287f3585cf
Reviewed-on: https://code.wireshark.org/review/34182
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-05 08:26:43 +00:00
Roland Knall f259187803 Qt: Update UI for profiles and handle export/import properly
This patchset ensures a 1:1 replacement of the old 3.0 version of the profiles
dialog. It is a major bugfix for the new version in case of handling creating/
deleting and adding profiles.

Delete can be performed on multiple profiles now, by selecting the profiles
which need to be deleted.

Import/Export functionality has been overhauled to follow these rules:

* No imports while changes are pending, due to datamodel sanity
* Export for Default Profile and Global Profiles is not possible
* Either all personal profiles can be selected or individually choosen ones
* Use last directory and store it properly
* Imports can be cancelled
* Only one import is allowed at a time (but it can contain as many profiles as needed)

Change-Id: Ie2fccd397202ec06976d764734437284f464409a
Reviewed-on: https://code.wireshark.org/review/34123
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-08-02 21:38:02 +00:00
Dario Lombardo d614865c8c docbook: fix infos and commands.
- Use apt instead of aptitude.
- Update example file name versions.
- Remove leading $ from command lines.

Change-Id: I888f6612615ac252c0c0b3f867bac36610ae3e51
Reviewed-on: https://code.wireshark.org/review/34110
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-07-30 07:56:13 +00:00
Gerald Combs ede4ecb8c8 [Automatic update for 2019-07-28]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Iae1d6218e2353d99569caaeff072f6691b7b817f
Reviewed-on: https://code.wireshark.org/review/34104
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-28 08:20:23 +00:00
Guy Harris 20800366dd HTTPS (almost) everywhere.
Change all wireshark.org URLs to use https.

Fix some broken links while we're at it.

Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c
Reviewed-on: https://code.wireshark.org/review/34089
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-26 18:44:40 +00:00
Gerald Combs 12e8b4edd3 3.1.0 > 3.1.1.
Change-Id: Idc7ab6cfe38cffa4053d0d8ce710cb95b33aa6ac
Reviewed-on: https://code.wireshark.org/review/34084
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-25 20:03:30 +00:00
Gerald Combs 414ca80b21 Build 3.1.0.
Change-Id: Iced73e36e00018ace596b671959bc087b3541765
Reviewed-on: https://code.wireshark.org/review/34082
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-25 18:47:24 +00:00
Gerald Combs 7122a8a53e Update the release notes for 3.1.0.
Change-Id: I85b2a8088e1968bd8e2fb707fe269e11fb2e0c90
Reviewed-on: https://code.wireshark.org/review/34078
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-24 22:50:25 +00:00
Moshe Kaplan b4c6b3981f WSUG: Corrected keyboard shortcuts for Edit Menu
Change-Id: Id65a56c179bdcf60772239f0f371efa4b79a652b
Reviewed-on: https://code.wireshark.org/review/34062
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-23 18:35:41 +00:00
Roland Knall 3a62b1bc75 Qt: Allow profile import from directory
To allow for easy import of profiles, one can select a directory
to import profiles from

Change-Id: I12f66e3dc6bd272d34baa76093152dce412b0158
Reviewed-on: https://code.wireshark.org/review/34038
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
2019-07-21 16:41:13 +00:00
Peter Wu c88e525168 Documentation: convert http URLS to https
Remove some dead links or point them to archive.org while at it. All
updated links have been verified.

Change-Id: Icf02167a13d5fe9dfce39ea57525b3f185554c9d
Reviewed-on: https://code.wireshark.org/review/34028
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-20 20:51:30 +00:00
Gerald Combs 8147af211d Editcap: Allow floating point split intervals.
Update the `-i` option to allow floating point values as suggested at
https://stackoverflow.com/questions/57004719/split-wireshark-to-miliseconds

Change-Id: I24028d409bc441ed3b45ac2179f7c42b2bc424bc
Reviewed-on: https://code.wireshark.org/review/33938
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-16 06:43:09 +00:00
Gerald Combs e5efd68d3b [Automatic update for 2019-07-14]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ia49e8d1cd5cefbcef6781a4abaab536b9547b4bf
Reviewed-on: https://code.wireshark.org/review/33929
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-07-14 08:20:51 +00:00
Jeremy Kerr eae522d9cc ncsi: Add NCSI dissector
This change adds a basic dissector for the Network Controller Sideband
Interface (NCSI), as described by DMTF specification DSP0222.

Change-Id: I4e98361bfb7315c524f9c90db38507892adeeebe
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Reviewed-on: https://code.wireshark.org/review/33818
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-03 08:55:02 +00:00
Moshe Kaplan f27c30c2a8 Add comments and reorder Lua example
Change-Id: Iabffbd43645914c92a98f45065ce3baee35d062f
Reviewed-on: https://code.wireshark.org/review/33825
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-03 03:46:51 +00:00
Dario Lombardo 1af6e1f860 tap: add credentials tap.
This new tap collects credentials (username and paassword)
from the dissectors.

So far, few dissectors have been instrumented:
- http (basic auth)
- http (header auth)
- ftp
Others can be instrumented as well using the same technique.

Tshark has a new option (-z credentials) and Wireshark a new
"tools" menu: the documentation has been updated accordingly.

Change-Id: I2d0d96598c85bb3ea4fb5ec090dd8dc28b481fc9
Reviewed-on: https://code.wireshark.org/review/33453
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@gmail.com>
2019-06-26 07:09:54 +00:00
Gerald Combs 94f497f929 Qt: Use a lighter link color in dark mode.
Add ColorUtils::themeLinkBrush, which returns a readable link color in
dark mode. Use it in place of existing ...palette().link() calls.

Add ColorUtils::themeLinkStyle, which produces an HTML <style/> block
that lightens the link foreground color in dark mode. Use this to style
links in the about box and in elided labels.

Catch ApplicationPaletteChange events where needed.

Add dark theme / dark mode notes to the WSDG.

Ping-Bug: 15511
Change-Id: I92925bd997f97b155491f55a8c818f03549bc7f4
Reviewed-on: https://code.wireshark.org/review/33704
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-06-25 20:31:41 +00:00
Dario Lombardo 7969c41519 Use I/O Graphs instead of IO graphs everywhere.
Change-Id: I6ce866b03632965dd1bad6eff361d91dd210c62b
Reviewed-on: https://code.wireshark.org/review/33680
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-20 20:01:00 +00:00
Anders Broman c1c0a2911b NRPPa: Add dissector for TS 38.455 V15.2.1
Change-Id: I66da8ced410163c872af1d4161f2c9fc38f72ff8
Reviewed-on: https://code.wireshark.org/review/33590
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 13:12:20 +00:00
Peter Wu 94b211977a Add support for embedding WireGuard keys in a pcapng file
pcapng spec update is here: https://github.com/pcapng/pcapng/pull/62

Bug: 15571
Change-Id: I2f1921b1da70ac0bab8c38dd5138a9dfe7843fea
Reviewed-on: https://code.wireshark.org/review/33300
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 00:48:29 +00:00
Gerald Combs 178e7ce9a5 Qt: Filter expression toolbar dark mode updates.
Move plus-8.png to stock_icons/8x8 and rename it list-add.template.png
which conforms to the Freedesktop icon naming specifications and makes
it a template icon.

Update our style sheet when we recive a QEvent::PaletteChange.

Ping-Bug: 15511
Change-Id: I4b8ddcb4eb64f11faec21d5df4a3fd7fdc5cf488
Reviewed-on: https://code.wireshark.org/review/33626
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 00:46:21 +00:00
Moshe Kaplan c6bed35254 WSUG: Clarified and improved phrasing
Change-Id: I1b3b8b7bf5f6460aa779c54881abd53059b26bbb
Reviewed-on: https://code.wireshark.org/review/33606
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-17 00:46:03 +00:00
João Valverde 63af1da7e7 Kill libwscodecs plugin library, just use plugins
Change-Id: I085d04840acb53b0b7681787429a2b4e10547cd5
Reviewed-on: https://code.wireshark.org/review/33068
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-11 20:59:39 +00:00
Jon Dennis de44630666 CL3DCW: Added Dual Channel Wi-Fi Dissectors
Initial go at adding the CableLabs Dual Channel Wi-Fi dissector.
Changes:
  . New dissector for CableLabs Layer-3 Protocol ("CL3") IEEE EtherType 0xB4E3
  . New dissector for Dual Channel Wi-Fi (Subprotocol of CL3)
  . Defined EtherType macro for CL3 + description

Bug: 15818
Change-Id: I6edf99d40883c1890659185cc3f0524a2218a6c4
Reviewed-on: https://code.wireshark.org/review/33440
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-11 20:26:56 +00:00
Tomasz Moń 8219ff2ed2 Add FTDI FT dissector to release notes
Change-Id: I89335813a5ec0a0748741bd8fb2f1ee77369bfe4
Reviewed-on: https://code.wireshark.org/review/33554
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-06-11 16:33:34 +00:00
Michael Mann 6476ec79aa Document why extcap utilities can't be run "by hand" on Windows
Bug: 15591
Change-Id: Icb8246ba196df026736ce1e54eb2ace2c7cd49b0
Reviewed-on: https://code.wireshark.org/review/33530
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-06-09 23:17:31 +00:00
Jaap Keuter 860e73c88f WSDG: Don't make hyperlinks of Gerrit git access links
The URL's used to access the repository with git should not be hyperlinks in
the documentation. These are not intended to be used by a webbrowser.

Change-Id: I2d516f823e58681474f6a2a9e2e229471fbc87f6
Reviewed-on: https://code.wireshark.org/review/33423
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-05-30 21:18:58 +00:00
Jaap Keuter 9d8f55cb05 WSDG: refine text on cloning repository
Text smells of CVS/SVN heratige.

Change-Id: I37c3309781f49149b2603ae32087ed01363460ee
Reviewed-on: https://code.wireshark.org/review/33421
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2019-05-30 12:41:01 +00:00
Slava Bacherikov 9fa13ff70d [packet-gelf.c] Add dissector for GELF protocol
Add dissection for Graylog Extended Log Format (GELF) over UDP.

Bug: 15776
Change-Id: Ie976a1dee8d3441532f209061aef5c804219f289
Reviewed-on: https://code.wireshark.org/review/33184
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-28 03:38:13 +00:00
Dario Lombardo 1f75694f14 docbook: add a link to the gerrit manual explaining change-ids.
Change-Id: I775e05bac8b0f8988d503bde6091922d2fab2583
Reviewed-on: https://code.wireshark.org/review/33381
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-28 03:33:29 +00:00
Uli Heilmeier d4836d1efe WSUG: Update vlan resolving
Update documentation to profile aware vlans file.

Change-Id: I210964528663bdf7e3e20e623eda1d93a26f7486
Ping-Bug: 15795
Reviewed-on: https://code.wireshark.org/review/33387
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-28 03:32:35 +00:00
Graham Bloice 93303118d4 Developers Guide: Fix issue with Windows env vars
Change-Id: I2f78cf59267196c2994f7f16934562074afa9f4f
Reviewed-on: https://code.wireshark.org/review/33358
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2019-05-25 18:25:22 +00:00
Graham Bloice 0636c267d9 developers-guide: restore winflexbison to Windows install
Change-Id: I46d0822b2939793990b7e0ef6a34bd421335c919
Reviewed-on: https://code.wireshark.org/review/33337
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-24 03:43:32 +00:00
Dario Lombardo 4cfe3fb6e0 docbook: add section from wiki.
The section "Writing a Good Commit Message" from the wiki has been
incorporated in the wsdg.

Missing parenthesis fix, while here.

Bug: 15752
Change-Id: I93f2a6956d366b3e1db0deab6d884f67748d3c54
Reviewed-on: https://code.wireshark.org/review/33254
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-20 04:20:13 +00:00
Moshe Kaplan f8e80f33f1 WSDG: Clarified and expanded Lua docs
Change-Id: Ib108ac256654ede1fd2ba5f0c87604e87b7ed5fb
Reviewed-on: https://code.wireshark.org/review/33216
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-20 04:19:42 +00:00
Solganik Alexander b06dcb32c7 nvme-tcp: Add nvme-tcp dissector
This patch adds support of NVMe/TCP (NVM Express over Fabrics for TCP).
to wireshark.

NVM Express is high speed interface for accessing solid state drives.
NVM Express specifications are maintained by NVM Express industry
association at https://nvmexpress.org/.

NVMe/TCP is the TCP transport binding specification
which recently ratified (Technical Proposal 8000) and is a part
of NVMe-oF spec version 1.1.

Reference can be found here:
https://lwn.net/Articles/772556/
and protocol specification:
https://nvmexpress.org/welcome-nvme-tcp-to-the-nvme-of-family-of-transports/

Supported commands are
*) NVMe/TCP ICREQ, ICRESP.
*) NVMe Fabrics commands
*) NVMe commands that are supported by packet-nvme dissector.

Testing is done with Linux 5.0 nvme-tcp host and target drivers.
H2C and C2H termination PDU`s are not supported as Linux NVMe/TCP driver
does not support them as well in kernel 5.0

Bug: 15735
Change-Id: I63ae7aa2a42ff843b9832110830fd345f30d9170
Reviewed-on: https://code.wireshark.org/review/32640
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-05-13 06:11:52 +00:00
Gerald Combs af80a96e8a Docbook: Remove an example capture file.
Remove docbook/examples/test.cap. According to Git we've never used it.

Change-Id: Ie789862fd3c9448a306194e6f5b3d1b92cb11084
Reviewed-on: https://code.wireshark.org/review/33139
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-10 03:43:36 +00:00
Harald Welte aa8d948cf4 3GPP CBSP (Cell Broadcast Service Protocol) dissector
This protocol is spoken between the BSC (Base Station Controller) and
the CBC (Cell Broadcast Centre).  It runs over TCP Port 48049 and is
specified in 3GPP TS 48.049.

Change-Id: I183e4741e2db5b9cc4dfe2b89f7920a32af67971
Reviewed-on: https://code.wireshark.org/review/29745
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-08 10:15:34 +00:00
João Valverde 186f985793 CMake: Check for and use system SpeexDSP library
Change-Id: I8443379d23a2946dd21c12e5e0bd5464ab73ca25
Reviewed-on: https://code.wireshark.org/review/31857
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: João Valverde <j@v6e.pt>
2019-05-02 21:12:01 +00:00
Gerald Combs cec5991f40 Windows: Modernize our WSAStartup usage.
Make sure we link each application that calls WSAStartup with ws2_32.lib.
Pass version 2.2 to WSAStartup. Wikipedia says it was introduced in 1996,
so we should be OK.

Ping-Bug: 15711
Change-Id: I431839e930e7c646669af7373789640b5180ec28
Reviewed-on: https://code.wireshark.org/review/33033
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Reviewed-by: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-05-01 17:51:59 +00:00
Peter Wu bb757e661a docbook/faq.adoc: remove execute bits
Change-Id: I9f4b2f5bd1646362fe5c0bb2dd98aa923abb78fe
Reviewed-on: https://code.wireshark.org/review/32971
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-24 22:23:21 +00:00
Peter Wu 6f31151f07 docbook: fix broken image link on ChLibsNpcap
Only warning, note and tips admonitions are documented for use in the
"Typographic Conventions" section. Asciidoctor also supports IMPORTANT
and CAUTION, but we do not use it. Remove it to avoid broken pictures.

Extcap is another user, but that is being removed in another patch.

Change-Id: Iea7c9e67ddb978ae1b9c18e5d8f65b0cfb0d6f2c
Reviewed-on: https://code.wireshark.org/review/32936
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-04-22 18:01:13 +00:00
Dániel Bakai 9ce60b173b Add brotli decompression support for HTTP and HTTP2 dissectors.
Change-Id: I9c09f55673187f6fee723fcd72798fb6b9958b03
Reviewed-on: https://code.wireshark.org/review/32745
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-22 15:24:46 +00:00
Peter Wu 0974b68f5c WSDG/Capture: Fix typo in extcap_example.py name
Change-Id: I0f1bff75e90f37d07afcbe3bb786965db9cb442e
Reviewed-on: https://code.wireshark.org/review/32900
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-19 17:38:20 +00:00
Moshe Kaplan 27dd00b30c Readability improvements to WSUG - Introduction
Change-Id: I39270092772daa0c119c2fb2ece2fcb1cbad2d8c
Reviewed-on: https://code.wireshark.org/review/32867
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-15 22:59:44 +00:00
Moshe Kaplan 75b03ac485 Improve phrasing in wsug-preface
Change-Id: I3460abadb36f77ec9d3eaac694a070b9a8eccdd0
Reviewed-on: https://code.wireshark.org/review/32838
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-04-12 20:20:37 +00:00
Joel Colledge 39299a13cb DRBD: Add dissector for the Distributed Replicated Block Device protocol
Bug: 15589
Change-Id: Iab2284f79130b0ab024e7ab00c0774d1907077db
Reviewed-on: https://code.wireshark.org/review/32332
Tested-by: Petri Dish Buildbot
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-04-11 23:37:01 +00:00
Moshe Kaplan 2cb8bed2e4 Update docs for WinPcap to Npcap switch
Change-Id: I23287165c3aaf11327a3320282fa9eebe23e2a22
Reviewed-on: https://code.wireshark.org/review/32616
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-03-29 07:06:10 +00:00
Gerald Combs d5f431b1ec WSUG: Update deprecated syntax.
Asciidoctor 2.0.0 deprecated "footnoteref". Use "footnote" instead.

Change-Id: Ic7eeabcb20ddbb5137c24c6861b01168879235d9
Reviewed-on: https://code.wireshark.org/review/32592
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-26 22:10:53 +00:00
Gerald Combs f717932af2 [Automatic update for 2019-03-24]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Ib05f06638757aa7d96f6ebfd4cfb5baaf347bf99
Reviewed-on: https://code.wireshark.org/review/32552
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-24 08:32:56 +00:00
Gerald Combs 62e8dba893 WSUG: Update the requirements section.
Change-Id: I84e7e0b22e1933385d6e928cc83ebd485beada06
Reviewed-on: https://code.wireshark.org/review/32470
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-18 16:29:43 +00:00
Gerald Combs 9887fe3d15 WSDG: Describe our tag naming conventions.
Change-Id: Icb8ba1be843b8a109713df9260330df5b215bf0b
Reviewed-on: https://code.wireshark.org/review/32318
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-04 18:35:06 +00:00
Gerald Combs ad45f19196 [Automatic update for 2019-03-03]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I1dcc92c6de3028af82556e6713451c3473fdb2d0
Reviewed-on: https://code.wireshark.org/review/32295
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-03-03 08:33:26 +00:00
Gerald Combs 0fcf4b1de9 [Automatic update for 2019-02-24]
Update manuf, services enterprise numbers, translations, and other items.

Change-Id: If37808291aca1f9bdd75d064bbfb738b89945eb8
Reviewed-on: https://code.wireshark.org/review/32180
Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-24 08:32:11 +00:00
Maximilian Kohler 334f7e1fd9 eCPRI: added new dissector
evolved Common Public Radio Interface (eCPRI) is a protocol, which will
be used in fronthaul transport network. It will be included in standard
ethernet frames and UDP frames.
There are 8 Message Types to decode with eCPRI Specification V1.2.

Bug: 15510
Change-Id: I2bb74c1e95e89f0b812492509a05395d6b86eb54
Reviewed-on: https://code.wireshark.org/review/32004
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-19 18:50:48 +00:00
Gerald Combs 3b8bf168e6 WSDG: Let Windows developers know that they need Perl.
Add an "Install Perl" section to the "Win32/64: Step-by-Step Guide"
section. Recommend Strawberry Perl first there and in the "Microsoft
compiler toolchain" chapter under the theory that if it's good enough
for Larry Wall then it's good enough for us.

Bug: 15512
Change-Id: I9a01c7ae2da01b98fd20b64d29144577a8f456b2
Reviewed-on: https://code.wireshark.org/review/32088
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-19 08:44:33 +00:00