Commit Graph

4656 Commits

Author SHA1 Message Date
Stephen Fisher 217b344bd9 Per Jaap's suggestion on -dev list: remove "with new_packet_list" from
version output since it has been the default for a while now and show
"with old_packet_list" if compiled as such. 


svn path=/trunk/; revision=33035
2010-06-01 18:33:16 +00:00
Jeff Morriss 47e2d75820 Move some code (including the optional objects) into libwsutil
svn path=/trunk/; revision=33012
2010-05-28 20:19:55 +00:00
Gerald Combs 17807a6b21 From Jakub Zawadzki via bug 4273:
After appending new record set packet_list->columnized to FALSE.

From me:

Use g_ptr_array_sort_with_data instead of g_qsort_with_data in case the
GPtrArray internals ever change.

svn path=/trunk/; revision=33011
2010-05-28 18:04:56 +00:00
Jörg Mayer c160ddd1de Add proto_help.c to the list of files.
svn path=/trunk/; revision=33008
2010-05-28 11:18:04 +00:00
Bill Meier 64d6943ddf Add svn:keywords & svn:eol-style properties
svn path=/trunk/; revision=33007
2010-05-28 01:37:32 +00:00
Gerald Combs f5df768724 fopen -> ws_fopen
svn path=/trunk/; revision=33002
2010-05-27 21:17:55 +00:00
Gerald Combs 8bdb1bff8d Protocol Help requires GLib 2.6+. Add newlines. Fixup whitespace.
svn path=/trunk/; revision=33001
2010-05-27 19:54:02 +00:00
Gerald Combs fa5f6cced7 From Edgar Gladkich:
This is an extension to the Wireshark context sensitive protocol help. Rows in
TreeView window are analyzed and suitable help file (as HTML) is opened in a
browser.

The help part (large file, 23 MB) of the Protocol Help can be downloaded under
www.inacon.com/dowload/stuff/protocol_help.tar.gz

This protocol help "light" provides descriptive content for the most frequently
used standard protocols, including IP, TCP or SMTP.

From me:

Changes:

Rename "ph_" in some function names to "proto_help_". Move the protocol
help code to its own module.

Make a bunch of functions static. Remove unused code.

Use browser_open_url() instead of a custom function.

Increase the logging levels. Don't clobber the normal log handler.

Update some Doxygen comments to match the format in the rest of the code
base.

Removed GTK version checks. We've been 2.x only for a while.

Move ph_replace_string to string_replace() in epan/strutil.[ch].

Fix a bunch of memory leaks.

Add a NULL pointer check.

Reformat the overview menu label.

Document the file format and locations.

Add Edgar to AUTHORS.

svn path=/trunk/; revision=32995
2010-05-27 15:51:25 +00:00
Gerald Combs b3a83551a3 Make sure our prefix length is > 0 before lopping off the last
character.  Fixes bug 4797.

svn path=/trunk/; revision=32987
2010-05-27 00:49:01 +00:00
Anders Broman 9992de5a4a From Jakub Zawadzki:
One more change from wtap_seek_read to cf_read_frame.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4666

svn path=/trunk/; revision=32984
2010-05-26 21:39:24 +00:00
Gerald Combs 074b9660b6 Have new_packet_list_queue_draw() redraw the packet detail as well. Call
new_packet_list_queue_draw() whenever we mark/unmark frames. Fixes bug
4669.

svn path=/trunk/; revision=32981
2010-05-26 19:44:40 +00:00
Anders Broman 65ee4e797a From Jakub Zawadzki:
New functions: cf_read_frame_r, cf_read_frame

It's much easier to write:
 cf_read_frame (cf, fdata, &err, &err_info)
Than:
 wtap_seek_read (cf->wth, fdata->file_off, &cf->pseudo_header, cf->pd,
fdata->cap_len, &err, &err_info)

svn path=/trunk/; revision=32980
2010-05-26 19:11:23 +00:00
Martin Mathieson 763a397ae3 Add a tooltip.
svn path=/trunk/; revision=32977
2010-05-26 15:51:47 +00:00
Martin Mathieson 13c9cf1d38 Add some tooltips.
svn path=/trunk/; revision=32976
2010-05-26 15:20:10 +00:00
Gerald Combs 237eef2ae7 r32323 broke packet detail tree expansion using the left/right keys on
X11. Add back the removed code and add checks for expandable items.

svn path=/trunk/; revision=32957
2010-05-25 23:55:33 +00:00
Martin Mathieson 892d3112ed Add a filter for DCT2000 error strings, and allow it be included in generated filters from RLC status window.
svn path=/trunk/; revision=32946
2010-05-25 14:02:17 +00:00
Guy Harris 36623bcb71 From H.sivank: GtkOSXApplication support.
Call the various flavors of OS X integration just "OS X integration",
not anything with "IGE" in it - it appears that, in some places,
"ige-mac-integration" refers only to the older Carbon-based functions,
although the library still appears to be called -ligemacintegration.

Update the URLs for the information about the OS X integration
libraries.

Clean up help message for --with-pcap-remote.

Clean up white space a bit.

Speaking of white space, it's "Mac OS X", not "MacOS X".

svn path=/trunk/; revision=32941
2010-05-25 00:35:44 +00:00
Bill Meier 4dcaf67f37 Fix regression: unable to enter values in Filter Expression window unless value list present.
(Regression introduced in SVN #30918).
Code reworked slightly for clarification.

svn path=/trunk/; revision=32912
2010-05-20 23:49:57 +00:00
Jaap Keuter 1a3fd99542 Fix for bug 4778:
Check that the widget pointer is still present.

svn path=/trunk/; revision=32911
2010-05-20 19:03:13 +00:00
Guy Harris 9d819eb925 Don't assume that certain address columns are always constant strings -
they're no more guaranteed to be constant strings than the columns we're
*not* assuming are constant strings.  Fixes bug 4771.

svn path=/trunk/; revision=32906
2010-05-20 07:15:27 +00:00
Guy Harris 15e546e65d If the user asks for the Capture -> Interfaces dialog, and there are no
network interfaces, pop up a dialog saying that, rather than popping up
an empty Interfaces dialog.

svn path=/trunk/; revision=32884
2010-05-19 03:05:40 +00:00
Guy Harris 991c5e9898 When dumpcap is run to get an interface list, interface capabilities, or
interface statistics, have its error messages come out as sync-pipe
errors, have it send a sync-pipe "success" message on success, and have
the callers get that message and display it.

svn path=/trunk/; revision=32843
2010-05-17 18:40:23 +00:00
Stig Bjørlykke 2bb480e70d Ensure we update default link-layer list when toggeling monitor mode.
svn path=/trunk/; revision=32835
2010-05-16 15:44:43 +00:00
Guy Harris 342d436705 If we don't know whether a device supports monitor mode, turn off
monitor mode in the checkbox before making the checkbox insensitive.

svn path=/trunk/; revision=32829
2010-05-16 08:14:29 +00:00
Stig Bjørlykke 01a135ef05 Also set sensitive on monitor and linktype label, as it's not clear that
the monitor mode is disabled when only the check box is disabled.

svn path=/trunk/; revision=32827
2010-05-15 23:25:53 +00:00
Stig Bjørlykke 5f58400065 Set the correct "monitor mode" button state.
svn path=/trunk/; revision=32826
2010-05-15 22:54:44 +00:00
Guy Harris e1e576c11b Support monitor mode in the capture preferences.
Use prefs_is_capture_device_hidden() to find out whether a device should
be hidden - don't scan the list of hidden devices ourselves.

svn path=/trunk/; revision=32820
2010-05-15 19:38:13 +00:00
Guy Harris a41f89c8f5 Fix the tooltip for the "monitor mode" checkbox.
Speak of network adapters rather than network cards (most personal
computers these days have no network cards - the network adapters are on
the motherboard).

svn path=/trunk/; revision=32810
2010-05-14 17:36:17 +00:00
Jeff Morriss 54082c6ed0 Add Cmake stuff to the source distribution so more people can try it out.
svn path=/trunk/; revision=32807
2010-05-14 16:27:03 +00:00
Guy Harris 0ad496957f Fix compilation when we don't have pcap_create().
svn path=/trunk/; revision=32805
2010-05-14 07:48:50 +00:00
Guy Harris 6aac80597f Support monitor mode from the GUI.
svn path=/trunk/; revision=32804
2010-05-14 05:15:40 +00:00
Guy Harris 8d56103f48 Don't include capture-related headers if we don't support capturing
network traffic.

svn path=/trunk/; revision=32802
2010-05-14 01:39:02 +00:00
Guy Harris 9307251bb8 Um, no, the problem with the Leopard x86 build is that we first do a
build without libpcap, to make sure that works, and then do a build with
libpcap, to put into a binary release.  It's the former that's failing;
I'll back out the previous change and then work on that.

svn path=/trunk/; revision=32801
2010-05-14 00:49:28 +00:00
Guy Harris 0e54136213 See whether the Leopard x86 buildbot is upset because of the name
if_capabilities_t - it doesn't fail on Snow Leopard, even if I undefine
HAVE_PCAP_CREATE, and doesn't fail on the Leopard PPC buildbot, either.

svn path=/trunk/; revision=32799
2010-05-14 00:10:15 +00:00
Guy Harris 1c18115bd3 Fetch an indication of whether the interface supports capturing in
monitor mode at the same time that we fetch its list of link-layer
types.  Support fetching that list in monitor mode, as the list may be
different in regular and monitor mode.  If the interface supports
monitor mode, when printing the list of link-layer types, indicate
whether they're fetched in monitor mode or not, as tcpdump 4.1.x does.

svn path=/trunk/; revision=32789
2010-05-13 17:37:39 +00:00
Guy Harris 74b7ca5802 Don't set the sensitivity of the Open button based on whether we can
open the currently-selected file; that button is also used to select the
file or directory typed in the location bar.  This should fix bug 1791.

svn path=/trunk/; revision=32774
2010-05-12 19:44:23 +00:00
Gerasimos Dimitriadis 35efe5e36f Initialize the GValues without triggering any warnings
svn path=/trunk/; revision=32767
2010-05-11 21:50:54 +00:00
Jaap Keuter 58843eaf03 Make the changes compile on Linux also.
svn path=/trunk/; revision=32762
2010-05-11 20:57:15 +00:00
Anders Broman 55572b41b3 Start to replace deprecated gtk_combo_new() with
gtk_combo_box_entry_new_text().

(I'll try to get back to this tomorrow)

svn path=/trunk/; revision=32759
2010-05-11 19:52:40 +00:00
Anders Broman 677e54d0a9 Replace deprecated gtk_input_add_full()
svn path=/trunk/; revision=32750
2010-05-11 08:36:16 +00:00
Jeff Morriss 60b8391d5b Follow on to rev 32593: apparently delaying the start of resolv_update_cb() isn't always enough. Delaying it further is would require adding the function call to several cases of an already complicated if/then/else + #ifdef/#else, so instead just put in a NULL check before calling gdk_window_invalidate_rect().
svn path=/trunk/; revision=32743
2010-05-11 02:25:22 +00:00
Bill Meier 7e9418f687 Fix a gcc -Wshadow warning.
svn path=/trunk/; revision=32736
2010-05-10 16:39:53 +00:00
Stig Bjørlykke f4418004f6 Bring back "1 min" and "10 min" in IO Graph Tick interval.
svn path=/trunk/; revision=32733
2010-05-10 10:48:45 +00:00
Jaap Keuter a7c62614d7 Clean comments and indentation.
svn path=/trunk/; revision=32726
2010-05-09 05:40:29 +00:00
Sake Blok 0618e53168 Enable "Decode As..." for ethertype 0x0000 (fix for bug 4721)
svn path=/trunk/; revision=32723
2010-05-08 07:55:12 +00:00
Guy Harris 547b9e48a2 The default capture buffer size is, in fact, *nominally* 1MB; however,
libpcap/WinPcap and the capture mechanism atop which they run might
either silently limit the buffer size to a smaller value or raise it to
a higher value - that's the part that's platform-dependent.

svn path=/trunk/; revision=32718
2010-05-08 00:39:07 +00:00
Guy Harris 0b62cc144e Don't define err_str twice if building on Win32 with AirPcap support.
svn path=/trunk/; revision=32717
2010-05-08 00:17:06 +00:00
Guy Harris 077ff72ac1 As with the list of data link types, so with the list of interfaces; move
the code to print the machine-readable format into dumpcap, and have the
code in capture_opts.c just print the human-readable format.

svn path=/trunk/; revision=32714
2010-05-07 19:24:32 +00:00
Guy Harris 13bf4a0c55 Add routines vfprintf_stderr() and fprintf_stderr() to print to the
standard error and, in Wireshark on Windows, create a console if
necessary.  Have the cmdarg_err routines use them.

Use *fprintf_stderr() to print the output of -L, rather than using
cmdarg_err_cont(), so that we don't get extra newlines in the output (it
should look similar to the output of tcpdump).

svn path=/trunk/; revision=32711
2010-05-07 08:40:02 +00:00
Guy Harris cc05b9250d For TShark and Wireshark, get the list of link-layer types for an
interface by running dumpcap, so that if you need privileges to open an
interface, and dumpcap has those privileges, neither TShark nor
Wireshark need them.

svn path=/trunk/; revision=32710
2010-05-07 08:06:25 +00:00