cfe11b1097
Add ENC_ASCII_7BITS encoding
...
Change-Id: I01ec87ff4181afb5b2de487fd5f5200f8d62f17d
Reviewed-on: https://code.wireshark.org/review/1088
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-13 20:02:52 +00:00
296591399f
Remove all $Id$ from top of file
...
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04 14:27:33 +00:00
ea1d5c151e
Use proto_tree_add_item() for most string encodings.
...
We support ISO 8859-1 and 8859-8, so use proto_tree_add_item() for them.
That leaves only EUC-KR.
Change-Id: Ie61f69af43be03e5abeb84b95601a407900fb79b
Reviewed-on: https://code.wireshark.org/review/403
Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-02-26 10:17:22 +00:00
205a9f9b50
Use tvb_get_string_enc() rather than tvb_get_string(); according to
...
TIA/EIA-637-A, call-back numbers are either BCD or ASCII.
svn path=/trunk/; revision=54917
2014-01-22 22:37:08 +00:00
eabf15f80a
Fix dissection of 3GPP2 SMS encoded in UCS2
...
svn path=/trunk/; revision=54787
2014-01-14 16:23:38 +00:00
86f6c85860
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
...
svn path=/trunk/; revision=54731
2014-01-13 22:25:03 +00:00
70dc6197ec
From Michael Lum via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9472 :
...
ANSI IS-637 SMS enhancements for CMAS (TIA-1149) and header dissection
svn path=/trunk/; revision=54684
2014-01-09 21:58:09 +00:00
6ebc058f47
Add proto_tree_add_ts_23_038_7bits_item() / tvb_get_ts_23_038_7bits_string() functions and update dissectors to use it.
...
Remove gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions.
Update documentation a bit.
svn path=/trunk/; revision=54534
2014-01-01 14:33:19 +00:00
5084f58ce2
We support ENC_UCS_2, so use that in proto_tree_add_item() and
...
tvb_get_string_enc() rather than using iconv to convert it to UTF-8.
svn path=/trunk/; revision=54350
2013-12-22 02:12:32 +00:00
5db2d622e4
From Michael Lum via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9554 :
...
GSM SMS: remove some globals and expose some UDH fields through dis_field_udh()
svn path=/trunk/; revision=53997
2013-12-12 22:35:45 +00:00
93398e794e
Use STR_UNICODE display instead of proto_tree_add_unicode_string() in the remaining dissectors
...
svn path=/trunk/; revision=53867
2013-12-08 20:03:15 +00:00
37660f413b
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9478 :
...
GSM SMS User Data header fill bits are wrong when using a 7 bits ASCII / IA5 encoding
svn path=/trunk/; revision=53631
2013-11-28 21:59:02 +00:00
a3cb8fdf95
Create/use value_string_ext to reference certain value-string-arrays.
...
Define a char array as const.
Remove an unneeded initializer.
Add editor modelines.
Do some minor whitespace changes.
svn path=/trunk/; revision=53319
2013-11-14 21:32:47 +00:00
1899903f69
Include <epan/to_str.h> only when needed.
...
svn path=/trunk/; revision=53189
2013-11-09 13:41:10 +00:00
9201e8ce14
3GPP2 SMS: add support for KSC5601 (Korean) character set
...
svn path=/trunk/; revision=53139
2013-11-07 10:27:11 +00:00
bb36a25089
Remove use of pinfo->private_data and just pass the data around through function parameters
...
Remove g_pinfo from packet-ansi_637.c and add packet_info* as a function parameter while we're at it.
svn path=/trunk/; revision=52883
2013-10-27 01:06:44 +00:00
a3a15ff90b
Remove instances of unused 'data_handle' (and of one other handle).
...
svn path=/trunk/; revision=52767
2013-10-22 16:13:32 +00:00
76d4b43a29
Minor whitespace, formatting & etc changes.
...
svn path=/trunk/; revision=52588
2013-10-13 18:14:59 +00:00
b46f9bebe2
Change some dissectors to use pinfo memory pool instead of malloc if it can trigger an exception between between buffer allocation and tvb_set_free_cb call
...
svn path=/trunk/; revision=51427
2013-08-19 14:55:41 +00:00
81b6d6aab3
Do not use ephemeral memory when adding a new data source
...
svn path=/trunk/; revision=51423
2013-08-19 10:39:43 +00:00
f4bcbeb9f2
Keep result of [new_]register_dissector in some dissectors. [2 of x]
...
(don't create new dissector handle if we can use already existing one)
svn path=/trunk/; revision=51159
2013-08-05 19:09:44 +00:00
9216d338f0
From Reinhard Speyerer via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8851 :
...
ansi_637_tele dissector displays MSB as MBS for Call-Back Number
svn path=/trunk/; revision=50151
2013-06-25 21:05:28 +00:00
20de5f1a9a
Fix 7bit ASCII / IA5 SMS dissection broken in r49910
...
svn path=/trunk/; revision=49986
2013-06-17 19:52:01 +00:00
3dbf3b975a
Give somewhat more precise names for character encodings ("Unicode"
...
doesn't specify a single way to encode characters in an octet stream -
there's UTF-8 and UTF-16BE/LE, as well as UCS-2BE/LE for a subset of
Unicode, and "Latin" really means "ISO 8859-1" a/k/a "ISO Latin 1".
svn path=/trunk/; revision=49912
2013-06-12 18:17:15 +00:00
41647faaba
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3289 :
...
dissector ansi_637 does not have unicode encoding in user data parameter
svn path=/trunk/; revision=49911
2013-06-12 17:25:04 +00:00
0975d03e8d
Fix dissection of 3GPP2 SMS messages when the User Data Header field is present (for fragmented SMS)
...
svn path=/trunk/; revision=49910
2013-06-12 16:59:59 +00:00
37600a157b
Rename value string (and similar) functions to use a consistent pattern. This
...
was done using textual search+replace, not anything syntax-aware, so presumably
it got most comments as well (except where there were typos).
Use a consistent coding style, and make proper use of the WS_DLL_* defines.
Group the functions appropriately in the header.
I ended up getting rid of most of the explanatory comments since many of them
duplicated what was in the value_string.c file (and were out of sync with the
recent updates I made to those in r48633). Presumably most of the comments
should be in the .h file not the .c file, but there's enough churn ahead that
it's not worth fixing yet.
Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467
svn path=/trunk/; revision=48634
2013-03-29 00:26:23 +00:00
221b249acd
svn path=/trunk/; revision=48272
2013-03-12 21:58:04 +00:00
c5a71b1006
String passed to val_to_str() must have int format specifier (%u, %d, %x, and so on...).
...
Fix some cases (easy to grep) by call to val_to_str_const().
svn path=/trunk/; revision=47807
2013-02-21 21:04:59 +00:00
c895033e4a
Comment out unused hf[] entry.
...
svn path=/trunk/; revision=47449
2013-02-02 18:25:38 +00:00
d66d8c44d2
Fix GSM 7-bit default alphabet decoding in ANSI IS-637-A
...
svn path=/trunk/; revision=46687
2012-12-21 21:03:31 +00:00
2552c750e5
We always HAVE_CONFIG_H so don't bother checking whether we have it or not.
...
svn path=/trunk/; revision=45017
2012-09-20 02:03:38 +00:00
b18e880040
Update FSF address - part II.
...
svn path=/trunk/; revision=43538
2012-06-28 23:18:38 +00:00
d12d5a606c
AFAICT sys/types.h & netinet/in.h #includes are not needed for these files.
...
(Let's see if any of the buildbots give any errors).
Also: remove trailing whitespace on lines.
svn path=/trunk/; revision=42429
2012-05-04 21:29:00 +00:00
8a1dc57c03
Remove doubled semicolons and semicolons outside function.
...
svn path=/trunk/; revision=42053
2012-04-13 20:22:31 +00:00
4e57694d4a
Convert 'encoding' parameter of certain proto_tree_add_item() calls in non-autogenerated epan/dissectors:
...
Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as
the encoding parameter for proto_tree_add_item() calls which directly reference
an item in hf[] which has a type of:
FT_UINT8
FT_UINT16
FT_UINT24
FT_UINT32
FT_UINT64
FT_INT8
FT_INT16
FT_INT24
FT_INT32
FT_INT64
FT_FLOAT
FT_DOUBLE
svn path=/trunk/; revision=39288
2011-10-06 03:35:44 +00:00
7ad71a2d78
Treat TVBs as opaque: use the accessor functions instead of accessing the fields
...
directly.
svn path=/trunk/; revision=37420
2011-05-27 01:57:33 +00:00
cdedb31e94
As suggested by Chris: use val_to_str_const() instead of match_strval() plus a
...
NULL-return check.
Use val_to_str_const instead of val_to_str() in a couple places where the string
is constant.
Use val_to_str() instead of blindly passing the return value from match_strval()
into a format routine (to ensure a non-NULL string pointer). A couple of these
were cases where it could not actually return NULL, but I changed it for
consistency.
Store the return value of match_strval() rather than calling it repeatedly.
svn path=/trunk/; revision=37204
2011-05-17 18:58:40 +00:00
e7a716144d
Use _U_ for unused function parameters instead of assigning a variable
...
to itself. Found by clang compiler.
svn path=/trunk/; revision=36813
2011-04-22 15:53:34 +00:00
df0f97844e
(Trivial) Fix a typo & some indentation.
...
svn path=/trunk/; revision=36505
2011-04-07 14:07:54 +00:00
964690903f
Use the correct handle when registering "media_type" "application/vnd.3gpp2.sms": Coverity 835.
...
svn path=/trunk/; revision=36496
2011-04-06 12:19:38 +00:00
db925b3bfb
Don't assign to a proto_item * if the value won't be used: Coverity 836;
...
Also: remove some unneeded #includes.
svn path=/trunk/; revision=36460
2011-04-04 18:41:49 +00:00
a8bc4a0d13
Rename the routines that handle dissector tables with unsigned integer
...
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
2010-12-20 05:35:29 +00:00
10ffd14b8f
Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)
...
svn path=/trunk/; revision=32735
2010-05-10 15:54:57 +00:00
09764dd969
Remove unneeded #include <stdio.h>
...
svn path=/trunk/; revision=32367
2010-04-03 21:55:23 +00:00
802b91ecdb
A stab in the dark at deissecting IS-637-A decoding for the CDMA SMS data Message Body.
...
svn path=/trunk/; revision=31903
2010-02-17 16:47:02 +00:00
440c3f9261
From Didier Gautheron:
...
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
2010-01-13 20:32:01 +00:00
f82442badc
Move IA5_7BIT_decode to strutil.c
...
svn path=/trunk/; revision=30669
2009-10-23 01:56:09 +00:00
6c545e0d79
Save some memory: Don't statically allocate ett[] arrays used "dynamically".
...
svn path=/trunk/; revision=29929
2009-09-15 17:37:54 +00:00
17c9803cac
Sanitize epan includes
...
svn path=/trunk/; revision=29499
2009-08-21 20:25:24 +00:00
Pascal Quantin