Commit Graph

29735 Commits

Author SHA1 Message Date
Jeff Morriss 350729607a dissect_udp_bundle(): check if dissect_payload_header() or
display_metadata_block() return 0 (meaning they failed to decode something and
the offset was not incremented) rather than checking if the resulting offset
is 0.

This fixes the infinite loop reported in:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4156

svn path=/trunk/; revision=30672
2009-10-23 15:55:39 +00:00
Anders Broman 9db0d46eba Forgot to remove IA5_7BIT_decode(unsigned char * dest, const unsigned char* src, int len);
svn path=/trunk/; revision=30671
2009-10-23 05:32:15 +00:00
Anders Broman ea679ff697 From Gerasimos Dimitriadis:
DTAP: Decoding of subaddress information.
sligtly modified.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4150

svn path=/trunk/; revision=30670
2009-10-23 02:12:39 +00:00
Anders Broman f82442badc Move IA5_7BIT_decode to strutil.c
svn path=/trunk/; revision=30669
2009-10-23 01:56:09 +00:00
Gerald Combs 0bbe1cb546 Make the new packet list the default on Win64.
svn path=/trunk/; revision=30668
2009-10-23 00:16:34 +00:00
Jaap Keuter eae4219cea From Lars Ruoff:
Do not make dialog windows transient to the Wireshark top level window on
WIN32, since this causes some strange behaviour on Windows.
See http://www.wireshark.org/lists/wireshark-dev/200909/msg00184.html

svn path=/trunk/; revision=30667
2009-10-22 19:40:15 +00:00
Martin Mathieson f5b4b6e32f Expert error if (non-padded) PDU is shorter than reported.
svn path=/trunk/; revision=30666
2009-10-22 17:22:27 +00:00
Gerald Combs 839977fd7d Fix the WpdPack version on Win64.
svn path=/trunk/; revision=30665
2009-10-22 17:00:26 +00:00
Martin Mathieson 0f8ee9cdf9 More long BSR fixes.
svn path=/trunk/; revision=30664
2009-10-22 11:45:40 +00:00
Martin Mathieson b3f5ccdae0 Fix issues with long BSR format, and attach expert info for non-zero RAR TA to correct item.
svn path=/trunk/; revision=30663
2009-10-22 10:31:13 +00:00
Jaap Keuter 802dc7f334 From Greg Schwendimann:
The 802.3at Power Via MDI TLV dissector is incomplete as it does not decode the
last three bytes.  I have attached a patch that decodes the type/source/priority, 
PD requested power value, and PSE allocated power value fields.

svn path=/trunk/; revision=30662
2009-10-22 07:10:05 +00:00
Anders Broman 3faf5345ab From Gerasimos Dimitriadis:
DTAP: Progress description depends on coding standard.
Changed to export value strings trough .h file
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4146

svn path=/trunk/; revision=30661
2009-10-22 05:28:53 +00:00
Jeff Morriss d163d9cad7 Remove non-ASCII characters
svn path=/trunk/; revision=30656
2009-10-21 12:56:28 +00:00
Anders Broman f5f2bf6ecd From Gerasimos Dimitriadis:
DTAP: Call state depends on coding standard.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4145

svn path=/trunk/; revision=30655
2009-10-21 09:38:51 +00:00
Jaap Keuter d42280adb1 From Joe Eykholt:
The Fibre-Channel Extended Link Service request REC (Read Exchange Concise) 
is used in error recovery.  It is currently identified as REC but not completely 
dissected (the payload is shown as data).

svn path=/trunk/; revision=30654
2009-10-21 08:01:35 +00:00
Anders Broman 89e9745ed5 Use 2.22.2-1
svn path=/trunk/; revision=30653
2009-10-21 06:01:36 +00:00
Gerald Combs 09a0650607 Update WinPcap and the developer's pack to 4.1.1.
svn path=/trunk/; revision=30652
2009-10-21 03:13:42 +00:00
Jeff Morriss 6274e6b1ff ... and emem_init isn't (it is called directly by reassemble_test).
svn path=/trunk/; revision=30651
2009-10-21 00:12:36 +00:00
Guy Harris 7443432ed5 ep_init_chunk() and se_init_chunk() are static.
svn path=/trunk/; revision=30650
2009-10-20 23:50:31 +00:00
Jeff Morriss 4b6e25c627 s/#if HAVE_KERBEROS/#ifdef HAVE_KERBEROS/
svn path=/trunk/; revision=30649
2009-10-20 20:26:51 +00:00
Jeff Morriss 9341d5c8fa Take a stab at adding a section on environment variables that affect *shark's behavior. So far, all the emem variables are included.
svn path=/trunk/; revision=30648
2009-10-20 20:14:23 +00:00
Guy Harris ef2e5d71cc Fix broken link.
svn path=/trunk/; revision=30647
2009-10-20 18:17:32 +00:00
Jeff Morriss 78318b32ee Add emem_init() which initializes both the ep_ and se_ allocators; have all
callers use that instead of initializing each allocator individually.

svn path=/trunk/; revision=30646
2009-10-20 17:43:05 +00:00
Jeff Morriss 8ec5a160ec Make sure no one calls PROTO_ITEM_SET_*(proto_tree_add_*) by forcing a compile error if they do.
svn path=/trunk/; revision=30645
2009-10-20 17:39:22 +00:00
Jeff Morriss 38cb8e82c3 Don't call xx_init_chunk() in ep_free_all() and se_free_all() if we're not
using chunks.  With this change, xx_init_chunk() are only called once at
startup (as their comments imply).

Instead, set free_list to NULL in emem_free_all() (if we're not using chunks).

svn path=/trunk/; revision=30644
2009-10-20 17:16:40 +00:00
Gerald Combs e42a887353 Update the Windows requirements section.
svn path=/trunk/; revision=30642
2009-10-20 16:48:52 +00:00
Jeff Morriss f687349c04 Another, more sensible, attempt to fix the Win64 build.
svn path=/trunk/; revision=30641
2009-10-20 16:40:00 +00:00
Gerald Combs ccdf52a4cc Update the WinPcap installer to 4.1. The WinPcap installer now enables
NPF at startp, so remove the checkbox and associated code from the
Wireshark installer.

svn path=/trunk/; revision=30640
2009-10-20 16:22:14 +00:00
Gerald Combs 830ee22db4 Set a mem_chunk to NULL after we destroy it. This should fix the Solaris
buildbot test failures.

svn path=/trunk/; revision=30639
2009-10-20 15:43:40 +00:00
Jeff Morriss e7bc1e8912 Initialize se_ memory, too (since it is used by the reassembly code). Reindent a bit.
svn path=/trunk/; revision=30638
2009-10-20 15:07:22 +00:00
Anders Broman e12ab4d346 From Gerasimos Dimitriadis:
DTAP: Expert info warning when BCD number malformed
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4143

svn path=/trunk/; revision=30637
2009-10-20 14:42:58 +00:00
Jeff Morriss d4d62e3e0d Try to get it compiling on Win64
svn path=/trunk/; revision=30636
2009-10-20 14:12:41 +00:00
Jeff Morriss 762af05327 Don't call PROTO_ITEM_SET_GENERATED(proto_tree_add[...]): that will end up adding the item to the tree multiple times.
svn path=/trunk/; revision=30635
2009-10-20 14:03:00 +00:00
Stig Bjørlykke d43aab714c From Jakub Zawadzki:
Make it compile without kerberos.

svn path=/trunk/; revision=30634
2009-10-20 10:20:14 +00:00
Stig Bjørlykke a34a6bee5e Extern declare hf_nt_cs_len and hf_nt_cs_size.
svn path=/trunk/; revision=30633
2009-10-20 10:03:55 +00:00
Stig Bjørlykke 39c732d8bf Removed some redundant prototypes and some shadowed variables.
svn path=/trunk/; revision=30632
2009-10-20 09:31:07 +00:00
Ronnie Sahlberg 3bb1c2cbd4 From Matthieu Patou
schannel decryption


svn path=/trunk/; revision=30631
2009-10-20 08:44:26 +00:00
Stig Bjørlykke 33987544f9 Removed some unused prototypes.
svn path=/trunk/; revision=30630
2009-10-20 08:27:25 +00:00
Anders Broman a85999a691 Fix higlight the correct hex value and add a value_string.
svn path=/trunk/; revision=30629
2009-10-20 07:42:27 +00:00
Anders Broman 923b04dd82 From Gerasimos Dimitriadis:
DTAP: Various enhancements.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4142

svn path=/trunk/; revision=30628
2009-10-20 07:33:01 +00:00
Anders Broman 40447d1c12 Updated decoding of GMM Cause to V8.6.0, i.e. added cause code 0x19 - "Not authorized for this CSG". Changed to use a range_string.
Based on 
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4132

svn path=/trunk/; revision=30627
2009-10-20 03:13:56 +00:00
Jörg Mayer e678798057 Add packet-omron-fins.c
svn path=/trunk/; revision=30626
2009-10-20 00:44:08 +00:00
Bill Meier bd8bb405bd From Matt Watchinski: OMRON-FINS dissector
(with some restructuring and cleanup by me).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3226

svn path=/trunk/; revision=30625
2009-10-20 00:12:09 +00:00
Jeff Morriss ab13546f71 From Jakub Zawadzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4140 :
There is emem_header_t struct, so IMHO is better to use struct instead of
global variables.

Split emem_alloc() into two functions: emem_alloc_chunk and emem_alloc_glib.
Current allocator is available in emem_header_t.memory_alloc

It should be easier to develop new memory allocator and maintain current.
It might also give some speedup (we don't need to check mem->debug_use_chunks
every time :)

From me:

Initialize emem_header_t.trees.  Some indentation cleanup.

svn path=/trunk/; revision=30624
2009-10-19 22:31:08 +00:00
Jaap Keuter 288927bc46 Adding RFC 2228 FTP replies.
svn path=/trunk/; revision=30623
2009-10-19 21:22:23 +00:00
Jaap Keuter f55ec2aeff From Jouni Malinen:
WPS encodes Bool attributes as single-octet values. Selected Registrar
attribute is parsed correctly (packet-wps.c), but many of the other Bool
attributes are marked incorrectly to use two-octet fields. This results in
showing incorrect octets for some of the attributes and incorrectly marking
frames invalid if a Bool attribute is included as the last attribute in a WPS
IE.

svn path=/trunk/; revision=30622
2009-10-19 18:36:34 +00:00
Jeff Morriss 8f8eb40e9b Make it actually work with glib < 2.10
svn path=/trunk/; revision=30621
2009-10-19 14:52:15 +00:00
Stig Bjørlykke c6ef47cbb4 Made some functions static.
svn path=/trunk/; revision=30620
2009-10-19 14:45:10 +00:00
Stig Bjørlykke 2ac6a245e2 Removed redundant redeclaration of optind.
svn path=/trunk/; revision=30619
2009-10-19 14:44:37 +00:00
Stig Bjørlykke a52bf035b7 Removed redundant redeclaration of delete_avpl().
svn path=/trunk/; revision=30618
2009-10-19 14:42:10 +00:00