Commit graph

4706 commits

Author SHA1 Message Date
Guy Harris
704493f4e2 From Mark Burton: reinstate data segment digest handling, and stop the
SCSI dissector from treating data digests as payload.

svn path=/trunk/; revision=4552
2002-01-16 20:25:07 +00:00
Gilbert Ramirez
06348ee4e0 Tethereal needs to allocate space for col_expr[] and col_expr_val[] too.
Capturing with non-verbose output being printed segfaulted w/o this.

svn path=/trunk/; revision=4551
2002-01-15 23:11:02 +00:00
Guy Harris
61147d4da2 Collapse the two entries for Mark Burton into one.
svn path=/trunk/; revision=4550
2002-01-15 23:07:20 +00:00
Guy Harris
e1af77c959 Make the label for the SCTP checksum type preference item indicate that
it's a checksum type (and remove "SCTP", as that's redundant), and make
the blurb explain it in a bit more detail.

svn path=/trunk/; revision=4549
2002-01-15 23:05:36 +00:00
Guy Harris
eb1d00480f From Michael Tuexen:
- Support of the crc32c algorithm.
	- Selection of the checksum algorithm (none, adler-32, crc32c,
	  automatic) in the preferences/protocols menu.
	- Display of the IP address in asconf chunks.

svn path=/trunk/; revision=4548
2002-01-15 22:58:06 +00:00
Guy Harris
b8157b393c From Marc Milgram: fix to allow VMS TCPIPtrace files that don't have
exactly 3 spaces before the word "TCPIPtrace" to be recognized.

svn path=/trunk/; revision=4547
2002-01-15 20:18:02 +00:00
Guy Harris
f4c930c8e2 From Martti Kuparinen: update the HMIPv6 support to match the latest
draft (draft-ietf-mobileip-hmipv6-05.txt).

svn path=/trunk/; revision=4546
2002-01-15 20:11:10 +00:00
Guy Harris
df6fa9cc90 Include <resolv.h> after "globals.h", as, at least on some platforms,
headers included by "globals.h" define MAXNAMELEN, and <resolv.h>
defines it if it's not already defined.

svn path=/trunk/; revision=4545
2002-01-15 20:09:55 +00:00
Guy Harris
e4f05dcac2 Correctly handle BGP attributes with lists of entries when the attribute
has the "extended length" flag set - the starting offset of the list
depends on whether the "extended length" bit was set or not.

svn path=/trunk/; revision=4544
2002-01-15 10:12:17 +00:00
Guy Harris
86d348aed1 Fix some preferences to eliminate the extra copy of the protocol name at
the beginning, and to use underscores rather than periods where the
preference's name really isn't part of a hierarchical namespace.

Use "%u" rather than "%d" to print unsigned quantities.

svn path=/trunk/; revision=4543
2002-01-15 10:01:21 +00:00
Guy Harris
c8f8db531f When checking whether to do DCERPC-over-SMB reassembly on a Read and X
response, don't assume that we saw the request and therefore that
"si->sip" is non-null - we might well not have seen the request and thus
might not have set "si->sip".

svn path=/trunk/; revision=4542
2002-01-15 09:42:26 +00:00
Uwe Girlich
164e11c137 From Ronnie Sahlberg:
this fixes the bug that nfs name snooping did not work for nfs v2.

svn path=/trunk/; revision=4541
2002-01-14 13:16:31 +00:00
Uwe Girlich
eebc0a4a66 NFSv3 fsstat reply label texts explanded. "afiles" and similar names were not
really that useful.

svn path=/trunk/; revision=4540
2002-01-14 12:22:58 +00:00
Guy Harris
d520b16754 Give each LDAP packet its own top-level protocol tree item. (This also
means if there are no complete LDAP packets in a TCP segment, there is
no LDAP top-level protocol tree item, which is as it should be.)

svn path=/trunk/; revision=4539
2002-01-14 03:01:13 +00:00
Guy Harris
cbd0ae1706 Add support for TCP desegmentation.
svn path=/trunk/; revision=4538
2002-01-14 02:50:28 +00:00
Guy Harris
32d7eac1ce Get the current value of Boolean preferences before adding widgets for
them (by putting back a line that got accidentally deleted in a previous
checkin).

svn path=/trunk/; revision=4537
2002-01-14 01:14:52 +00:00
Guy Harris
0a03b0f73e Add a preferences page for the name resolution flags.
Separate the preferences value for those flags and the name resolution
code's value into separate variables; this means that the resolution
code no longer depends on the preferences code, and may let us
eventually have the current setting and the preference setting differ
(so that a user can temporarily override the preference setting without
causing subsequent saves of the preferences to save the temporary
value).

Add routines to create various types of widgets for preferences, and to
fetch the values for "enumerated" preferences, and use them both in the
code to handle hardwired preference pages and table-driven preference
pages.

svn path=/trunk/; revision=4536
2002-01-13 20:35:12 +00:00
Guy Harris
649cc279d6 Put the labels of check boxes to the left of the checkboxes,
right-aligned, and give all of them a colon at the end, to match the
style of other preferences.

svn path=/trunk/; revision=4535
2002-01-12 11:09:09 +00:00
Guy Harris
6437001da6 Get rid of unused variables.
Put the labels of check boxes to the left of the checkboxes,
right-aligned, and give all of them a colon at the end, to match the
style of module preferences.

svn path=/trunk/; revision=4534
2002-01-12 11:02:47 +00:00
Guy Harris
354b4b74d0 From Ronnie Sahlberg: file handle to file name resolution in NFS and
related protocols.

svn path=/trunk/; revision=4533
2002-01-12 10:24:47 +00:00
Guy Harris
ea02d23f06 While you're at it, use the key for the auto scroll option checkbox for
the pointer to the auto scroll options checkbox....

svn path=/trunk/; revision=4532
2002-01-12 09:19:59 +00:00
Guy Harris
0ad27ce8a7 Make the key for the capture preference window's pointer to the auto
scroll option checkbox distinct from the key for the pointer to the
real-time capture option checkbox, so thee auto scroll option checkbox
can be fetched.

svn path=/trunk/; revision=4531
2002-01-12 09:13:50 +00:00
Guy Harris
45dc78bd7d Support for BSD Compress, MVRCA, and Deflate compression options in
CCP, from Motonori Shindo.

svn path=/trunk/; revision=4530
2002-01-11 21:37:10 +00:00
Gilbert Ramirez
41f20b3449 From Guy Harris, after checking his Python code.
Some compilers don't mind zero-length arrays, but MSVC++ 6.0 does.

"ncp2222.py" was generating a zero-length "ett[]" array.  Make it generate
the "ett[]" array and the call to "proto_register_subtree_array()"
only if the list of items for "ett[]" is non-empty CVS:

svn path=/trunk/; revision=4529
2002-01-11 14:33:04 +00:00
Guy Harris
51cb58401f "void" values cannot be returned, even by a "void" function.
The "downstream" flag is a Boolean; treat it as such.

svn path=/trunk/; revision=4528
2002-01-11 11:07:21 +00:00
Guy Harris
e8297af92b Declare "capture()" appropriately.
svn path=/trunk/; revision=4527
2002-01-11 11:04:03 +00:00
Guy Harris
4b6951cd89 Put in a comment giving various Internet Draft names for ICMPv6 stuff we
handle.

svn path=/trunk/; revision=4526
2002-01-11 09:19:54 +00:00
Guy Harris
13b58598b3 Fix some more signed vs. unsigned issues.
svn path=/trunk/; revision=4525
2002-01-11 09:12:26 +00:00
Guy Harris
dce2c4c283 Update the man page to reflect user interface changes.
svn path=/trunk/; revision=4524
2002-01-11 09:02:15 +00:00
Guy Harris
1aadf9cfc2 Label the window popped up by "Capture->Start" "Capture Options", not
"Capture Preferences", to avoid confusion with the "Capture" item in the
"Preferences" dialog (which sets the initial default values for the
"Capture Options" dialog).

svn path=/trunk/; revision=4523
2002-01-11 08:55:02 +00:00
Guy Harris
30a043931e From Jirka Novak:
Support for generating filter expressions based on packet list
	    column values
	Support for adding filter expressions generated from column or
	    protocol tree field values to the current expression rather
	    than replacing the current expression

svn path=/trunk/; revision=4522
2002-01-11 08:21:02 +00:00
Guy Harris
feb5791d6a Have a routine to create a scrolled window, set its vertical scrollbar
preference, and add it to the list of scrolled windows; call that
routine to create scrolled windows, rather than creating it and calling
other routines to do the other two operations.

As "set_scrollbar_placement_all()" and "set_ctree_styles_all()" always
set the styles to match the user's preference, don't have them take an
argument, have them just use the user's preference settings.

Get rid of unnecessary includes of "prefs_dlg.h", replacing them with
includes of "prefs.h" if necessary.  Don't have "prefs_dlg.h" include
"prefs.h" - its sole purpose is to declare routines defined in
"prefs_dlg.c" - and add any additional includes of "prefs.h" this
requires.

Get rid of unnecessary includes of "prefs.h" and "gtkglobals.h".

Fix up white space.

svn path=/trunk/; revision=4521
2002-01-11 07:40:32 +00:00
Guy Harris
e592fa4a6b Have routines to create GtkCTrees, set their line and expander style
based on the user's UI preferences, and add them to a list of GtkCTrees.
Use those routines to create all GtkCTrees.

Have a routine to update the preferences for all of those GtkCTrees.
Call that routine whenever the preferences change.

Label the line and expander style preferences as "Tree line style" and
"Tree expander style", as they no longer apply only to protocol trees.

Move the routines to maintain a list of scrolled windows, and to update
scrollbar placement for scrolled windows, to "ui_util.c".

svn path=/trunk/; revision=4520
2002-01-11 06:43:18 +00:00
Guy Harris
fc53c2b7b3 Oh, what the heck, write out FDDI and bit-swapped FDDI as the same type
in Sniffer Classic files; there's nothing we can do about those
platforms that bit-swap FDDI addresses before handing them to DLPI or
whatever, so we'll just let people live with wrong FDDI addresses (or
maybe someday put in code to bit-swap them before writing them out to
the capture file).

svn path=/trunk/; revision=4519
2002-01-11 02:51:31 +00:00
Guy Harris
a4d560eb5b From Nagarjuna Venna: only display the reason in BYE RTCP packets if
it's present.

svn path=/trunk/; revision=4518
2002-01-10 22:21:14 +00:00
Guy Harris
43caedd1f9 From Irfan Khan: don't use bitfields.
svn path=/trunk/; revision=4517
2002-01-10 22:07:49 +00:00
Guy Harris
381c21783e As per a comment from Ronnie Sahlberg, display TCP sequence numbers in
the list of segments in a desegmented PDU as unsigned, rather than
signed.

Fix some other displays of unsigned quantities with "%d" while we're at
it.

svn path=/trunk/; revision=4516
2002-01-10 11:27:57 +00:00
Guy Harris
65b96f652d Fix more unsigned items to be displayed with "%u" rather than "%d", as
per Martti Kuparinen's comments.

svn path=/trunk/; revision=4515
2002-01-10 11:21:21 +00:00
Guy Harris
b3f81eb30c Separate the promiscuous mode, "Update list of packets in real time",
and "Automatic scrolling in live capture" options from the preference
settings for them, so that the preference settings affect the initial
values of those options, but changing those values in a capture don't
affect the preferences, and don't automatically get saved when you save
the preferences.

If we're building without libpcap, don't have an "Automatic scrolling in
live capture" option anywhere.

svn path=/trunk/; revision=4514
2002-01-10 11:05:50 +00:00
Guy Harris
d663cdb4a1 Fix some problems with building Ethereal/Tethereal without libpcap.
Get rid of a #include I'd #if 0'ed out.

svn path=/trunk/; revision=4513
2002-01-10 09:51:23 +00:00
Guy Harris
60c8a87e44 The filetime is an unsigned quantity, so display it with %u, as per
Martti Kuparinen's comment.

svn path=/trunk/; revision=4512
2002-01-10 09:49:35 +00:00
Guy Harris
09b62420e7 Don't break out of a loop from inside TRY clause; set a flag and break
after the ENDTRY.

svn path=/trunk/; revision=4511
2002-01-10 08:06:25 +00:00
Guy Harris
9357047df5 Add a preferences page for capture preferences, so that the user can
directly edit the capture preferences, rather than only being able to
set them implicitly from the values for the most recent capture.

Add a preferences item for the interface on which to capture.

Get rid of some unused variables.

svn path=/trunk/; revision=4510
2002-01-10 07:43:39 +00:00
Gilbert Ramirez
f7265ba975 Allow NCP types to define bitfields. In order to implement
sub-trees, I added new functions to ptvcursor:

	ptvcursor_add_no_advance()
	ptvcursor_tvbuff()
	ptvcursor_current_offset()

Note that no NCP type that actually uses bitfields has been
checked in yet.

svn path=/trunk/; revision=4509
2002-01-10 04:44:34 +00:00
Guy Harris
aa36cec9df SCSI dissector, and changes to make the iSCSI dissector use it, from
Dinesh Dutt.

svn path=/trunk/; revision=4508
2002-01-10 01:28:45 +00:00
Gilbert Ramirez
573f3fb04a Provide a --disable-usr-local flag to configure so that
-I/usr/local/include and -L/usr/local/lib aren't automatically added
to the build flags.

svn path=/trunk/; revision=4507
2002-01-09 23:21:55 +00:00
Guy Harris
bd42a598db HMIPv6 fix, from Martti Kuparinen.
svn path=/trunk/; revision=4506
2002-01-09 19:13:03 +00:00
Guy Harris
aa0459d3c2 Add DHCPv6 dissector to Windows build.
svn path=/trunk/; revision=4505
2002-01-09 02:55:38 +00:00
Jun-ichiro itojun Hagino
7cfaf110e6 DHCPv6 dissector, based on draft-ietf-dhc-dhcpv6-22.txt.
note that protocol constants are subject to change.
(packet format is also subject to change.  but 22 draft should go
to wg last call very soon, and I really hope it to be the final one...)

svn path=/trunk/; revision=4504
2002-01-09 02:51:46 +00:00
Guy Harris
5e7698f322 From Marc Milgram: all packets in DBS Etherwatch and VMS TCPIPTRACE
captures are IP packets, so make the file encapsulation
WTAP_ENCAP_RAW_IP rather than WTAP_ENCAP_PER_PACKET, so you can save
those captures in other formats.

svn path=/trunk/; revision=4503
2002-01-08 22:30:29 +00:00