Commit Graph

39 Commits

Author SHA1 Message Date
Bill Meier 7be91cb9e9 Fix potential infinite loop: for (guint8=0; guint8 < int; guint8++);
Fixes bug #5053.

svn path=/trunk/; revision=33637
2010-07-26 19:00:44 +00:00
Guy Harris 927b7da346 Have abs_time_to_str() and abs_time_to_str_secs() take an additional
argument indicating whether to include the time zone in the string.  If
we're constructing a display filter, don't include the time zone,
otherwise do.  Fixes bug 4756.

svn path=/trunk/; revision=32913
2010-05-21 06:33:25 +00:00
Jeff Morriss 729de1a635 As suggested in http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html
(as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 :

Write a new convenience routine for finding a conversation and, if it is not
found, create it.  The frame number and addresses are taken from pinfo (as is
the common case).

Use this function in a bunch of dissectors.

svn path=/trunk/; revision=32790
2010-05-13 18:28:34 +00:00
Guy Harris 500eb99cd9 Add a third date format, ABSOLUTE_TIME_DOY_UTC, to show UTC with the
date as YYYY/DDD, where DDD is a 1-origin day of year.  Move the formats
to a "time_fmt.h" file, included by the headers that use it.  Have
abs_time_to_str() and abs_time_secs_to_str() take the date format value,
rather than a Boolean "show this as UTC" flag, as an argument.  Document
the ABSOLUTE_TIME_ formats a bit better.  Use that format in the CCSDS
and VCDU dissectors, rather than having those dissectors do the
formatting themselves.

svn path=/trunk/; revision=32034
2010-02-27 19:01:27 +00:00
Anders Broman c4dd31cd87 From Didier Gautheron:
col_clear.diff 
Remove calls to col_clear :
- called twice.
- before functions which also clear the column
- by replacing col_clear + col_append_xxx with col_add_xxx
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394

svn path=/trunk/; revision=31517
2010-01-13 20:25:10 +00:00
Guy Harris ab0a5a3e15 Show absolute times as UTC, as was done before.
svn path=/trunk/; revision=31228
2009-12-10 22:20:18 +00:00
Guy Harris 4fde145bd2 Add an argument to abs_time_to_str() and abs_time_secs_to_str()
indicating whether the time should be shown as local time or UTC.  For
now, always pass FALSE, meaning "show as local time".

Clean up some stuff in the SNMP dissector, use abs_time_secs_to_str()
for times with one-second resolution, and update a comment in various
macros in the WSP dissector, while we're at it.

svn path=/trunk/; revision=31227
2009-12-10 22:19:29 +00:00
Guy Harris 9a4bdbf9ea Use existing code to format relative and absolute times.
svn path=/trunk/; revision=31224
2009-12-10 20:48:31 +00:00
Bill Meier 4bc9b95d69 Fix Bug #4319: IPMI dissector crash (on Windows) displaying date/time;
Using strftime(..., "%F %T", ...) crashes on Windows (VC9) (!!);
Use "%Y-%m-%d %H:%M:%S" instead.....

svn path=/trunk/; revision=31223
2009-12-10 20:26:39 +00:00
Stig Bjørlykke c8810bbc2a Put type/length elements in correct subtree.
svn path=/trunk/; revision=30897
2009-11-09 15:05:34 +00:00
Kovarththanan Rajaratnam 6110a96f68 Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check
svn path=/trunk/; revision=29345
2009-08-09 07:59:51 +00:00
Stig Bjørlykke 0437f102c3 From Kovarththanan Rajaratnam:
More FT_XXX cleanup.

svn path=/trunk/; revision=28971
2009-07-07 09:02:59 +00:00
Stig Bjørlykke b228488bc0 From Kovarththanan Rajaratnam via bug 3548:
(1) Trailing/leading spaces are removed from 'name's/'blurb's
(2) Duplicate 'blurb's are replaced with NULL
(3) Empty ("") 'blurb's are replaced with NULL
(4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields
    for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME,
    FT_PROTOCOL, FT_STRING and FT_STRINGZ field types
(5) Only allow non-zero value for 'display' if 'bitmask' is non-zero

svn path=/trunk/; revision=28770
2009-06-18 21:30:42 +00:00
Bill Meier f3d59ba1fe More ethereal --> wireshark
svn path=/trunk/; revision=27994
2009-04-08 13:07:21 +00:00
Guy Harris 91407025b7 Put back the Intel URL for the IPMI specs.
svn path=/trunk/; revision=25952
2008-08-07 20:58:27 +00:00
Anders Broman 82ca2b89f0 Activate the IPMI changes
From    Alexey Neyman.

svn path=/trunk/; revision=25951
2008-08-07 19:33:40 +00:00
Anders Broman ce25ea6f22 From Stephane Chazelas:
The description of the most significant bit of the "Device Revision" byte of
the response to a "Get Device ID" is the wrong way round. 1 means "device
provides Device SDRs" and not the contrary according to IPMI specs 1.5 and 2.0.

Also, I noticed in that file that "Chassis" is spelled "Chasis".

svn path=/trunk/; revision=23292
2007-10-27 15:53:29 +00:00
Anders Broman 1950ffc214 Apply the small performance enhancment patches for:
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster.
Replace 
- col_append_fstr() with faster  col_append_str() 
- col_add_str() with col_set_str()
when it's safe

svn path=/trunk/; revision=23252
2007-10-23 05:50:00 +00:00
Jeff Morriss 794a933a2c Change "lenght" to "length" and "decypt" to "decrypt"
svn path=/trunk/; revision=22356
2007-07-19 13:05:39 +00:00
Anders Broman f6e12b2533 From Flavio Leitner:
Fix IPMI Completion Codes.

svn path=/trunk/; revision=22191
2007-06-25 19:51:23 +00:00
Ulf Lamping f1a58d41d4 from Peter Johansson:
compilation warnings fixed

svn path=/trunk/; revision=21230
2007-03-27 21:20:19 +00:00
Bill Meier 103bf29730 Continuing the tradition: squelch some compiler warnings ....
svn path=/trunk/; revision=20866
2007-02-19 22:29:23 +00:00
Guy Harris fa9aeff8db Give dissect_cmd_Get_Channel_Auth_Capabilities() a return type (it
returns nothing, so it should be void), and make it static like the
other functions.

Make the ipmi_cmd_array[] table static - and const, while we're at it.

svn path=/trunk/; revision=20235
2006-12-29 22:48:09 +00:00
Anders Broman a78874863a Dissect Get Channel Authentication Capabilities Command.
svn path=/trunk/; revision=20124
2006-12-12 07:06:40 +00:00
Guy Harris 562570782d Add #defines for the authentication types, and use them.
Squelch some compiler warnings.

Get rid of a C++/C99 comment.

Fix some typoes.

Clean up indentation.

svn path=/trunk/; revision=20105
2006-12-11 01:55:50 +00:00
Anders Broman e9ddf3558a Applied the patch http://www.wireshark.org/lists/wireshark-dev/200606/msg01818.html
from Jason Allred.
Added some more V2 dissection but far from complete.

svn path=/trunk/; revision=20103
2006-12-10 22:58:55 +00:00
Ronnie Sahlberg 1edbac09c0 fix for bug 766
display truncated responses as "truncated response" and not "malformed packet"



svn path=/trunk/; revision=18412
2006-06-09 22:55:25 +00:00
Ronnie Sahlberg feab79e328 change a whole bunch of ethereal into wireshark
svn path=/trunk/; revision=18196
2006-05-21 04:49:01 +00:00
Jaap Keuter e77c4cdfc4 Consolidate duration decoding and presentation
svn path=/trunk/; revision=17536
2006-03-08 21:48:36 +00:00
Jaap Keuter 4939134507 Fix for bug 762: implementing Off/On duration presentation in 10ms units
svn path=/trunk/; revision=17430
2006-02-28 18:22:46 +00:00
Jaap Keuter 83f28ac9f5 Fix bug 765. ARMBER -> AMBER
svn path=/trunk/; revision=17394
2006-02-23 22:09:54 +00:00
Jaap Keuter b678c64c5a Fix for bug 762. Decode either LED function or off duration.
svn path=/trunk/; revision=17380
2006-02-23 11:56:18 +00:00
Jörg Mayer 30adb1d8f7 Fix for http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=656
Incorrect decoding of IPMI System Software IDs


svn path=/trunk/; revision=16950
2006-01-05 08:52:06 +00:00
Jörg Mayer 7b2ff03d8c Fix more "no previous declaration" warnings
svn path=/trunk/; revision=15169
2005-08-02 04:31:42 +00:00
Ulf Lamping 78ff68d4b5 a lot of warnings removed, most of them about pointer to int casts without using the appropriate GLib macros
svn path=/trunk/; revision=12832
2004-12-25 13:49:30 +00:00
Jörg Mayer 9c75e56ac7 Fix the following:
packet-ipmi.c:3568: warning: ISO C forbids initialization
        between function pointer and 'void *'
by declaring a proper function variable.

svn path=/trunk/; revision=12692
2004-12-08 13:11:46 +00:00
Guy Harris b3b1679a57 Fix some typoes.
svn path=/trunk/; revision=12592
2004-11-24 09:00:23 +00:00
Guy Harris 8747b8e544 From Lane Hu: add support for more IPMI commands.
svn path=/trunk/; revision=12588
2004-11-24 03:54:40 +00:00
Gilbert Ramirez 669db206cb Move dissectors to epan/dissectors directory.
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.

Adjust #include lines in files that include packet-*.h
files.

svn path=/trunk/; revision=11410
2004-07-18 18:06:47 +00:00