Commit Graph

10 Commits

Author SHA1 Message Date
Guy Harris 857318d3b7 Use "tvb_get_string()" instead of allocating a (len+1)-sized buffer,
"tvb_memcpy()"ing to it, and putting in a null terminator;
"tvb_get_string()" will check whether all bytes of the string are
present before allocating the buffer, so that you don't leak memory if
the copy throws an exception, and don't crash if the length is absurdly
large.

Use "tvb_memdup()" instead of allocating a buffer and "tvb_memcpy()"ing
to it, so that an exception is thrown before you try to allocate the
buffer (for the same reasons as listed above).

Before allocating a buffer used when processing a chunk of data from a
packet, get a pointer to the chunk with "tvb_get_ptr()", or check that
the data is all there with "tvb_ensure_bytes_exist()", so that an
exception is thrown before you try to allocate the buffer (for the same
reasons as listed above).

Fix up the lengths of the tvbuff used when dissecting ONC RPC opaque data
with a particular dissector.

svn path=/trunk/; revision=10236
2004-02-25 09:31:07 +00:00
Guy Harris 31167cebea From Magnus Hansson:
* Added decoding of Transport type/trigger
	* Updated service code's text to match specification
	* Added new vendor IDs from ODVA
	* Added service etc to info column, formatted info column for
	  easier overview
	* Added actual time out calculation for Forward close,
	  Unconnected send
	* Fixed bug, port not shown for extended addresses
	* Added Network Segment to EPATH decode
	* NOP packets not decoded as they contain Common data Format

svn path=/trunk/; revision=9979
2004-02-04 20:34:53 +00:00
Guy Harris 83cafdc1d6 For EtherNet/IP-over-TCP, handle multiple PDUs in a TCP segment and PDUs
split across segment boundaries.

svn path=/trunk/; revision=9882
2004-01-27 04:43:35 +00:00
Guy Harris 16d0331e43 Fix the handling of padding bytes.
svn path=/trunk/; revision=8620
2003-10-06 08:10:32 +00:00
Guy Harris 18496f5d55 Reject frames with no command (too short) or an invalid command.
Clean up white space somewhat.

svn path=/trunk/; revision=8585
2003-10-01 21:51:59 +00:00
Guy Harris 42c646eeb4 From Joakim Wiberg: change additional status display to word array
instead of byte array.

svn path=/trunk/; revision=8339
2003-09-02 21:17:31 +00:00
Guy Harris bf258889fb From Joakim Wiberg: various fixes and cleanups, including fixes to
malformed packets caused by unconnected send and support for connected
class 3 data.

svn path=/trunk/; revision=8173
2003-08-16 01:53:41 +00:00
Gilbert Ramirez 64a13fd560 Remove some warnings from gcc.
svn path=/trunk/; revision=8085
2003-07-25 04:17:37 +00:00
Guy Harris e502949ecc Show the segment type in the line for an 8-bit logical connection point
segment, as is done for othr logical segments (including 16-bit and
32-bit logical connection point segments).

svn path=/trunk/; revision=7855
2003-06-12 07:33:26 +00:00
Guy Harris 329fcc6750 From Joakim Wiberg: update to the CIP dissector, reverting to the
"EtherNet/IP" name in his original version ("IP" there is "Industrial
Protocol", not "Internet Protocol"), and to the original file name, and
getting rid of some unused variables.

svn path=/trunk/; revision=7851
2003-06-11 22:36:18 +00:00