Commit graph

8541 commits

Author SHA1 Message Date
Ulf Lamping
85e14ceb86 rename REGISTER_xxx_GROUP_NONE to REGISTER_xxx_GROUP_UNSORTED, as NONE seems a bit misleading
svn path=/trunk/; revision=25086
2008-04-17 02:16:39 +00:00
Ulf Lamping
f7a6d27307 fix comments
svn path=/trunk/; revision=25084
2008-04-17 01:45:37 +00:00
Anders Broman
19b0132216 Handle:
SAEB-IE-ContainerList
SAEB-IE-ContainerPairList
and
ProtocolError-IE-ContainerList

svn path=/trunk/; revision=25081
2008-04-16 20:47:34 +00:00
Jeff Morriss
10a67c2028 sccp_ssn_table is not used so remove it. The handoff function does not need to be called after preference changes so stop doing that. Found this on the hunt for bug 2053's cause but it shouldn't (AFAICS) be related.
svn path=/trunk/; revision=25080
2008-04-16 14:28:22 +00:00
Jeff Morriss
1c4a7f8f30 Remove (no longer needed) forward declaration of handoff function
svn path=/trunk/; revision=25079
2008-04-16 14:15:04 +00:00
Richard van der Hoff
bcfb45de67 fields passed into proto_tree_add_bits_* should have bits==0
svn path=/trunk/; revision=25074
2008-04-16 09:49:39 +00:00
Guy Harris
b346a99d0b tvb_get_ephemeral_string() is defined never to return null (currently,
it aborts - even if we don't make it abort, we should make it throw an
assertion, so we abort the dissection of the packet and let the user
know that we ran out of memory).

svn path=/trunk/; revision=25069
2008-04-16 07:23:56 +00:00
Guy Harris
266b212aad The right length to use when scanning all the data in a packet is the
*reported* length, so that if the packet was cut short by a snapshot
length, we get an exception because we run past the end, and the packet
is marked as having been cut short.

Do not use DISSECTOR_ASSERT() to check for the validity of packet data;
dissectors should try to handle even malformed packets, they shouldn't
report malformed packets as dissector bugs (if DISSECTOR_ASSERT(), that
is *ipso facto* evidence of a dissector bug, *even if the packet is
malformed*).

Update the offset when scanning the packet even if we *aren't* building
the protocol tree.

svn path=/trunk/; revision=25068
2008-04-16 07:18:08 +00:00
Ulf Lamping
561c514688 add packet-h263.h
svn path=/trunk/; revision=25066
2008-04-16 00:48:57 +00:00
Sake Blok
1984f23e28 Fix for the "Malformed packet: RPC" that is encountered in bug 1392:
Don't call a RPC subdissector if there is no more data in the packet.


svn path=/trunk/; revision=25058
2008-04-15 22:53:34 +00:00
Gerald Combs
b65d445bf2 Fix a typo found by Don Arrowsmith.
svn path=/trunk/; revision=25056
2008-04-15 21:45:46 +00:00
Sake Blok
3751e74f67 From Didier (bug 1392):
Add port to conversation key so that RPC reassembly works when relative
sequence numbers are used.


svn path=/trunk/; revision=25055
2008-04-15 21:12:38 +00:00
Anders Broman
ce1abe9f3b Fix some typos etc.
svn path=/trunk/; revision=25053
2008-04-15 20:40:06 +00:00
Anders Broman
a7144cf536 From Jonas Nilsson:
Add dissection of Measurement report and result and minor bugfixes.

svn path=/trunk/; revision=25052
2008-04-15 20:37:53 +00:00
Richard van der Hoff
4a8ee5ed25 bitmasks are unnecessary with proto_tree_add_bits_*, and indeed break filtering.
svn path=/trunk/; revision=25050
2008-04-15 17:28:11 +00:00
Richard van der Hoff
30bd275138 i'm an idiot. we don't need to dissect data unless tree is non-NULL.
We *do* need to pass it through to h263data, however.

svn path=/trunk/; revision=25049
2008-04-15 17:26:29 +00:00
Richard van der Hoff
b1d400bb2d rename protocol to h263
svn path=/trunk/; revision=25048
2008-04-15 16:03:38 +00:00
Richard van der Hoff
6f9dbbdae8 rename header fields so that they can be distinguished from the h.263 ones
svn path=/trunk/; revision=25047
2008-04-15 15:15:35 +00:00
Richard van der Hoff
5dcbfbf800 split the various bits of h263 dissector into separate files, so that we
can see which fields belong to which bit.

Also make sure that we can filter on the fields in the rfc2190 dissector
by actually parsing them even when tree=NULL.


svn path=/trunk/; revision=25046
2008-04-15 14:52:15 +00:00
Luis Ontanon
0fca04e6a0 attempt to fix init.lua construction in Windows.
more diagnostics to make-init-lua.pl


svn path=/trunk/; revision=25044
2008-04-15 12:22:25 +00:00
Luis Ontanon
1cbce0623f It is useless in a Protocol Analyzer to avoid the user to have a password shorter than 8 chars.
svn path=/trunk/; revision=25043
2008-04-15 12:12:20 +00:00
Luis Ontanon
602de4d33c Die stating why when a file could no be opened.
svn path=/trunk/; revision=25042
2008-04-15 10:22:39 +00:00
Stig Bjørlykke
87a476645b Call DISSECTOR_ASSERT instead of g_assert in dissector code.
svn path=/trunk/; revision=25040
2008-04-15 06:58:37 +00:00
Stig Bjørlykke
04eb913d71 Call DISSECTOR_ASSERT instead of g_assert in dissector code.
This fixes bug 2464.

svn path=/trunk/; revision=25039
2008-04-15 06:57:56 +00:00
Jaap Keuter
6b142f5016 From Roberto Morro:
Added support for RFC4207 (SONET/SDH encoding for LMP test messages);
added support for (provisional) oif-p0040.010.006 (OIF interoperability demo
during ECOC2007).

svn path=/trunk/; revision=25038
2008-04-15 06:47:05 +00:00
Ulf Lamping
7a8c589d32 don't use strdup() if you want to free the memory later with g_free(), this doesn't work (at least) on MSVC2005 builds!
svn path=/trunk/; revision=25037
2008-04-15 02:21:04 +00:00
Jaap Keuter
10a55966b2 Fix for bug 2458:
Adding dissection for more recent PPPoE tags.

svn path=/trunk/; revision=25031
2008-04-14 22:32:17 +00:00
Jörg Mayer
dc85c37b17 packet-ieee802154.c will create a warning using gcc 4.3
svn path=/trunk/; revision=25030
2008-04-14 21:35:35 +00:00
Jörg Mayer
60547db130 gcc 4.3 will not handle an overflow in the expected way but will warn instead. -Werror does the rest
svn path=/trunk/; revision=25029
2008-04-14 21:33:56 +00:00
Jörg Mayer
944beafd70 Get rid of some unsued code: The warning causes a failure due to -Werror
svn path=/trunk/; revision=25028
2008-04-14 21:31:19 +00:00
Luis Ontanon
4eb08aad66 From Marton Nemeth:
Addenda and fixes to WSLUA_CLASS_DEFINE documentation

Mine: fix init.lua generation



svn path=/trunk/; revision=25025
2008-04-14 21:16:32 +00:00
Stig Bjørlykke
5acf099bd2 From Roberto Morro (bug 2416):
Added support for Ethernet SENDER_TSPEC and FLOWSPEC objects according to
draft-ietf-ccamp-ethernet-traffic-parameters-02.
Added support for enhancements in the LSP_TUNNEL_INTERFACE_ID object according
to draft-ietf-ccamp-lsp-hierarchy-bis-02.
Added support for NOTIFY_REQUEST and RECOVERY_LABEL objects.
Added display filters for some fields of the GENERALIZED_UNI and CALL_ID
objects.

svn path=/trunk/; revision=25023
2008-04-14 19:43:39 +00:00
Jörg Mayer
7bad41d7aa The unknown value (aka flags) can take any value
svn path=/trunk/; revision=25022
2008-04-14 19:34:05 +00:00
Jörg Mayer
f932eb742d Add a FIXME
svn path=/trunk/; revision=25021
2008-04-14 19:31:36 +00:00
Jörg Mayer
6935e50369 Get rid of a warning in gcc 4.3: An integer overflow will not cause a sign change
svn path=/trunk/; revision=25020
2008-04-14 19:30:35 +00:00
Stig Bjørlykke
03c1c32b5c From Philip Frey (bug 2443):
Fixed issues from last patch.

svn path=/trunk/; revision=25018
2008-04-14 19:22:19 +00:00
Jaap Keuter
e3463e8d53 From Jim Young:
Within the packet-diameter_3gpp.c module, the call to proto_register_protocol()
comes AFTER the proto_register_field_array() call. 
While the delayed call to proto_register_protocol() does not appear to impair the use 
of the display filters, it DOES effect the generation of the wireshark-filter man page.

svn path=/trunk/; revision=25014
2008-04-14 06:43:42 +00:00
Ulf Lamping
79ebaba30a export emem_tree_foreach as requested by user
svn path=/trunk/; revision=25003
2008-04-13 21:59:39 +00:00
Stig Bjørlykke
428703d8ad From Giodi Giorgi (bug 2201):
Fix dumping of PROTECTION INFO and GENERALIZED UNI according to RFC3471.

svn path=/trunk/; revision=25002
2008-04-13 21:57:04 +00:00
Jaap Keuter
c22bfae716 Fix for bug 1603:
SMPP validity period as relative time interpretation corrected.

svn path=/trunk/; revision=25001
2008-04-13 21:54:07 +00:00
Stig Bjørlykke
da74314d91 Initialize linelen to avoid a warning.
svn path=/trunk/; revision=24994
2008-04-13 16:58:57 +00:00
Stig Bjørlykke
b65207f6de Initialize conversation.
svn path=/trunk/; revision=24993
2008-04-13 16:55:56 +00:00
Stig Bjørlykke
772b24c149 Fix the crash from bug 2432. I don't really like that we use a new tvb
and a new data source for displaying unaligned octet strings, because the
user cannot easily see where in the data package the values are from.

Maybe we should implement a "Packet Bits" pane for bit protocols?
Or just an option to turn the Bytes pane to a Bits pane?

Another problem is that the generated pdml (from the bug report) does not
generate correct data for these fields, as the "pos" value is always zero
(because we use a new tvb with offset 0).  But I suppose it's difficult to
fix this with byte values...

svn path=/trunk/; revision=24992
2008-04-13 16:42:41 +00:00
Graeme Lunt
847d2bcb88 Support for some additionl heading fields and the display of the (non-MIME) message text.
svn path=/trunk/; revision=24991
2008-04-13 16:38:01 +00:00
Graeme Lunt
fb6d3314b5 Support for the reassembly dissection of IMF/MIME messages retrieved over POP using the RETR and TOP commands.
The reassembly is, as usual, a preference.


svn path=/trunk/; revision=24990
2008-04-13 16:36:41 +00:00
Graeme Lunt
fe88a7720d Support for RFC 2920 SMTP Command Pipelining.
The client can send multiple requests before waiting for responses.
Multiple requests/responses are delimited in the info column using  " | ".

Also changed to using "C:" (client) and "S:" (server) to save space in the info column and align with examples in RFC 2821.

Lack of support for PIPELINING was shown up during Sake's session at SharkFest08!


svn path=/trunk/; revision=24989
2008-04-13 16:33:44 +00:00
Graeme Lunt
668e79995a Removed #defined preference grouping
svn path=/trunk/; revision=24987
2008-04-13 16:21:08 +00:00
Graeme Lunt
85536e668e Removal of #defined preference grouping and tidy up agreement id.
svn path=/trunk/; revision=24986
2008-04-13 16:20:12 +00:00
Graeme Lunt
fb3b8307e8 Remove #defined preference grouping
svn path=/trunk/; revision=24985
2008-04-13 16:18:40 +00:00
Graeme Lunt
9bd868fae7 Support for RFC 4530 - LDAP entryUUID attribute.
svn path=/trunk/; revision=24984
2008-04-13 16:14:03 +00:00