Commit Graph

5807 Commits

Author SHA1 Message Date
Tim Potter 7c8ae51531 A printer port name is a notification string, not a two word value.
A RFNPCNEX request contains a NOTIFY_OPTIONS_ARRAY_CTR instead of a
NOTIFY_OPTIONS_ARRAY.

svn path=/trunk/; revision=5639
2002-06-07 03:42:02 +00:00
Gerald Combs 563a25c153 Keep an invalid packet length from overflowing a data buffer.
svn path=/trunk/; revision=5638
2002-06-06 22:42:27 +00:00
Guy Harris 358df4f2f4 From Michael Tuexen: remove the old workaround for "select()"s not
working on MacOS X.

It appears that the underlying problem with the timeout was that we
weren't treating MacOS X as a BSD, and the "select()" we were doing
presumably wasn't working as it doesn't work on BPF devices on many
BSDs; the workaround no longer appears to be necessary, with Michael's
fix to treat MacOS X as BSD.

(Presumably a select timeout with "tv_usec" set to 1000*1000
microseconds was treated as an error, or otherwise treated in such a way
that it didn't block waiting for the BPF device to say it could be
read.)

svn path=/trunk/; revision=5637
2002-06-06 19:03:39 +00:00
Guy Harris 7acc6a8e1a Use "phtons()", not "htons()", just as we use "pntohs()" rather than
"ntohs()".

svn path=/trunk/; revision=5636
2002-06-06 18:58:12 +00:00
Nathan Neulinger c66c1ba70a more dissection of flags, break out into subs
svn path=/trunk/; revision=5635
2002-06-06 13:17:49 +00:00
Guy Harris cf204c9938 Properly check for unknown RSVP message types.
Note where the message types are defined.

svn path=/trunk/; revision=5634
2002-06-06 11:02:05 +00:00
Guy Harris bb778e86a7 Support the Solaris+SunATM libpcap capture file type (not yet checked
into libpcap or tcpdump, but the LINKTYPE_ number is reserved for that
purpose).

svn path=/trunk/; revision=5633
2002-06-06 09:18:28 +00:00
Tim Potter 7db4c88dcd Dissect spoolss FCPN. Not sure what it stands for.
svn path=/trunk/; revision=5632
2002-06-06 05:46:55 +00:00
Tim Potter fb78dde09e Implemented ReplyClosePrinter().
Fixed calls to dissect_nt_policy_hnd() as ReplyOpenPrinter() opens a
handle and ReplyClosePrinter() closes one.

svn path=/trunk/; revision=5631
2002-06-06 03:18:14 +00:00
Guy Harris b9ba6ca176 From Martin Gignac: make the MMS heuristic dissector recognize packets
that lack a Transaction-Id header, as some packets don't have one.

svn path=/trunk/; revision=5630
2002-06-05 23:54:10 +00:00
Guy Harris d0773ba9bf From Martin Gignac: fix some values to match the
WAP-209-MMSEncapsulation-20020105-a spec.

svn path=/trunk/; revision=5629
2002-06-05 19:03:42 +00:00
Nathan Neulinger 715ba268f9 add support for bitfield of global session options, nt proto options, and connect flags, needs verification likely
svn path=/trunk/; revision=5628
2002-06-05 17:41:59 +00:00
Ronnie Sahlberg 1e043ca82a Updated NDMP and ONC RPC services to use the new function to display
fregment trees.

svn path=/trunk/; revision=5627
2002-06-05 11:32:14 +00:00
Ronnie Sahlberg 31823cb851 Added show_fragment_tree() to reassemble. This function will do the common
task of creating a fregment tree for the fragmented packets.
Having this identical code to create this tree in every dissector that does
PDU reassembly is a huge waste and duplication of code.

Updated IP, SMB and DCERPC to use the new function.

svn path=/trunk/; revision=5626
2002-06-05 11:21:49 +00:00
Tim Potter 230ac0da7a Implemented RRPCN (RemotePrinterChangeNotification).
Use the di->levels field to pass info to notify options rather than
mucking about with the private_data fields which mysteriously doesn't
work.

Fixed some display bugs in notify data.

svn path=/trunk/; revision=5625
2002-06-05 07:15:47 +00:00
Tim Potter 134404b92a Added dissect_ndr_uint16s() utility function for dissecting a buffer
of uint16 values.

svn path=/trunk/; revision=5624
2002-06-05 04:17:47 +00:00
Tim Potter 4616797423 Converted all reply functions to use dissect_doserror() instead of
prs_werror().

Converted RFFPCNEX (FindFirstPrintChangeNotification) to Ronnie's NDR
routines.

Implemented RFNPCNEX (FindNextPrintChangeNotification).  Print
notification data is dissected in a length/buffer format instead of
dissecting as the underlying type (string secdesc, devmode etc).

svn path=/trunk/; revision=5623
2002-06-05 04:15:30 +00:00
Tim Potter 18324cb59a Added a whole lot of print notification constants.
svn path=/trunk/; revision=5622
2002-06-05 04:12:22 +00:00
Gerald Combs 8c89f47bf5 Change bvlc_result_name() and bvlc_function_name() to value_strings.
This fixes a problem where bvlc_result_name() would cause a segfault if
passed a bad value.

svn path=/trunk/; revision=5621
2002-06-05 00:03:06 +00:00
Guy Harris 2dbb4324e3 From Michael Tuexen: treat Darwin/MacOS X like the other BSDs, as its
BPF, in at least some OS versions, acts like the other BPFs in some
versions of other BSDs, and doesn't work with "select()".

svn path=/trunk/; revision=5620
2002-06-04 22:15:12 +00:00
Guy Harris 290fc65130 The "sequential_close" routine for a capture file type, if it has one,
is always called before the "close" routine is called, so the "close"
routine doesn't need to free anything that's freed by the
"sequential_close" routine.

svn path=/trunk/; revision=5619
2002-06-04 21:56:45 +00:00
Guy Harris 15a5bdca30 The frame table isn't needed once we've made a sequential pass through
the packets, as the offsets of the frames have been saved by our caller
(because they need them to pass to the random-read routine); add a
sequential_close routine for Netmon files and free up the frame table in
that routine.

svn path=/trunk/; revision=5618
2002-06-04 21:55:38 +00:00
Guy Harris f103a8a076 From Graeme Hewson: varargs code cleanup in "simple_dialog.c".
svn path=/trunk/; revision=5617
2002-06-04 11:24:35 +00:00
Guy Harris bc5a543e03 From Graeme Hewson:
This fixes some bugs:

	1. With the -S option under Linux, Capture/Stop or ^E was
	ignored until the next packet was read.  This is because
	capture.c wasn't checking for EINTR from select(), which is
	returned when the child receives SIGUSR1 from the parent.

	2. When reading from a pipe, a spurious error message from
	pcap_open_live() was written to stderr.

	3. Error messages from the child in Sync mode were displayed in
	a Warning alert box.

	Also, there's a new subroutine, popup_errmsg(), to replace
	several instances of duplicate code.

svn path=/trunk/; revision=5616
2002-06-04 11:19:59 +00:00
Guy Harris 117f95bb39 Clean up white space.
svn path=/trunk/; revision=5615
2002-06-04 07:48:57 +00:00
Guy Harris 392a7dfc04 Get rid of the "data_src" member of the "frame_data" structure; put it
in the "packet_info" structure instead, as we don't need a pointer for
every single frame in the capture file, just for each frame for which we
currently have an open "epan_dissect_t".

svn path=/trunk/; revision=5614
2002-06-04 07:03:57 +00:00
Guy Harris 1155a2fb43 From Martin Gignac: fix the "cc" field.
svn path=/trunk/; revision=5613
2002-06-03 19:00:00 +00:00
Gerald Combs cf247c7360 Require that the LMP and RSVP message types be greater than 0.
svn path=/trunk/; revision=5612
2002-06-02 23:55:11 +00:00
Gerald Combs 0caa130763 Mark a frame invalid if its message type value exceeds
LMPF_MSG_CHANNEL_STATUS_RESP.

svn path=/trunk/; revision=5611
2002-06-02 21:42:58 +00:00
Gerald Combs 8de8efa284 Mark frames with a subvector length of less than one as being invalid.
svn path=/trunk/; revision=5610
2002-06-02 17:51:00 +00:00
Ronnie Sahlberg 6fb5e72ab1 TAPI interface.
svn path=/trunk/; revision=5609
2002-06-02 12:33:15 +00:00
Ronnie Sahlberg c9f2880cff Another small DCERPC interface from the winsows world implemented. TAPI.
svn path=/trunk/; revision=5608
2002-06-02 12:32:10 +00:00
Guy Harris f8b5326405 Install the Diameter DTD and XML files in the "diameter" subdirectory
of the directory for Ethereal configuration files, not the configuration
file directory, as the Diameter dissector looks for them in the
subdirectory.

svn path=/trunk/; revision=5607
2002-06-01 22:17:22 +00:00
Guy Harris 921f66e709 Install the Diameter DTD and XML files in the "diameter" subdirectory
of the directory for Ethereal configuration files, not the configuration
file directory, as the Diameter dissector looks for them in the
subdirectory.

svn path=/trunk/; revision=5606
2002-06-01 22:11:17 +00:00
Guy Harris ed670cfe44 Put in an update about libpcap 0.7.1 appearing to handle BPF not too
badly (especially given problems that have been seen with DLPI, e.g. not
seeing outgoing packets).

svn path=/trunk/; revision=5605
2002-05-31 10:22:51 +00:00
Tim Potter 501daf1770 Removed some trailing commas from various DCERPC dissectors.
svn path=/trunk/; revision=5604
2002-05-31 00:31:13 +00:00
Guy Harris 1504346601 SMB 0x31 is "Close And Tree Disconnect", not "Close And Tree Discover",
and it looks like "Close" (it's a close that also disconnects the tree
used for the SMB).

svn path=/trunk/; revision=5603
2002-05-30 11:29:38 +00:00
Ronnie Sahlberg ebdfa84dee From KevinM, fixes for the L2TP protocol. Incorrect display filter names.
svn path=/trunk/; revision=5602
2002-05-30 10:09:27 +00:00
Ronnie Sahlberg 7f798e68ee Fixed bug when dissectors forgot to eat the array headers for conformant_run==1
resulting in an assert to abort ethereal.
It shows that the assers worked and that it will find bugs and not allow the dissectors to misdissect the packets.

svn path=/trunk/; revision=5601
2002-05-30 10:06:58 +00:00
Guy Harris 531cb17873 From Albert Chin: fix various non-GCC compiler warnings.
svn path=/trunk/; revision=5600
2002-05-30 08:34:19 +00:00
Guy Harris ca03167c44 Don't pass "tvb_reported_length_remaining(tvb, offset)" as the fourth
argument to "tvb_new_subset()" - just use -1 if the subset tvbuff is to
run to the end of the parent tvbuff.

svn path=/trunk/; revision=5599
2002-05-30 05:26:05 +00:00
Guy Harris 8ec09e1441 Don't pass "tvb_reported_length_remaining(tvb, offset)" as the fourth
argument to "tvb_new_subset()" - just use -1 if the subset tvbuff is to
run to the end of the parent tvbuff.

svn path=/trunk/; revision=5598
2002-05-30 02:04:43 +00:00
Guy Harris 4401f1433f Don't pass "tvb_reported_length_remaining(tvb, offset)" as the fourth
argument to "tvb_new_subset()" - just use -1 if the subset tvbuff is to
run to the end of the parent tvbuff.

svn path=/trunk/; revision=5597
2002-05-30 01:56:55 +00:00
Guy Harris b5f0786318 Don't assume that just because a purported font name begins with "-"
it's an XLFD font name.

svn path=/trunk/; revision=5596
2002-05-30 00:44:50 +00:00
Tim Potter 1852e00c8a Removed debugging fprintf calls.
svn path=/trunk/; revision=5595
2002-05-30 00:20:32 +00:00
Guy Harris dc4106b0b1 From Martin Gignac: fix Sender-Visibility field to use the right
value_string table.

Clean up capitalization.

svn path=/trunk/; revision=5594
2002-05-29 22:52:55 +00:00
Guy Harris f2880aad6b AODV6 support, from Antti Tuominen.
svn path=/trunk/; revision=5593
2002-05-29 21:32:23 +00:00
Guy Harris 2a8dfde425 Display unsigned quantities with "%u".
svn path=/trunk/; revision=5592
2002-05-29 19:55:55 +00:00
Guy Harris a6b22a6bec Update the item on turning off name resolution to mention the "-N" flag
and the preference item.

svn path=/trunk/; revision=5591
2002-05-29 19:16:40 +00:00
Guy Harris 0feb7affba Java RMI protocol support, from Michael Stiller.
svn path=/trunk/; revision=5590
2002-05-29 18:52:28 +00:00