Commit Graph

5807 Commits

Author SHA1 Message Date
Guy Harris cc00331455 From Kan Sasaki:
1. Add some VSAs.

	2. Modify the routines match_numval() and
	   rd_match_strval_attrib() to use a null string pointer, rather
	   than a 0 value, to signify the end of the attribute table,
	   because some vendors are using an attribute with a value of 0.

	3. Bug fix.

svn path=/trunk/; revision=5890
2002-07-17 01:02:45 +00:00
Guy Harris 77fa06b899 From Joerg Mayer:
dftest.c:
	     Remove #if-0-ed includes

	packet-ieee80211.c, packet-wtls.c, packet-afp.c, packet-wsp.c,
        packet-wtp.c, ethereal_gen.py:
	     Remove redundant include varargs (already in snprintf.h,
	     and required only for snprintf.h)

	Remove unused include of snprintf.h from files not using
	"snprintf()".

svn path=/trunk/; revision=5889
2002-07-17 00:43:03 +00:00
Guy Harris ca6badc579 Get rid of some "unused variable" and "unused static function" warnings,
and some compile errors in Tethereal, when compiling without libpcap.

If libpcap is missing (whether that's detected at compile time or, as on
Windows, at run time), don't call any of the "capture_prefs" routines -
the routine to create the capture preferences page wasn't called, so the
other routines can try to refer to non-existent widgets and other items
and crash.

Get rid of the stub routines in "capture_prefs()" used when compiling
without libpcap, as they're no longer called.

svn path=/trunk/; revision=5888
2002-07-17 00:22:30 +00:00
Guy Harris ff49944dcd From Joerg Mayer: add #includes of "snprintf.h" in modules that used
"snprintf()" but weren't including "snprintf.h".

svn path=/trunk/; revision=5887
2002-07-16 22:50:48 +00:00
Guy Harris f65887d220 Get rid of carriage returns.
svn path=/trunk/; revision=5886
2002-07-16 10:11:41 +00:00
Guy Harris c10a2f283d Don't allocate structures to remember how to re-access a packet's data,
or the array to hold pointers to those structures, if we're only reading
the file sequentially.

svn path=/trunk/; revision=5885
2002-07-16 09:41:32 +00:00
Guy Harris 44d19627ef From Graeme Hewson:
Allow "-" as the output file name in Wiretap, referring to the
	standard error.

	Optimize the capture loop.

Fix some of the error-message printing code in Ethereal and Tethereal.

Have Wiretap check whether it can seek on a file descriptor, and pass
the results of that test to the file-type-specific "open for output"
routine.  Have the "open for output" routines for files where we need to
seek when writing the file return an error if seeks don't work.

svn path=/trunk/; revision=5884
2002-07-16 07:15:09 +00:00
Guy Harris 41dc7b1b59 From Graeme Hewson:
In sync mode, if the capture file written by the child can't be
	opened by the parent, ethereal will write two identical popup
	error messages.

	This patch fixes the problem.

svn path=/trunk/; revision=5883
2002-07-16 05:43:39 +00:00
Guy Harris a77d6a14c2 Update the "NT sucks for PPP capture" note to include NT 5.1 (XP and
.NET Server).

Fix indentation.

svn path=/trunk/; revision=5882
2002-07-15 23:25:59 +00:00
Ashok Narayanan 7f7af9143a Added support for dissecting RSVP Bundle Messages
svn path=/trunk/; revision=5881
2002-07-15 21:19:56 +00:00
Guy Harris e0dc69929e From Joerg Mayer:
Replace our own definitions of TRUE/FALSE by their glib.h
	equivalents.  Put sys/types.h into ifdefs.

svn path=/trunk/; revision=5880
2002-07-15 20:57:13 +00:00
Guy Harris 736c64296e From Joerg Mayer:
Use the GLib macros to convert from network to host byte order.

svn path=/trunk/; revision=5879
2002-07-15 20:55:51 +00:00
Guy Harris 4c86bb6b38 From Joerg Mayer:
Change struct addr to guint32 which is the way it is used
	anyway.

	Use the GLib macros to convert from network to host byte order.

svn path=/trunk/; revision=5878
2002-07-15 20:54:45 +00:00
Guy Harris a650adbf57 Fix a sample call to add an item to the subtree for a protocol to add it
there rather than to the top-level tree, and use
"proto_tree_add_item()".

Add a description of PROTOSHORTNAME, and give an example of the way
PROTONAME, PROTOSHORTNAME, and PROTOABBREV would be set for a protocol.

svn path=/trunk/; revision=5877
2002-07-15 20:31:06 +00:00
Guy Harris 976fcf09d4 The mysterious two bytes were just the FCS. Use the length field from
the IP header as the reported length again, but make the actual length
be the minimum of the length of the tvbuff and the reported length, just
to keep from having a weird tvbuff that has more data than the packet
has.

svn path=/trunk/; revision=5876
2002-07-15 09:56:04 +00:00
Guy Harris 6f9a78cc79 Clean up the setting of "id_offset" and "sd_offset"; this fixes a bug in
handling the first few packets in a file.

svn path=/trunk/; revision=5875
2002-07-15 09:50:02 +00:00
Guy Harris 5b3660e693 SMTP and FTP response codes need more than 1 byte, as they can go up to
999; give them 4.

svn path=/trunk/; revision=5874
2002-07-15 09:40:20 +00:00
Guy Harris 2537158d48 Redo the way random access is handled. Save, for each packet, the
offset of the beginning of the first record containing data from that
packet, and the offset from the first byte of data in that record of the
first byte of data from that packet; to read a given packet, seek to the
offset of the first record, and keep processing packets until we find
one with the right direction.

This fixes a problem where it wasn't correctly reading the packet, when
doing random access, in cases where you have a sequence of records that
stop in the middle of a packet.

svn path=/trunk/; revision=5873
2002-07-15 08:45:32 +00:00
Richard Sharpe eac7bf1188 This seems to fix the problem of trying to save over the top of an existing
capture on some occassions.

svn path=/trunk/; revision=5872
2002-07-15 05:14:26 +00:00
Guy Harris fbaa0dd809 Add Booleans for the Ack and Srefresh messages, and move the Boolean for
the HELLO message to be in numerical message-code order.

svn path=/trunk/; revision=5871
2002-07-14 19:33:16 +00:00
Guy Harris 5e2787151a Add a Boolean field for the Bundle message type.
svn path=/trunk/; revision=5870
2002-07-14 19:23:04 +00:00
Guy Harris 3dc1693e97 Clarify the octet-stuffed framing code, by adding comments and by using
hex values rather than characters in a switch statement.

svn path=/trunk/; revision=5869
2002-07-14 10:59:38 +00:00
Guy Harris 4ceeb56841 Make the reported length of the VJ-uncompressed tvbuff the reported
length of the data in the PPP packet, not the value from the IP header,
just in case there's extra crap at the end.  (That appears to be the
case in at least one pppdump capture filel; that's probably either a bug
in the version of pppdump that produced the capture or in the pppdump
reading code, but, until we fix that, if we can, let's at least get this
right, so that the reported length of the tvbuff won't be less than the
length unless that was the case for the tvbuff handed to us.)

svn path=/trunk/; revision=5868
2002-07-14 08:57:56 +00:00
Guy Harris 2e7f37aee7 From Anand V. Narwani: fix so that when a filter is applied to a DOCSIS
management frame, the Info column isn't erased.

Replace a call to "tvb_length_remaining()" with the value returned by a
earlier identical call.

svn path=/trunk/; revision=5867
2002-07-14 08:37:45 +00:00
Guy Harris 9d1fdfedb7 Only put "smtp.req" into the tree for packets that contain request
lines, and only put "smtp.rsp" into the tree for packets that contain
reply lines; don't put either into the tree for packets that contain
only message body text or an EOM.

svn path=/trunk/; revision=5866
2002-07-14 08:27:34 +00:00
Guy Harris c5a0e76a76 In FTP, a normal reply line has a 3-digit number at the beginning - a
line that doesn't is a middle line of a multi-line reply.  Treat only
lines with a 3-digit number at the beginning as reply lines with a
response code and response argument.

Provide filterable fields for the SMTP command and parameters, and the
SMTP reply code and parameters, along the lines of what's done for FTP.

svn path=/trunk/; revision=5865
2002-07-14 00:40:07 +00:00
Guy Harris 331c6c3fbd Fix a typo.
svn path=/trunk/; revision=5864
2002-07-13 20:08:33 +00:00
Guy Harris ab97d374eb From Joerg Mayer: add missing include.
svn path=/trunk/; revision=5863
2002-07-13 19:33:20 +00:00
Tim Potter 784204a500 Fixed up some warnings.
svn path=/trunk/; revision=5862
2002-07-13 04:32:14 +00:00
Guy Harris 8a9b35cb5e From Anand V. Narwani:
DOCSIS support, including support for "Ethernet" captures where
	    the raw frame is a DOCSIS frame rather than an Ethernet
	    frame (some Cisco cable-modem head-end gear can send out a
	    trace of all traffic on an Ethernet, but what it sends are
	    the raw bytes of DOCSIS frames, not Ethernet frames)

Get rid of second AUTHORS entry for Devin Heitmueller, merging its item
into the older entry.

Clean up the order of some lists of plugin items.

svn path=/trunk/; revision=5861
2002-07-12 22:52:43 +00:00
Guy Harris 8f7a0ba2e1 IUA updates from Michael Tuexen:
provide compatibility with
	   http://www.ietf.org/rfc/rfc3057.txt
	   http://www.ietf.org/internet-drafts/draft-ietf-sigtran-iua-imp-guide-00.txt

	Make all packet fields searchable.

	Add a preference for support of the Implementers Guide.

svn path=/trunk/; revision=5860
2002-07-12 19:37:33 +00:00
Gerald Combs 5d50007db0 Add NSIS checkbox bitmaps.
svn path=/trunk/; revision=5859
2002-07-11 18:43:35 +00:00
Tim Potter 202b8793e8 Added another authentication service for Snego.
svn path=/trunk/; revision=5858
2002-07-11 04:46:32 +00:00
Guy Harris cb4c2bdc3e From Michael Tuexen:
get rid of presumably-unneeded #includes;

	correct the DATA chunk handling when padding bytes are
	available.

svn path=/trunk/; revision=5857
2002-07-10 21:01:57 +00:00
Guy Harris ffe5c2cbe9 From Thierry Pelle: Redback vendor-specific items for RADIUS and L2TP.
svn path=/trunk/; revision=5856
2002-07-10 20:55:45 +00:00
Guy Harris e7dbdc13fa The time stamps in credentials, at least, sometimes appear to be
UNIX-style "time_t" values (seconds since January 1, 1970, 00:00:00 GMT
- yes, GMT, not local time as in UTIME values).

They also appear to require 4-byte alignment.

svn path=/trunk/; revision=5855
2002-07-10 06:54:24 +00:00
Guy Harris 4d1afddfab Show lengths as decimal, not hex.
Show an authentication message's contents as "Unknown contents", not as
an "Unrecognized NTLMSSP Message".

svn path=/trunk/; revision=5854
2002-07-10 06:17:55 +00:00
Guy Harris 23a0d7e548 Put back the code to show the authentication data as "Auth Data"; call
it if we don't show it as NTLMSSP.

Use #defines for the authentication protocols.

svn path=/trunk/; revision=5853
2002-07-10 06:16:14 +00:00
Guy Harris 90922fb718 Fix some other errors.
svn path=/trunk/; revision=5852
2002-07-10 04:29:23 +00:00
Guy Harris caaccf5a94 Fix an erroneous example.
svn path=/trunk/; revision=5851
2002-07-10 04:24:37 +00:00
Tim Potter 7ad8ddcc46 Reordered some boolean fields to be consistent with the rest of ethereal.
svn path=/trunk/; revision=5850
2002-07-10 02:59:38 +00:00
Tim Potter f56ccc93ab Added Devin for NTLMSSP dissector.
svn path=/trunk/; revision=5849
2002-07-09 20:52:46 +00:00
Tim Potter 8d4650823d Dissector for DCERPC auth type == 10 (NTLMSSP) from
dheitmueller@netilla.com.

svn path=/trunk/; revision=5848
2002-07-09 20:49:27 +00:00
Guy Harris 5b4159ad1e From Bernd Becker:
- changed field types of the Trace Cross Facility Items
	  (hf_tns_trace_cf1 and hf_tns_trace_cf2) from FT_UINT16
	  to FT_UINT32
	- changed field type of Trace Unique Connection ID (tns.trace_cid)
	  to FT_UINT64
	- changed the base for display of some length fields from BASE_HEX
	  to BASE_DEC (tns.accept_data_length, tns.refuse_data_length,
	  tns.redirect_data_length)
	- corrected typo in field name for tns.refuse_reason_system

based on the output of the Oracle trace tool trcasst (specifically
trcasst -od) on Oracle 9.0.1.

svn path=/trunk/; revision=5847
2002-07-09 20:02:54 +00:00
Tim Potter 98933ccb32 Converted form related dissectors from prs_* routines to dissect_ndr_*
routines.

svn path=/trunk/; revision=5846
2002-07-09 14:24:39 +00:00
Ronnie Sahlberg c068194c6b Updated GetDCName LogonControl and GetAnyDCName
svn path=/trunk/; revision=5845
2002-07-09 13:32:29 +00:00
Guy Harris c3fc75e610 Desegmentation of multi-TCP-segment TNS messages (and support for
multiple TNS messages per TCP segment), from Bernd Becker.

svn path=/trunk/; revision=5844
2002-07-08 22:57:55 +00:00
Guy Harris 225914a343 From Michael Tuexen: update for the ASAP dissector which provides
support for the new version of the I-Ds

    http://www.ietf.org/internet-drafts/draft-ietf-rserpool-common-param-01.txt
    http://www.ietf.org/internet-drafts/draft-ietf-rserpool-asap-04.txt

svn path=/trunk/; revision=5843
2002-07-08 21:09:32 +00:00
Guy Harris 2d84cd97ce Give some more information on the "command.com" vs. "cmd.exe" issue.
svn path=/trunk/; revision=5842
2002-07-08 21:03:04 +00:00
Ronnie Sahlberg c819581499 Updated ACCOUNTDELTAS and ACCOUNTSYNC functions
svn path=/trunk/; revision=5841
2002-07-08 14:01:46 +00:00