Commit Graph

16325 Commits

Author SHA1 Message Date
Ronnie Sahlberg 8e2ab17da8 dont dereference null pointers
svn path=/trunk/; revision=16466
2005-11-11 07:49:13 +00:00
Ronnie Sahlberg 886e149907 the uid is 64 bits
svn path=/trunk/; revision=16465
2005-11-11 07:41:09 +00:00
Ronnie Sahlberg 6c348b1db4 from albert chin
remove some c99-isms


svn path=/trunk/; revision=16464
2005-11-11 04:35:22 +00:00
Ronnie Sahlberg 078ef72ee4 break out some structures into packet-smb2.h so we can start tapping in later
we will do service-response-time   statistics before other inferior products have even noticed a new protocol is in town.




svn path=/trunk/; revision=16463
2005-11-11 03:50:53 +00:00
Gerald Combs 66296cdf17 Don't use null values for blurbs in header fields.
svn path=/trunk/; revision=16462
2005-11-11 00:04:37 +00:00
Ronnie Sahlberg 46f0739541 start decoding SMB2_FILE_INFO_22
svn path=/trunk/; revision=16461
2005-11-10 22:46:10 +00:00
Ronnie Sahlberg f10211313f from albert chan
dont use a variable with the name dirname since it will collide with symbols on some hosts


svn path=/trunk/; revision=16460
2005-11-10 21:52:55 +00:00
Ronnie Sahlberg 8d54b19302 from albert chin
dont use c++ style comments


svn path=/trunk/; revision=16459
2005-11-10 21:50:30 +00:00
Ronnie Sahlberg b78b018dbc use the policy_handle framework for dcerpc to trach which frame a policy handle is opened in and which one it is closed in.
also attempt to store a name for it   like File:foo


but this does not work yet.




svn path=/trunk/; revision=16458
2005-11-10 10:08:32 +00:00
Guy Harris cdd6ccea1d Don't pass signed characters to the <ctype.h> macros.
svn path=/trunk/; revision=16457
2005-11-10 07:42:23 +00:00
Guy Harris 07d0b328c7 Include <ctype.h> to declare "isprint()".
svn path=/trunk/; revision=16456
2005-11-10 07:26:30 +00:00
Guy Harris 13a24cc310 There's no guarantee that BYTE_ORDER is defined as anything useful, and
the BYTE_ORDER == BIG_ENDIAN values for FMIP_HI_FLAG_ASSIGNED and
FMIP_HI_FLAG_BUFFER are bogus for the way they're used anyway (they're
used to check bits in a one-byte value), so throw away those values, and
get rid of the leading 00 in the BYTE_ORDER == LITTLE_ENDIAN values.

svn path=/trunk/; revision=16455
2005-11-10 03:16:25 +00:00
Guy Harris 177dc6902c Skip some toolbar #includes if we're not using GTK+ 2.x.
svn path=/trunk/; revision=16454
2005-11-10 03:00:43 +00:00
Guy Harris 17456c2e09 Include <unistd.h> if available, to get "close()" declared.
Update the big comment to reflect current reality.

svn path=/trunk/; revision=16453
2005-11-10 02:49:54 +00:00
Anders Broman f86d2d458c From Andrei Emeltchenko
I have added new RTCP POC fields as OMA standard says. With some additions. 

svn path=/trunk/; revision=16452
2005-11-09 21:50:39 +00:00
Ronnie Sahlberg 4acbd6bcc9 add initial decode for SMB2_FS_INFO_01
svn path=/trunk/; revision=16451
2005-11-09 21:06:06 +00:00
Ronnie Sahlberg d0a574078d add decode of SMB2_FS_INFO_05
svn path=/trunk/; revision=16450
2005-11-09 20:57:56 +00:00
Ronnie Sahlberg 005fbb5304 add decoding of the create request
svn path=/trunk/; revision=16449
2005-11-09 20:37:49 +00:00
Gerald Combs f9d4caf148 From Stig Bjørlykke:
I just learned how easy it is to reassemble multiple UDP packets, so  I
had to implement this for the P_Mul protocol :)

This patch fixes:
* Reassemble multiple data packets
* Add packet length check
* Fix for PDU type in tree entry

svn path=/trunk/; revision=16448
2005-11-09 16:01:35 +00:00
Ronnie Sahlberg 8ba0aaf3a9 some more of the never ending stream of smb2 updates
svn path=/trunk/; revision=16447
2005-11-09 13:19:57 +00:00
Ronnie Sahlberg 2c0b087fde add decode of Write commands
svn path=/trunk/; revision=16446
2005-11-09 10:18:31 +00:00
Ronnie Sahlberg d94d156a7a add support for Close and the new guess that the FID is present in the Find request.
Ohoy sailor,    we have spotted the concept of current working directory.

does this mean we also get rid of the silly 200-256 byte path length limitation?




svn path=/trunk/; revision=16445
2005-11-09 09:29:41 +00:00
Ronnie Sahlberg a204fdaea7 dissect more of the SMB2/Close function
svn path=/trunk/; revision=16444
2005-11-09 09:14:11 +00:00
Guy Harris 03ac44a500 Remove comment that no longer applies.
If we get a getopt() error in the pre-scanning, quit - don't do all the
GUI stuff and re-scan the arguments (and print the error message twice).

svn path=/trunk/; revision=16443
2005-11-09 08:46:24 +00:00
Ulf Lamping 5fa59abfe4 Updated feature: When cancelling a file load operation...
svn path=/trunk/; revision=16442
2005-11-09 00:39:20 +00:00
Ulf Lamping a10a0d2636 from Jaap Keuter:
Anyone having objections to idea of stopping the load of a capture file
i.s.o. cancelling it? I'm refering to WishList Data I/O item #6.
It seems a very reasonable idea and easy to implement.

I've done some extensions:
-Improve the corresponding comment on the implications why this is useful
-added a new simple_dialog text to explain what's really going on (simply using the WTAP truncated packet message was a bit misleading)

svn path=/trunk/; revision=16441
2005-11-08 22:24:53 +00:00
Anders Broman 2044d02bcb Move def of subid_t to format-oid.h don't include asn1.h in cops any more.
svn path=/trunk/; revision=16440
2005-11-08 22:18:06 +00:00
Ronnie Sahlberg 53ab6ed970 start dissecting SMB2_FILE_INFO_12
svn path=/trunk/; revision=16439
2005-11-08 21:16:36 +00:00
Gerald Combs 781f8051e5 From Peter Kovar: Fix the typo referenced in bug 577.
svn path=/trunk/; revision=16438
2005-11-08 15:28:15 +00:00
Gerald Combs ba26efe7f1 Fix a cut-and-pasteo.
svn path=/trunk/; revision=16437
2005-11-08 15:23:20 +00:00
Gerald Combs f2d2a624d8 You don't tug on Superman's cape. You don't spit into the wind.
You don't pull the mask off the old Lone Ranger, and you don't
overflow a guint8.  Fixes the infinite loop in bug 576.

Fix up whitespace.  Add an entry to the release notes.  Apologies
to Jim Croce.

svn path=/trunk/; revision=16436
2005-11-08 15:22:38 +00:00
Ronnie Sahlberg 6f2482bc9f dissect some of GetInfo requests and Replies
svn path=/trunk/; revision=16435
2005-11-08 09:20:04 +00:00
Ronnie Sahlberg f8b4f34276 add a comment to keep the dissector in sync with the wiki
rename functions 0x10 and 0x11 to follow the names in the wiki



svn path=/trunk/; revision=16434
2005-11-08 08:53:55 +00:00
Ronnie Sahlberg b46a5611ed add a pointer to the wiki for documentation of this protocol
svn path=/trunk/; revision=16433
2005-11-08 08:41:42 +00:00
Ronnie Sahlberg 40b13e337f add dissection of the known parts of negotiate protocol
svn path=/trunk/; revision=16432
2005-11-08 08:40:32 +00:00
Guy Harris 31a44d4bfc When using GCC, compile with -Wpointer-arith, to catch code that some
other C compilers can't handle.

svn path=/trunk/; revision=16431
2005-11-08 04:03:50 +00:00
Guy Harris af00219b1b Use "proto_tree_add_item()", not "proto_tree_add_bytes()", if you're
just supplying the result of "tvb_get_ptr()" with the same tvbuff,
offset, and length as the byte array.

Get rid of an unused variable.

Set svn:keywords and svn:eol-style appropriately.

svn path=/trunk/; revision=16430
2005-11-07 22:50:34 +00:00
Gerald Combs b1b1c50f1e Fix an ftsanity.py error.
svn path=/trunk/; revision=16429
2005-11-07 21:58:27 +00:00
Gerald Combs 062621786f Fix bug 575, from Menno Andriesse:
In two functions that call proto_tree_add_bytes I forgot the
  'tvb_get_ptr' function, the argument was 'FALSE' instead.  This gave
  a predictable 'NULL' pointer bug...

Fix an ftsanity.py error.  Fixup whitespace.


svn path=/trunk/; revision=16428
2005-11-07 21:54:08 +00:00
Ronnie Sahlberg 66d99c3eed begin dissecting the Find response packet
svn path=/trunk/; revision=16427
2005-11-07 21:19:59 +00:00
Guy Harris 6c521f90f5 The return value of tvb_get_ptr() is a const ptr; assign it to a const
ptr.

The answer to the question
"??????????????????????????????????????????????????????????????????" is
"No - the return value of tvb_get_ptr() is a reference, not an allocated
copy, and it cannot be freed and doesn't need to be freed."

svn path=/trunk/; revision=16426
2005-11-07 21:10:52 +00:00
Ronnie Sahlberg 39ecd87667 dissect the treeconnect request packet
svn path=/trunk/; revision=16425
2005-11-07 21:00:09 +00:00
Ronnie Sahlberg 8012fd3cd9 add request response matching so we can start passing info levels around from request to response and start dissecting some of the commands
svn path=/trunk/; revision=16424
2005-11-07 20:32:27 +00:00
Guy Harris 262a414f41 The problem wasn't that <sys/stat.h> wasn't being included, the problem
was that file_util.h wasn't in the distribution tarball, so it couldn't
be included - it handles including <sys/stat.h>.

svn path=/trunk/; revision=16423
2005-11-07 20:14:40 +00:00
Ulf Lamping 91e66afb84 add file_util.h so distcheck might work
svn path=/trunk/; revision=16422
2005-11-07 19:51:16 +00:00
Anders Broman 708d793e63 Display MSW and LSW as NTP timestamp as well.
svn path=/trunk/; revision=16421
2005-11-07 19:40:55 +00:00
Anders Broman a9a63056df Dissect NSAP
svn path=/trunk/; revision=16420
2005-11-07 19:39:38 +00:00
Anders Broman b2ec8c9ca4 Bug fix to dissection of NSAP E164 Country codes
svn path=/trunk/; revision=16419
2005-11-07 19:39:02 +00:00
Anders Broman 199214844b Martin Hill has examined packet-dec-dnart.c and found some errors and made some improvements.
svn path=/trunk/; revision=16418
2005-11-07 19:37:10 +00:00
Anders Broman 8586ce47d2 From Stig Bjørlykke
A new dissector for P_Mul (ACP142) http://www.jcs.mil/j6/cceb/acps/Acp142.pdf

svn path=/trunk/; revision=16417
2005-11-07 19:35:48 +00:00