building one or not - we have to do some of that work anyway, so we know
the offset of the payload and so that we call sub-dissectors, and the
easiest way to do that is to do all the work (you make more procedure
calls that way than you'd like, but the procedures at least return
quickly when they find they've been passed a null pointer; hopefully
that won't add too much CPU time to dissection of BACNET traces on the
first pass).
Don't use "proto_tree_add_uint_format()" in a case where it's not
necessary - and fix the field being used not to have a bitmask, as it's
not a bitfield.
svn path=/trunk/; revision=10861
and time rather than as a raw seconds-since-1900-01-01-00:00:00 GMT.
Put it into the protocol tree as a named field (the named field was
there but wasn't being used).
Give the RFC number for the protocol in a comment.
svn path=/trunk/; revision=10860
"col_set_str()", for that matter.
Eliminate a compiler warning by initializing a variable.
Don't use "match_strval()" on values you don't know for certain are in
the value_string table - use "val_to_str()", so that you don't get a
null pointer if the value isn't in that table. ("Know for certain"
meaning "the code has made sure it's a value that's in the table", not
"the protocol spec says the field must have one of the values in the
table".)
svn path=/trunk/; revision=10859
an RTSP request name - either the line has to end after the request name
or there has to be a whitespace character after the request name.
svn path=/trunk/; revision=10849
at least one mail message:
http://mailman.mit.edu/pipermail/kerberos/2004-February/004653.html
shows some of the weird Microsoft encryption type values logged by some
KDC implementation as negative integers. Also, show them as decimal in
the top-level line for encryption types, just as we do in the lines for
each encryption type.
svn path=/trunk/; revision=10848
bits as a parenthesized, comma-separated lists - using only blanks as
separators doesn't work well if the names themselves have blanks in
them, as some of them do.
Note that "dissect_ber_integer()" won't work well if the length of the
item isn't appropriate for the field, e.g. a length > 4 for an FT_INTn
or FT_UINTn field.
svn path=/trunk/; revision=10847
function with a different signature than the one defined in util.c/util.h.
For this reason, we need to rename our base64_decode() routine.
The routine is now called epan_base64_decode().
svn path=/trunk/; revision=10840
add a config.nmake option to control whether to build
libethereal.dll or not;
remove "./wiretap" from PATH to prevent problems due to
wrongly-loaded files;
build dissector.lib with MSVC;
move "print.c" and "ps.c" to the dissector helpers, as "print.c"
imports variables from packet-frame.c and packet-data.c, which
are in libethereal;
move "g711.c" out of the dissector helpers, as they're used only
by Ethereal in a tap, not in Tethereal or in any dissector;
add a .def file for libethereal;
arrange to declare global variables exported from libethereal
with "__declspec(dllimport)" when building programs that import
those variables;
update the NSIS installer.
Make the "configure" script define ETH_VAR_IMPORT as "extern".
svn path=/trunk/; revision=10834
is being dechunked; this will highlight the correct bytes when selecting the
compressed data from the protocol tree.
Add comments for explaining what happens where.
Strip trailing white space.
svn path=/trunk/; revision=10832
Error if protocol specified on RHS of display filter comparison.
If user specified "fc", they probably intended a byte value rather than
the fibre channel protocol; fix makes mistake clear.
Fix assertion failure with range on LHS of display filter comparison
and field on RHS.
svn path=/trunk/; revision=10829
octal, as the maximum of 3 octal digits can be more than 0377, but not
necessary for hex, as the maximum of 2 hex digits can't be more than
0xff).
svn path=/trunk/; revision=10827
conversation. Fix this by checking whether there is conversation data for
the DICOM dissector. If not, the conversatioj is not a DICOM conversation,
and we do not attempt at dissecting it as DICOM.
svn path=/trunk/; revision=10823
* Add comments on why we may not use tvb_free() at some places.
* Add a new data source for a reassembled chunked entity.
svn path=/trunk/; revision=10821
double freeing of memory. Add a comment at the tvb_new_subset() call so
future developers will be warned.
Always add the compressed entity as an item in the protocol tree, so it can
be exported by selecting the packet bytes.
svn path=/trunk/; revision=10819
Ronnie Sahlberg